All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] imx:mx6sl_pins add pad settings for usb
@ 2014-11-01  2:43 Peng Fan
  2014-11-01  2:44 ` [U-Boot] [PATCH 2/2] arm:imx-common add function prototype for gpr set Peng Fan
  2014-11-01 14:31 ` [U-Boot] [PATCH 1/2] imx:mx6sl_pins add pad settings for usb Fabio Estevam
  0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan @ 2014-11-01  2:43 UTC (permalink / raw)
  To: u-boot

Add pad settings for usb support.

This patch "imx:mx6slevk add usb support" missed to add pad
definition.

Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
---
 arch/arm/include/asm/arch-mx6/mx6sl_pins.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/include/asm/arch-mx6/mx6sl_pins.h b/arch/arm/include/asm/arch-mx6/mx6sl_pins.h
index 045ccc4..17b4798 100644
--- a/arch/arm/include/asm/arch-mx6/mx6sl_pins.h
+++ b/arch/arm/include/asm/arch-mx6/mx6sl_pins.h
@@ -34,5 +34,10 @@ enum {
 	MX6_PAD_FEC_REF_CLK__FEC_REF_OUT			= IOMUX_PAD(0x424, 0x134, 0x10, 0x000, 0, 0),
 	MX6_PAD_FEC_RX_ER__GPIO_4_19				= IOMUX_PAD(0x0428, 0x0138, 5, 0x0000, 0, 0),
 	MX6_PAD_FEC_TX_CLK__GPIO_4_21				= IOMUX_PAD(0x0434, 0x0144, 5, 0x0000, 0, 0),
+
+	MX6_PAD_EPDC_PWRCOM__ANATOP_USBOTG1_ID			= IOMUX_PAD(0x03D0, 0x00E0, 4, 0x05DC, 0, 0),
+
+	MX6_PAD_KEY_COL4__USB_USBOTG1_PWR			= IOMUX_PAD(0x0484, 0x017C, 6, 0x0000, 0, 0),
+	MX6_PAD_KEY_COL5__USB_USBOTG2_PWR			= IOMUX_PAD(0x0488, 0x0180, 6, 0x0000, 0, 0),
 };
 #endif	/* __ASM_ARCH_MX6_MX6SL_PINS_H__ */
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] arm:imx-common add function prototype for gpr set
  2014-11-01  2:43 [U-Boot] [PATCH 1/2] imx:mx6sl_pins add pad settings for usb Peng Fan
@ 2014-11-01  2:44 ` Peng Fan
  2014-11-03  9:28   ` Stefano Babic
  2014-11-01 14:31 ` [U-Boot] [PATCH 1/2] imx:mx6sl_pins add pad settings for usb Fabio Estevam
  1 sibling, 1 reply; 4+ messages in thread
From: Peng Fan @ 2014-11-01  2:44 UTC (permalink / raw)
  To: u-boot

This patch "arm:imx-common introduce a new function to set gpr"
missed to add the function prototype.

Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
---
 arch/arm/include/asm/imx-common/iomux-v3.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/include/asm/imx-common/iomux-v3.h b/arch/arm/include/asm/imx-common/iomux-v3.h
index a8ca49c..23421b5 100644
--- a/arch/arm/include/asm/imx-common/iomux-v3.h
+++ b/arch/arm/include/asm/imx-common/iomux-v3.h
@@ -182,6 +182,9 @@ typedef u64 iomux_v3_cfg_t;
 void imx_iomux_v3_setup_pad(iomux_v3_cfg_t pad);
 void imx_iomux_v3_setup_multiple_pads(iomux_v3_cfg_t const *pad_list,
 				     unsigned count);
+/* Set bits for general purpose registers */
+void mxc_iomux_set_gpr_register(int group, int start_bit, int num_bits,
+				int value);
 
 /* macros for declaring and using pinmux array */
 #if defined(CONFIG_MX6QDL)
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/2] imx:mx6sl_pins add pad settings for usb
  2014-11-01  2:43 [U-Boot] [PATCH 1/2] imx:mx6sl_pins add pad settings for usb Peng Fan
  2014-11-01  2:44 ` [U-Boot] [PATCH 2/2] arm:imx-common add function prototype for gpr set Peng Fan
@ 2014-11-01 14:31 ` Fabio Estevam
  1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2014-11-01 14:31 UTC (permalink / raw)
  To: u-boot

On Sat, Nov 1, 2014 at 12:43 AM, Peng Fan <Peng.Fan@freescale.com> wrote:
> Add pad settings for usb support.
>
> This patch "imx:mx6slevk add usb support" missed to add pad
> definition.

Then please resend the patch with the pad definition.

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] arm:imx-common add function prototype for gpr set
  2014-11-01  2:44 ` [U-Boot] [PATCH 2/2] arm:imx-common add function prototype for gpr set Peng Fan
@ 2014-11-03  9:28   ` Stefano Babic
  0 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2014-11-03  9:28 UTC (permalink / raw)
  To: u-boot

Hi Peng,

On 01/11/2014 03:44, Peng Fan wrote:
> This patch "arm:imx-common introduce a new function to set gpr"
> missed to add the function prototype.
> 

A fix of a previous patch makes sense when the patch was already merged.
In that case, the fix should also have in the message the commit-id of
the patch causing the issue.

Your patches are not yet merged: please send a new version of the
patchset fixing the issues you have found.

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-11-03  9:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-01  2:43 [U-Boot] [PATCH 1/2] imx:mx6sl_pins add pad settings for usb Peng Fan
2014-11-01  2:44 ` [U-Boot] [PATCH 2/2] arm:imx-common add function prototype for gpr set Peng Fan
2014-11-03  9:28   ` Stefano Babic
2014-11-01 14:31 ` [U-Boot] [PATCH 1/2] imx:mx6sl_pins add pad settings for usb Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.