* [PULL 0/1] Block patches
@ 2021-10-21 17:41 Stefan Hajnoczi
2021-10-21 17:41 ` [PULL 1/1] coroutine: resize pool periodically instead of limiting size Stefan Hajnoczi
2021-10-21 22:08 ` [PULL 0/1] Block patches Richard Henderson
0 siblings, 2 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-10-21 17:41 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Kevin Wolf, Paolo Bonzini, Stefan Hajnoczi, qemu-block
The following changes since commit afc9fcde55296b83f659de9da3cdf044812a6eeb:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-10-20 06:10:51 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 4b2b3d2653f255ef4259a7689af1956536565901:
coroutine: resize pool periodically instead of limiting size (2021-10-21 18:40:07 +0100)
----------------------------------------------------------------
Pull request
Performance optimization when guest applications submit a lot of parallel I/O.
This has also been found to improve clang SafeStack performance.
----------------------------------------------------------------
Stefan Hajnoczi (1):
coroutine: resize pool periodically instead of limiting size
include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++
include/qemu/coroutine.h | 7 ++++
iothread.c | 6 +++
util/coroutine-pool-timer.c | 35 ++++++++++++++++
util/main-loop.c | 5 +++
util/qemu-coroutine.c | 64 ++++++++++++++++-------------
util/meson.build | 1 +
7 files changed, 125 insertions(+), 29 deletions(-)
create mode 100644 include/qemu/coroutine-pool-timer.h
create mode 100644 util/coroutine-pool-timer.c
--
2.31.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 1/1] coroutine: resize pool periodically instead of limiting size
2021-10-21 17:41 [PULL 0/1] Block patches Stefan Hajnoczi
@ 2021-10-21 17:41 ` Stefan Hajnoczi
2021-10-21 22:08 ` [PULL 0/1] Block patches Richard Henderson
1 sibling, 0 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-10-21 17:41 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Kevin Wolf, Honghao Wang, qemu-block, Tingting Mao,
Stefan Hajnoczi, Paolo Bonzini, Daniele Buono, Serge Guelton
It was reported that enabling SafeStack reduces IOPS significantly
(>25%) with the following fio benchmark on virtio-blk using a NVMe host
block device:
# fio --rw=randrw --bs=4k --iodepth=64 --runtime=1m --direct=1 \
--filename=/dev/vdb --name=job1 --ioengine=libaio --thread \
--group_reporting --numjobs=16 --time_based \
--output=/tmp/fio_result
Serge Guelton and I found that SafeStack is not really at fault, it just
increases the cost of coroutine creation. This fio workload exhausts the
coroutine pool and coroutine creation becomes a bottleneck. Previous
work by Honghao Wang also pointed to excessive coroutine creation.
Creating new coroutines is expensive due to allocating new stacks with
mmap(2) and mprotect(2). Currently there are thread-local and global
pools that recycle old Coroutine objects and their stacks but the
hardcoded size limit of 64 for thread-local pools and 128 for the global
pool is insufficient for the fio benchmark shown above.
This patch changes the coroutine pool algorithm to a simple thread-local
pool without a maximum size limit. Threads periodically shrink the pool
down to a size sufficient for the maximum observed number of coroutines.
The global pool is removed by this patch. It can help to hide the fact
that local pools are easily exhausted, but it's doesn't fix the root
cause. I don't think there is a need for a global pool because QEMU's
threads are long-lived, so let's keep things simple.
Performance of the above fio benchmark is as follows:
Before After
IOPS 60k 97k
Memory usage varies over time as needed by the workload:
VSZ (KB) RSS (KB)
Before fio 4705248 843128
During fio 5747668 (+ ~100 MB) 849280
After fio 4694996 (- ~100 MB) 845184
This confirms that coroutines are indeed being freed when no longer
needed.
Thanks to Serge Guelton for working on identifying the bottleneck with
me!
Reported-by: Tingting Mao <timao@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20210913153524.1190696-1-stefanha@redhat.com
Cc: Serge Guelton <sguelton@redhat.com>
Cc: Honghao Wang <wanghonghao@bytedance.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Daniele Buono <dbuono@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
[Moved atexit notifier to coroutine_delete() after GitLab CI reported a
memory leak in tests/unit/test-aio-multithread because the Coroutine
object was created in the main thread but runs in an IOThread (where
it's also deleted).
--Stefan]
---
include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++
include/qemu/coroutine.h | 7 ++++
iothread.c | 6 +++
util/coroutine-pool-timer.c | 35 ++++++++++++++++
util/main-loop.c | 5 +++
util/qemu-coroutine.c | 64 ++++++++++++++++-------------
util/meson.build | 1 +
7 files changed, 125 insertions(+), 29 deletions(-)
create mode 100644 include/qemu/coroutine-pool-timer.h
create mode 100644 util/coroutine-pool-timer.c
diff --git a/include/qemu/coroutine-pool-timer.h b/include/qemu/coroutine-pool-timer.h
new file mode 100644
index 0000000000..c0b520ce99
--- /dev/null
+++ b/include/qemu/coroutine-pool-timer.h
@@ -0,0 +1,36 @@
+/*
+ * QEMU coroutine pool timer
+ *
+ * Copyright (c) 2021 Red Hat, Inc.
+ *
+ * SPDX-License-Identifier: LGPL-2.1-or-later
+ *
+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
+ * See the COPYING.LIB file in the top-level directory.
+ *
+ */
+#ifndef COROUTINE_POOL_TIMER_H
+#define COROUTINE_POOL_TIMER_H
+
+#include "qemu/osdep.h"
+#include "block/aio.h"
+
+/**
+ * A timer that periodically resizes this thread's coroutine pool, freeing
+ * memory if there are too many unused coroutines.
+ *
+ * Threads that make heavy use of coroutines should use this. Failure to resize
+ * the coroutine pool can lead to large amounts of memory sitting idle and
+ * never being used after the first time.
+ */
+typedef struct {
+ QEMUTimer *timer;
+} CoroutinePoolTimer;
+
+/* Call this before the thread runs the AioContext */
+void coroutine_pool_timer_init(CoroutinePoolTimer *pt, AioContext *ctx);
+
+/* Call this before the AioContext from the init function is destroyed */
+void coroutine_pool_timer_cleanup(CoroutinePoolTimer *pt);
+
+#endif /* COROUTINE_POOL_TIMER_H */
diff --git a/include/qemu/coroutine.h b/include/qemu/coroutine.h
index 4829ff373d..fdb2955ff9 100644
--- a/include/qemu/coroutine.h
+++ b/include/qemu/coroutine.h
@@ -122,6 +122,13 @@ bool qemu_in_coroutine(void);
*/
bool qemu_coroutine_entered(Coroutine *co);
+/**
+ * Optionally call this function periodically to shrink the thread-local pool
+ * down. Spiky workloads can create many coroutines and then never reach that
+ * level again. Shrinking the pool reclaims memory in this case.
+ */
+void qemu_coroutine_pool_periodic_resize(void);
+
/**
* Provides a mutex that can be used to synchronise coroutines
*/
diff --git a/iothread.c b/iothread.c
index 0f98af0f2a..f0a73705ec 100644
--- a/iothread.c
+++ b/iothread.c
@@ -23,6 +23,7 @@
#include "qemu/error-report.h"
#include "qemu/rcu.h"
#include "qemu/main-loop.h"
+#include "qemu/coroutine-pool-timer.h"
typedef ObjectClass IOThreadClass;
@@ -42,6 +43,7 @@ DECLARE_CLASS_CHECKERS(IOThreadClass, IOTHREAD,
static void *iothread_run(void *opaque)
{
IOThread *iothread = opaque;
+ CoroutinePoolTimer co_pool_timer;
rcu_register_thread();
/*
@@ -53,6 +55,8 @@ static void *iothread_run(void *opaque)
iothread->thread_id = qemu_get_thread_id();
qemu_sem_post(&iothread->init_done_sem);
+ coroutine_pool_timer_init(&co_pool_timer, iothread->ctx);
+
while (iothread->running) {
/*
* Note: from functional-wise the g_main_loop_run() below can
@@ -74,6 +78,8 @@ static void *iothread_run(void *opaque)
}
}
+ coroutine_pool_timer_cleanup(&co_pool_timer);
+
g_main_context_pop_thread_default(iothread->worker_context);
rcu_unregister_thread();
return NULL;
diff --git a/util/coroutine-pool-timer.c b/util/coroutine-pool-timer.c
new file mode 100644
index 0000000000..36d3216718
--- /dev/null
+++ b/util/coroutine-pool-timer.c
@@ -0,0 +1,35 @@
+/*
+ * QEMU coroutine pool timer
+ *
+ * Copyright (c) 2021 Red Hat, Inc.
+ *
+ * SPDX-License-Identifier: LGPL-2.1-or-later
+ *
+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
+ * See the COPYING.LIB file in the top-level directory.
+ *
+ */
+#include "qemu/coroutine-pool-timer.h"
+
+static void coroutine_pool_timer_cb(void *opaque)
+{
+ CoroutinePoolTimer *pt = opaque;
+ int64_t expiry_time_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME) +
+ 15 * NANOSECONDS_PER_SECOND;
+
+ qemu_coroutine_pool_periodic_resize();
+ timer_mod(pt->timer, expiry_time_ns);
+}
+
+void coroutine_pool_timer_init(CoroutinePoolTimer *pt, AioContext *ctx)
+{
+ pt->timer = aio_timer_new(ctx, QEMU_CLOCK_REALTIME, SCALE_NS,
+ coroutine_pool_timer_cb, pt);
+ coroutine_pool_timer_cb(pt);
+}
+
+void coroutine_pool_timer_cleanup(CoroutinePoolTimer *pt)
+{
+ timer_free(pt->timer);
+ pt->timer = NULL;
+}
diff --git a/util/main-loop.c b/util/main-loop.c
index 06b18b195c..23342e2215 100644
--- a/util/main-loop.c
+++ b/util/main-loop.c
@@ -33,6 +33,7 @@
#include "qemu/error-report.h"
#include "qemu/queue.h"
#include "qemu/compiler.h"
+#include "qemu/coroutine-pool-timer.h"
#ifndef _WIN32
#include <sys/wait.h>
@@ -131,6 +132,7 @@ static int qemu_signal_init(Error **errp)
static AioContext *qemu_aio_context;
static QEMUBH *qemu_notify_bh;
+static CoroutinePoolTimer main_loop_co_pool_timer;
static void notify_event_cb(void *opaque)
{
@@ -181,6 +183,9 @@ int qemu_init_main_loop(Error **errp)
g_source_set_name(src, "io-handler");
g_source_attach(src, NULL);
g_source_unref(src);
+
+ coroutine_pool_timer_init(&main_loop_co_pool_timer, qemu_aio_context);
+
return 0;
}
diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c
index 38fb6d3084..d9dc8b38db 100644
--- a/util/qemu-coroutine.c
+++ b/util/qemu-coroutine.c
@@ -21,14 +21,19 @@
#include "block/aio.h"
enum {
- POOL_BATCH_SIZE = 64,
+ /*
+ * qemu_coroutine_pool_periodic_resize() keeps at least this many
+ * coroutines around.
+ */
+ ALLOC_POOL_MIN = 64,
};
+
/** Free list to speed up creation */
-static QSLIST_HEAD(, Coroutine) release_pool = QSLIST_HEAD_INITIALIZER(pool);
-static unsigned int release_pool_size;
static __thread QSLIST_HEAD(, Coroutine) alloc_pool = QSLIST_HEAD_INITIALIZER(pool);
static __thread unsigned int alloc_pool_size;
+static __thread unsigned int num_coroutines;
+static __thread unsigned int max_coroutines_this_slice;
static __thread Notifier coroutine_pool_cleanup_notifier;
static void coroutine_pool_cleanup(Notifier *n, void *value)
@@ -48,27 +53,15 @@ Coroutine *qemu_coroutine_create(CoroutineEntry *entry, void *opaque)
if (CONFIG_COROUTINE_POOL) {
co = QSLIST_FIRST(&alloc_pool);
- if (!co) {
- if (release_pool_size > POOL_BATCH_SIZE) {
- /* Slow path; a good place to register the destructor, too. */
- if (!coroutine_pool_cleanup_notifier.notify) {
- coroutine_pool_cleanup_notifier.notify = coroutine_pool_cleanup;
- qemu_thread_atexit_add(&coroutine_pool_cleanup_notifier);
- }
-
- /* This is not exact; there could be a little skew between
- * release_pool_size and the actual size of release_pool. But
- * it is just a heuristic, it does not need to be perfect.
- */
- alloc_pool_size = qatomic_xchg(&release_pool_size, 0);
- QSLIST_MOVE_ATOMIC(&alloc_pool, &release_pool);
- co = QSLIST_FIRST(&alloc_pool);
- }
- }
if (co) {
QSLIST_REMOVE_HEAD(&alloc_pool, pool_next);
alloc_pool_size--;
}
+
+ num_coroutines++;
+ if (num_coroutines > max_coroutines_this_slice) {
+ max_coroutines_this_slice = num_coroutines;
+ }
}
if (!co) {
@@ -86,21 +79,34 @@ static void coroutine_delete(Coroutine *co)
co->caller = NULL;
if (CONFIG_COROUTINE_POOL) {
- if (release_pool_size < POOL_BATCH_SIZE * 2) {
- QSLIST_INSERT_HEAD_ATOMIC(&release_pool, co, pool_next);
- qatomic_inc(&release_pool_size);
- return;
- }
- if (alloc_pool_size < POOL_BATCH_SIZE) {
- QSLIST_INSERT_HEAD(&alloc_pool, co, pool_next);
- alloc_pool_size++;
- return;
+ if (!coroutine_pool_cleanup_notifier.notify) {
+ coroutine_pool_cleanup_notifier.notify = coroutine_pool_cleanup;
+ qemu_thread_atexit_add(&coroutine_pool_cleanup_notifier);
}
+
+ num_coroutines--;
+ QSLIST_INSERT_HEAD(&alloc_pool, co, pool_next);
+ alloc_pool_size++;
+ return;
}
qemu_coroutine_delete(co);
}
+void qemu_coroutine_pool_periodic_resize(void)
+{
+ unsigned pool_size_target =
+ MAX(ALLOC_POOL_MIN, max_coroutines_this_slice) - num_coroutines;
+ max_coroutines_this_slice = num_coroutines;
+
+ while (alloc_pool_size > pool_size_target) {
+ Coroutine *co = QSLIST_FIRST(&alloc_pool);
+ QSLIST_REMOVE_HEAD(&alloc_pool, pool_next);
+ qemu_coroutine_delete(co);
+ alloc_pool_size--;
+ }
+}
+
void qemu_aio_coroutine_enter(AioContext *ctx, Coroutine *co)
{
QSIMPLEQ_HEAD(, Coroutine) pending = QSIMPLEQ_HEAD_INITIALIZER(pending);
diff --git a/util/meson.build b/util/meson.build
index 05b593055a..ac03e87955 100644
--- a/util/meson.build
+++ b/util/meson.build
@@ -65,6 +65,7 @@ if have_block
util_ss.add(files('buffer.c'))
util_ss.add(files('bufferiszero.c'))
util_ss.add(files('coroutine-@0@.c'.format(config_host['CONFIG_COROUTINE_BACKEND'])))
+ util_ss.add(files('coroutine-pool-timer.c'))
util_ss.add(files('hbitmap.c'))
util_ss.add(files('hexdump.c'))
util_ss.add(files('iova-tree.c'))
--
2.31.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-10-21 17:41 [PULL 0/1] Block patches Stefan Hajnoczi
2021-10-21 17:41 ` [PULL 1/1] coroutine: resize pool periodically instead of limiting size Stefan Hajnoczi
@ 2021-10-21 22:08 ` Richard Henderson
2021-10-25 10:10 ` Stefan Hajnoczi
1 sibling, 1 reply; 38+ messages in thread
From: Richard Henderson @ 2021-10-21 22:08 UTC (permalink / raw)
To: Stefan Hajnoczi, Peter Maydell, qemu-devel
Cc: Kevin Wolf, Paolo Bonzini, qemu-block
On 10/21/21 10:41 AM, Stefan Hajnoczi wrote:
> The following changes since commit afc9fcde55296b83f659de9da3cdf044812a6eeb:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-10-20 06:10:51 -0700)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 4b2b3d2653f255ef4259a7689af1956536565901:
>
> coroutine: resize pool periodically instead of limiting size (2021-10-21 18:40:07 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> Performance optimization when guest applications submit a lot of parallel I/O.
> This has also been found to improve clang SafeStack performance.
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> coroutine: resize pool periodically instead of limiting size
>
> include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++
> include/qemu/coroutine.h | 7 ++++
> iothread.c | 6 +++
> util/coroutine-pool-timer.c | 35 ++++++++++++++++
> util/main-loop.c | 5 +++
> util/qemu-coroutine.c | 64 ++++++++++++++++-------------
> util/meson.build | 1 +
> 7 files changed, 125 insertions(+), 29 deletions(-)
> create mode 100644 include/qemu/coroutine-pool-timer.h
> create mode 100644 util/coroutine-pool-timer.c
This is causing
(001/170) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg: INTERRUPTED:
Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal status:
ERROR\n{'name': '001-tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg',
'logdir': '/home/richard.henderson/qemu/bld/tests/results/job-2021-10-21T20.58-ae0f6...
(900.15 s)
(002/170) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_kvm: INTERRUPTED:
Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal status:
ERROR\n{'name': '002-tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_kvm',
'logdir': '/home/richard.henderson/qemu/bld/tests/results/job-2021-10-21T20.58-ae0f6...
(900.23 s)
I initially though this was just gitlab, but it reliably happens on my local machine as well.
r~
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-10-21 22:08 ` [PULL 0/1] Block patches Richard Henderson
@ 2021-10-25 10:10 ` Stefan Hajnoczi
0 siblings, 0 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-10-25 10:10 UTC (permalink / raw)
To: Richard Henderson
Cc: Kevin Wolf, Peter Maydell, qemu-devel, qemu-block, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 2854 bytes --]
On Thu, Oct 21, 2021 at 03:08:56PM -0700, Richard Henderson wrote:
> On 10/21/21 10:41 AM, Stefan Hajnoczi wrote:
> > The following changes since commit afc9fcde55296b83f659de9da3cdf044812a6eeb:
> >
> > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-10-20 06:10:51 -0700)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to 4b2b3d2653f255ef4259a7689af1956536565901:
> >
> > coroutine: resize pool periodically instead of limiting size (2021-10-21 18:40:07 +0100)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > Performance optimization when guest applications submit a lot of parallel I/O.
> > This has also been found to improve clang SafeStack performance.
> >
> > ----------------------------------------------------------------
> >
> > Stefan Hajnoczi (1):
> > coroutine: resize pool periodically instead of limiting size
> >
> > include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++
> > include/qemu/coroutine.h | 7 ++++
> > iothread.c | 6 +++
> > util/coroutine-pool-timer.c | 35 ++++++++++++++++
> > util/main-loop.c | 5 +++
> > util/qemu-coroutine.c | 64 ++++++++++++++++-------------
> > util/meson.build | 1 +
> > 7 files changed, 125 insertions(+), 29 deletions(-)
> > create mode 100644 include/qemu/coroutine-pool-timer.h
> > create mode 100644 util/coroutine-pool-timer.c
>
> This is causing
>
> (001/170) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg:
> INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout
> reached\nOriginal status: ERROR\n{'name':
> '001-tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg',
> 'logdir':
> '/home/richard.henderson/qemu/bld/tests/results/job-2021-10-21T20.58-ae0f6...
> (900.15 s)
> (002/170) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_kvm:
> INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout
> reached\nOriginal status: ERROR\n{'name':
> '002-tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_kvm',
> 'logdir':
> '/home/richard.henderson/qemu/bld/tests/results/job-2021-10-21T20.58-ae0f6...
> (900.23 s)
>
> I initially though this was just gitlab, but it reliably happens on my local machine as well.
Thanks, the coroutine pool timer commit in this pull request is broken.
Coroutines are created in one thread and then destroyed in another, so
the thread-local book keeping that assumed coroutines live in a single
thread was getting out of sync.
I will drop this pull request for now.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2024-04-29 13:43 Stefan Hajnoczi
0 siblings, 0 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2024-04-29 13:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Jeuk Kim, qemu-block, Stefan Hajnoczi
The following changes since commit fd87be1dada5672f877e03c2ca8504458292c479:
Merge tag 'accel-20240426' of https://github.com/philmd/qemu into staging (2024-04-26 15:28:13 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to d1c4580662bf75bf6875bb5e1ad446b300816ac7:
hw/ufs: Fix buffer overflow bug (2024-04-29 09:33:06 -0400)
----------------------------------------------------------------
Pull request
Buffer overflow fix for Universal Flash Storage (UFS) emulation.
----------------------------------------------------------------
Jeuk Kim (1):
hw/ufs: Fix buffer overflow bug
hw/ufs/ufs.c | 8 ++++++++
1 file changed, 8 insertions(+)
--
2.44.0
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2024-03-19 15:09 Stefan Hajnoczi
@ 2024-03-19 19:11 ` Peter Maydell
0 siblings, 0 replies; 38+ messages in thread
From: Peter Maydell @ 2024-03-19 19:11 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Michael S. Tsirkin, qemu-block, Kevin Wolf, Hanna Reitz
On Tue, 19 Mar 2024 at 15:09, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit ddc27d2ad9361a81c2b3800d14143bf420dae172:
>
> Merge tag 'pull-request-2024-03-18' of https://gitlab.com/thuth/qemu into staging (2024-03-19 10:25:25 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 86a637e48104ae74d8be53bed6441ce32be33433:
>
> coroutine: cap per-thread local pool size (2024-03-19 10:49:31 -0400)
>
> ----------------------------------------------------------------
> Pull request
>
> This fix solves the "failed to set up stack guard page" error that has been
> reported on Linux hosts where the QEMU coroutine pool exceeds the
> vm.max_map_count limit.
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2024-03-19 15:09 Stefan Hajnoczi
2024-03-19 19:11 ` Peter Maydell
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2024-03-19 15:09 UTC (permalink / raw)
To: qemu-devel
Cc: Michael S. Tsirkin, qemu-block, Kevin Wolf, Stefan Hajnoczi,
Peter Maydell, Hanna Reitz
The following changes since commit ddc27d2ad9361a81c2b3800d14143bf420dae172:
Merge tag 'pull-request-2024-03-18' of https://gitlab.com/thuth/qemu into staging (2024-03-19 10:25:25 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 86a637e48104ae74d8be53bed6441ce32be33433:
coroutine: cap per-thread local pool size (2024-03-19 10:49:31 -0400)
----------------------------------------------------------------
Pull request
This fix solves the "failed to set up stack guard page" error that has been
reported on Linux hosts where the QEMU coroutine pool exceeds the
vm.max_map_count limit.
----------------------------------------------------------------
Stefan Hajnoczi (1):
coroutine: cap per-thread local pool size
util/qemu-coroutine.c | 282 +++++++++++++++++++++++++++++++++---------
1 file changed, 223 insertions(+), 59 deletions(-)
--
2.44.0
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2024-02-06 15:31 Stefan Hajnoczi
@ 2024-02-07 22:19 ` Kevin Wolf
0 siblings, 0 replies; 38+ messages in thread
From: Kevin Wolf @ 2024-02-07 22:19 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Peter Maydell, Michael S. Tsirkin, Hanna Reitz, qemu-block
Am 06.02.2024 um 16:31 hat Stefan Hajnoczi geschrieben:
> The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:
>
> Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 1d52cc0ac27761e296b14655c2f5b2649ee69491:
>
> virtio-blk: avoid using ioeventfd state in irqfd conditional (2024-02-06 10:22:18 -0500)
>
> ----------------------------------------------------------------
> Pull request
>
> A bug fix for in-flight I/O during ioeventfd shutdown.
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> virtio-blk: avoid using ioeventfd state in irqfd conditional
I noticed that this patch is also in the pull request I sent, so I
guess if mine goes through, you don't have to process this one
separately.
Kevin
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2024-02-06 15:31 Stefan Hajnoczi
2024-02-07 22:19 ` Kevin Wolf
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2024-02-06 15:31 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Kevin Wolf, Stefan Hajnoczi, Michael S. Tsirkin,
Hanna Reitz, qemu-block
The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:
Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 1d52cc0ac27761e296b14655c2f5b2649ee69491:
virtio-blk: avoid using ioeventfd state in irqfd conditional (2024-02-06 10:22:18 -0500)
----------------------------------------------------------------
Pull request
A bug fix for in-flight I/O during ioeventfd shutdown.
----------------------------------------------------------------
Stefan Hajnoczi (1):
virtio-blk: avoid using ioeventfd state in irqfd conditional
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.43.0
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2023-10-16 19:40 Stefan Hajnoczi
0 siblings, 0 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2023-10-16 19:40 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Michael S. Tsirkin, qemu-block, Stefan Hajnoczi, Hanna Reitz
The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56:
Merge tag 'pull-riscv-to-apply-20231012-1' of https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 071d6d107db2e26dde9bb15457c74956c88ec5b4:
virtio-blk: don't start dataplane during the stop of dataplane (2023-10-16 15:39:13 -0400)
----------------------------------------------------------------
Pull request
Contains a virtio-blk IOThread fix.
----------------------------------------------------------------
hujian (1):
virtio-blk: don't start dataplane during the stop of dataplane
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.41.0
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2023-10-04 13:53 Stefan Hajnoczi
@ 2023-10-04 18:33 ` Stefan Hajnoczi
0 siblings, 0 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2023-10-04 18:33 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Stefan Hajnoczi, Thomas Huth, Daniel P. Berrangé,
qemu-block, Philippe Mathieu-Daudé,
Marc-André Lureau, Kevin Wolf, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2023-10-04 13:53 Stefan Hajnoczi
2023-10-04 18:33 ` Stefan Hajnoczi
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2023-10-04 13:53 UTC (permalink / raw)
To: qemu-devel
Cc: Stefan Hajnoczi, Thomas Huth, Daniel P. Berrangé,
qemu-block, Philippe Mathieu-Daudé,
Marc-André Lureau, Kevin Wolf, Paolo Bonzini
The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0:
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 9afa888ce0f816d0f2cfc95eebe4f49244c518af:
osdep: set _FORTIFY_SOURCE=2 when optimization is enabled (2023-10-04 09:52:06 -0400)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Daniel P. Berrangé (1):
osdep: set _FORTIFY_SOURCE=2 when optimization is enabled
meson.build | 10 ----------
include/qemu/osdep.h | 4 ++++
util/coroutine-sigaltstack.c | 4 ++--
util/coroutine-ucontext.c | 4 ++--
4 files changed, 8 insertions(+), 14 deletions(-)
--
2.41.0
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2023-07-12 19:36 Stefan Hajnoczi
@ 2023-07-14 6:35 ` Richard Henderson
0 siblings, 0 replies; 38+ messages in thread
From: Richard Henderson @ 2023-07-14 6:35 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, qemu-block, Hanna Reitz, Richard Henderson
On 7/12/23 20:36, Stefan Hajnoczi wrote:
> The following changes since commit 887cba855bb6ff4775256f7968409281350b568c:
>
> configure: Fix cross-building for RISCV host (v5) (2023-07-11 17:56:09 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 75dcb4d790bbe5327169fd72b185960ca58e2fa6:
>
> virtio-blk: fix host notifier issues during dataplane start/stop (2023-07-12 15:20:32 -0400)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> virtio-blk: fix host notifier issues during dataplane start/stop
>
> hw/block/dataplane/virtio-blk.c | 67 +++++++++++++++++++--------------
> 1 file changed, 38 insertions(+), 29 deletions(-)
>
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.
r~
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2023-07-12 19:36 Stefan Hajnoczi
2023-07-14 6:35 ` Richard Henderson
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2023-07-12 19:36 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, qemu-block, Hanna Reitz, Stefan Hajnoczi, Richard Henderson
The following changes since commit 887cba855bb6ff4775256f7968409281350b568c:
configure: Fix cross-building for RISCV host (v5) (2023-07-11 17:56:09 +0100)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 75dcb4d790bbe5327169fd72b185960ca58e2fa6:
virtio-blk: fix host notifier issues during dataplane start/stop (2023-07-12 15:20:32 -0400)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Stefan Hajnoczi (1):
virtio-blk: fix host notifier issues during dataplane start/stop
hw/block/dataplane/virtio-blk.c | 67 +++++++++++++++++++--------------
1 file changed, 38 insertions(+), 29 deletions(-)
--
2.40.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2023-07-04 15:29 Stefan Hajnoczi
@ 2023-07-06 6:04 ` Richard Henderson
0 siblings, 0 replies; 38+ messages in thread
From: Richard Henderson @ 2023-07-06 6:04 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, Hanna Reitz, qemu-block, Richard Henderson
On 7/4/23 16:29, Stefan Hajnoczi wrote:
> The following changes since commit d145c0da22cde391d8c6672d33146ce306e8bf75:
>
> Merge tag 'pull-tcg-20230701' ofhttps://gitlab.com/rth7680/qemu into staging (2023-07-01 08:55:37 +0200)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to c21eae1ccc782440f320accb6f90c66cb8f45ee9:
>
> block/blkio: fix module_block.py parsing (2023-07-04 17:28:25 +0200)
>
> ----------------------------------------------------------------
> Pull request
>
> Fix --enable-modules with the blkio block driver.
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.
r~
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2023-07-04 15:29 Stefan Hajnoczi
2023-07-06 6:04 ` Richard Henderson
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2023-07-04 15:29 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Stefan Hajnoczi, Hanna Reitz, qemu-block, Richard Henderson
The following changes since commit d145c0da22cde391d8c6672d33146ce306e8bf75:
Merge tag 'pull-tcg-20230701' of https://gitlab.com/rth7680/qemu into staging (2023-07-01 08:55:37 +0200)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to c21eae1ccc782440f320accb6f90c66cb8f45ee9:
block/blkio: fix module_block.py parsing (2023-07-04 17:28:25 +0200)
----------------------------------------------------------------
Pull request
Fix --enable-modules with the blkio block driver.
----------------------------------------------------------------
Stefan Hajnoczi (1):
block/blkio: fix module_block.py parsing
block/blkio.c | 108 ++++++++++++++++++++++++++------------------------
1 file changed, 56 insertions(+), 52 deletions(-)
--
2.40.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2022-09-22 17:14 Stefan Hajnoczi
@ 2022-09-27 15:04 ` Stefan Hajnoczi
0 siblings, 0 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2022-09-27 15:04 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Stefan Hajnoczi, qemu-block, Dr. David Alan Gilbert,
virtio-fs
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2022-09-22 17:14 Stefan Hajnoczi
2022-09-27 15:04 ` Stefan Hajnoczi
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2022-09-22 17:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Stefan Hajnoczi, qemu-block, Dr. David Alan Gilbert, virtio-fs
The following changes since commit 6338c30111d596d955e6bc933a82184a0b910c43:
Merge tag 'm68k-for-7.2-pull-request' of https://github.com/vivier/qemu-m68k into staging (2022-09-21 13:12:36 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to f16d15c9276bd8f501f861c39cbd4adc812d0c1d:
virtiofsd: use g_date_time_get_microsecond to get subsecond (2022-09-22 13:13:47 -0400)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Yusuke Okada (1):
virtiofsd: use g_date_time_get_microsecond to get subsecond
tools/virtiofsd/passthrough_ll.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
--
2.37.3
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2022-05-25 12:49 Stefan Hajnoczi
@ 2022-05-25 18:35 ` Richard Henderson
0 siblings, 0 replies; 38+ messages in thread
From: Richard Henderson @ 2022-05-25 18:35 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Dr. David Alan Gilbert, virtio-fs, qemu-block
On 5/25/22 05:49, Stefan Hajnoczi wrote:
> The following changes since commit 0cac736e73723850a99e5142e35d14d8f8efb232:
>
> Merge tag 'pull-riscv-to-apply-20220525' of github.com:alistair23/qemu into staging (2022-05-24 15:55:12 -0700)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 29320530cf6684646b3a642fdbb5bc77ee8039de:
>
> docs: Correct the default thread-pool-size (2022-05-25 11:01:38 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> A small documentation fix.
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate.
r~
>
> ----------------------------------------------------------------
>
> Liu Yiding (1):
> docs: Correct the default thread-pool-size
>
> docs/tools/virtiofsd.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2022-05-25 12:49 Stefan Hajnoczi
2022-05-25 18:35 ` Richard Henderson
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2022-05-25 12:49 UTC (permalink / raw)
To: qemu-devel
Cc: Dr. David Alan Gilbert, Richard Henderson, Stefan Hajnoczi,
virtio-fs, qemu-block
The following changes since commit 0cac736e73723850a99e5142e35d14d8f8efb232:
Merge tag 'pull-riscv-to-apply-20220525' of github.com:alistair23/qemu into staging (2022-05-24 15:55:12 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 29320530cf6684646b3a642fdbb5bc77ee8039de:
docs: Correct the default thread-pool-size (2022-05-25 11:01:38 +0100)
----------------------------------------------------------------
Pull request
A small documentation fix.
----------------------------------------------------------------
Liu Yiding (1):
docs: Correct the default thread-pool-size
docs/tools/virtiofsd.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.36.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 15:21 Stefan Hajnoczi
2021-12-09 15:46 ` Peter Maydell
@ 2021-12-14 22:31 ` Richard Henderson
1 sibling, 0 replies; 38+ messages in thread
From: Richard Henderson @ 2021-12-14 22:31 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel, Peter Maydell
Cc: Fam Zheng, Kevin Wolf, qemu-block, Hanna Reitz, Paolo Bonzini,
Philippe Mathieu-Daudé
On 12/9/21 7:21 AM, Stefan Hajnoczi wrote:
> The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0:
>
> Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to cf4fbc3030c974fff726756a7ceef8386cdf500b:
>
> block/nvme: fix infinite loop in nvme_free_req_queue_cb() (2021-12-09 09:19:49 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> An infinite loop fix for the userspace NVMe driver.
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> block/nvme: fix infinite loop in nvme_free_req_queue_cb()
>
> block/nvme.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions
Applied, as the beginning of the 7.0 development tree.
r~
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 16:53 ` Richard Henderson
@ 2021-12-13 9:33 ` Stefan Hajnoczi
0 siblings, 0 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-12-13 9:33 UTC (permalink / raw)
To: Richard Henderson
Cc: Fam Zheng, Peter Maydell, qemu-block, qemu-devel, Hanna Reitz,
Kevin Wolf, Paolo Bonzini, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On Thu, Dec 09, 2021 at 08:53:25AM -0800, Richard Henderson wrote:
> On 12/9/21 8:34 AM, Stefan Hajnoczi wrote:
> > > I'm not running the release cycle this time around, but: it's
> > > already rc4, pull requests by this point need a clear justification
> > > in the cover letter for why they're really release critical.
> >
> > It's late, this isn't a show-stopper (block/nvme.c is not widely used).
> > Let's leave it for the next release cycle and -stable.
>
> Good.
>
> Unless you want to re-issue with Cc: qemu-stable included in the patch, this
> can be the first PR of the next devel cycle, since it's already here. :-)
Thank you! qemu-stable can merge it separately. I won't add a Cc: tag to
the commit description.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 16:34 ` Stefan Hajnoczi
@ 2021-12-09 16:53 ` Richard Henderson
2021-12-13 9:33 ` Stefan Hajnoczi
0 siblings, 1 reply; 38+ messages in thread
From: Richard Henderson @ 2021-12-09 16:53 UTC (permalink / raw)
To: Stefan Hajnoczi, Peter Maydell
Cc: Fam Zheng, Kevin Wolf, qemu-block, qemu-devel, Hanna Reitz,
Paolo Bonzini, Philippe Mathieu-Daudé
On 12/9/21 8:34 AM, Stefan Hajnoczi wrote:
>> I'm not running the release cycle this time around, but: it's
>> already rc4, pull requests by this point need a clear justification
>> in the cover letter for why they're really release critical.
>
> It's late, this isn't a show-stopper (block/nvme.c is not widely used).
> Let's leave it for the next release cycle and -stable.
Good.
Unless you want to re-issue with Cc: qemu-stable included in the patch, this can be the
first PR of the next devel cycle, since it's already here. :-)
r~
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 15:46 ` Peter Maydell
@ 2021-12-09 16:34 ` Stefan Hajnoczi
2021-12-09 16:53 ` Richard Henderson
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-12-09 16:34 UTC (permalink / raw)
To: Peter Maydell
Cc: Fam Zheng, Kevin Wolf, qemu-block, Richard Henderson, qemu-devel,
Hanna Reitz, Paolo Bonzini, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
On Thu, Dec 09, 2021 at 03:46:29PM +0000, Peter Maydell wrote:
> On Thu, 9 Dec 2021 at 15:21, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0:
> >
> > Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to cf4fbc3030c974fff726756a7ceef8386cdf500b:
> >
> > block/nvme: fix infinite loop in nvme_free_req_queue_cb() (2021-12-09 09:19:49 +0000)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > An infinite loop fix for the userspace NVMe driver.
> >
> > ----------------------------------------------------------------
>
> I'm not running the release cycle this time around, but: it's
> already rc4, pull requests by this point need a clear justification
> in the cover letter for why they're really release critical.
It's late, this isn't a show-stopper (block/nvme.c is not widely used).
Let's leave it for the next release cycle and -stable.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 15:21 Stefan Hajnoczi
@ 2021-12-09 15:46 ` Peter Maydell
2021-12-09 16:34 ` Stefan Hajnoczi
2021-12-14 22:31 ` Richard Henderson
1 sibling, 1 reply; 38+ messages in thread
From: Peter Maydell @ 2021-12-09 15:46 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Kevin Wolf, qemu-block, Richard Henderson, qemu-devel,
Hanna Reitz, Paolo Bonzini, Philippe Mathieu-Daudé
On Thu, 9 Dec 2021 at 15:21, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0:
>
> Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to cf4fbc3030c974fff726756a7ceef8386cdf500b:
>
> block/nvme: fix infinite loop in nvme_free_req_queue_cb() (2021-12-09 09:19:49 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> An infinite loop fix for the userspace NVMe driver.
>
> ----------------------------------------------------------------
I'm not running the release cycle this time around, but: it's
already rc4, pull requests by this point need a clear justification
in the cover letter for why they're really release critical.
-- PMM
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2021-12-09 15:21 Stefan Hajnoczi
2021-12-09 15:46 ` Peter Maydell
2021-12-14 22:31 ` Richard Henderson
0 siblings, 2 replies; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-12-09 15:21 UTC (permalink / raw)
To: qemu-devel, Peter Maydell
Cc: Fam Zheng, Kevin Wolf, qemu-block, Hanna Reitz, Stefan Hajnoczi,
Paolo Bonzini, Philippe Mathieu-Daudé
The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0:
Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to cf4fbc3030c974fff726756a7ceef8386cdf500b:
block/nvme: fix infinite loop in nvme_free_req_queue_cb() (2021-12-09 09:19:49 +0000)
----------------------------------------------------------------
Pull request
An infinite loop fix for the userspace NVMe driver.
----------------------------------------------------------------
Stefan Hajnoczi (1):
block/nvme: fix infinite loop in nvme_free_req_queue_cb()
block/nvme.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.33.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-06 15:27 Stefan Hajnoczi
@ 2021-12-06 21:16 ` Richard Henderson
0 siblings, 0 replies; 38+ messages in thread
From: Richard Henderson @ 2021-12-06 21:16 UTC (permalink / raw)
To: Stefan Hajnoczi, Peter Maydell, qemu-devel
Cc: Kevin Wolf, Paolo Bonzini, Hanna Reitz, qemu-block
On 12/6/21 7:27 AM, Stefan Hajnoczi wrote:
> The following changes since commit 99fc08366b06282614daeda989d2fde6ab8a707f:
>
> Merge tag 'seabios-20211203-pull-request' of git://git.kraxel.org/qemu into staging (2021-12-03 05:26:40 -0800)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 5b807181c27a940a3a7ad1f221a2e76a132cbdc0:
>
> virtio-blk: Fix clean up of host notifiers for single MR transaction. (2021-12-06 14:21:14 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Mark Mielke (1):
> virtio-blk: Fix clean up of host notifiers for single MR transaction.
>
> hw/block/dataplane/virtio-blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
r~
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2021-12-06 15:27 Stefan Hajnoczi
2021-12-06 21:16 ` Richard Henderson
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-12-06 15:27 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Kevin Wolf, Paolo Bonzini, Hanna Reitz, Stefan Hajnoczi, qemu-block
The following changes since commit 99fc08366b06282614daeda989d2fde6ab8a707f:
Merge tag 'seabios-20211203-pull-request' of git://git.kraxel.org/qemu into staging (2021-12-03 05:26:40 -0800)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 5b807181c27a940a3a7ad1f221a2e76a132cbdc0:
virtio-blk: Fix clean up of host notifiers for single MR transaction. (2021-12-06 14:21:14 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Mark Mielke (1):
virtio-blk: Fix clean up of host notifiers for single MR transaction.
hw/block/dataplane/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.33.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-03-15 9:51 Stefan Hajnoczi
@ 2021-03-15 22:01 ` Peter Maydell
0 siblings, 0 replies; 38+ messages in thread
From: Peter Maydell @ 2021-03-15 22:01 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Eduardo Habkost, Qemu-block, Michael S. Tsirkin,
QEMU Developers, Max Reitz
On Mon, 15 Mar 2021 at 09:51, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
>
> Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
> request' into staging (2021-03-14 17:47:49 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to fb0b154c801e3447e505de420195fb7038695941:
>
> virtio-blk: Respect discard granularity (2021-03-15 09:48:53 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2021-03-15 9:51 Stefan Hajnoczi
2021-03-15 22:01 ` Peter Maydell
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-03-15 9:51 UTC (permalink / raw)
To: qemu-devel, Peter Maydell
Cc: Kevin Wolf, Eduardo Habkost, qemu-block, Michael S. Tsirkin,
Max Reitz, Stefan Hajnoczi
The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
request' into staging (2021-03-14 17:47:49 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to fb0b154c801e3447e505de420195fb7038695941:
virtio-blk: Respect discard granularity (2021-03-15 09:48:53 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Akihiko Odaki (1):
virtio-blk: Respect discard granularity
include/hw/virtio/virtio-blk.h | 1 +
hw/block/virtio-blk.c | 8 +++++++-
hw/core/machine.c | 1 +
3 files changed, 9 insertions(+), 1 deletion(-)
--=20
2.29.2
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2021-01-04 14:23 Stefan Hajnoczi
@ 2021-01-04 17:17 ` Peter Maydell
0 siblings, 0 replies; 38+ messages in thread
From: Peter Maydell @ 2021-01-04 17:17 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: QEMU Developers, Qemu-block
On Mon, 4 Jan 2021 at 14:23, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 41192db338588051f21501abc13743e62b0a5605:
>
> Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 593621f36b716eb091c4ec791db72dd4461789da:
>
> readline: Fix possible array index out of bounds in readline_hist_add() (2021-01-04 11:13:39 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2021-01-04 14:23 Stefan Hajnoczi
2021-01-04 17:17 ` Peter Maydell
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2021-01-04 14:23 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Stefan Hajnoczi, qemu-block
The following changes since commit 41192db338588051f21501abc13743e62b0a5605:
Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 593621f36b716eb091c4ec791db72dd4461789da:
readline: Fix possible array index out of bounds in readline_hist_add() (2021-01-04 11:13:39 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Alex Chen (1):
readline: Fix possible array index out of bounds in
readline_hist_add()
util/readline.c | 3 +++
1 file changed, 3 insertions(+)
--
2.29.2
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2020-03-17 15:18 Stefan Hajnoczi
@ 2020-03-17 18:32 ` Peter Maydell
0 siblings, 0 replies; 38+ messages in thread
From: Peter Maydell @ 2020-03-17 18:32 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Fam Zheng, QEMU Developers, Qemu-block, Max Reitz
On Tue, 17 Mar 2020 at 15:18, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 61c265f0660ee476985808c8aa7915617c44fd53:
>
> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200313a' into staging (2020-03-13 10:33:04 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 4ab78b19189a81038e744728ed949d09aa477550:
>
> block/io: fix bdrv_co_do_copy_on_readv (2020-03-16 11:46:11 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2020-03-17 15:18 Stefan Hajnoczi
2020-03-17 18:32 ` Peter Maydell
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2020-03-17 15:18 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Fam Zheng, qemu-block, Peter Maydell, Max Reitz,
Stefan Hajnoczi
The following changes since commit 61c265f0660ee476985808c8aa7915617c44fd53:
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200313a' into staging (2020-03-13 10:33:04 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 4ab78b19189a81038e744728ed949d09aa477550:
block/io: fix bdrv_co_do_copy_on_readv (2020-03-16 11:46:11 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Vladimir Sementsov-Ogievskiy (1):
block/io: fix bdrv_co_do_copy_on_readv
block/io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.24.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2020-01-14 9:30 Stefan Hajnoczi
@ 2020-01-14 16:00 ` Peter Maydell
0 siblings, 0 replies; 38+ messages in thread
From: Peter Maydell @ 2020-01-14 16:00 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Kevin Wolf, QEMU Developers, Qemu-block, Max Reitz
On Tue, 14 Jan 2020 at 09:31, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 2558cb8dd4150512bc8ae6d505cdcd10d0cc46bb:
>
> linux-aio: increasing MAX_EVENTS to a larger hardcoded value (2020-01-13 16:41:45 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Wangyong (1):
> linux-aio: increasing MAX_EVENTS to a larger hardcoded value
>
> block/linux-aio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2020-01-14 9:30 Stefan Hajnoczi
2020-01-14 16:00 ` Peter Maydell
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2020-01-14 9:30 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Peter Maydell, Stefan Hajnoczi, qemu-block, Max Reitz
The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 2558cb8dd4150512bc8ae6d505cdcd10d0cc46bb:
linux-aio: increasing MAX_EVENTS to a larger hardcoded value (2020-01-13 16:41:45 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Wangyong (1):
linux-aio: increasing MAX_EVENTS to a larger hardcoded value
block/linux-aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.24.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PULL 0/1] Block patches
2019-10-14 8:52 Stefan Hajnoczi
@ 2019-10-15 11:00 ` Peter Maydell
0 siblings, 0 replies; 38+ messages in thread
From: Peter Maydell @ 2019-10-15 11:00 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Kevin Wolf, Qemu-block, Michael S. Tsirkin,
QEMU Developers, Max Reitz
On Mon, 14 Oct 2019 at 09:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 69de48445a0d6169f1e2a6c5bfab994e1c810e33:
>
> test-bdrv-drain: fix iothread_join() hang (2019-10-14 09:48:01 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> test-bdrv-drain: fix iothread_join() hang
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PULL 0/1] Block patches
@ 2019-10-14 8:52 Stefan Hajnoczi
2019-10-15 11:00 ` Peter Maydell
0 siblings, 1 reply; 38+ messages in thread
From: Stefan Hajnoczi @ 2019-10-14 8:52 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, qemu-block, Michael S. Tsirkin,
Max Reitz, Stefan Hajnoczi, Kevin Wolf
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 69de48445a0d6169f1e2a6c5bfab994e1c810e33:
test-bdrv-drain: fix iothread_join() hang (2019-10-14 09:48:01 +0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Stefan Hajnoczi (1):
test-bdrv-drain: fix iothread_join() hang
tests/iothread.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 38+ messages in thread
end of thread, other threads:[~2024-04-29 13:44 UTC | newest]
Thread overview: 38+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21 17:41 [PULL 0/1] Block patches Stefan Hajnoczi
2021-10-21 17:41 ` [PULL 1/1] coroutine: resize pool periodically instead of limiting size Stefan Hajnoczi
2021-10-21 22:08 ` [PULL 0/1] Block patches Richard Henderson
2021-10-25 10:10 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2024-04-29 13:43 Stefan Hajnoczi
2024-03-19 15:09 Stefan Hajnoczi
2024-03-19 19:11 ` Peter Maydell
2024-02-06 15:31 Stefan Hajnoczi
2024-02-07 22:19 ` Kevin Wolf
2023-10-16 19:40 Stefan Hajnoczi
2023-10-04 13:53 Stefan Hajnoczi
2023-10-04 18:33 ` Stefan Hajnoczi
2023-07-12 19:36 Stefan Hajnoczi
2023-07-14 6:35 ` Richard Henderson
2023-07-04 15:29 Stefan Hajnoczi
2023-07-06 6:04 ` Richard Henderson
2022-09-22 17:14 Stefan Hajnoczi
2022-09-27 15:04 ` Stefan Hajnoczi
2022-05-25 12:49 Stefan Hajnoczi
2022-05-25 18:35 ` Richard Henderson
2021-12-09 15:21 Stefan Hajnoczi
2021-12-09 15:46 ` Peter Maydell
2021-12-09 16:34 ` Stefan Hajnoczi
2021-12-09 16:53 ` Richard Henderson
2021-12-13 9:33 ` Stefan Hajnoczi
2021-12-14 22:31 ` Richard Henderson
2021-12-06 15:27 Stefan Hajnoczi
2021-12-06 21:16 ` Richard Henderson
2021-03-15 9:51 Stefan Hajnoczi
2021-03-15 22:01 ` Peter Maydell
2021-01-04 14:23 Stefan Hajnoczi
2021-01-04 17:17 ` Peter Maydell
2020-03-17 15:18 Stefan Hajnoczi
2020-03-17 18:32 ` Peter Maydell
2020-01-14 9:30 Stefan Hajnoczi
2020-01-14 16:00 ` Peter Maydell
2019-10-14 8:52 Stefan Hajnoczi
2019-10-15 11:00 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.