All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier
@ 2019-12-16 23:54 Imre Deak
  2019-12-17  0:00 ` [igt-dev] [PATCH v2] " Imre Deak
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Imre Deak @ 2019-12-16 23:54 UTC (permalink / raw)
  To: igt-dev; +Cc: Dhinakaran Pandiyan

Media compressed framebuffers don't have a CCS CC plane. Add helpers to
select the different types of CCS planes and make sure we setup the
planes correctly for MC framebuffers too.

Note that the order of MC framebuffer planes this change assumes is

plane 0: Y plane
plane 1: UV plane
plane 2: CCS plane for plane 0
plane 3: CCS plane for plane 1

unlike the order defined in the latest decompression kernel patchset.
The above order is the logical one that allows us to keep the existing
way of handling the Y/UV planes.

Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 lib/igt_fb.c | 92 ++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 64 insertions(+), 28 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 3b141b93..8c6c426d 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -487,18 +487,50 @@ static bool is_ccs_modifier(uint64_t modifier)
 		modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
 }
 
+static bool is_ccs_plane(const struct igt_fb *fb, int plane)
+{
+	if (is_gen12_mc_ccs_modifier(fb->modifier))
+		return plane >= fb->num_planes / 2;
+
+	return plane > 0;
+}
+
+static bool is_gen12_ccs_plane(const struct igt_fb *fb, int plane)
+{
+	return is_gen12_ccs_modifier(fb->modifier) && is_ccs_plane(fb, plane);
+}
+
+static bool is_gen12_ccs_cc_plane(const struct igt_fb *fb, int plane)
+{
+	return fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC &&
+	       plane == 2;
+}
+
+static int ccs_to_main_plane(const struct igt_fb *fb, int plane)
+{
+	if (is_gen12_ccs_cc_plane(fb, plane))
+		return 0;
+
+	return plane - fb->num_planes / 2;
+}
+
 static unsigned fb_plane_width(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && plane == 1) {
-		if (is_gen12_ccs_modifier(fb->modifier))
-			return DIV_ROUND_UP(fb->width,
-					    512 / (fb->plane_bpp[0] / 8)) * 64;
-		else
-			return DIV_ROUND_UP(fb->width, 1024) * 128;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
+	if (is_gen12_ccs_cc_plane(fb, plane)) {
 		return 64;
+	} if (is_gen12_ccs_plane(fb, plane)) {
+		int main_plane = ccs_to_main_plane(fb, plane);
+		int width = fb->width;
+
+		if (main_plane)
+			width = DIV_ROUND_UP(width, format->hsub);
+
+		return DIV_ROUND_UP(width,
+				    512 / (fb->plane_bpp[main_plane] / 8)) * 64;
+	} else if (is_ccs_plane(fb, plane)) {
+		 return DIV_ROUND_UP(fb->width, 1024) * 128;
 	}
 
 	if (plane == 0)
@@ -511,7 +543,7 @@ static unsigned fb_plane_bpp(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2))
+	if (is_ccs_plane(fb, plane))
 		return 8;
 	else
 		return format->plane_bpp[plane];
@@ -521,13 +553,18 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && plane == 1) {
-		if (is_gen12_ccs_modifier(fb->modifier))
-			return DIV_ROUND_UP(fb->height, 128) * 4;
-		else
-			return DIV_ROUND_UP(fb->height, 512) * 32;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2)
+	if (is_gen12_ccs_cc_plane(fb, plane)) {
 		return 1;
+	} else if (is_gen12_ccs_plane(fb, plane)) {
+		int height = fb->height;
+
+		if (ccs_to_main_plane(fb, plane))
+			height = DIV_ROUND_UP(height, format->vsub);
+
+		return DIV_ROUND_UP(height, 128) * 4;
+	} else if (is_ccs_plane(fb, plane)) {
+		return DIV_ROUND_UP(fb->height, 512) * 32;
+	}
 
 	if (plane == 0)
 		return fb->height;
@@ -537,16 +574,15 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
 
 static int fb_num_planes(const struct igt_fb *fb)
 {
-	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
+	int num_planes = lookup_drm_format(fb->drm_format)->num_planes;
 
-	if (is_ccs_modifier(fb->modifier)) {
-		if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
-			return 3;
-		else
-			return 2;
-	} else {
-		return format->num_planes;
-	}
+	if (is_ccs_modifier(fb->modifier))
+		num_planes *= 2;
+
+	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
+		num_planes++;
+
+	return num_planes;
 }
 
 void igt_init_fb(struct igt_fb *fb, int fd, int width, int height,
@@ -604,12 +640,12 @@ static uint32_t calc_plane_stride(struct igt_fb *fb, int plane)
 		 * so the easiest way is to align the luma stride to 256.
 		 */
 		return ALIGN(min_stride, 256);
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 1) {
-		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
-		return ALIGN(min_stride, 64);
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
+	} else if (is_gen12_ccs_cc_plane(fb, plane)) {
 		/* clear color always fixed to 64 bytes */
 		return 64;
+	} else if (is_gen12_ccs_plane(fb, plane)) {
+		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
+		return ALIGN(min_stride, 64);
 	} else {
 		unsigned int tile_width, tile_height;
 
@@ -644,7 +680,7 @@ static uint64_t calc_plane_size(struct igt_fb *fb, int plane)
 		size = roundup_power_of_two(size);
 
 		return size;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2)) {
+	} else if (is_gen12_ccs_plane(fb, plane)) {
 		/* The AUX CCS surface must be page aligned */
 		return (uint64_t)fb->strides[plane] *
 			ALIGN(fb->plane_height[plane], 64);
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [igt-dev] [PATCH v2] lib/igt_fb: Add support for the gen12 media compressed modifier
  2019-12-16 23:54 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier Imre Deak
@ 2019-12-17  0:00 ` Imre Deak
  2019-12-17  2:02   ` [igt-dev] [PATCH v3] " Imre Deak
  2019-12-17  1:00 ` [igt-dev] [PATCH i-g-t] " Dhinakaran Pandiyan
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 12+ messages in thread
From: Imre Deak @ 2019-12-17  0:00 UTC (permalink / raw)
  To: igt-dev; +Cc: Dhinakaran Pandiyan

Media compressed framebuffers don't have a CCS CC plane. Add helpers to
select the different types of CCS planes and make sure we setup the
planes correctly for MC framebuffers too.

Note that the order of MC framebuffer planes this change assumes is

plane 0: Y plane
plane 1: UV plane
plane 2: CCS plane for plane 0
plane 3: CCS plane for plane 1

unlike the order defined in the latest decompression kernel patchset.
The above order is the logical one that allows us to keep the existing
way of handling the Y/UV planes.

v2:
- Fix is_ccs_plane() adding the missing is_ccs_modifier() check.

Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 lib/igt_fb.c | 92 ++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 64 insertions(+), 28 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 3b141b93..1dccdc66 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -487,18 +487,50 @@ static bool is_ccs_modifier(uint64_t modifier)
 		modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
 }
 
+static bool is_ccs_plane(const struct igt_fb *fb, int plane)
+{
+	if (is_gen12_mc_ccs_modifier(fb->modifier))
+		return plane >= fb->num_planes / 2;
+
+	return is_ccs_modifier(fb->modifier) && plane > 0;
+}
+
+static bool is_gen12_ccs_plane(const struct igt_fb *fb, int plane)
+{
+	return is_gen12_ccs_modifier(fb->modifier) && is_ccs_plane(fb, plane);
+}
+
+static bool is_gen12_ccs_cc_plane(const struct igt_fb *fb, int plane)
+{
+	return fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC &&
+	       plane == 2;
+}
+
+static int ccs_to_main_plane(const struct igt_fb *fb, int plane)
+{
+	if (is_gen12_ccs_cc_plane(fb, plane))
+		return 0;
+
+	return plane - fb->num_planes / 2;
+}
+
 static unsigned fb_plane_width(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && plane == 1) {
-		if (is_gen12_ccs_modifier(fb->modifier))
-			return DIV_ROUND_UP(fb->width,
-					    512 / (fb->plane_bpp[0] / 8)) * 64;
-		else
-			return DIV_ROUND_UP(fb->width, 1024) * 128;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
+	if (is_gen12_ccs_cc_plane(fb, plane)) {
 		return 64;
+	} if (is_gen12_ccs_plane(fb, plane)) {
+		int main_plane = ccs_to_main_plane(fb, plane);
+		int width = fb->width;
+
+		if (main_plane)
+			width = DIV_ROUND_UP(width, format->hsub);
+
+		return DIV_ROUND_UP(width,
+				    512 / (fb->plane_bpp[main_plane] / 8)) * 64;
+	} else if (is_ccs_plane(fb, plane)) {
+		 return DIV_ROUND_UP(fb->width, 1024) * 128;
 	}
 
 	if (plane == 0)
@@ -511,7 +543,7 @@ static unsigned fb_plane_bpp(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2))
+	if (is_ccs_plane(fb, plane))
 		return 8;
 	else
 		return format->plane_bpp[plane];
@@ -521,13 +553,18 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && plane == 1) {
-		if (is_gen12_ccs_modifier(fb->modifier))
-			return DIV_ROUND_UP(fb->height, 128) * 4;
-		else
-			return DIV_ROUND_UP(fb->height, 512) * 32;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2)
+	if (is_gen12_ccs_cc_plane(fb, plane)) {
 		return 1;
+	} else if (is_gen12_ccs_plane(fb, plane)) {
+		int height = fb->height;
+
+		if (ccs_to_main_plane(fb, plane))
+			height = DIV_ROUND_UP(height, format->vsub);
+
+		return DIV_ROUND_UP(height, 128) * 4;
+	} else if (is_ccs_plane(fb, plane)) {
+		return DIV_ROUND_UP(fb->height, 512) * 32;
+	}
 
 	if (plane == 0)
 		return fb->height;
@@ -537,16 +574,15 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
 
 static int fb_num_planes(const struct igt_fb *fb)
 {
-	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
+	int num_planes = lookup_drm_format(fb->drm_format)->num_planes;
 
-	if (is_ccs_modifier(fb->modifier)) {
-		if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
-			return 3;
-		else
-			return 2;
-	} else {
-		return format->num_planes;
-	}
+	if (is_ccs_modifier(fb->modifier))
+		num_planes *= 2;
+
+	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
+		num_planes++;
+
+	return num_planes;
 }
 
 void igt_init_fb(struct igt_fb *fb, int fd, int width, int height,
@@ -604,12 +640,12 @@ static uint32_t calc_plane_stride(struct igt_fb *fb, int plane)
 		 * so the easiest way is to align the luma stride to 256.
 		 */
 		return ALIGN(min_stride, 256);
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 1) {
-		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
-		return ALIGN(min_stride, 64);
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
+	} else if (is_gen12_ccs_cc_plane(fb, plane)) {
 		/* clear color always fixed to 64 bytes */
 		return 64;
+	} else if (is_gen12_ccs_plane(fb, plane)) {
+		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
+		return ALIGN(min_stride, 64);
 	} else {
 		unsigned int tile_width, tile_height;
 
@@ -644,7 +680,7 @@ static uint64_t calc_plane_size(struct igt_fb *fb, int plane)
 		size = roundup_power_of_two(size);
 
 		return size;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2)) {
+	} else if (is_gen12_ccs_plane(fb, plane)) {
 		/* The AUX CCS surface must be page aligned */
 		return (uint64_t)fb->strides[plane] *
 			ALIGN(fb->plane_height[plane], 64);
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier
  2019-12-16 23:54 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier Imre Deak
  2019-12-17  0:00 ` [igt-dev] [PATCH v2] " Imre Deak
@ 2019-12-17  1:00 ` Dhinakaran Pandiyan
  2019-12-17  1:53   ` Imre Deak
  2019-12-17  1:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev2) Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 12+ messages in thread
From: Dhinakaran Pandiyan @ 2019-12-17  1:00 UTC (permalink / raw)
  To: Imre Deak, igt-dev

On Tue, 2019-12-17 at 01:54 +0200, Imre Deak wrote:
> Media compressed framebuffers don't have a CCS CC plane. Add helpers to
> select the different types of CCS planes and make sure we setup the
> planes correctly for MC framebuffers too.
> 
> Note that the order of MC framebuffer planes this change assumes is
> 
> plane 0: Y plane
> plane 1: UV plane
> plane 2: CCS plane for plane 0
> plane 3: CCS plane for plane 1
> 
> unlike the order defined in the latest decompression kernel patchset.

Hmm. that is indeed the order in the latest (back in September) patch set I sent out  
https://patchwork.freedesktop.org/patch/333113/?series=67078&rev=3

+static bool is_ccs_plane(const struct drm_framebuffer *fb, int color_plane)
+{
+	if (!is_ccs_modifier(fb->modifier))
+		return false;
+
+	return color_plane >= fb->format->num_planes / 2;
+}


The docs in the modifier were probably not updated.

-DK

> The above order is the logical one that allows us to keep the existing
> way of handling the Y/UV planes.
> 
> Cc: Mika Kahola <mika.kahola@intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  lib/igt_fb.c | 92 ++++++++++++++++++++++++++++++++++++----------------
>  1 file changed, 64 insertions(+), 28 deletions(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 3b141b93..8c6c426d 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -487,18 +487,50 @@ static bool is_ccs_modifier(uint64_t modifier)
>  		modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
>  }
>  
> +static bool is_ccs_plane(const struct igt_fb *fb, int plane)
> +{
> +	if (is_gen12_mc_ccs_modifier(fb->modifier))
> +		return plane >= fb->num_planes / 2;
> +
> +	return plane > 0;
> +}
> +
> +static bool is_gen12_ccs_plane(const struct igt_fb *fb, int plane)
> +{
> +	return is_gen12_ccs_modifier(fb->modifier) && is_ccs_plane(fb, plane);
> +}
> +
> +static bool is_gen12_ccs_cc_plane(const struct igt_fb *fb, int plane)
> +{
> +	return fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC &&
> +	       plane == 2;
> +}
> +
> +static int ccs_to_main_plane(const struct igt_fb *fb, int plane)
> +{
> +	if (is_gen12_ccs_cc_plane(fb, plane))
> +		return 0;
> +
> +	return plane - fb->num_planes / 2;
> +}
> +
>  static unsigned fb_plane_width(const struct igt_fb *fb, int plane)
>  {
>  	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
>  
> -	if (is_ccs_modifier(fb->modifier) && plane == 1) {
> -		if (is_gen12_ccs_modifier(fb->modifier))
> -			return DIV_ROUND_UP(fb->width,
> -					    512 / (fb->plane_bpp[0] / 8)) * 64;
> -		else
> -			return DIV_ROUND_UP(fb->width, 1024) * 128;
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
> +	if (is_gen12_ccs_cc_plane(fb, plane)) {
>  		return 64;
> +	} if (is_gen12_ccs_plane(fb, plane)) {
> +		int main_plane = ccs_to_main_plane(fb, plane);
> +		int width = fb->width;
> +
> +		if (main_plane)
> +			width = DIV_ROUND_UP(width, format->hsub);
> +
> +		return DIV_ROUND_UP(width,
> +				    512 / (fb->plane_bpp[main_plane] / 8)) * 64;
> +	} else if (is_ccs_plane(fb, plane)) {
> +		 return DIV_ROUND_UP(fb->width, 1024) * 128;
>  	}
>  
>  	if (plane == 0)
> @@ -511,7 +543,7 @@ static unsigned fb_plane_bpp(const struct igt_fb *fb, int plane)
>  {
>  	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
>  
> -	if (is_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2))
> +	if (is_ccs_plane(fb, plane))
>  		return 8;
>  	else
>  		return format->plane_bpp[plane];
> @@ -521,13 +553,18 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
>  {
>  	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
>  
> -	if (is_ccs_modifier(fb->modifier) && plane == 1) {
> -		if (is_gen12_ccs_modifier(fb->modifier))
> -			return DIV_ROUND_UP(fb->height, 128) * 4;
> -		else
> -			return DIV_ROUND_UP(fb->height, 512) * 32;
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2)
> +	if (is_gen12_ccs_cc_plane(fb, plane)) {
>  		return 1;
> +	} else if (is_gen12_ccs_plane(fb, plane)) {
> +		int height = fb->height;
> +
> +		if (ccs_to_main_plane(fb, plane))
> +			height = DIV_ROUND_UP(height, format->vsub);
> +
> +		return DIV_ROUND_UP(height, 128) * 4;
> +	} else if (is_ccs_plane(fb, plane)) {
> +		return DIV_ROUND_UP(fb->height, 512) * 32;
> +	}
>  
>  	if (plane == 0)
>  		return fb->height;
> @@ -537,16 +574,15 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
>  
>  static int fb_num_planes(const struct igt_fb *fb)
>  {
> -	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
> +	int num_planes = lookup_drm_format(fb->drm_format)->num_planes;
>  
> -	if (is_ccs_modifier(fb->modifier)) {
> -		if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
> -			return 3;
> -		else
> -			return 2;
> -	} else {
> -		return format->num_planes;
> -	}
> +	if (is_ccs_modifier(fb->modifier))
> +		num_planes *= 2;
> +
> +	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
> +		num_planes++;
> +
> +	return num_planes;
>  }
>  
>  void igt_init_fb(struct igt_fb *fb, int fd, int width, int height,
> @@ -604,12 +640,12 @@ static uint32_t calc_plane_stride(struct igt_fb *fb, int plane)
>  		 * so the easiest way is to align the luma stride to 256.
>  		 */
>  		return ALIGN(min_stride, 256);
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 1) {
> -		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
> -		return ALIGN(min_stride, 64);
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
> +	} else if (is_gen12_ccs_cc_plane(fb, plane)) {
>  		/* clear color always fixed to 64 bytes */
>  		return 64;
> +	} else if (is_gen12_ccs_plane(fb, plane)) {
> +		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
> +		return ALIGN(min_stride, 64);
>  	} else {
>  		unsigned int tile_width, tile_height;
>  
> @@ -644,7 +680,7 @@ static uint64_t calc_plane_size(struct igt_fb *fb, int plane)
>  		size = roundup_power_of_two(size);
>  
>  		return size;
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2)) {
> +	} else if (is_gen12_ccs_plane(fb, plane)) {
>  		/* The AUX CCS surface must be page aligned */
>  		return (uint64_t)fb->strides[plane] *
>  			ALIGN(fb->plane_height[plane], 64);

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev2)
  2019-12-16 23:54 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier Imre Deak
  2019-12-17  0:00 ` [igt-dev] [PATCH v2] " Imre Deak
  2019-12-17  1:00 ` [igt-dev] [PATCH i-g-t] " Dhinakaran Pandiyan
@ 2019-12-17  1:06 ` Patchwork
  2019-12-17  3:08 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3) Patchwork
  2019-12-17  8:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-12-17  1:06 UTC (permalink / raw)
  To: Imre Deak; +Cc: igt-dev

== Series Details ==

Series: lib/igt_fb: Add support for the gen12 media compressed modifier (rev2)
URL   : https://patchwork.freedesktop.org/series/71012/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7578 -> IGTPW_3868
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3868 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3868, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3868:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_gt_heartbeat:
    - fi-tgl-y:           [PASS][1] -> [DMESG-FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-tgl-y/igt@i915_selftest@live_gt_heartbeat.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-tgl-y/igt@i915_selftest@live_gt_heartbeat.html

  
Known issues
------------

  Here are the changes found in IGTPW_3868 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [PASS][3] -> [DMESG-WARN][4] ([i915#592])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770r:       [PASS][5] -> [DMESG-FAIL][6] ([i915#770])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770r/igt@i915_selftest@live_blt.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-hsw-4770r/igt@i915_selftest@live_blt.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-icl-u2:          [FAIL][7] ([fdo#103375]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-icl-u2:          [FAIL][9] ([fdo#111550]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-n2820:       [DMESG-FAIL][11] ([i915#722]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
    - fi-cfl-guc:         [DMESG-FAIL][13] ([i915#730]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_busy@basic-flip-pipe-a:
    - fi-icl-u2:          [INCOMPLETE][15] ([i915#140]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][17] ([fdo#109635] / [i915#217]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][19] ([fdo#111096] / [i915#323]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][21] ([i915#62] / [i915#92]) -> [DMESG-WARN][22] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][23] ([i915#553] / [i915#725]) -> [DMESG-FAIL][24] ([i915#563])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-kbl-x1275:       [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +10 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
  [i915#592]: https://gitlab.freedesktop.org/drm/intel/issues/592
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#730]: https://gitlab.freedesktop.org/drm/intel/issues/730
  [i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (51 -> 45)
------------------------------

  Additional (2): fi-kbl-soraka fi-kbl-7560u 
  Missing    (8): fi-ilk-m540 fi-tgl-u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5349 -> IGTPW_3868

  CI-20190529: 20190529
  CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3868: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/index.html
  IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3868/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier
  2019-12-17  1:00 ` [igt-dev] [PATCH i-g-t] " Dhinakaran Pandiyan
@ 2019-12-17  1:53   ` Imre Deak
  0 siblings, 0 replies; 12+ messages in thread
From: Imre Deak @ 2019-12-17  1:53 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: igt-dev

On Mon, Dec 16, 2019 at 05:00:47PM -0800, Dhinakaran Pandiyan wrote:
> On Tue, 2019-12-17 at 01:54 +0200, Imre Deak wrote:
> > Media compressed framebuffers don't have a CCS CC plane. Add helpers to
> > select the different types of CCS planes and make sure we setup the
> > planes correctly for MC framebuffers too.
> > 
> > Note that the order of MC framebuffer planes this change assumes is
> > 
> > plane 0: Y plane
> > plane 1: UV plane
> > plane 2: CCS plane for plane 0
> > plane 3: CCS plane for plane 1
> > 
> > unlike the order defined in the latest decompression kernel patchset.
> 
> Hmm. that is indeed the order in the latest (back in September) patch set I sent out  
> https://patchwork.freedesktop.org/patch/333113/?series=67078&rev=3

The patchset was resent in October that uses a different order and
that's what I picked up:
https://patchwork.freedesktop.org/patch/337991/?series=66814&rev=9

> +static bool is_ccs_plane(const struct drm_framebuffer *fb, int color_plane)
> +{
> +	if (!is_ccs_modifier(fb->modifier))
> +		return false;
> +
> +	return color_plane >= fb->format->num_planes / 2;
> +}

Thanks, this is simpler.

> The docs in the modifier were probably not updated.

I'll update the docs in the kernel patchset.

> 
> -DK
> 
> > The above order is the logical one that allows us to keep the existing
> > way of handling the Y/UV planes.
> > 
> > Cc: Mika Kahola <mika.kahola@intel.com>
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  lib/igt_fb.c | 92 ++++++++++++++++++++++++++++++++++++----------------
> >  1 file changed, 64 insertions(+), 28 deletions(-)
> > 
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index 3b141b93..8c6c426d 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -487,18 +487,50 @@ static bool is_ccs_modifier(uint64_t modifier)
> >  		modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
> >  }
> >  
> > +static bool is_ccs_plane(const struct igt_fb *fb, int plane)
> > +{
> > +	if (is_gen12_mc_ccs_modifier(fb->modifier))
> > +		return plane >= fb->num_planes / 2;
> > +
> > +	return plane > 0;
> > +}
> > +
> > +static bool is_gen12_ccs_plane(const struct igt_fb *fb, int plane)
> > +{
> > +	return is_gen12_ccs_modifier(fb->modifier) && is_ccs_plane(fb, plane);
> > +}
> > +
> > +static bool is_gen12_ccs_cc_plane(const struct igt_fb *fb, int plane)
> > +{
> > +	return fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC &&
> > +	       plane == 2;
> > +}
> > +
> > +static int ccs_to_main_plane(const struct igt_fb *fb, int plane)
> > +{
> > +	if (is_gen12_ccs_cc_plane(fb, plane))
> > +		return 0;
> > +
> > +	return plane - fb->num_planes / 2;
> > +}
> > +
> >  static unsigned fb_plane_width(const struct igt_fb *fb, int plane)
> >  {
> >  	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
> >  
> > -	if (is_ccs_modifier(fb->modifier) && plane == 1) {
> > -		if (is_gen12_ccs_modifier(fb->modifier))
> > -			return DIV_ROUND_UP(fb->width,
> > -					    512 / (fb->plane_bpp[0] / 8)) * 64;
> > -		else
> > -			return DIV_ROUND_UP(fb->width, 1024) * 128;
> > -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
> > +	if (is_gen12_ccs_cc_plane(fb, plane)) {
> >  		return 64;
> > +	} if (is_gen12_ccs_plane(fb, plane)) {
> > +		int main_plane = ccs_to_main_plane(fb, plane);
> > +		int width = fb->width;
> > +
> > +		if (main_plane)
> > +			width = DIV_ROUND_UP(width, format->hsub);
> > +
> > +		return DIV_ROUND_UP(width,
> > +				    512 / (fb->plane_bpp[main_plane] / 8)) * 64;
> > +	} else if (is_ccs_plane(fb, plane)) {
> > +		 return DIV_ROUND_UP(fb->width, 1024) * 128;
> >  	}
> >  
> >  	if (plane == 0)
> > @@ -511,7 +543,7 @@ static unsigned fb_plane_bpp(const struct igt_fb *fb, int plane)
> >  {
> >  	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
> >  
> > -	if (is_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2))
> > +	if (is_ccs_plane(fb, plane))
> >  		return 8;
> >  	else
> >  		return format->plane_bpp[plane];
> > @@ -521,13 +553,18 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
> >  {
> >  	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
> >  
> > -	if (is_ccs_modifier(fb->modifier) && plane == 1) {
> > -		if (is_gen12_ccs_modifier(fb->modifier))
> > -			return DIV_ROUND_UP(fb->height, 128) * 4;
> > -		else
> > -			return DIV_ROUND_UP(fb->height, 512) * 32;
> > -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2)
> > +	if (is_gen12_ccs_cc_plane(fb, plane)) {
> >  		return 1;
> > +	} else if (is_gen12_ccs_plane(fb, plane)) {
> > +		int height = fb->height;
> > +
> > +		if (ccs_to_main_plane(fb, plane))
> > +			height = DIV_ROUND_UP(height, format->vsub);
> > +
> > +		return DIV_ROUND_UP(height, 128) * 4;
> > +	} else if (is_ccs_plane(fb, plane)) {
> > +		return DIV_ROUND_UP(fb->height, 512) * 32;
> > +	}
> >  
> >  	if (plane == 0)
> >  		return fb->height;
> > @@ -537,16 +574,15 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
> >  
> >  static int fb_num_planes(const struct igt_fb *fb)
> >  {
> > -	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
> > +	int num_planes = lookup_drm_format(fb->drm_format)->num_planes;
> >  
> > -	if (is_ccs_modifier(fb->modifier)) {
> > -		if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
> > -			return 3;
> > -		else
> > -			return 2;
> > -	} else {
> > -		return format->num_planes;
> > -	}
> > +	if (is_ccs_modifier(fb->modifier))
> > +		num_planes *= 2;
> > +
> > +	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
> > +		num_planes++;
> > +
> > +	return num_planes;
> >  }
> >  
> >  void igt_init_fb(struct igt_fb *fb, int fd, int width, int height,
> > @@ -604,12 +640,12 @@ static uint32_t calc_plane_stride(struct igt_fb *fb, int plane)
> >  		 * so the easiest way is to align the luma stride to 256.
> >  		 */
> >  		return ALIGN(min_stride, 256);
> > -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 1) {
> > -		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
> > -		return ALIGN(min_stride, 64);
> > -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
> > +	} else if (is_gen12_ccs_cc_plane(fb, plane)) {
> >  		/* clear color always fixed to 64 bytes */
> >  		return 64;
> > +	} else if (is_gen12_ccs_plane(fb, plane)) {
> > +		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
> > +		return ALIGN(min_stride, 64);
> >  	} else {
> >  		unsigned int tile_width, tile_height;
> >  
> > @@ -644,7 +680,7 @@ static uint64_t calc_plane_size(struct igt_fb *fb, int plane)
> >  		size = roundup_power_of_two(size);
> >  
> >  		return size;
> > -	} else if (is_gen12_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2)) {
> > +	} else if (is_gen12_ccs_plane(fb, plane)) {
> >  		/* The AUX CCS surface must be page aligned */
> >  		return (uint64_t)fb->strides[plane] *
> >  			ALIGN(fb->plane_height[plane], 64);
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [igt-dev] [PATCH v3] lib/igt_fb: Add support for the gen12 media compressed modifier
  2019-12-17  0:00 ` [igt-dev] [PATCH v2] " Imre Deak
@ 2019-12-17  2:02   ` Imre Deak
  2019-12-17 14:25     ` Kahola, Mika
  0 siblings, 1 reply; 12+ messages in thread
From: Imre Deak @ 2019-12-17  2:02 UTC (permalink / raw)
  To: igt-dev; +Cc: Dhinakaran Pandiyan

Media compressed framebuffers don't have a CCS CC plane. Add helpers to
select the different types of CCS planes and make sure we setup the
planes correctly for MC framebuffers too.

Note that the order of MC framebuffer planes this change assumes is

plane 0: Y plane
plane 1: UV plane
plane 2: CCS plane for plane 0
plane 3: CCS plane for plane 1

unlike the order defined in the latest decompression kernel patchset.
The above order is the logical one that allows us to keep the existing
way of handling the Y/UV planes.

v2:
- Fix is_ccs_plane() adding the missing is_ccs_modifier() check.
v3:
- Simplify is_ccs_plane(). (DK)

Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 lib/igt_fb.c | 92 ++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 64 insertions(+), 28 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 3b141b93..e6eb39ac 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -487,18 +487,50 @@ static bool is_ccs_modifier(uint64_t modifier)
 		modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
 }
 
+static bool is_ccs_plane(const struct igt_fb *fb, int plane)
+{
+	if (!is_ccs_modifier(fb->modifier))
+		return false;
+
+	return plane >= fb->num_planes / 2;
+}
+
+static bool is_gen12_ccs_plane(const struct igt_fb *fb, int plane)
+{
+	return is_gen12_ccs_modifier(fb->modifier) && is_ccs_plane(fb, plane);
+}
+
+static bool is_gen12_ccs_cc_plane(const struct igt_fb *fb, int plane)
+{
+	return fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC &&
+	       plane == 2;
+}
+
+static int ccs_to_main_plane(const struct igt_fb *fb, int plane)
+{
+	if (is_gen12_ccs_cc_plane(fb, plane))
+		return 0;
+
+	return plane - fb->num_planes / 2;
+}
+
 static unsigned fb_plane_width(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && plane == 1) {
-		if (is_gen12_ccs_modifier(fb->modifier))
-			return DIV_ROUND_UP(fb->width,
-					    512 / (fb->plane_bpp[0] / 8)) * 64;
-		else
-			return DIV_ROUND_UP(fb->width, 1024) * 128;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
+	if (is_gen12_ccs_cc_plane(fb, plane)) {
 		return 64;
+	} if (is_gen12_ccs_plane(fb, plane)) {
+		int main_plane = ccs_to_main_plane(fb, plane);
+		int width = fb->width;
+
+		if (main_plane)
+			width = DIV_ROUND_UP(width, format->hsub);
+
+		return DIV_ROUND_UP(width,
+				    512 / (fb->plane_bpp[main_plane] / 8)) * 64;
+	} else if (is_ccs_plane(fb, plane)) {
+		 return DIV_ROUND_UP(fb->width, 1024) * 128;
 	}
 
 	if (plane == 0)
@@ -511,7 +543,7 @@ static unsigned fb_plane_bpp(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2))
+	if (is_ccs_plane(fb, plane))
 		return 8;
 	else
 		return format->plane_bpp[plane];
@@ -521,13 +553,18 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
 {
 	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
 
-	if (is_ccs_modifier(fb->modifier) && plane == 1) {
-		if (is_gen12_ccs_modifier(fb->modifier))
-			return DIV_ROUND_UP(fb->height, 128) * 4;
-		else
-			return DIV_ROUND_UP(fb->height, 512) * 32;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2)
+	if (is_gen12_ccs_cc_plane(fb, plane)) {
 		return 1;
+	} else if (is_gen12_ccs_plane(fb, plane)) {
+		int height = fb->height;
+
+		if (ccs_to_main_plane(fb, plane))
+			height = DIV_ROUND_UP(height, format->vsub);
+
+		return DIV_ROUND_UP(height, 128) * 4;
+	} else if (is_ccs_plane(fb, plane)) {
+		return DIV_ROUND_UP(fb->height, 512) * 32;
+	}
 
 	if (plane == 0)
 		return fb->height;
@@ -537,16 +574,15 @@ static unsigned fb_plane_height(const struct igt_fb *fb, int plane)
 
 static int fb_num_planes(const struct igt_fb *fb)
 {
-	const struct format_desc_struct *format = lookup_drm_format(fb->drm_format);
+	int num_planes = lookup_drm_format(fb->drm_format)->num_planes;
 
-	if (is_ccs_modifier(fb->modifier)) {
-		if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
-			return 3;
-		else
-			return 2;
-	} else {
-		return format->num_planes;
-	}
+	if (is_ccs_modifier(fb->modifier))
+		num_planes *= 2;
+
+	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
+		num_planes++;
+
+	return num_planes;
 }
 
 void igt_init_fb(struct igt_fb *fb, int fd, int width, int height,
@@ -604,12 +640,12 @@ static uint32_t calc_plane_stride(struct igt_fb *fb, int plane)
 		 * so the easiest way is to align the luma stride to 256.
 		 */
 		return ALIGN(min_stride, 256);
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 1) {
-		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
-		return ALIGN(min_stride, 64);
-	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
+	} else if (is_gen12_ccs_cc_plane(fb, plane)) {
 		/* clear color always fixed to 64 bytes */
 		return 64;
+	} else if (is_gen12_ccs_plane(fb, plane)) {
+		/* A main surface using a CCS AUX surface must be 4x4 tiles aligned. */
+		return ALIGN(min_stride, 64);
 	} else {
 		unsigned int tile_width, tile_height;
 
@@ -644,7 +680,7 @@ static uint64_t calc_plane_size(struct igt_fb *fb, int plane)
 		size = roundup_power_of_two(size);
 
 		return size;
-	} else if (is_gen12_ccs_modifier(fb->modifier) && (plane == 1 || plane == 2)) {
+	} else if (is_gen12_ccs_plane(fb, plane)) {
 		/* The AUX CCS surface must be page aligned */
 		return (uint64_t)fb->strides[plane] *
 			ALIGN(fb->plane_height[plane], 64);
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
  2019-12-16 23:54 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier Imre Deak
                   ` (2 preceding siblings ...)
  2019-12-17  1:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev2) Patchwork
@ 2019-12-17  3:08 ` Patchwork
  2019-12-17  8:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-12-17  3:08 UTC (permalink / raw)
  To: Imre Deak; +Cc: igt-dev

== Series Details ==

Series: lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
URL   : https://patchwork.freedesktop.org/series/71012/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7578 -> IGTPW_3869
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html

Known issues
------------

  Here are the changes found in IGTPW_3869 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_sync@basic-all:
    - fi-tgl-y:           [PASS][1] -> [INCOMPLETE][2] ([i915#470] / [i915#472])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-tgl-y/igt@gem_sync@basic-all.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-tgl-y/igt@gem_sync@basic-all.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770r:       [PASS][3] -> [DMESG-FAIL][4] ([i915#725])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770r/igt@i915_selftest@live_blt.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-hsw-4770r/igt@i915_selftest@live_blt.html

  
#### Possible fixes ####

  * igt@gem_exec_parallel@basic:
    - {fi-tgl-u}:         [INCOMPLETE][5] ([i915#476]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-tgl-u/igt@gem_exec_parallel@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-tgl-u/igt@gem_exec_parallel@basic.html

  * igt@gem_exec_suspend@basic-s3:
    - fi-icl-u2:          [FAIL][7] ([fdo#103375]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-icl-u2:          [FAIL][9] ([fdo#111550]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-guc:         [DMESG-FAIL][11] ([i915#730]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_busy@basic-flip-pipe-a:
    - fi-icl-u2:          [INCOMPLETE][13] ([i915#140]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][15] ([fdo#109635] / [i915#217]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][17] ([fdo#111096] / [i915#323]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][19] ([i915#62] / [i915#92]) -> [DMESG-WARN][20] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][21] ([i915#553] / [i915#725]) -> [DMESG-FAIL][22] ([i915#563])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-n2820:       [DMESG-FAIL][23] ([i915#722]) -> [INCOMPLETE][24] ([i915#45])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-kbl-x1275:       [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +9 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
  [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
  [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#730]: https://gitlab.freedesktop.org/drm/intel/issues/730
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (51 -> 45)
------------------------------

  Additional (1): fi-kbl-soraka 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5349 -> IGTPW_3869

  CI-20190529: 20190529
  CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3869: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
  IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
  2019-12-16 23:54 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier Imre Deak
                   ` (3 preceding siblings ...)
  2019-12-17  3:08 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3) Patchwork
@ 2019-12-17  8:47 ` Patchwork
  2019-12-17 11:29   ` Imre Deak
  4 siblings, 1 reply; 12+ messages in thread
From: Patchwork @ 2019-12-17  8:47 UTC (permalink / raw)
  To: Imre Deak; +Cc: igt-dev

== Series Details ==

Series: lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
URL   : https://patchwork.freedesktop.org/series/71012/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7578_full -> IGTPW_3869_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3869_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3869_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3869_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_flush@basic-batch-kernel-default-cmd:
    - shard-hsw:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html

  
Known issues
------------

  Here are the changes found in IGTPW_3869_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +5 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_exec_schedule@fifo-bsd1:
    - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#109276])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@gem_exec_schedule@fifo-bsd1.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb3/igt@gem_exec_schedule@fifo-bsd1.html

  * igt@gem_exec_schedule@preempt-queue-bsd:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#112146])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd.html

  * igt@gem_exec_schedule@preempt-queue-chain-bsd1:
    - shard-tglb:         [PASS][9] -> [INCOMPLETE][10] ([fdo#111606] / [fdo#111677])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-tglb:         [PASS][11] -> [TIMEOUT][12] ([i915#530])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-thrashing.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb1/igt@gem_persistent_relocs@forked-thrashing.html
    - shard-hsw:          [PASS][13] -> [FAIL][14] ([i915#520])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_persistent_relocs@forked-thrashing.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw6/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-glk:          [PASS][15] -> [FAIL][16] ([i915#644])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
    - shard-kbl:          [PASS][17] -> [FAIL][18] ([i915#644])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl7/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_sync@basic-many-each:
    - shard-tglb:         [PASS][19] -> [INCOMPLETE][20] ([i915#472] / [i915#707])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_sync@basic-many-each.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb8/igt@gem_sync@basic-many-each.html

  * igt@gem_tiled_partial_pwrite_pread@writes-after-reads:
    - shard-hsw:          [PASS][21] -> [FAIL][22] ([i915#817])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw1/igt@gem_tiled_partial_pwrite_pread@writes-after-reads.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@gem_tiled_partial_pwrite_pread@writes-after-reads.html

  * igt@gem_workarounds@suspend-resume-fd:
    - shard-apl:          [PASS][23] -> [DMESG-WARN][24] ([i915#180])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-fd.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl1/igt@gem_workarounds@suspend-resume-fd.html

  * igt@i915_pm_rpm@cursor:
    - shard-apl:          [PASS][25] -> [SKIP][26] ([fdo#109271])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_pm_rpm@cursor.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl2/igt@i915_pm_rpm@cursor.html

  * igt@i915_selftest@live_hangcheck:
    - shard-tglb:         [PASS][27] -> [INCOMPLETE][28] ([i915#435])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@i915_selftest@live_hangcheck.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb8/igt@i915_selftest@live_hangcheck.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
    - shard-tglb:         [PASS][29] -> [FAIL][30] ([i915#49])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
    - shard-tglb:         [PASS][31] -> [INCOMPLETE][32] ([i915#474] / [i915#667]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html

  * igt@kms_plane@pixel-format-pipe-b-planes:
    - shard-kbl:          [PASS][33] -> [INCOMPLETE][34] ([fdo#103665] / [i915#648] / [i915#667])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@kms_plane@pixel-format-pipe-b-planes.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl4/igt@kms_plane@pixel-format-pipe-b-planes.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][35] -> [FAIL][36] ([i915#31])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@kms_setmode@basic.html

  * igt@perf@oa-exponents:
    - shard-tglb:         [PASS][37] -> [FAIL][38] ([i915#84])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@perf@oa-exponents.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb6/igt@perf@oa-exponents.html

  * igt@perf_pmu@cpu-hotplug:
    - shard-tglb:         [PASS][39] -> [DMESG-WARN][40] ([i915#799])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@perf_pmu@cpu-hotplug.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb5/igt@perf_pmu@cpu-hotplug.html

  
#### Possible fixes ####

  * igt@gem_busy@close-race:
    - shard-tglb:         [INCOMPLETE][41] ([i915#435]) -> [PASS][42] +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@gem_busy@close-race.html

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-tglb:         [INCOMPLETE][43] ([i915#456]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_ctx_persistence@vcs0-mixed-process:
    - shard-apl:          [FAIL][45] ([i915#679]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html

  * igt@gem_eio@banned:
    - shard-tglb:         [INCOMPLETE][47] ([i915#476]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@gem_eio@banned.html

  * igt@gem_eio@suspend:
    - shard-tglb:         [INCOMPLETE][49] ([i915#460]) -> [PASS][50] +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_eio@suspend.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb5/igt@gem_eio@suspend.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd2:
    - shard-iclb:         [SKIP][51] ([fdo#109276]) -> [PASS][52] +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd2.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd2.html

  * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
    - shard-tglb:         [INCOMPLETE][53] ([fdo#111677]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb1/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html

  * igt@gem_exec_schedule@preemptive-hang-bsd:
    - shard-iclb:         [SKIP][55] ([fdo#112146]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html

  * {igt@gen9_exec_parse@allowed-single}:
    - shard-glk:          [DMESG-WARN][57] ([i915#716]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk3/igt@gen9_exec_parse@allowed-single.html
    - shard-apl:          [DMESG-WARN][59] ([i915#716]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl8/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +3 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
    - shard-hsw:          [DMESG-WARN][63] ([IGT#6]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-tglb:         [INCOMPLETE][65] ([i915#456] / [i915#460]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][67] ([i915#180]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [FAIL][69] ([i915#79]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-apl:          [FAIL][71] ([i915#79]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-tglb:         [INCOMPLETE][73] ([i915#460] / [i915#516]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@kms_flip@flip-vs-suspend.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
    - shard-glk:          [FAIL][75] ([i915#49]) -> [PASS][76]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
    - shard-tglb:         [FAIL][77] ([i915#49]) -> [PASS][78] +1 similar issue
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs2-dirty-create:
    - shard-tglb:         [SKIP][79] ([fdo#111912] / [fdo#112080]) -> [SKIP][80] ([fdo#112080])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_ctx_isolation@vcs2-dirty-create.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@gem_ctx_isolation@vcs2-dirty-create.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
  [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
  [fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
  [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
  [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
  [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
  [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
  [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#516]: https://gitlab.freedesktop.org/drm/intel/issues/516
  [i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
  [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
  [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
  [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
  [i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667
  [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
  [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#799]: https://gitlab.freedesktop.org/drm/intel/issues/799
  [i915#817]: https://gitlab.freedesktop.org/drm/intel/issues/817
  [i915#84]: https://gitlab.freedesktop.org/drm/intel/issues/84


Participating hosts (10 -> 8)
------------------------------

  Missing    (2): pig-skl-6260u pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5349 -> IGTPW_3869
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3869: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
  IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
  2019-12-17  8:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-12-17 11:29   ` Imre Deak
  2019-12-17 11:51     ` Vudum, Lakshminarayana
  0 siblings, 1 reply; 12+ messages in thread
From: Imre Deak @ 2019-12-17 11:29 UTC (permalink / raw)
  To: igt-dev; +Cc: Lakshminarayana Vudum

On Tue, Dec 17, 2019 at 08:47:36AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
> URL   : https://patchwork.freedesktop.org/series/71012/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7578_full -> IGTPW_3869_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with IGTPW_3869_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in IGTPW_3869_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in IGTPW_3869_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_exec_flush@basic-batch-kernel-default-cmd:
>     - shard-hsw:          [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html

There is no compression support on HSW, so the changes in the patch are
unrelated to the above failure.

> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in IGTPW_3869_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_ctx_isolation@rcs0-s3:
>     - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +5 similar issues
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
> 
>   * igt@gem_exec_schedule@fifo-bsd1:
>     - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#109276])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@gem_exec_schedule@fifo-bsd1.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb3/igt@gem_exec_schedule@fifo-bsd1.html
> 
>   * igt@gem_exec_schedule@preempt-queue-bsd:
>     - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#112146])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd.html
> 
>   * igt@gem_exec_schedule@preempt-queue-chain-bsd1:
>     - shard-tglb:         [PASS][9] -> [INCOMPLETE][10] ([fdo#111606] / [fdo#111677])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
> 
>   * igt@gem_persistent_relocs@forked-thrashing:
>     - shard-tglb:         [PASS][11] -> [TIMEOUT][12] ([i915#530])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-thrashing.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb1/igt@gem_persistent_relocs@forked-thrashing.html
>     - shard-hsw:          [PASS][13] -> [FAIL][14] ([i915#520])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_persistent_relocs@forked-thrashing.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw6/igt@gem_persistent_relocs@forked-thrashing.html
> 
>   * igt@gem_ppgtt@flink-and-close-vma-leak:
>     - shard-glk:          [PASS][15] -> [FAIL][16] ([i915#644])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
>     - shard-kbl:          [PASS][17] -> [FAIL][18] ([i915#644])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl7/igt@gem_ppgtt@flink-and-close-vma-leak.html
> 
>   * igt@gem_sync@basic-many-each:
>     - shard-tglb:         [PASS][19] -> [INCOMPLETE][20] ([i915#472] / [i915#707])
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_sync@basic-many-each.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb8/igt@gem_sync@basic-many-each.html
> 
>   * igt@gem_tiled_partial_pwrite_pread@writes-after-reads:
>     - shard-hsw:          [PASS][21] -> [FAIL][22] ([i915#817])
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw1/igt@gem_tiled_partial_pwrite_pread@writes-after-reads.html
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@gem_tiled_partial_pwrite_pread@writes-after-reads.html
> 
>   * igt@gem_workarounds@suspend-resume-fd:
>     - shard-apl:          [PASS][23] -> [DMESG-WARN][24] ([i915#180])
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-fd.html
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl1/igt@gem_workarounds@suspend-resume-fd.html
> 
>   * igt@i915_pm_rpm@cursor:
>     - shard-apl:          [PASS][25] -> [SKIP][26] ([fdo#109271])
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_pm_rpm@cursor.html
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl2/igt@i915_pm_rpm@cursor.html
> 
>   * igt@i915_selftest@live_hangcheck:
>     - shard-tglb:         [PASS][27] -> [INCOMPLETE][28] ([i915#435])
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@i915_selftest@live_hangcheck.html
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb8/igt@i915_selftest@live_hangcheck.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
>     - shard-tglb:         [PASS][29] -> [FAIL][30] ([i915#49])
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
>     - shard-tglb:         [PASS][31] -> [INCOMPLETE][32] ([i915#474] / [i915#667]) +1 similar issue
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
> 
>   * igt@kms_plane@pixel-format-pipe-b-planes:
>     - shard-kbl:          [PASS][33] -> [INCOMPLETE][34] ([fdo#103665] / [i915#648] / [i915#667])
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@kms_plane@pixel-format-pipe-b-planes.html
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl4/igt@kms_plane@pixel-format-pipe-b-planes.html
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          [PASS][35] -> [FAIL][36] ([i915#31])
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@kms_setmode@basic.html
> 
>   * igt@perf@oa-exponents:
>     - shard-tglb:         [PASS][37] -> [FAIL][38] ([i915#84])
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@perf@oa-exponents.html
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb6/igt@perf@oa-exponents.html
> 
>   * igt@perf_pmu@cpu-hotplug:
>     - shard-tglb:         [PASS][39] -> [DMESG-WARN][40] ([i915#799])
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@perf_pmu@cpu-hotplug.html
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb5/igt@perf_pmu@cpu-hotplug.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_busy@close-race:
>     - shard-tglb:         [INCOMPLETE][41] ([i915#435]) -> [PASS][42] +1 similar issue
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@gem_busy@close-race.html
> 
>   * igt@gem_ctx_isolation@bcs0-s3:
>     - shard-tglb:         [INCOMPLETE][43] ([i915#456]) -> [PASS][44]
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@gem_ctx_isolation@bcs0-s3.html
> 
>   * igt@gem_ctx_persistence@vcs0-mixed-process:
>     - shard-apl:          [FAIL][45] ([i915#679]) -> [PASS][46]
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
> 
>   * igt@gem_eio@banned:
>     - shard-tglb:         [INCOMPLETE][47] ([i915#476]) -> [PASS][48]
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@gem_eio@banned.html
> 
>   * igt@gem_eio@suspend:
>     - shard-tglb:         [INCOMPLETE][49] ([i915#460]) -> [PASS][50] +1 similar issue
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_eio@suspend.html
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb5/igt@gem_eio@suspend.html
> 
>   * igt@gem_exec_schedule@preempt-other-chain-bsd2:
>     - shard-iclb:         [SKIP][51] ([fdo#109276]) -> [PASS][52] +1 similar issue
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd2.html
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd2.html
> 
>   * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
>     - shard-tglb:         [INCOMPLETE][53] ([fdo#111677]) -> [PASS][54]
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb1/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
> 
>   * igt@gem_exec_schedule@preemptive-hang-bsd:
>     - shard-iclb:         [SKIP][55] ([fdo#112146]) -> [PASS][56]
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html
> 
>   * {igt@gen9_exec_parse@allowed-single}:
>     - shard-glk:          [DMESG-WARN][57] ([i915#716]) -> [PASS][58]
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk3/igt@gen9_exec_parse@allowed-single.html
>     - shard-apl:          [DMESG-WARN][59] ([i915#716]) -> [PASS][60]
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl8/igt@gen9_exec_parse@allowed-single.html
> 
>   * igt@i915_suspend@fence-restore-tiled2untiled:
>     - shard-apl:          [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +3 similar issues
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
>     - shard-hsw:          [DMESG-WARN][63] ([IGT#6]) -> [PASS][64]
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
>     - shard-tglb:         [INCOMPLETE][65] ([i915#456] / [i915#460]) -> [PASS][66]
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-suspend:
>     - shard-kbl:          [DMESG-WARN][67] ([i915#180]) -> [PASS][68]
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
>    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
> 
>   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
>     - shard-glk:          [FAIL][69] ([i915#79]) -> [PASS][70]
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-apl:          [FAIL][71] ([i915#79]) -> [PASS][72]
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_flip@flip-vs-suspend:
>     - shard-tglb:         [INCOMPLETE][73] ([i915#460] / [i915#516]) -> [PASS][74]
>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@kms_flip@flip-vs-suspend.html
>    [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@kms_flip@flip-vs-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
>     - shard-glk:          [FAIL][75] ([i915#49]) -> [PASS][76]
>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
>    [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
>     - shard-tglb:         [FAIL][77] ([i915#49]) -> [PASS][78] +1 similar issue
>    [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
>    [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_ctx_isolation@vcs2-dirty-create:
>     - shard-tglb:         [SKIP][79] ([fdo#111912] / [fdo#112080]) -> [SKIP][80] ([fdo#112080])
>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_ctx_isolation@vcs2-dirty-create.html
>    [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@gem_ctx_isolation@vcs2-dirty-create.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
>   [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
>   [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
>   [fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
>   [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
>   [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
>   [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
>   [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
>   [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
>   [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
>   [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
>   [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
>   [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
>   [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
>   [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
>   [i915#516]: https://gitlab.freedesktop.org/drm/intel/issues/516
>   [i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
>   [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
>   [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
>   [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
>   [i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667
>   [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
>   [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
>   [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
>   [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
>   [i915#799]: https://gitlab.freedesktop.org/drm/intel/issues/799
>   [i915#817]: https://gitlab.freedesktop.org/drm/intel/issues/817
>   [i915#84]: https://gitlab.freedesktop.org/drm/intel/issues/84
> 
> 
> Participating hosts (10 -> 8)
> ------------------------------
> 
>   Missing    (2): pig-skl-6260u pig-glk-j5005 
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * IGT: IGT_5349 -> IGTPW_3869
>   * Piglit: piglit_4509 -> None
> 
>   CI-20190529: 20190529
>   CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGTPW_3869: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
>   IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
  2019-12-17 11:29   ` Imre Deak
@ 2019-12-17 11:51     ` Vudum, Lakshminarayana
  2019-12-17 12:48       ` Imre Deak
  0 siblings, 1 reply; 12+ messages in thread
From: Vudum, Lakshminarayana @ 2019-12-17 11:51 UTC (permalink / raw)
  To: Deak, Imre, igt-dev

Filed a bug and re reported the results.

Lakshmi.

-----Original Message-----
From: Imre Deak <imre.deak@intel.com> 
Sent: Tuesday, December 17, 2019 1:30 PM
To: igt-dev@lists.freedesktop.org
Cc: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Subject: Re: ✗ Fi.CI.IGT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)

On Tue, Dec 17, 2019 at 08:47:36AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
> URL   : https://patchwork.freedesktop.org/series/71012/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7578_full -> IGTPW_3869_full 
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with IGTPW_3869_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in IGTPW_3869_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in IGTPW_3869_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_exec_flush@basic-batch-kernel-default-cmd:
>     - shard-hsw:          [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@gem
> _exec_flush@basic-batch-kernel-default-cmd.html

There is no compression support on HSW, so the changes in the patch are unrelated to the above failure.

> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in IGTPW_3869_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_ctx_isolation@rcs0-s3:
>     - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +5 similar issues
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl7/igt@gem
> _ctx_isolation@rcs0-s3.html
> 
>   * igt@gem_exec_schedule@fifo-bsd1:
>     - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#109276])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@gem_exec_schedule@fifo-bsd1.html
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb3/igt@ge
> m_exec_schedule@fifo-bsd1.html
> 
>   * igt@gem_exec_schedule@preempt-queue-bsd:
>     - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#112146])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb4/igt@ge
> m_exec_schedule@preempt-queue-bsd.html
> 
>   * igt@gem_exec_schedule@preempt-queue-chain-bsd1:
>     - shard-tglb:         [PASS][9] -> [INCOMPLETE][10] ([fdo#111606] / [fdo#111677])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb6/igt@ge
> m_exec_schedule@preempt-queue-chain-bsd1.html
> 
>   * igt@gem_persistent_relocs@forked-thrashing:
>     - shard-tglb:         [PASS][11] -> [TIMEOUT][12] ([i915#530])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-thrashing.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb1/igt@gem_persistent_relocs@forked-thrashing.html
>     - shard-hsw:          [PASS][13] -> [FAIL][14] ([i915#520])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_persistent_relocs@forked-thrashing.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw6/igt@gem
> _persistent_relocs@forked-thrashing.html
> 
>   * igt@gem_ppgtt@flink-and-close-vma-leak:
>     - shard-glk:          [PASS][15] -> [FAIL][16] ([i915#644])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
>     - shard-kbl:          [PASS][17] -> [FAIL][18] ([i915#644])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [18]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl7/igt@gem
> _ppgtt@flink-and-close-vma-leak.html
> 
>   * igt@gem_sync@basic-many-each:
>     - shard-tglb:         [PASS][19] -> [INCOMPLETE][20] ([i915#472] / [i915#707])
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_sync@basic-many-each.html
>    [20]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb8/igt@ge
> m_sync@basic-many-each.html
> 
>   * igt@gem_tiled_partial_pwrite_pread@writes-after-reads:
>     - shard-hsw:          [PASS][21] -> [FAIL][22] ([i915#817])
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw1/igt@gem_tiled_partial_pwrite_pread@writes-after-reads.html
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@gem
> _tiled_partial_pwrite_pread@writes-after-reads.html
> 
>   * igt@gem_workarounds@suspend-resume-fd:
>     - shard-apl:          [PASS][23] -> [DMESG-WARN][24] ([i915#180])
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-fd.html
>    [24]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl1/igt@gem
> _workarounds@suspend-resume-fd.html
> 
>   * igt@i915_pm_rpm@cursor:
>     - shard-apl:          [PASS][25] -> [SKIP][26] ([fdo#109271])
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_pm_rpm@cursor.html
>    [26]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl2/igt@i91
> 5_pm_rpm@cursor.html
> 
>   * igt@i915_selftest@live_hangcheck:
>     - shard-tglb:         [PASS][27] -> [INCOMPLETE][28] ([i915#435])
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@i915_selftest@live_hangcheck.html
>    [28]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb8/igt@i9
> 15_selftest@live_hangcheck.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
>     - shard-tglb:         [PASS][29] -> [FAIL][30] ([i915#49])
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@km
> s_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
>     - shard-tglb:         [PASS][31] -> [INCOMPLETE][32] ([i915#474] / [i915#667]) +1 similar issue
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@km
> s_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
> 
>   * igt@kms_plane@pixel-format-pipe-b-planes:
>     - shard-kbl:          [PASS][33] -> [INCOMPLETE][34] ([fdo#103665] / [i915#648] / [i915#667])
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@kms_plane@pixel-format-pipe-b-planes.html
>    [34]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl4/igt@kms
> _plane@pixel-format-pipe-b-planes.html
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          [PASS][35] -> [FAIL][36] ([i915#31])
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
>    [36]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@kms
> _setmode@basic.html
> 
>   * igt@perf@oa-exponents:
>     - shard-tglb:         [PASS][37] -> [FAIL][38] ([i915#84])
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@perf@oa-exponents.html
>    [38]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb6/igt@pe
> rf@oa-exponents.html
> 
>   * igt@perf_pmu@cpu-hotplug:
>     - shard-tglb:         [PASS][39] -> [DMESG-WARN][40] ([i915#799])
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@perf_pmu@cpu-hotplug.html
>    [40]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb5/igt@pe
> rf_pmu@cpu-hotplug.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_busy@close-race:
>     - shard-tglb:         [INCOMPLETE][41] ([i915#435]) -> [PASS][42] +1 similar issue
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
>    [42]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@ge
> m_busy@close-race.html
> 
>   * igt@gem_ctx_isolation@bcs0-s3:
>     - shard-tglb:         [INCOMPLETE][43] ([i915#456]) -> [PASS][44]
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
>    [44]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@ge
> m_ctx_isolation@bcs0-s3.html
> 
>   * igt@gem_ctx_persistence@vcs0-mixed-process:
>     - shard-apl:          [FAIL][45] ([i915#679]) -> [PASS][46]
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
>    [46]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@gem
> _ctx_persistence@vcs0-mixed-process.html
> 
>   * igt@gem_eio@banned:
>     - shard-tglb:         [INCOMPLETE][47] ([i915#476]) -> [PASS][48]
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
>    [48]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@ge
> m_eio@banned.html
> 
>   * igt@gem_eio@suspend:
>     - shard-tglb:         [INCOMPLETE][49] ([i915#460]) -> [PASS][50] +1 similar issue
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_eio@suspend.html
>    [50]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb5/igt@ge
> m_eio@suspend.html
> 
>   * igt@gem_exec_schedule@preempt-other-chain-bsd2:
>     - shard-iclb:         [SKIP][51] ([fdo#109276]) -> [PASS][52] +1 similar issue
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd2.html
>    [52]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb2/igt@ge
> m_exec_schedule@preempt-other-chain-bsd2.html
> 
>   * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
>     - shard-tglb:         [INCOMPLETE][53] ([fdo#111677]) -> [PASS][54]
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
>    [54]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb1/igt@ge
> m_exec_schedule@preempt-queue-contexts-vebox.html
> 
>   * igt@gem_exec_schedule@preemptive-hang-bsd:
>     - shard-iclb:         [SKIP][55] ([fdo#112146]) -> [PASS][56]
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
>    [56]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb3/igt@ge
> m_exec_schedule@preemptive-hang-bsd.html
> 
>   * {igt@gen9_exec_parse@allowed-single}:
>     - shard-glk:          [DMESG-WARN][57] ([i915#716]) -> [PASS][58]
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk3/igt@gen9_exec_parse@allowed-single.html
>     - shard-apl:          [DMESG-WARN][59] ([i915#716]) -> [PASS][60]
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
>    [60]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl8/igt@gen
> 9_exec_parse@allowed-single.html
> 
>   * igt@i915_suspend@fence-restore-tiled2untiled:
>     - shard-apl:          [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +3 similar issues
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
>    [62]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl2/igt@i91
> 5_suspend@fence-restore-tiled2untiled.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
>     - shard-hsw:          [DMESG-WARN][63] ([IGT#6]) -> [PASS][64]
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
>    [64]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@kms
> _cursor_crc@pipe-a-cursor-64x64-sliding.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
>     - shard-tglb:         [INCOMPLETE][65] ([i915#456] / [i915#460]) -> [PASS][66]
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
>    [66]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb7/igt@km
> s_cursor_crc@pipe-a-cursor-suspend.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-suspend:
>     - shard-kbl:          [DMESG-WARN][67] ([i915#180]) -> [PASS][68]
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
>    [68]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl4/igt@kms
> _cursor_crc@pipe-b-cursor-suspend.html
> 
>   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
>     - shard-glk:          [FAIL][69] ([i915#79]) -> [PASS][70]
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
>    [70]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk7/igt@kms
> _flip@2x-flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-apl:          [FAIL][71] ([i915#79]) -> [PASS][72]
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>    [72]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@kms
> _flip@flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_flip@flip-vs-suspend:
>     - shard-tglb:         [INCOMPLETE][73] ([i915#460] / [i915#516]) -> [PASS][74]
>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@kms_flip@flip-vs-suspend.html
>    [74]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@km
> s_flip@flip-vs-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
>     - shard-glk:          [FAIL][75] ([i915#49]) -> [PASS][76]
>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
>    [76]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk4/igt@kms
> _frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
>     - shard-tglb:         [FAIL][77] ([i915#49]) -> [PASS][78] +1 similar issue
>    [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
>    [78]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb3/igt@km
> s_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_ctx_isolation@vcs2-dirty-create:
>     - shard-tglb:         [SKIP][79] ([fdo#111912] / [fdo#112080]) -> [SKIP][80] ([fdo#112080])
>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_ctx_isolation@vcs2-dirty-create.html
>    [80]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@ge
> m_ctx_isolation@vcs2-dirty-create.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
>   [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
>   [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
>   [fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
>   [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
>   [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
>   [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
>   [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
>   [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
>   [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
>   [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
>   [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
>   [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
>   [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
>   [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
>   [i915#516]: https://gitlab.freedesktop.org/drm/intel/issues/516
>   [i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
>   [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
>   [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
>   [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
>   [i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667
>   [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
>   [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
>   [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
>   [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
>   [i915#799]: https://gitlab.freedesktop.org/drm/intel/issues/799
>   [i915#817]: https://gitlab.freedesktop.org/drm/intel/issues/817
>   [i915#84]: https://gitlab.freedesktop.org/drm/intel/issues/84
> 
> 
> Participating hosts (10 -> 8)
> ------------------------------
> 
>   Missing    (2): pig-skl-6260u pig-glk-j5005 
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * IGT: IGT_5349 -> IGTPW_3869
>   * Piglit: piglit_4509 -> None
> 
>   CI-20190529: 20190529
>   CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGTPW_3869: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
>   IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ 
> git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
  2019-12-17 11:51     ` Vudum, Lakshminarayana
@ 2019-12-17 12:48       ` Imre Deak
  0 siblings, 0 replies; 12+ messages in thread
From: Imre Deak @ 2019-12-17 12:48 UTC (permalink / raw)
  To: Vudum, Lakshminarayana; +Cc: igt-dev

On Tue, Dec 17, 2019 at 01:51:24PM +0200, Vudum, Lakshminarayana wrote:
> Filed a bug and re reported the results.
> 
> Lakshmi.

Thanks.

> 
> -----Original Message-----
> From: Imre Deak <imre.deak@intel.com> 
> Sent: Tuesday, December 17, 2019 1:30 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
> Subject: Re: ✗ Fi.CI.IGT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
> 
> On Tue, Dec 17, 2019 at 08:47:36AM +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: lib/igt_fb: Add support for the gen12 media compressed modifier (rev3)
> > URL   : https://patchwork.freedesktop.org/series/71012/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_7578_full -> IGTPW_3869_full 
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with IGTPW_3869_full absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in IGTPW_3869_full, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in IGTPW_3869_full:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@gem_exec_flush@basic-batch-kernel-default-cmd:
> >     - shard-hsw:          [PASS][1] -> [FAIL][2]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
> >    [2]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@gem
> > _exec_flush@basic-batch-kernel-default-cmd.html
> 
> There is no compression support on HSW, so the changes in the patch are unrelated to the above failure.
> 
> > 
> >   
> > Known issues
> > ------------
> > 
> >   Here are the changes found in IGTPW_3869_full that come from known issues:
> > 
> > ### IGT changes ###
> > 
> > #### Issues hit ####
> > 
> >   * igt@gem_ctx_isolation@rcs0-s3:
> >     - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +5 similar issues
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
> >    [4]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl7/igt@gem
> > _ctx_isolation@rcs0-s3.html
> > 
> >   * igt@gem_exec_schedule@fifo-bsd1:
> >     - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#109276])
> >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@gem_exec_schedule@fifo-bsd1.html
> >    [6]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb3/igt@ge
> > m_exec_schedule@fifo-bsd1.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-bsd:
> >     - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#112146])
> >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd.html
> >    [8]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb4/igt@ge
> > m_exec_schedule@preempt-queue-bsd.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-chain-bsd1:
> >     - shard-tglb:         [PASS][9] -> [INCOMPLETE][10] ([fdo#111606] / [fdo#111677])
> >    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
> >    [10]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb6/igt@ge
> > m_exec_schedule@preempt-queue-chain-bsd1.html
> > 
> >   * igt@gem_persistent_relocs@forked-thrashing:
> >     - shard-tglb:         [PASS][11] -> [TIMEOUT][12] ([i915#530])
> >    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-thrashing.html
> >    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb1/igt@gem_persistent_relocs@forked-thrashing.html
> >     - shard-hsw:          [PASS][13] -> [FAIL][14] ([i915#520])
> >    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_persistent_relocs@forked-thrashing.html
> >    [14]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw6/igt@gem
> > _persistent_relocs@forked-thrashing.html
> > 
> >   * igt@gem_ppgtt@flink-and-close-vma-leak:
> >     - shard-glk:          [PASS][15] -> [FAIL][16] ([i915#644])
> >    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >     - shard-kbl:          [PASS][17] -> [FAIL][18] ([i915#644])
> >    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [18]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl7/igt@gem
> > _ppgtt@flink-and-close-vma-leak.html
> > 
> >   * igt@gem_sync@basic-many-each:
> >     - shard-tglb:         [PASS][19] -> [INCOMPLETE][20] ([i915#472] / [i915#707])
> >    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_sync@basic-many-each.html
> >    [20]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb8/igt@ge
> > m_sync@basic-many-each.html
> > 
> >   * igt@gem_tiled_partial_pwrite_pread@writes-after-reads:
> >     - shard-hsw:          [PASS][21] -> [FAIL][22] ([i915#817])
> >    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw1/igt@gem_tiled_partial_pwrite_pread@writes-after-reads.html
> >    [22]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@gem
> > _tiled_partial_pwrite_pread@writes-after-reads.html
> > 
> >   * igt@gem_workarounds@suspend-resume-fd:
> >     - shard-apl:          [PASS][23] -> [DMESG-WARN][24] ([i915#180])
> >    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-fd.html
> >    [24]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl1/igt@gem
> > _workarounds@suspend-resume-fd.html
> > 
> >   * igt@i915_pm_rpm@cursor:
> >     - shard-apl:          [PASS][25] -> [SKIP][26] ([fdo#109271])
> >    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_pm_rpm@cursor.html
> >    [26]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl2/igt@i91
> > 5_pm_rpm@cursor.html
> > 
> >   * igt@i915_selftest@live_hangcheck:
> >     - shard-tglb:         [PASS][27] -> [INCOMPLETE][28] ([i915#435])
> >    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@i915_selftest@live_hangcheck.html
> >    [28]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb8/igt@i9
> > 15_selftest@live_hangcheck.html
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
> >     - shard-tglb:         [PASS][29] -> [FAIL][30] ([i915#49])
> >    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
> >    [30]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@km
> > s_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
> >     - shard-tglb:         [PASS][31] -> [INCOMPLETE][32] ([i915#474] / [i915#667]) +1 similar issue
> >    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
> >    [32]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@km
> > s_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
> > 
> >   * igt@kms_plane@pixel-format-pipe-b-planes:
> >     - shard-kbl:          [PASS][33] -> [INCOMPLETE][34] ([fdo#103665] / [i915#648] / [i915#667])
> >    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@kms_plane@pixel-format-pipe-b-planes.html
> >    [34]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl4/igt@kms
> > _plane@pixel-format-pipe-b-planes.html
> > 
> >   * igt@kms_setmode@basic:
> >     - shard-apl:          [PASS][35] -> [FAIL][36] ([i915#31])
> >    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
> >    [36]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@kms
> > _setmode@basic.html
> > 
> >   * igt@perf@oa-exponents:
> >     - shard-tglb:         [PASS][37] -> [FAIL][38] ([i915#84])
> >    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@perf@oa-exponents.html
> >    [38]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb6/igt@pe
> > rf@oa-exponents.html
> > 
> >   * igt@perf_pmu@cpu-hotplug:
> >     - shard-tglb:         [PASS][39] -> [DMESG-WARN][40] ([i915#799])
> >    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@perf_pmu@cpu-hotplug.html
> >    [40]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb5/igt@pe
> > rf_pmu@cpu-hotplug.html
> > 
> >   
> > #### Possible fixes ####
> > 
> >   * igt@gem_busy@close-race:
> >     - shard-tglb:         [INCOMPLETE][41] ([i915#435]) -> [PASS][42] +1 similar issue
> >    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
> >    [42]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb4/igt@ge
> > m_busy@close-race.html
> > 
> >   * igt@gem_ctx_isolation@bcs0-s3:
> >     - shard-tglb:         [INCOMPLETE][43] ([i915#456]) -> [PASS][44]
> >    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
> >    [44]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@ge
> > m_ctx_isolation@bcs0-s3.html
> > 
> >   * igt@gem_ctx_persistence@vcs0-mixed-process:
> >     - shard-apl:          [FAIL][45] ([i915#679]) -> [PASS][46]
> >    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
> >    [46]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@gem
> > _ctx_persistence@vcs0-mixed-process.html
> > 
> >   * igt@gem_eio@banned:
> >     - shard-tglb:         [INCOMPLETE][47] ([i915#476]) -> [PASS][48]
> >    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
> >    [48]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@ge
> > m_eio@banned.html
> > 
> >   * igt@gem_eio@suspend:
> >     - shard-tglb:         [INCOMPLETE][49] ([i915#460]) -> [PASS][50] +1 similar issue
> >    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_eio@suspend.html
> >    [50]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb5/igt@ge
> > m_eio@suspend.html
> > 
> >   * igt@gem_exec_schedule@preempt-other-chain-bsd2:
> >     - shard-iclb:         [SKIP][51] ([fdo#109276]) -> [PASS][52] +1 similar issue
> >    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd2.html
> >    [52]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb2/igt@ge
> > m_exec_schedule@preempt-other-chain-bsd2.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
> >     - shard-tglb:         [INCOMPLETE][53] ([fdo#111677]) -> [PASS][54]
> >    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
> >    [54]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb1/igt@ge
> > m_exec_schedule@preempt-queue-contexts-vebox.html
> > 
> >   * igt@gem_exec_schedule@preemptive-hang-bsd:
> >     - shard-iclb:         [SKIP][55] ([fdo#112146]) -> [PASS][56]
> >    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
> >    [56]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-iclb3/igt@ge
> > m_exec_schedule@preemptive-hang-bsd.html
> > 
> >   * {igt@gen9_exec_parse@allowed-single}:
> >     - shard-glk:          [DMESG-WARN][57] ([i915#716]) -> [PASS][58]
> >    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
> >    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk3/igt@gen9_exec_parse@allowed-single.html
> >     - shard-apl:          [DMESG-WARN][59] ([i915#716]) -> [PASS][60]
> >    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
> >    [60]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl8/igt@gen
> > 9_exec_parse@allowed-single.html
> > 
> >   * igt@i915_suspend@fence-restore-tiled2untiled:
> >     - shard-apl:          [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +3 similar issues
> >    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
> >    [62]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl2/igt@i91
> > 5_suspend@fence-restore-tiled2untiled.html
> > 
> >   * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
> >     - shard-hsw:          [DMESG-WARN][63] ([IGT#6]) -> [PASS][64]
> >    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> >    [64]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-hsw4/igt@kms
> > _cursor_crc@pipe-a-cursor-64x64-sliding.html
> > 
> >   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
> >     - shard-tglb:         [INCOMPLETE][65] ([i915#456] / [i915#460]) -> [PASS][66]
> >    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> >    [66]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb7/igt@km
> > s_cursor_crc@pipe-a-cursor-suspend.html
> > 
> >   * igt@kms_cursor_crc@pipe-b-cursor-suspend:
> >     - shard-kbl:          [DMESG-WARN][67] ([i915#180]) -> [PASS][68]
> >    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
> >    [68]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-kbl4/igt@kms
> > _cursor_crc@pipe-b-cursor-suspend.html
> > 
> >   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
> >     - shard-glk:          [FAIL][69] ([i915#79]) -> [PASS][70]
> >    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> >    [70]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk7/igt@kms
> > _flip@2x-flip-vs-expired-vblank-interruptible.html
> > 
> >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> >     - shard-apl:          [FAIL][71] ([i915#79]) -> [PASS][72]
> >    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> >    [72]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-apl3/igt@kms
> > _flip@flip-vs-expired-vblank-interruptible.html
> > 
> >   * igt@kms_flip@flip-vs-suspend:
> >     - shard-tglb:         [INCOMPLETE][73] ([i915#460] / [i915#516]) -> [PASS][74]
> >    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@kms_flip@flip-vs-suspend.html
> >    [74]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@km
> > s_flip@flip-vs-suspend.html
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
> >     - shard-glk:          [FAIL][75] ([i915#49]) -> [PASS][76]
> >    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
> >    [76]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-glk4/igt@kms
> > _frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
> > 
> >   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
> >     - shard-tglb:         [FAIL][77] ([i915#49]) -> [PASS][78] +1 similar issue
> >    [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
> >    [78]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb3/igt@km
> > s_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
> > 
> >   
> > #### Warnings ####
> > 
> >   * igt@gem_ctx_isolation@vcs2-dirty-create:
> >     - shard-tglb:         [SKIP][79] ([fdo#111912] / [fdo#112080]) -> [SKIP][80] ([fdo#112080])
> >    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_ctx_isolation@vcs2-dirty-create.html
> >    [80]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/shard-tglb9/igt@ge
> > m_ctx_isolation@vcs2-dirty-create.html
> > 
> >   
> >   {name}: This element is suppressed. This means it is ignored when computing
> >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> > 
> >   [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
> >   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> >   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
> >   [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
> >   [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
> >   [fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
> >   [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
> >   [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
> >   [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
> >   [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
> >   [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
> >   [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
> >   [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
> >   [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
> >   [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
> >   [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
> >   [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
> >   [i915#516]: https://gitlab.freedesktop.org/drm/intel/issues/516
> >   [i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
> >   [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
> >   [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
> >   [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
> >   [i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667
> >   [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
> >   [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
> >   [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
> >   [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
> >   [i915#799]: https://gitlab.freedesktop.org/drm/intel/issues/799
> >   [i915#817]: https://gitlab.freedesktop.org/drm/intel/issues/817
> >   [i915#84]: https://gitlab.freedesktop.org/drm/intel/issues/84
> > 
> > 
> > Participating hosts (10 -> 8)
> > ------------------------------
> > 
> >   Missing    (2): pig-skl-6260u pig-glk-j5005 
> > 
> > 
> > Build changes
> > -------------
> > 
> >   * CI: CI-20190529 -> None
> >   * IGT: IGT_5349 -> IGTPW_3869
> >   * Piglit: piglit_4509 -> None
> > 
> >   CI-20190529: 20190529
> >   CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
> >   IGTPW_3869: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
> >   IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ 
> > git://anongit.freedesktop.org/piglit
> > 
> > == Logs ==
> > 
> > For more details see: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3869/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH v3] lib/igt_fb: Add support for the gen12 media compressed modifier
  2019-12-17  2:02   ` [igt-dev] [PATCH v3] " Imre Deak
@ 2019-12-17 14:25     ` Kahola, Mika
  0 siblings, 0 replies; 12+ messages in thread
From: Kahola, Mika @ 2019-12-17 14:25 UTC (permalink / raw)
  To: igt-dev, Deak, Imre; +Cc: Pandiyan, Dhinakaran

On Tue, 2019-12-17 at 04:02 +0200, Imre Deak wrote:
> Media compressed framebuffers don't have a CCS CC plane. Add helpers
> to
> select the different types of CCS planes and make sure we setup the
> planes correctly for MC framebuffers too.
> 
> Note that the order of MC framebuffer planes this change assumes is
> 
> plane 0: Y plane
> plane 1: UV plane
> plane 2: CCS plane for plane 0
> plane 3: CCS plane for plane 1
> 
> unlike the order defined in the latest decompression kernel patchset.
> The above order is the logical one that allows us to keep the
> existing
> way of handling the Y/UV planes.
> 
> v2:
> - Fix is_ccs_plane() adding the missing is_ccs_modifier() check.
> v3:
> - Simplify is_ccs_plane(). (DK)
> 
> Cc: Mika Kahola <mika.kahola@intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> ---
>  lib/igt_fb.c | 92 ++++++++++++++++++++++++++++++++++++------------
> ----
>  1 file changed, 64 insertions(+), 28 deletions(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 3b141b93..e6eb39ac 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -487,18 +487,50 @@ static bool is_ccs_modifier(uint64_t modifier)
>  		modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
>  }
>  
> +static bool is_ccs_plane(const struct igt_fb *fb, int plane)
> +{
> +	if (!is_ccs_modifier(fb->modifier))
> +		return false;
> +
> +	return plane >= fb->num_planes / 2;
> +}
> +
> +static bool is_gen12_ccs_plane(const struct igt_fb *fb, int plane)
> +{
> +	return is_gen12_ccs_modifier(fb->modifier) && is_ccs_plane(fb,
> plane);
> +}
> +
> +static bool is_gen12_ccs_cc_plane(const struct igt_fb *fb, int
> plane)
> +{
> +	return fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC
> &&
> +	       plane == 2;
> +}
> +
> +static int ccs_to_main_plane(const struct igt_fb *fb, int plane)
> +{
> +	if (is_gen12_ccs_cc_plane(fb, plane))
> +		return 0;
> +
> +	return plane - fb->num_planes / 2;
> +}
> +
>  static unsigned fb_plane_width(const struct igt_fb *fb, int plane)
>  {
>  	const struct format_desc_struct *format = lookup_drm_format(fb-
> >drm_format);
>  
> -	if (is_ccs_modifier(fb->modifier) && plane == 1) {
> -		if (is_gen12_ccs_modifier(fb->modifier))
> -			return DIV_ROUND_UP(fb->width,
> -					    512 / (fb->plane_bpp[0] /
> 8)) * 64;
> -		else
> -			return DIV_ROUND_UP(fb->width, 1024) * 128;
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
> +	if (is_gen12_ccs_cc_plane(fb, plane)) {
>  		return 64;
> +	} if (is_gen12_ccs_plane(fb, plane)) {
> +		int main_plane = ccs_to_main_plane(fb, plane);
> +		int width = fb->width;
> +
> +		if (main_plane)
> +			width = DIV_ROUND_UP(width, format->hsub);
> +
> +		return DIV_ROUND_UP(width,
> +				    512 / (fb->plane_bpp[main_plane] /
> 8)) * 64;
> +	} else if (is_ccs_plane(fb, plane)) {
> +		 return DIV_ROUND_UP(fb->width, 1024) * 128;
>  	}
>  
>  	if (plane == 0)
> @@ -511,7 +543,7 @@ static unsigned fb_plane_bpp(const struct igt_fb
> *fb, int plane)
>  {
>  	const struct format_desc_struct *format = lookup_drm_format(fb-
> >drm_format);
>  
> -	if (is_ccs_modifier(fb->modifier) && (plane == 1 || plane ==
> 2))
> +	if (is_ccs_plane(fb, plane))
>  		return 8;
>  	else
>  		return format->plane_bpp[plane];
> @@ -521,13 +553,18 @@ static unsigned fb_plane_height(const struct
> igt_fb *fb, int plane)
>  {
>  	const struct format_desc_struct *format = lookup_drm_format(fb-
> >drm_format);
>  
> -	if (is_ccs_modifier(fb->modifier) && plane == 1) {
> -		if (is_gen12_ccs_modifier(fb->modifier))
> -			return DIV_ROUND_UP(fb->height, 128) * 4;
> -		else
> -			return DIV_ROUND_UP(fb->height, 512) * 32;
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2)
> +	if (is_gen12_ccs_cc_plane(fb, plane)) {
>  		return 1;
> +	} else if (is_gen12_ccs_plane(fb, plane)) {
> +		int height = fb->height;
> +
> +		if (ccs_to_main_plane(fb, plane))
> +			height = DIV_ROUND_UP(height, format->vsub);
> +
> +		return DIV_ROUND_UP(height, 128) * 4;
> +	} else if (is_ccs_plane(fb, plane)) {
> +		return DIV_ROUND_UP(fb->height, 512) * 32;
> +	}
>  
>  	if (plane == 0)
>  		return fb->height;
> @@ -537,16 +574,15 @@ static unsigned fb_plane_height(const struct
> igt_fb *fb, int plane)
>  
>  static int fb_num_planes(const struct igt_fb *fb)
>  {
> -	const struct format_desc_struct *format = lookup_drm_format(fb-
> >drm_format);
> +	int num_planes = lookup_drm_format(fb->drm_format)->num_planes;
>  
> -	if (is_ccs_modifier(fb->modifier)) {
> -		if (fb->modifier ==
> I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
> -			return 3;
> -		else
> -			return 2;
> -	} else {
> -		return format->num_planes;
> -	}
> +	if (is_ccs_modifier(fb->modifier))
> +		num_planes *= 2;
> +
> +	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
> +		num_planes++;
> +
> +	return num_planes;
>  }
>  
>  void igt_init_fb(struct igt_fb *fb, int fd, int width, int height,
> @@ -604,12 +640,12 @@ static uint32_t calc_plane_stride(struct igt_fb
> *fb, int plane)
>  		 * so the easiest way is to align the luma stride to
> 256.
>  		 */
>  		return ALIGN(min_stride, 256);
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 1) {
> -		/* A main surface using a CCS AUX surface must be 4x4
> tiles aligned. */
> -		return ALIGN(min_stride, 64);
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && plane == 2) {
> +	} else if (is_gen12_ccs_cc_plane(fb, plane)) {
>  		/* clear color always fixed to 64 bytes */
>  		return 64;
> +	} else if (is_gen12_ccs_plane(fb, plane)) {
> +		/* A main surface using a CCS AUX surface must be 4x4
> tiles aligned. */
> +		return ALIGN(min_stride, 64);
>  	} else {
>  		unsigned int tile_width, tile_height;
>  
> @@ -644,7 +680,7 @@ static uint64_t calc_plane_size(struct igt_fb
> *fb, int plane)
>  		size = roundup_power_of_two(size);
>  
>  		return size;
> -	} else if (is_gen12_ccs_modifier(fb->modifier) && (plane == 1
> || plane == 2)) {
> +	} else if (is_gen12_ccs_plane(fb, plane)) {
>  		/* The AUX CCS surface must be page aligned */
>  		return (uint64_t)fb->strides[plane] *
>  			ALIGN(fb->plane_height[plane], 64);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-12-17 14:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 23:54 [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier Imre Deak
2019-12-17  0:00 ` [igt-dev] [PATCH v2] " Imre Deak
2019-12-17  2:02   ` [igt-dev] [PATCH v3] " Imre Deak
2019-12-17 14:25     ` Kahola, Mika
2019-12-17  1:00 ` [igt-dev] [PATCH i-g-t] " Dhinakaran Pandiyan
2019-12-17  1:53   ` Imre Deak
2019-12-17  1:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: Add support for the gen12 media compressed modifier (rev2) Patchwork
2019-12-17  3:08 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: Add support for the gen12 media compressed modifier (rev3) Patchwork
2019-12-17  8:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-12-17 11:29   ` Imre Deak
2019-12-17 11:51     ` Vudum, Lakshminarayana
2019-12-17 12:48       ` Imre Deak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.