All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Maximilian Engelhardt <maxi@daemonizer.de>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Seth Forshee" <seth.forshee@canonical.com>,
	"brcm80211 development" <brcm80211-dev-list@broadcom.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Network Development" <netdev@vger.kernel.org>
Subject: Re: BCM4313 & brcmsmac & 3.12: only semi-working?
Date: Wed, 19 Nov 2014 14:46:19 +0100	[thread overview]
Message-ID: <546C9F2B.8090104@broadcom.com> (raw)
In-Reply-To: <3543341.FmUQFH9nrl@eisbaer>

On 11/17/14 23:36, Maximilian Engelhardt wrote:
> On Thursday 09 October 2014 10:21:12 Rafał Miłecki wrote:
>> On 9 October 2014 09:52, Arend van Spriel<arend@broadcom.com>  wrote:
>>> I have been staring at differences brcmsmac and our internal driver (which
>>> wl is derived from as well). Would you be able to make an mmiotrace
>>> loading
>>> wl and brcmsmac.
>>
>> Arend,
>>
>> As you noticed earlier, this is a WiFi card with BT. I've checked
>> siutils.c from SDK 7.14.43.7 (got it from Netgear R8000) and it has
>> three BCM4313 workarounds:
>>
>>
>> 1) si_doattach
>> SI_MSG(("Applying 4313 WARs\n"));
>> si_pmu_chipcontrol(sih, 0, CCTRL_4313_12MA_LED_DRIVE,
>> CCTRL_4313_12MA_LED_DRIVE);
>>
>> It's already implemented in bcma, see driver_chipcommon_pmu.c
>>
>>
>> 2) si_epa_4313war
>> /* EPA Fix */
>> W_REG(sii->osh,&cc->gpiocontrol,
>> R_REG(sii->osh,&cc->gpiocontrol) | GPIO_CTRL_EPA_EN_MASK);
>>
>> This is what you already implement in ai_epa_4313war
>>
>>
>> 3) si_pmu_synth_pwrsw_4313_war
>> I don't think it's implemented.
>>
>>
>> 4) si_btcombo_p250_4313_war
>> I also don't think it's implemented
>>
>>
>> The last one (si_btcombo_p250_4313_war) looks promising, the comment
>> above the function says:
>> /** WL/BT control for 4313 btcombo boards>= P250 */
>> I guess you need to re-implement this function and call it somewhere
>> in brcmsmac.
>
> Hi,
>
> I just wanted to ask if there is any progress on this issue since I haven't
> heard anything for a month. Please let me know if you need any additional
> information.

I had a bit of problem with the mmiotrace files. Well, my (virtual) 
linux machine had as it ended up swapping on my disk and went down the 
drain.

I still wanted to look at items 3) and 4) that Rafal mentioned although 
item 4) does not seems to apply to Michael's 4313 it may help yours. I 
submitted a patch to get counter statistics from the 802.11 core on the 
chip [1] as I am curious whether that will show a possible lead.

Regards,
Arend

  parent reply	other threads:[~2014-11-19 13:46 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-27 20:58 BCM4313 & brcmsmac & 3.12: only semi-working? Michael Tokarev
2013-12-28  9:42 ` Arend van Spriel
2013-12-28 12:24   ` Michael Tokarev
2014-01-14  8:59     ` Michael Tokarev
2014-01-14  9:30       ` Nikita N.
2014-02-10 19:16       ` Michael Tokarev
2014-04-19 11:42         ` Michael Tokarev
2014-08-26  5:13           ` Michael Tokarev
2014-08-26 14:56             ` Arend van Spriel
2014-08-26 14:56               ` Arend van Spriel
2014-08-26 16:15               ` Michael Tokarev
2014-08-26 21:37                 ` Arend van Spriel
2014-08-27 10:02                   ` Michael Tokarev
2014-08-27 15:27                     ` Arend van Spriel
2014-09-15  8:03                       ` Arend van Spriel
2014-09-21 15:30                         ` Michael Tokarev
2014-09-23 10:04                           ` Michael Tokarev
2014-09-23 12:47                             ` Arend van Spriel
2014-09-23 13:44                               ` Seth Forshee
2014-09-23 13:44                                 ` Seth Forshee
2014-09-23 13:50                                 ` Arend van Spriel
2014-09-23 13:50                                   ` Arend van Spriel
2014-09-23 14:25                                   ` Michael Tokarev
2014-09-23 14:28                                     ` Michael Tokarev
2014-09-23 14:31                                       ` Seth Forshee
2014-09-23 16:02                                         ` Michael Tokarev
2014-09-23 16:02                                           ` Michael Tokarev
2014-09-23 17:35                                           ` Arend van Spriel
2014-09-23 18:10                                             ` Michael Tokarev
2014-09-24 13:28                                               ` Arend van Spriel
2014-09-24 13:28                                                 ` Arend van Spriel
2014-09-24 14:51                                                 ` Michael Tokarev
2014-09-24 14:51                                                   ` Michael Tokarev
2014-09-26 14:26                                                   ` Michael Tokarev
2014-09-26 14:42                                                     ` Arend van Spriel
2014-09-26 15:20                                                       ` Michael Tokarev
2014-09-26 15:20                                                         ` Michael Tokarev
2014-09-29 13:44                                                         ` Arend van Spriel
2014-09-29 19:40                                                           ` Maximilian Engelhardt
2014-09-30 10:06                                                             ` Arend van Spriel
2014-10-08 22:19                                                               ` Maximilian Engelhardt
2014-10-09  7:52                                                                 ` Arend van Spriel
2014-10-09  8:21                                                                   ` Rafał Miłecki
2014-11-17 22:36                                                                     ` Maximilian Engelhardt
2014-11-19  9:04                                                                       ` Michael Tokarev
2014-11-19 17:54                                                                         ` Arend van Spriel
2014-11-19 19:58                                                                           ` Michael Tokarev
2014-11-19 21:00                                                                             ` Michael Tokarev
2014-11-23  9:43                                                                               ` Arend van Spriel
2014-11-26  9:52                                                                                 ` Michael Tokarev
2014-11-30 12:04                                                                                   ` Arend van Spriel
2014-11-30 12:04                                                                                     ` Arend van Spriel
2014-12-02 21:40                                                                                     ` Michael Tokarev
2014-12-02 21:40                                                                                       ` Michael Tokarev
2014-12-03 12:43                                                                                       ` Arend van Spriel
2014-12-16 16:51                                                                                         ` Arend van Spriel
2014-12-21  9:58                                                                                           ` Michael Tokarev
2014-12-21  9:58                                                                                             ` Michael Tokarev
2014-12-21 10:12                                                                                             ` Arend van Spriel
2014-12-21 10:12                                                                                               ` Arend van Spriel
2014-12-21 10:27                                                                                               ` Michael Tokarev
2014-12-21 11:38                                                                                                 ` Arend van Spriel
2014-12-21 14:08                                                                                               ` Maximilian Engelhardt
2014-12-21 14:08                                                                                                 ` Maximilian Engelhardt
2014-12-21 14:13                                                                                                 ` Arend van Spriel
2014-12-21 14:24                                                                                                   ` Maximilian Engelhardt
2014-12-21 15:03                                                                                                     ` Arend van Spriel
2014-12-21 17:34                                                                                                       ` Maximilian Engelhardt
2015-03-09 20:54                                                                                                         ` Daniel Glöckner
2015-03-09 20:54                                                                                                           ` Daniel Glöckner
2015-03-10 21:27                                                                                                           ` Arend van Spriel
2016-03-14 16:41                                                                                                             ` Daniel Glöckner
     [not found]                                                                                           ` <54969A46.8000807@msgid.tls.msk.ru>
2014-12-21 10:17                                                                                             ` Arend van Spriel
2014-12-01 22:06                                                                                   ` Maximilian Engelhardt
2014-11-19 13:46                                                                       ` Arend van Spriel [this message]
2014-11-19 13:49                                                                         ` Arend van Spriel
2014-11-19 13:49                                                                           ` Arend van Spriel
2020-08-24  3:44 Sébastien Le Preste De Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546C9F2B.8090104@broadcom.com \
    --to=arend@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maxi@daemonizer.de \
    --cc=mjt@tls.msk.ru \
    --cc=netdev@vger.kernel.org \
    --cc=seth.forshee@canonical.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.