All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Will Deacon <will.deacon@arm.com>
Cc: David Long <dave.long@linaro.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Russell King <linux@arm.linux.org.uk>,
	Sandeepa Prabhu <sandeepa.prabhu@linaro.org>,
	William Cohen <wcohen@redhat.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"Jon Medhurst (Tixy)" <tixy@linaro.org>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature
Date: Thu, 20 Nov 2014 16:20:15 +0900	[thread overview]
Message-ID: <546D962F.3080309@hitachi.com> (raw)
In-Reply-To: <20141118145228.GN18842@arm.com>

(2014/11/18 23:52), Will Deacon wrote:
> Hi David,
> 
> On Tue, Nov 18, 2014 at 06:32:55AM +0000, David Long wrote:
>> From: "David A. Long" <dave.long@linaro.org>
>>
>> Add HAVE_REGS_AND_STACK_ACCESS_API feature for arm64.
> 
> [...]
> 
>> diff --git a/arch/arm64/include/asm/ptrace.h b/arch/arm64/include/asm/ptrace.h
>> index d3e782a..24cc048 100644
>> --- a/arch/arm64/include/asm/ptrace.h
>> +++ b/arch/arm64/include/asm/ptrace.h
>> @@ -111,6 +111,8 @@ struct pt_regs {
>>  	u64 syscallno;
>>  };
>>  
>> +#define MAX_REG_OFFSET (offsetof(struct pt_regs, orig_x0))
> 
> Is orig_x0 actually useful to this API? If not, we could instead operate on
> the user_pt_regs structure, and define the maximum offset in terms of sizeof
> that.

It depends on the architecture, but this patch provides the common interface
for kprobe-tracer. I think this code looks OK, since kprobe-tracer doesn't
use user_pt_regs.

> 
>> +#define ARM_cpsr	pstate
>> +#define ARM_pc		pc
>> +#define ARM_sp		sp
>> +#define ARM_lr		regs[30]
>> +#define ARM_fp		regs[29]
>> +#define ARM_x28		regs[28]
>> +#define ARM_x27		regs[27]
> 
> [...]
> 
> I don't think we need these #defines.

Agreed.

Thank you,


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



WARNING: multiple messages have this Message-ID (diff)
From: masami.hiramatsu.pt@hitachi.com (Masami Hiramatsu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/5] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature
Date: Thu, 20 Nov 2014 16:20:15 +0900	[thread overview]
Message-ID: <546D962F.3080309@hitachi.com> (raw)
In-Reply-To: <20141118145228.GN18842@arm.com>

(2014/11/18 23:52), Will Deacon wrote:
> Hi David,
> 
> On Tue, Nov 18, 2014 at 06:32:55AM +0000, David Long wrote:
>> From: "David A. Long" <dave.long@linaro.org>
>>
>> Add HAVE_REGS_AND_STACK_ACCESS_API feature for arm64.
> 
> [...]
> 
>> diff --git a/arch/arm64/include/asm/ptrace.h b/arch/arm64/include/asm/ptrace.h
>> index d3e782a..24cc048 100644
>> --- a/arch/arm64/include/asm/ptrace.h
>> +++ b/arch/arm64/include/asm/ptrace.h
>> @@ -111,6 +111,8 @@ struct pt_regs {
>>  	u64 syscallno;
>>  };
>>  
>> +#define MAX_REG_OFFSET (offsetof(struct pt_regs, orig_x0))
> 
> Is orig_x0 actually useful to this API? If not, we could instead operate on
> the user_pt_regs structure, and define the maximum offset in terms of sizeof
> that.

It depends on the architecture, but this patch provides the common interface
for kprobe-tracer. I think this code looks OK, since kprobe-tracer doesn't
use user_pt_regs.

> 
>> +#define ARM_cpsr	pstate
>> +#define ARM_pc		pc
>> +#define ARM_sp		sp
>> +#define ARM_lr		regs[30]
>> +#define ARM_fp		regs[29]
>> +#define ARM_x28		regs[28]
>> +#define ARM_x27		regs[27]
> 
> [...]
> 
> I don't think we need these #defines.

Agreed.

Thank you,


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt at hitachi.com

  reply	other threads:[~2014-11-20  7:20 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18  6:32 [PATCH v3 0/5] ARM64: Add kernel probes(Kprobes) support David Long
2014-11-18  6:32 ` David Long
2014-11-18  6:32 ` [PATCH v3 1/5] arm64: Kprobes with single stepping support David Long
2014-11-18  6:32   ` David Long
2014-11-18 13:28   ` Jon Medhurst (Tixy)
2014-11-18 13:28     ` Jon Medhurst (Tixy)
2014-11-21  4:28     ` David Long
2014-11-21  4:28       ` David Long
2014-11-18 14:38   ` William Cohen
2014-11-18 14:38     ` William Cohen
2014-11-18 14:39   ` William Cohen
2014-11-18 14:39     ` William Cohen
2014-11-18 14:56   ` Will Deacon
2014-11-18 14:56     ` Will Deacon
2014-11-19 11:21     ` Sandeepa Prabhu
2014-11-19 11:21       ` Sandeepa Prabhu
2014-11-19 11:25       ` Will Deacon
2014-11-19 11:25         ` Will Deacon
2014-11-19 14:55         ` David Long
2014-11-19 14:55           ` David Long
2014-11-20  5:10           ` Sandeepa Prabhu
2014-11-20  5:10             ` Sandeepa Prabhu
2014-11-26  6:46           ` David Long
2014-11-26  6:46             ` David Long
2014-11-26 10:09             ` Will Deacon
2014-11-26 10:09               ` Will Deacon
2014-12-22 10:10   ` Pratyush Anand
2014-12-22 10:10     ` Pratyush Anand
2014-11-18  6:32 ` [PATCH v3 2/5] arm64: Kprobes instruction simulation support David Long
2014-11-18  6:32   ` David Long
2014-11-18 14:43   ` William Cohen
2014-11-18 14:43     ` William Cohen
2014-11-18  6:32 ` [PATCH v3 3/5] arm64: Add kernel return probes support(kretprobes) David Long
2014-11-18  6:32   ` David Long
2014-11-18 14:50   ` William Cohen
2014-11-18 14:50     ` William Cohen
2014-11-18  6:32 ` [PATCH v3 4/5] kprobes: Add arm64 case in kprobe example module David Long
2014-11-18  6:32   ` David Long
2014-11-18  6:32 ` [PATCH v3 5/5] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature David Long
2014-11-18  6:32   ` David Long
2014-11-18 14:52   ` Will Deacon
2014-11-18 14:52     ` Will Deacon
2014-11-20  7:20     ` Masami Hiramatsu [this message]
2014-11-20  7:20       ` Masami Hiramatsu
2014-11-21  6:16     ` David Long
2014-11-21  6:16       ` David Long
2014-11-20 15:02 ` [PATCH v3 0/5] ARM64: Add kernel probes(Kprobes) support Steve Capper
2014-11-20 15:02   ` Steve Capper
2014-11-26  8:33   ` Masami Hiramatsu
2014-11-26  8:33     ` Masami Hiramatsu
2014-11-26 10:03     ` Steve Capper
2014-11-26 10:03       ` Steve Capper
2014-11-26 17:46       ` David Long
2014-11-26 17:46         ` David Long
2014-11-26 18:59         ` Steve Capper
2014-11-26 18:59           ` Steve Capper
2014-11-27  6:07           ` Masami Hiramatsu
2014-11-27  6:07             ` Masami Hiramatsu
2014-11-28 16:01             ` Steve Capper
2014-11-28 16:01               ` Steve Capper
2014-12-01  9:37               ` Re: " Masami Hiramatsu
2014-12-01  9:37                 ` Masami Hiramatsu
2014-12-02 19:27                 ` William Cohen
2014-12-02 19:27                   ` William Cohen
2014-12-02 20:00                   ` William Cohen
2014-12-02 20:00                     ` William Cohen
2014-12-03  3:36                   ` Masami Hiramatsu
2014-12-03  3:36                     ` Masami Hiramatsu
2014-12-03 14:54                 ` William Cohen
2014-12-03 14:54                   ` William Cohen
2014-12-03 22:54                   ` David Long
2014-12-03 22:54                     ` David Long
2014-12-04  0:02                     ` David Long
2014-12-04  0:02                       ` David Long
2014-12-04  1:16                     ` William Cohen
2014-12-04  1:16                       ` William Cohen
2014-12-04  2:48                       ` David Long
2014-12-04  2:48                         ` David Long
2014-12-04 10:21                         ` Steve Capper
2014-12-04 10:21                           ` Steve Capper
2014-12-04 10:43                           ` Masami Hiramatsu
2014-12-04 10:43                             ` Masami Hiramatsu
2014-12-04 11:29                             ` Steve Capper
2014-12-04 11:29                               ` Steve Capper
2014-12-04 11:53                               ` Masami Hiramatsu
2014-12-04 11:53                                 ` Masami Hiramatsu
2014-12-09 13:33                                 ` Steve Capper
2014-12-09 13:33                                   ` Steve Capper
2014-12-09 14:27                                   ` David Long
2014-12-09 14:27                                     ` David Long
2014-12-10 16:38                                     ` Steve Capper
2014-12-10 16:38                                       ` Steve Capper
2014-12-12 22:42                                       ` David Long
2014-12-12 22:42                                         ` David Long
2014-12-12 23:10                                         ` Steve Capper
2014-12-12 23:10                                           ` Steve Capper
2014-12-15  5:58                                           ` Masami Hiramatsu
2014-12-15  5:58                                             ` Masami Hiramatsu
2014-12-15  6:29                                           ` David Long
2014-12-15  6:29                                             ` David Long
2014-12-05  5:08                       ` William Cohen
2014-12-05  5:08                         ` William Cohen
2014-11-27  5:13       ` Masami Hiramatsu
2014-11-27  5:13         ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546D962F.3080309@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=dave.long@linaro.org \
    --cc=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sandeepa.prabhu@linaro.org \
    --cc=tixy@linaro.org \
    --cc=wcohen@redhat.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.