* linux-next: build warnings after merge of the driver-core tree
@ 2014-12-01 7:42 Stephen Rothwell
2014-12-01 7:45 ` Arend van Spriel
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2014-12-01 7:42 UTC (permalink / raw)
To: Greg KH; +Cc: linux-next, linux-kernel, Arend van Spriel
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
Hi Greg,
After merging the driver-core tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from kernel/power/main.c:16:0:
include/linux/debugfs.h:105:10: warning: 'struct device' declared inside parameter list
void *data));
^
And many more like this.
Introduced by commit 98210b7f73f1 ("debugfs: add helper function to
create device related seq_file"). See Rule 1 from
Documentation/SubmitChecklist - though in this case a simple "struct
device;" would probably do.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warnings after merge of the driver-core tree
2014-12-01 7:42 linux-next: build warnings after merge of the driver-core tree Stephen Rothwell
@ 2014-12-01 7:45 ` Arend van Spriel
0 siblings, 0 replies; 10+ messages in thread
From: Arend van Spriel @ 2014-12-01 7:45 UTC (permalink / raw)
To: Stephen Rothwell, Greg KH; +Cc: linux-next, linux-kernel
On 01-12-14 08:42, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the driver-core tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from kernel/power/main.c:16:0:
> include/linux/debugfs.h:105:10: warning: 'struct device' declared inside parameter list
> void *data));
> ^
>
> And many more like this.
>
> Introduced by commit 98210b7f73f1 ("debugfs: add helper function to
> create device related seq_file"). See Rule 1 from
> Documentation/SubmitChecklist - though in this case a simple "struct
> device;" would probably do.
>
I submitted a patch for that yesterday [1] and got (automated) email
from Greg that it is going into his driver-core tree.
Regards,
Arend
[1] http://mid.gmane.org/1417361481-1136-1-git-send-email-arend@broadcom.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warnings after merge of the driver-core tree
@ 2014-12-01 7:45 ` Arend van Spriel
0 siblings, 0 replies; 10+ messages in thread
From: Arend van Spriel @ 2014-12-01 7:45 UTC (permalink / raw)
To: Stephen Rothwell, Greg KH; +Cc: linux-next, linux-kernel
On 01-12-14 08:42, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the driver-core tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from kernel/power/main.c:16:0:
> include/linux/debugfs.h:105:10: warning: 'struct device' declared inside parameter list
> void *data));
> ^
>
> And many more like this.
>
> Introduced by commit 98210b7f73f1 ("debugfs: add helper function to
> create device related seq_file"). See Rule 1 from
> Documentation/SubmitChecklist - though in this case a simple "struct
> device;" would probably do.
>
I submitted a patch for that yesterday [1] and got (automated) email
from Greg that it is going into his driver-core tree.
Regards,
Arend
[1] http://mid.gmane.org/1417361481-1136-1-git-send-email-arend@broadcom.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warnings after merge of the driver-core tree
2014-12-01 7:45 ` Arend van Spriel
(?)
@ 2014-12-02 18:09 ` Greg KH
-1 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2014-12-02 18:09 UTC (permalink / raw)
To: Arend van Spriel; +Cc: Stephen Rothwell, linux-next, linux-kernel
On Mon, Dec 01, 2014 at 08:45:13AM +0100, Arend van Spriel wrote:
> On 01-12-14 08:42, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > After merging the driver-core tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > In file included from kernel/power/main.c:16:0:
> > include/linux/debugfs.h:105:10: warning: 'struct device' declared inside parameter list
> > void *data));
> > ^
> >
> > And many more like this.
> >
> > Introduced by commit 98210b7f73f1 ("debugfs: add helper function to
> > create device related seq_file"). See Rule 1 from
> > Documentation/SubmitChecklist - though in this case a simple "struct
> > device;" would probably do.
> >
>
> I submitted a patch for that yesterday [1] and got (automated) email
> from Greg that it is going into his driver-core tree.
>
> Regards,
> Arend
>
> [1] http://mid.gmane.org/1417361481-1136-1-git-send-email-arend@broadcom.com
Sorry for the delay, is now in my driver-core-next branch, so this will
be fixed in the next linux-next pull.
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warnings after merge of the driver-core tree
2010-05-21 22:27 ` Greg KH
@ 2010-05-24 14:03 ` Jiri Kosina
0 siblings, 0 replies; 10+ messages in thread
From: Jiri Kosina @ 2010-05-24 14:03 UTC (permalink / raw)
To: Greg KH
Cc: Stephen Rothwell, linux-next, linux-kernel, Stefan Achatz, Chris Wright
On Fri, 21 May 2010, Greg KH wrote:
> > > > drivers/hid/hid-roccat-kone.c:696: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:701: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:703: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:708: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:710: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:715: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:717: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:722: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:724: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:729: warning: initialization from incompatible pointer type
> > > > drivers/hid/hid-roccat-kone.c:731: warning: initialization from incompatible pointer type
> > > >
> > > > Introduced by commit 867040163f10f2b52b45bc573f330d6eb28f5914 ("sysfs:
> > > > add struct file* to bin_attr callbacks") from the driver-core tree
> > > > interacting with commit 14bf62cde79423a02a590e02664ed29a36facec1 ("HID:
> > > > add driver for Roccat Kone gaming mouse") from the hid tree.
> > > >
> > > > I added the following patch:
> > > >
> > > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > Date: Fri, 21 May 2010 16:15:32 +1000
> > > > Subject: [PATCH] hid: fix hid-roccat-kone for bin_attr API change
> > > >
> > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > ---
> > > > drivers/hid/hid-roccat-kone.c | 24 ++++++++++++------------
> > >
> > > That patch looks fine, but I can't take it in my tree as the HID tree
> > > isn't merged with Linus's tree yet :(
> >
> > It is merged now, so you can proceed.
>
> Heh, so is the driver core changes as well.
>
> Care to take this through your tree as it does only touch drivers/hid/ ?
>
> Sorry about this.
Yup, I have now applied it to my tree.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warnings after merge of the driver-core tree
2010-05-21 21:30 ` Jiri Kosina
@ 2010-05-21 22:27 ` Greg KH
2010-05-24 14:03 ` Jiri Kosina
0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2010-05-21 22:27 UTC (permalink / raw)
To: Jiri Kosina
Cc: Stephen Rothwell, linux-next, linux-kernel, Stefan Achatz, Chris Wright
On Fri, May 21, 2010 at 11:30:37PM +0200, Jiri Kosina wrote:
> On Fri, 21 May 2010, Greg KH wrote:
>
> > > drivers/hid/hid-roccat-kone.c:694: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:696: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:701: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:703: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:708: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:710: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:715: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:717: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:722: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:724: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:729: warning: initialization from incompatible pointer type
> > > drivers/hid/hid-roccat-kone.c:731: warning: initialization from incompatible pointer type
> > >
> > > Introduced by commit 867040163f10f2b52b45bc573f330d6eb28f5914 ("sysfs:
> > > add struct file* to bin_attr callbacks") from the driver-core tree
> > > interacting with commit 14bf62cde79423a02a590e02664ed29a36facec1 ("HID:
> > > add driver for Roccat Kone gaming mouse") from the hid tree.
> > >
> > > I added the following patch:
> > >
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Date: Fri, 21 May 2010 16:15:32 +1000
> > > Subject: [PATCH] hid: fix hid-roccat-kone for bin_attr API change
> > >
> > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > ---
> > > drivers/hid/hid-roccat-kone.c | 24 ++++++++++++------------
> >
> > That patch looks fine, but I can't take it in my tree as the HID tree
> > isn't merged with Linus's tree yet :(
>
> It is merged now, so you can proceed.
Heh, so is the driver core changes as well.
Care to take this through your tree as it does only touch drivers/hid/ ?
Sorry about this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warnings after merge of the driver-core tree
2010-05-21 16:47 ` Greg KH
@ 2010-05-21 21:30 ` Jiri Kosina
2010-05-21 22:27 ` Greg KH
0 siblings, 1 reply; 10+ messages in thread
From: Jiri Kosina @ 2010-05-21 21:30 UTC (permalink / raw)
To: Greg KH
Cc: Stephen Rothwell, linux-next, linux-kernel, Stefan Achatz, Chris Wright
On Fri, 21 May 2010, Greg KH wrote:
> > drivers/hid/hid-roccat-kone.c:694: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:696: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:701: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:703: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:708: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:710: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:715: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:717: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:722: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:724: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:729: warning: initialization from incompatible pointer type
> > drivers/hid/hid-roccat-kone.c:731: warning: initialization from incompatible pointer type
> >
> > Introduced by commit 867040163f10f2b52b45bc573f330d6eb28f5914 ("sysfs:
> > add struct file* to bin_attr callbacks") from the driver-core tree
> > interacting with commit 14bf62cde79423a02a590e02664ed29a36facec1 ("HID:
> > add driver for Roccat Kone gaming mouse") from the hid tree.
> >
> > I added the following patch:
> >
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Fri, 21 May 2010 16:15:32 +1000
> > Subject: [PATCH] hid: fix hid-roccat-kone for bin_attr API change
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> > drivers/hid/hid-roccat-kone.c | 24 ++++++++++++------------
>
> That patch looks fine, but I can't take it in my tree as the HID tree
> isn't merged with Linus's tree yet :(
It is merged now, so you can proceed.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warnings after merge of the driver-core tree
2010-05-21 6:18 Stephen Rothwell
2010-05-21 16:22 ` Chris Wright
@ 2010-05-21 16:47 ` Greg KH
2010-05-21 21:30 ` Jiri Kosina
1 sibling, 1 reply; 10+ messages in thread
From: Greg KH @ 2010-05-21 16:47 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Stefan Achatz, Jiri Kosina, Chris Wright
On Fri, May 21, 2010 at 04:18:43PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the driver-core tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/hid/hid-roccat-kone.c:694: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:696: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:701: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:703: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:708: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:710: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:715: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:717: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:722: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:724: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:729: warning: initialization from incompatible pointer type
> drivers/hid/hid-roccat-kone.c:731: warning: initialization from incompatible pointer type
>
> Introduced by commit 867040163f10f2b52b45bc573f330d6eb28f5914 ("sysfs:
> add struct file* to bin_attr callbacks") from the driver-core tree
> interacting with commit 14bf62cde79423a02a590e02664ed29a36facec1 ("HID:
> add driver for Roccat Kone gaming mouse") from the hid tree.
>
> I added the following patch:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 21 May 2010 16:15:32 +1000
> Subject: [PATCH] hid: fix hid-roccat-kone for bin_attr API change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/hid/hid-roccat-kone.c | 24 ++++++++++++------------
That patch looks fine, but I can't take it in my tree as the HID tree
isn't merged with Linus's tree yet :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warnings after merge of the driver-core tree
2010-05-21 6:18 Stephen Rothwell
@ 2010-05-21 16:22 ` Chris Wright
2010-05-21 16:47 ` Greg KH
1 sibling, 0 replies; 10+ messages in thread
From: Chris Wright @ 2010-05-21 16:22 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, linux-next, linux-kernel, Stefan Achatz, Jiri Kosina,
Chris Wright
* Stephen Rothwell (sfr@canb.auug.org.au) wrote:
...
> drivers/hid/hid-roccat-kone.c:731: warning: initialization from incompatible pointer type
>
> Introduced by commit 867040163f10f2b52b45bc573f330d6eb28f5914 ("sysfs:
> add struct file* to bin_attr callbacks") from the driver-core tree
> interacting with commit 14bf62cde79423a02a590e02664ed29a36facec1 ("HID:
> add driver for Roccat Kone gaming mouse") from the hid tree.
>
> I added the following patch:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 21 May 2010 16:15:32 +1000
> Subject: [PATCH] hid: fix hid-roccat-kone for bin_attr API change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Yep, looks good. I figured we'd hit one or two of those w/ the API
change.
Acked-by: Chris Wright <chrisw@sous-sol.org>
thanks,
-chris
^ permalink raw reply [flat|nested] 10+ messages in thread
* linux-next: build warnings after merge of the driver-core tree
@ 2010-05-21 6:18 Stephen Rothwell
2010-05-21 16:22 ` Chris Wright
2010-05-21 16:47 ` Greg KH
0 siblings, 2 replies; 10+ messages in thread
From: Stephen Rothwell @ 2010-05-21 6:18 UTC (permalink / raw)
To: Greg KH
Cc: linux-next, linux-kernel, Stefan Achatz, Jiri Kosina, Chris Wright
Hi Greg,
After merging the driver-core tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
drivers/hid/hid-roccat-kone.c:694: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:696: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:701: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:703: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:708: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:710: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:715: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:717: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:722: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:724: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:729: warning: initialization from incompatible pointer type
drivers/hid/hid-roccat-kone.c:731: warning: initialization from incompatible pointer type
Introduced by commit 867040163f10f2b52b45bc573f330d6eb28f5914 ("sysfs:
add struct file* to bin_attr callbacks") from the driver-core tree
interacting with commit 14bf62cde79423a02a590e02664ed29a36facec1 ("HID:
add driver for Roccat Kone gaming mouse") from the hid tree.
I added the following patch:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 21 May 2010 16:15:32 +1000
Subject: [PATCH] hid: fix hid-roccat-kone for bin_attr API change
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/hid/hid-roccat-kone.c | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
index 66e6940..b6371d3 100644
--- a/drivers/hid/hid-roccat-kone.c
+++ b/drivers/hid/hid-roccat-kone.c
@@ -263,7 +263,7 @@ static int kone_get_firmware_version(struct usb_device *usb_dev, int *result)
return 0;
}
-static ssize_t kone_sysfs_read_settings(struct kobject *kobj,
+static ssize_t kone_sysfs_read_settings(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
struct device *dev = container_of(kobj, struct device, kobj);
@@ -287,7 +287,7 @@ static ssize_t kone_sysfs_read_settings(struct kobject *kobj,
* This function keeps values in kone_device up to date and assumes that in
* case of error the old data is still valid
*/
-static ssize_t kone_sysfs_write_settings(struct kobject *kobj,
+static ssize_t kone_sysfs_write_settings(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
struct device *dev = container_of(kobj, struct device, kobj);
@@ -342,31 +342,31 @@ static ssize_t kone_sysfs_read_profilex(struct kobject *kobj,
return count;
}
-static ssize_t kone_sysfs_read_profile1(struct kobject *kobj,
+static ssize_t kone_sysfs_read_profile1(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_read_profilex(kobj, attr, buf, off, count, 1);
}
-static ssize_t kone_sysfs_read_profile2(struct kobject *kobj,
+static ssize_t kone_sysfs_read_profile2(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_read_profilex(kobj, attr, buf, off, count, 2);
}
-static ssize_t kone_sysfs_read_profile3(struct kobject *kobj,
+static ssize_t kone_sysfs_read_profile3(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_read_profilex(kobj, attr, buf, off, count, 3);
}
-static ssize_t kone_sysfs_read_profile4(struct kobject *kobj,
+static ssize_t kone_sysfs_read_profile4(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_read_profilex(kobj, attr, buf, off, count, 4);
}
-static ssize_t kone_sysfs_read_profile5(struct kobject *kobj,
+static ssize_t kone_sysfs_read_profile5(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_read_profilex(kobj, attr, buf, off, count, 5);
@@ -404,31 +404,31 @@ static ssize_t kone_sysfs_write_profilex(struct kobject *kobj,
return sizeof(struct kone_profile);
}
-static ssize_t kone_sysfs_write_profile1(struct kobject *kobj,
+static ssize_t kone_sysfs_write_profile1(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_write_profilex(kobj, attr, buf, off, count, 1);
}
-static ssize_t kone_sysfs_write_profile2(struct kobject *kobj,
+static ssize_t kone_sysfs_write_profile2(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_write_profilex(kobj, attr, buf, off, count, 2);
}
-static ssize_t kone_sysfs_write_profile3(struct kobject *kobj,
+static ssize_t kone_sysfs_write_profile3(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_write_profilex(kobj, attr, buf, off, count, 3);
}
-static ssize_t kone_sysfs_write_profile4(struct kobject *kobj,
+static ssize_t kone_sysfs_write_profile4(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_write_profilex(kobj, attr, buf, off, count, 4);
}
-static ssize_t kone_sysfs_write_profile5(struct kobject *kobj,
+static ssize_t kone_sysfs_write_profile5(struct file *fp, struct kobject *kobj,
struct bin_attribute *attr, char *buf,
loff_t off, size_t count) {
return kone_sysfs_write_profilex(kobj, attr, buf, off, count, 5);
--
1.7.1
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-12-02 18:09 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-01 7:42 linux-next: build warnings after merge of the driver-core tree Stephen Rothwell
2014-12-01 7:45 ` Arend van Spriel
2014-12-01 7:45 ` Arend van Spriel
2014-12-02 18:09 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-05-21 6:18 Stephen Rothwell
2010-05-21 16:22 ` Chris Wright
2010-05-21 16:47 ` Greg KH
2010-05-21 21:30 ` Jiri Kosina
2010-05-21 22:27 ` Greg KH
2010-05-24 14:03 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.