From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: John Garry <john.garry@huawei.com>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
iommu <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] iommu/arm-smmu-v3: Use command queue batching helpers to improve performance
Date: Mon, 16 Aug 2021 10:15:37 +0800 [thread overview]
Message-ID: <5482d2e5-24db-6139-a8a8-74be1282e2ec@huawei.com> (raw)
In-Reply-To: <4e741216-d6e7-c40c-f257-242cd2fea302@huawei.com>
On 2021/8/14 0:45, John Garry wrote:
> On 13/08/2021 17:01, Robin Murphy wrote:
>>>
>>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> index 235f9bdaeaf223b..c81cd929047f573 100644
>>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> @@ -1747,15 +1747,16 @@ static int arm_smmu_atc_inv_master(struct arm_smmu_master *master)
>>> {
>>> int i;
>>> struct arm_smmu_cmdq_ent cmd;
>>> + struct arm_smmu_cmdq_batch cmds = {};
>>
>> BTW, it looks like this has crossed over with John's patch removing these.
>
> It is only called from arm_smmu_disable_ats(), so not hot-path by the look for it. Or who even has ats HW ...?
>
> But it should be at least cleaned-up for consistency. Leizhen?
Okay, I'll revise it. But Will already took it. So I'm not sure whether to send v2 or a separate patch.
>
> Thanks,
> John
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: John Garry <john.garry@huawei.com>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
iommu <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] iommu/arm-smmu-v3: Use command queue batching helpers to improve performance
Date: Mon, 16 Aug 2021 10:15:37 +0800 [thread overview]
Message-ID: <5482d2e5-24db-6139-a8a8-74be1282e2ec@huawei.com> (raw)
In-Reply-To: <4e741216-d6e7-c40c-f257-242cd2fea302@huawei.com>
On 2021/8/14 0:45, John Garry wrote:
> On 13/08/2021 17:01, Robin Murphy wrote:
>>>
>>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> index 235f9bdaeaf223b..c81cd929047f573 100644
>>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> @@ -1747,15 +1747,16 @@ static int arm_smmu_atc_inv_master(struct arm_smmu_master *master)
>>> {
>>> int i;
>>> struct arm_smmu_cmdq_ent cmd;
>>> + struct arm_smmu_cmdq_batch cmds = {};
>>
>> BTW, it looks like this has crossed over with John's patch removing these.
>
> It is only called from arm_smmu_disable_ats(), so not hot-path by the look for it. Or who even has ats HW ...?
>
> But it should be at least cleaned-up for consistency. Leizhen?
Okay, I'll revise it. But Will already took it. So I'm not sure whether to send v2 or a separate patch.
>
> Thanks,
> John
> .
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: John Garry <john.garry@huawei.com>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
iommu <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] iommu/arm-smmu-v3: Use command queue batching helpers to improve performance
Date: Mon, 16 Aug 2021 10:15:37 +0800 [thread overview]
Message-ID: <5482d2e5-24db-6139-a8a8-74be1282e2ec@huawei.com> (raw)
In-Reply-To: <4e741216-d6e7-c40c-f257-242cd2fea302@huawei.com>
On 2021/8/14 0:45, John Garry wrote:
> On 13/08/2021 17:01, Robin Murphy wrote:
>>>
>>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> index 235f9bdaeaf223b..c81cd929047f573 100644
>>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>>> @@ -1747,15 +1747,16 @@ static int arm_smmu_atc_inv_master(struct arm_smmu_master *master)
>>> {
>>> int i;
>>> struct arm_smmu_cmdq_ent cmd;
>>> + struct arm_smmu_cmdq_batch cmds = {};
>>
>> BTW, it looks like this has crossed over with John's patch removing these.
>
> It is only called from arm_smmu_disable_ats(), so not hot-path by the look for it. Or who even has ats HW ...?
>
> But it should be at least cleaned-up for consistency. Leizhen?
Okay, I'll revise it. But Will already took it. So I'm not sure whether to send v2 or a separate patch.
>
> Thanks,
> John
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-16 2:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 11:48 [PATCH 0/4] Prepare for ECMDQ support Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-11 11:48 ` [PATCH 1/4] iommu/arm-smmu-v3: Use command queue batching helpers to improve performance Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-13 16:01 ` Robin Murphy
2021-08-13 16:01 ` Robin Murphy
2021-08-13 16:01 ` Robin Murphy
2021-08-13 16:45 ` John Garry
2021-08-13 16:45 ` John Garry
2021-08-13 16:45 ` John Garry
2021-08-16 2:15 ` Leizhen (ThunderTown) [this message]
2021-08-16 2:15 ` Leizhen (ThunderTown)
2021-08-16 2:15 ` Leizhen (ThunderTown)
2021-08-16 4:05 ` Leizhen (ThunderTown)
2021-08-16 4:05 ` Leizhen (ThunderTown)
2021-08-16 4:05 ` Leizhen (ThunderTown)
2021-08-16 7:24 ` John Garry
2021-08-16 7:24 ` John Garry
2021-08-16 7:24 ` John Garry
2021-08-16 7:47 ` Leizhen (ThunderTown)
2021-08-16 7:47 ` Leizhen (ThunderTown)
2021-08-16 7:47 ` Leizhen (ThunderTown)
2021-08-16 8:21 ` Will Deacon
2021-08-16 8:21 ` Will Deacon
2021-08-16 8:21 ` Will Deacon
2021-08-16 8:41 ` Leizhen (ThunderTown)
2021-08-16 8:41 ` Leizhen (ThunderTown)
2021-08-16 8:41 ` Leizhen (ThunderTown)
2021-08-11 11:48 ` [PATCH 2/4] iommu/arm-smmu-v3: Add and use static helper function arm_smmu_cmdq_issue_cmd_with_sync() Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-11 11:48 ` [PATCH 3/4] iommu/arm-smmu-v3: Add and use static helper function arm_smmu_get_cmdq() Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-11 11:48 ` [PATCH 4/4] iommu/arm-smmu-v3: Extract reusable function __arm_smmu_cmdq_skip_err() Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-11 11:48 ` Zhen Lei
2021-08-13 14:33 ` [PATCH 0/4] Prepare for ECMDQ support Will Deacon
2021-08-13 14:33 ` Will Deacon
2021-08-13 14:33 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5482d2e5-24db-6139-a8a8-74be1282e2ec@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.