* [PULL for-6.2 0/2] ppc queue
@ 2021-11-26 11:51 Cédric Le Goater
2021-11-26 11:51 ` [PULL for-6.2 1/2] pmu: fix pmu vmstate subsection list Cédric Le Goater
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Cédric Le Goater @ 2021-11-26 11:51 UTC (permalink / raw)
To: qemu-ppc, qemu-devel
Cc: Alexey Kardashevskiy, Daniel Henrique Barboza, Greg Kurz,
Cédric Le Goater, Frederic Barrat, David Gibson
The following changes since commit 67f9968ce3f0847ffddb6ee2837a3641acd92abf:
Update version for v6.2.0-rc1 release (2021-11-16 21:07:31 +0100)
are available in the Git repository at:
https://github.com/legoater/qemu/ tags/pull-ppc-20211119
for you to fetch changes up to a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d:
tests/tcg/ppc64le: Fix compile flags for byte_reverse (2021-11-17 19:10:44 +0100)
----------------------------------------------------------------
ppc 6.2 queue:
* fix pmu vmstate
* Fix compile of byte_reverse on new compilers
----------------------------------------------------------------
Laurent Vivier (1):
pmu: fix pmu vmstate subsection list
Richard Henderson (1):
tests/tcg/ppc64le: Fix compile flags for byte_reverse
hw/misc/macio/pmu.c | 1 +
tests/tcg/ppc64le/Makefile.target | 12 +++---------
2 files changed, 4 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PULL for-6.2 1/2] pmu: fix pmu vmstate subsection list
2021-11-26 11:51 [PULL for-6.2 0/2] ppc queue Cédric Le Goater
@ 2021-11-26 11:51 ` Cédric Le Goater
2021-11-26 11:51 ` [PULL for-6.2 2/2] tests/tcg/ppc64le: Fix compile flags for byte_reverse Cédric Le Goater
2021-11-26 11:53 ` [PULL for-6.2 0/2] ppc queue Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Cédric Le Goater @ 2021-11-26 11:51 UTC (permalink / raw)
To: qemu-ppc, qemu-devel
Cc: Laurent Vivier, Alexey Kardashevskiy, Daniel Henrique Barboza,
mark.cave-ayland, Greg Kurz, Cédric Le Goater,
Frederic Barrat, Philippe Mathieu-Daudé,
David Gibson
From: Laurent Vivier <lvivier@redhat.com>
The subsection is not closed by a NULL marker so this can trigger
a segfault when the pmu vmstate is saved.
This can be easily shown with:
$ ./qemu-system-ppc64 -dump-vmstate vmstate.json
Segmentation fault (core dumped)
Fixes: d811d61fbc6c ("mac_newworld: add PMU device")
Cc: mark.cave-ayland@ilande.co.uk
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/misc/macio/pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/misc/macio/pmu.c b/hw/misc/macio/pmu.c
index 4ad4f50e08c3..eb39c64694aa 100644
--- a/hw/misc/macio/pmu.c
+++ b/hw/misc/macio/pmu.c
@@ -718,6 +718,7 @@ static const VMStateDescription vmstate_pmu = {
},
.subsections = (const VMStateDescription * []) {
&vmstate_pmu_adb,
+ NULL
}
};
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PULL for-6.2 2/2] tests/tcg/ppc64le: Fix compile flags for byte_reverse
2021-11-26 11:51 [PULL for-6.2 0/2] ppc queue Cédric Le Goater
2021-11-26 11:51 ` [PULL for-6.2 1/2] pmu: fix pmu vmstate subsection list Cédric Le Goater
@ 2021-11-26 11:51 ` Cédric Le Goater
2021-11-26 11:53 ` [PULL for-6.2 0/2] ppc queue Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Cédric Le Goater @ 2021-11-26 11:51 UTC (permalink / raw)
To: qemu-ppc, qemu-devel
Cc: Alexey Kardashevskiy, Daniel Henrique Barboza, Richard Henderson,
Greg Kurz, Cédric Le Goater, Frederic Barrat, David Gibson
From: Richard Henderson <richard.henderson@linaro.org>
With a host compiler new enough to recognize power10 insns,
CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu
option to the compiler, resulting in
/tmp/ccAVdYJd.s: Assembler messages:
/tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh'
/tmp/ccAVdYJd.s:78: Error: unrecognized opcode: `brw'
/tmp/ccAVdYJd.s:107: Error: unrecognized opcode: `brd'
make[2]: *** [byte_reverse] Error 1
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
tests/tcg/ppc64le/Makefile.target | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tests/tcg/ppc64le/Makefile.target b/tests/tcg/ppc64le/Makefile.target
index 5e65b1590dba..ba2fde5ff1c3 100644
--- a/tests/tcg/ppc64le/Makefile.target
+++ b/tests/tcg/ppc64le/Makefile.target
@@ -9,18 +9,12 @@ PPC64LE_TESTS=bcdsub
endif
bcdsub: CFLAGS += -mpower8-vector
-PPC64LE_TESTS += byte_reverse
ifneq ($(DOCKER_IMAGE)$(CROSS_CC_HAS_POWER10),)
+PPC64LE_TESTS += byte_reverse
+endif
+byte_reverse: CFLAGS += -mcpu=power10
run-byte_reverse: QEMU_OPTS+=-cpu POWER10
run-plugin-byte_reverse-with-%: QEMU_OPTS+=-cpu POWER10
-else
-byte_reverse:
- $(call skip-test, "BUILD of $@", "missing compiler support")
-run-byte_reverse:
- $(call skip-test, "RUN of byte_reverse", "not built")
-run-plugin-byte_reverse-with-%:
- $(call skip-test, "RUN of byte_reverse ($*)", "not built")
-endif
PPC64LE_TESTS += signal_save_restore_xer
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PULL for-6.2 0/2] ppc queue
2021-11-26 11:51 [PULL for-6.2 0/2] ppc queue Cédric Le Goater
2021-11-26 11:51 ` [PULL for-6.2 1/2] pmu: fix pmu vmstate subsection list Cédric Le Goater
2021-11-26 11:51 ` [PULL for-6.2 2/2] tests/tcg/ppc64le: Fix compile flags for byte_reverse Cédric Le Goater
@ 2021-11-26 11:53 ` Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Cédric Le Goater @ 2021-11-26 11:53 UTC (permalink / raw)
To: qemu-ppc, qemu-devel
Cc: Alexey Kardashevskiy, Frederic Barrat, Daniel Henrique Barboza,
Greg Kurz, David Gibson
Oops forget this email. I got the directory wrong on my command line.
Sorry for the noise.
C.
On 11/26/21 12:51, Cédric Le Goater wrote:
> The following changes since commit 67f9968ce3f0847ffddb6ee2837a3641acd92abf:
>
> Update version for v6.2.0-rc1 release (2021-11-16 21:07:31 +0100)
>
> are available in the Git repository at:
>
> https://github.com/legoater/qemu/ tags/pull-ppc-20211119
>
> for you to fetch changes up to a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d:
>
> tests/tcg/ppc64le: Fix compile flags for byte_reverse (2021-11-17 19:10:44 +0100)
>
> ----------------------------------------------------------------
> ppc 6.2 queue:
>
> * fix pmu vmstate
> * Fix compile of byte_reverse on new compilers
>
> ----------------------------------------------------------------
> Laurent Vivier (1):
> pmu: fix pmu vmstate subsection list
>
> Richard Henderson (1):
> tests/tcg/ppc64le: Fix compile flags for byte_reverse
>
> hw/misc/macio/pmu.c | 1 +
> tests/tcg/ppc64le/Makefile.target | 12 +++---------
> 2 files changed, 4 insertions(+), 9 deletions(-)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PULL for-6.2 0/2] ppc queue
2021-11-19 11:55 Cédric Le Goater
@ 2021-11-19 14:25 ` Richard Henderson
0 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2021-11-19 14:25 UTC (permalink / raw)
To: Cédric Le Goater, qemu-ppc, qemu-devel; +Cc: Peter Maydell
On 11/19/21 12:55 PM, Cédric Le Goater wrote:
> The following changes since commit 67f9968ce3f0847ffddb6ee2837a3641acd92abf:
>
> Update version for v6.2.0-rc1 release (2021-11-16 21:07:31 +0100)
>
> are available in the Git repository at:
>
> https://github.com/legoater/qemu/ tags/pull-ppc-20211119
>
> for you to fetch changes up to a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d:
>
> tests/tcg/ppc64le: Fix compile flags for byte_reverse (2021-11-17 19:10:44 +0100)
>
> ----------------------------------------------------------------
> ppc 6.2 queue:
>
> * fix pmu vmstate
> * Fix compile of byte_reverse on new compilers
>
> ----------------------------------------------------------------
> Laurent Vivier (1):
> pmu: fix pmu vmstate subsection list
>
> Richard Henderson (1):
> tests/tcg/ppc64le: Fix compile flags for byte_reverse
>
> hw/misc/macio/pmu.c | 1 +
> tests/tcg/ppc64le/Makefile.target | 12 +++---------
> 2 files changed, 4 insertions(+), 9 deletions(-)
Applied, thanks.
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PULL for-6.2 0/2] ppc queue
@ 2021-11-19 11:55 Cédric Le Goater
2021-11-19 14:25 ` Richard Henderson
0 siblings, 1 reply; 6+ messages in thread
From: Cédric Le Goater @ 2021-11-19 11:55 UTC (permalink / raw)
To: qemu-ppc, qemu-devel
Cc: Peter Maydell, Richard Henderson, Cédric Le Goater
The following changes since commit 67f9968ce3f0847ffddb6ee2837a3641acd92abf:
Update version for v6.2.0-rc1 release (2021-11-16 21:07:31 +0100)
are available in the Git repository at:
https://github.com/legoater/qemu/ tags/pull-ppc-20211119
for you to fetch changes up to a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d:
tests/tcg/ppc64le: Fix compile flags for byte_reverse (2021-11-17 19:10:44 +0100)
----------------------------------------------------------------
ppc 6.2 queue:
* fix pmu vmstate
* Fix compile of byte_reverse on new compilers
----------------------------------------------------------------
Laurent Vivier (1):
pmu: fix pmu vmstate subsection list
Richard Henderson (1):
tests/tcg/ppc64le: Fix compile flags for byte_reverse
hw/misc/macio/pmu.c | 1 +
tests/tcg/ppc64le/Makefile.target | 12 +++---------
2 files changed, 4 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-26 12:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 11:51 [PULL for-6.2 0/2] ppc queue Cédric Le Goater
2021-11-26 11:51 ` [PULL for-6.2 1/2] pmu: fix pmu vmstate subsection list Cédric Le Goater
2021-11-26 11:51 ` [PULL for-6.2 2/2] tests/tcg/ppc64le: Fix compile flags for byte_reverse Cédric Le Goater
2021-11-26 11:53 ` [PULL for-6.2 0/2] ppc queue Cédric Le Goater
-- strict thread matches above, loose matches on Subject: below --
2021-11-19 11:55 Cédric Le Goater
2021-11-19 14:25 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.