From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block-migration: fix pending() return value
Date: Fri, 19 Dec 2014 14:44:32 +0300 [thread overview]
Message-ID: <54940FA0.1010606@parallels.com> (raw)
In-Reply-To: <5489B333.8060502@redhat.com>
Hi there.. Can someone review my bug fix? I'll surely fix typos in
description after it.
Best regards,
Vladimir
On 11.12.2014 18:07, Eric Blake wrote:
> On 12/11/2014 04:55 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Because of wrong return value of .save_live_pending() in
>> block-migration, migration finishes before the whole disk
>> is transferred. Such situation occures when the migration
> s/occures/occurs/
>
>> process is fast enouth, for example when source and dest
> s/enouth/enough/
>
>> are on the same host.
>>
>> If in the bulk phase we return something < max_size, we will skip
>> transferring the tail of the device. Currently we have "set pending to
>> BLOCK_SIZE if it is zero" for bulk phase, but there no guarantee, that
>> it will be < max_size.
>>
>> True approach is to return, for example, max_size+1 when we are in the
>> bulk phase.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
>> ---
>> block-migration.c | 4 ++--
> I'll let someone else review the code proper.
>
next prev parent reply other threads:[~2014-12-19 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 11:55 [Qemu-devel] [PATCH] Fix block migration bug Vladimir Sementsov-Ogievskiy
2014-12-11 11:55 ` [Qemu-devel] [PATCH] block-migration: fix pending() return value Vladimir Sementsov-Ogievskiy
2014-12-11 15:07 ` Eric Blake
2014-12-19 11:44 ` Vladimir Sementsov-Ogievskiy [this message]
2015-01-29 7:58 ` Markus Armbruster
2015-01-29 8:35 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54940FA0.1010606@parallels.com \
--to=vsementsov@parallels.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.