All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] migration: fix typo in mig_throttle_guest_down comment
@ 2021-07-08 16:21 Olaf Hering
  2021-07-08 16:36 ` Dr. David Alan Gilbert
  2021-07-09  9:14 ` Laurent Vivier
  0 siblings, 2 replies; 4+ messages in thread
From: Olaf Hering @ 2021-07-08 16:21 UTC (permalink / raw)
  To: qemu-trivial, qemu-devel
  Cc: Olaf Hering, Dr. David Alan Gilbert, Juan Quintela

Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
all functions comments")

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/ram.c b/migration/ram.c
index 723af67c2e..88ff34f574 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
 }
 
 /**
- * mig_throttle_guest_down: throotle down the guest
+ * mig_throttle_guest_down: throttle down the guest
  *
  * Reduce amount of guest cpu execution to hopefully slow down memory
  * writes. If guest dirty memory rate is reduced below the rate at


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] migration: fix typo in mig_throttle_guest_down comment
  2021-07-08 16:21 [PATCH v1] migration: fix typo in mig_throttle_guest_down comment Olaf Hering
@ 2021-07-08 16:36 ` Dr. David Alan Gilbert
  2021-07-08 17:07   ` Philippe Mathieu-Daudé
  2021-07-09  9:14 ` Laurent Vivier
  1 sibling, 1 reply; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2021-07-08 16:36 UTC (permalink / raw)
  To: Olaf Hering; +Cc: qemu-trivial, qemu-devel, Juan Quintela

* Olaf Hering (olaf@aepfle.de) wrote:
> Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
> all functions comments")
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  migration/ram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 723af67c2e..88ff34f574 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
>  }
>  
>  /**
> - * mig_throttle_guest_down: throotle down the guest
> + * mig_throttle_guest_down: throttle down the guest

Ah yes, Juan frequently throotles.


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>   *
>   * Reduce amount of guest cpu execution to hopefully slow down memory
>   * writes. If guest dirty memory rate is reduced below the rate at
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] migration: fix typo in mig_throttle_guest_down comment
  2021-07-08 16:36 ` Dr. David Alan Gilbert
@ 2021-07-08 17:07   ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-08 17:07 UTC (permalink / raw)
  To: Dr. David Alan Gilbert, Olaf Hering
  Cc: qemu-trivial, qemu-devel, Juan Quintela

On 7/8/21 6:36 PM, Dr. David Alan Gilbert wrote:
> * Olaf Hering (olaf@aepfle.de) wrote:
>> Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
>> all functions comments")
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> ---
>>  migration/ram.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/migration/ram.c b/migration/ram.c
>> index 723af67c2e..88ff34f574 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
>>  }
>>  
>>  /**
>> - * mig_throttle_guest_down: throotle down the guest
>> + * mig_throttle_guest_down: throttle down the guest
> 
> Ah yes, Juan frequently throotles.

=)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] migration: fix typo in mig_throttle_guest_down comment
  2021-07-08 16:21 [PATCH v1] migration: fix typo in mig_throttle_guest_down comment Olaf Hering
  2021-07-08 16:36 ` Dr. David Alan Gilbert
@ 2021-07-09  9:14 ` Laurent Vivier
  1 sibling, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-07-09  9:14 UTC (permalink / raw)
  To: Olaf Hering, qemu-trivial, qemu-devel
  Cc: Dr. David Alan Gilbert, Juan Quintela

Le 08/07/2021 à 18:21, Olaf Hering a écrit :
> Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
> all functions comments")
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  migration/ram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 723af67c2e..88ff34f574 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
>  }
>  
>  /**
> - * mig_throttle_guest_down: throotle down the guest
> + * mig_throttle_guest_down: throttle down the guest
>   *
>   * Reduce amount of guest cpu execution to hopefully slow down memory
>   * writes. If guest dirty memory rate is reduced below the rate at
> 

Applied to my trivial-patches branch.

Thanks,
Laurent


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-09  9:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 16:21 [PATCH v1] migration: fix typo in mig_throttle_guest_down comment Olaf Hering
2021-07-08 16:36 ` Dr. David Alan Gilbert
2021-07-08 17:07   ` Philippe Mathieu-Daudé
2021-07-09  9:14 ` Laurent Vivier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.