* [PATCH] staging/iio/accel: checkpatch: fixed long lines by moving comments
@ 2014-12-22 1:23 Helene Gsaenger
2014-12-22 13:48 ` Sudip Mukherjee
0 siblings, 1 reply; 6+ messages in thread
From: Helene Gsaenger @ 2014-12-22 1:23 UTC (permalink / raw)
To: helene.gsaenger
Cc: simone.weiss, linux-kernel, lars, Michael.Hennerich, jic23,
knaack.h, pmeerw, gregkh, linux-iio, devel, linux-kernel
Signed-off-by: Helene Gsaenger <helene.gsaenger@studium.fau.de>
Signed-off-by: Simone Weiss <simone.weiss@fau.de>
---
drivers/staging/iio/accel/adis16203.h | 41 ++++++++++++++++++++++++++---------
1 file changed, 31 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16203.h b/drivers/staging/iio/accel/adis16203.h
index acc688d..fefe2f9 100644
--- a/drivers/staging/iio/accel/adis16203.h
+++ b/drivers/staging/iio/accel/adis16203.h
@@ -16,26 +16,47 @@
#define ADIS16203_ALM_SMPL2 0x26 /* Alarm 2, sample period */
#define ADIS16203_ALM_CTRL 0x28 /* Alarm control */
#define ADIS16203_AUX_DAC 0x30 /* Auxiliary DAC data */
-#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output control */
+#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output
+ * control */
#define ADIS16203_MSC_CTRL 0x34 /* Miscellaneous control */
-#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate) control */
+#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate)
+ * control */
#define ADIS16203_AVG_CNT 0x38 /* Operation, filter configuration */
#define ADIS16203_SLP_CNT 0x3A /* Operation, sleep mode control */
#define ADIS16203_DIAG_STAT 0x3C /* Diagnostics, system status register */
#define ADIS16203_GLOB_CMD 0x3E /* Operation, system command register */
/* MSC_CTRL */
-#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at power-on: 1 = disabled, 0 = enabled */
-#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation of both inclination outputs */
+#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at
+ * power-on:
+ * 1 = disabled,
+ * 0 = enabled */
+#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation
+ * of both
+ * inclination
+ * outputs */
#define ADIS16203_MSC_CTRL_SELF_TEST_EN (1 << 8) /* Self-test enable */
-#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable: 1 = enabled, 0 = disabled */
-#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready polarity: 1 = active high, 0 = active low */
-#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
+#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable:
+ * 1 = enabled,
+ * 0 = disabled */
+#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready
+ * polarity:
+ * 1 = active high,
+ * 0 = active low */
+#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line
+ * selection:
+ * 1 = DIO1,
+ * 0 = DIO0 */
/* DIAG_STAT */
-#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
-#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
-#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error flag */
+#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status:
+ * 1 = alarm active,
+ * 0 = alarm inactive */
+#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status:
+ * 1 = alarm active,
+ * 0 = alarm inactive */
+#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error
+ * flag */
#define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3 /* SPI communications failure */
#define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2 /* Flash update failure */
#define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1 /* Power supply above 3.625 V */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging/iio/accel: checkpatch: fixed long lines by moving comments
2014-12-22 1:23 [PATCH] staging/iio/accel: checkpatch: fixed long lines by moving comments Helene Gsaenger
@ 2014-12-22 13:48 ` Sudip Mukherjee
2014-12-26 10:00 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2014-12-22 13:48 UTC (permalink / raw)
To: Helene Gsaenger
Cc: simone.weiss, linux-kernel, lars, Michael.Hennerich, jic23,
knaack.h, pmeerw, gregkh, linux-iio, devel, linux-kernel
On Mon, Dec 22, 2014 at 02:23:42AM +0100, Helene Gsaenger wrote:
> Signed-off-by: Helene Gsaenger <helene.gsaenger@studium.fau.de>
> Signed-off-by: Simone Weiss <simone.weiss@fau.de>
> ---
> drivers/staging/iio/accel/adis16203.h | 41 ++++++++++++++++++++++++++---------
> 1 file changed, 31 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16203.h b/drivers/staging/iio/accel/adis16203.h
> index acc688d..fefe2f9 100644
> --- a/drivers/staging/iio/accel/adis16203.h
> +++ b/drivers/staging/iio/accel/adis16203.h
> @@ -16,26 +16,47 @@
> #define ADIS16203_ALM_SMPL2 0x26 /* Alarm 2, sample period */
> #define ADIS16203_ALM_CTRL 0x28 /* Alarm control */
> #define ADIS16203_AUX_DAC 0x30 /* Auxiliary DAC data */
> -#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output control */
> +#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output
> + * control */
> #define ADIS16203_MSC_CTRL 0x34 /* Miscellaneous control */
> -#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate) control */
> +#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate)
> + * control */
this is not the style for multiline comments. Check in CodingStyle.
and besides, I think it will be better if you can put the comments in a line of its own.
thanks
sudip
> #define ADIS16203_AVG_CNT 0x38 /* Operation, filter configuration */
> #define ADIS16203_SLP_CNT 0x3A /* Operation, sleep mode control */
> #define ADIS16203_DIAG_STAT 0x3C /* Diagnostics, system status register */
> #define ADIS16203_GLOB_CMD 0x3E /* Operation, system command register */
>
> /* MSC_CTRL */
> -#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at power-on: 1 = disabled, 0 = enabled */
> -#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation of both inclination outputs */
> +#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at
> + * power-on:
> + * 1 = disabled,
> + * 0 = enabled */
> +#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation
> + * of both
> + * inclination
> + * outputs */
> #define ADIS16203_MSC_CTRL_SELF_TEST_EN (1 << 8) /* Self-test enable */
> -#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable: 1 = enabled, 0 = disabled */
> -#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready polarity: 1 = active high, 0 = active low */
> -#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
> +#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable:
> + * 1 = enabled,
> + * 0 = disabled */
> +#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready
> + * polarity:
> + * 1 = active high,
> + * 0 = active low */
> +#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line
> + * selection:
> + * 1 = DIO1,
> + * 0 = DIO0 */
>
> /* DIAG_STAT */
> -#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
> -#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
> -#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error flag */
> +#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status:
> + * 1 = alarm active,
> + * 0 = alarm inactive */
> +#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status:
> + * 1 = alarm active,
> + * 0 = alarm inactive */
> +#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error
> + * flag */
> #define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3 /* SPI communications failure */
> #define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2 /* Flash update failure */
> #define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1 /* Power supply above 3.625 V */
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging/iio/accel: checkpatch: fixed long lines by moving comments
2014-12-22 13:48 ` Sudip Mukherjee
@ 2014-12-26 10:00 ` Jonathan Cameron
2014-12-27 7:24 ` Sudip Mukherjee
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2014-12-26 10:00 UTC (permalink / raw)
To: Sudip Mukherjee, Helene Gsaenger
Cc: simone.weiss, linux-kernel, lars, Michael.Hennerich, knaack.h,
pmeerw, gregkh, linux-iio, devel, linux-kernel
On 22/12/14 13:48, Sudip Mukherjee wrote:
> On Mon, Dec 22, 2014 at 02:23:42AM +0100, Helene Gsaenger wrote:
>> Signed-off-by: Helene Gsaenger <helene.gsaenger@studium.fau.de>
>> Signed-off-by: Simone Weiss <simone.weiss@fau.de>
>> ---
>> drivers/staging/iio/accel/adis16203.h | 41 ++++++++++++++++++++++++++---------
>> 1 file changed, 31 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/iio/accel/adis16203.h b/drivers/staging/iio/accel/adis16203.h
>> index acc688d..fefe2f9 100644
>> --- a/drivers/staging/iio/accel/adis16203.h
>> +++ b/drivers/staging/iio/accel/adis16203.h
>> @@ -16,26 +16,47 @@
>> #define ADIS16203_ALM_SMPL2 0x26 /* Alarm 2, sample period */
>> #define ADIS16203_ALM_CTRL 0x28 /* Alarm control */
>> #define ADIS16203_AUX_DAC 0x30 /* Auxiliary DAC data */
>> -#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output control */
>> +#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output
>> + * control */
>> #define ADIS16203_MSC_CTRL 0x34 /* Miscellaneous control */
>> -#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate) control */
>> +#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate)
>> + * control */
>
> this is not the style for multiline comments. Check in CodingStyle.
> and besides, I think it will be better if you can put the comments in a line of its own.
+ remember checkpatch is only for guidance. Some rules such as the 80 character limit
are often ignored if clarity would be gained by doing so, or if as here a large patch
would be needed (move all comments to separate lines) in order to meet the 80 character
line limit for a couple of cases.
>
> thanks
> sudip
>> #define ADIS16203_AVG_CNT 0x38 /* Operation, filter configuration */
>> #define ADIS16203_SLP_CNT 0x3A /* Operation, sleep mode control */
>> #define ADIS16203_DIAG_STAT 0x3C /* Diagnostics, system status register */
>> #define ADIS16203_GLOB_CMD 0x3E /* Operation, system command register */
>>
>> /* MSC_CTRL */
>> -#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at power-on: 1 = disabled, 0 = enabled */
>> -#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation of both inclination outputs */
>> +#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at
>> + * power-on:
>> + * 1 = disabled,
>> + * 0 = enabled */
>> +#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation
>> + * of both
>> + * inclination
>> + * outputs */
>> #define ADIS16203_MSC_CTRL_SELF_TEST_EN (1 << 8) /* Self-test enable */
>> -#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable: 1 = enabled, 0 = disabled */
>> -#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready polarity: 1 = active high, 0 = active low */
>> -#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
>> +#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable:
>> + * 1 = enabled,
>> + * 0 = disabled */
>> +#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready
>> + * polarity:
>> + * 1 = active high,
>> + * 0 = active low */
>> +#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line
>> + * selection:
>> + * 1 = DIO1,
>> + * 0 = DIO0 */
>>
>> /* DIAG_STAT */
>> -#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
>> -#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
>> -#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error flag */
>> +#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status:
>> + * 1 = alarm active,
>> + * 0 = alarm inactive */
>> +#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status:
>> + * 1 = alarm active,
>> + * 0 = alarm inactive */
>> +#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error
>> + * flag */
>> #define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3 /* SPI communications failure */
>> #define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2 /* Flash update failure */
>> #define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1 /* Power supply above 3.625 V */
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging/iio/accel: checkpatch: fixed long lines by moving comments
2014-12-26 10:00 ` Jonathan Cameron
@ 2014-12-27 7:24 ` Sudip Mukherjee
2015-01-14 12:18 ` [PATCH] staging/iio/accel: checkpatch: fixed long lines by putting comments in seperate lines Helene Gsaenger
0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2014-12-27 7:24 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Helene Gsaenger, simone.weiss, linux-kernel, lars,
Michael.Hennerich, knaack.h, pmeerw, gregkh, linux-iio, devel,
linux-kernel
On Fri, Dec 26, 2014 at 10:00:00AM +0000, Jonathan Cameron wrote:
> On 22/12/14 13:48, Sudip Mukherjee wrote:
> > On Mon, Dec 22, 2014 at 02:23:42AM +0100, Helene Gsaenger wrote:
> >> Signed-off-by: Helene Gsaenger <helene.gsaenger@studium.fau.de>
> >> Signed-off-by: Simone Weiss <simone.weiss@fau.de>
> >> ---
> >> drivers/staging/iio/accel/adis16203.h | 41 ++++++++++++++++++++++++++---------
> >> 1 file changed, 31 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/drivers/staging/iio/accel/adis16203.h b/drivers/staging/iio/accel/adis16203.h
> >> index acc688d..fefe2f9 100644
> >> --- a/drivers/staging/iio/accel/adis16203.h
> >> +++ b/drivers/staging/iio/accel/adis16203.h
> >> @@ -16,26 +16,47 @@
> >> #define ADIS16203_ALM_SMPL2 0x26 /* Alarm 2, sample period */
> >> #define ADIS16203_ALM_CTRL 0x28 /* Alarm control */
> >> #define ADIS16203_AUX_DAC 0x30 /* Auxiliary DAC data */
> >> -#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output control */
> >> +#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output
> >> + * control */
> >> #define ADIS16203_MSC_CTRL 0x34 /* Miscellaneous control */
> >> -#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate) control */
> >> +#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate)
> >> + * control */
> >
> > this is not the style for multiline comments. Check in CodingStyle.
> > and besides, I think it will be better if you can put the comments in a line of its own.
> + remember checkpatch is only for guidance. Some rules such as the 80 character limit
> are often ignored if clarity would be gained by doing so, or if as here a large patch
> would be needed (move all comments to separate lines) in order to meet the 80 character
> line limit for a couple of cases.
ofcourse checkpatch is only for guidance, and we need to use our own judgement to decide.
here I mentioned separate line because Helene Gsaenger has sent the patch splitting some commments in the second line, which was not looking good.
Personally, I will like comments beside the #define, so that while reading the code, i can immediately see what that #define is doing.
Sudip
> >
> > thanks
> > sudip
> >> #define ADIS16203_AVG_CNT 0x38 /* Operation, filter configuration */
> >> #define ADIS16203_SLP_CNT 0x3A /* Operation, sleep mode control */
> >> #define ADIS16203_DIAG_STAT 0x3C /* Diagnostics, system status register */
> >> #define ADIS16203_GLOB_CMD 0x3E /* Operation, system command register */
> >>
> >> /* MSC_CTRL */
> >> -#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at power-on: 1 = disabled, 0 = enabled */
> >> -#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation of both inclination outputs */
> >> +#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at
> >> + * power-on:
> >> + * 1 = disabled,
> >> + * 0 = enabled */
> >> +#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation
> >> + * of both
> >> + * inclination
> >> + * outputs */
> >> #define ADIS16203_MSC_CTRL_SELF_TEST_EN (1 << 8) /* Self-test enable */
> >> -#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable: 1 = enabled, 0 = disabled */
> >> -#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready polarity: 1 = active high, 0 = active low */
> >> -#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
> >> +#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable:
> >> + * 1 = enabled,
> >> + * 0 = disabled */
> >> +#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready
> >> + * polarity:
> >> + * 1 = active high,
> >> + * 0 = active low */
> >> +#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line
> >> + * selection:
> >> + * 1 = DIO1,
> >> + * 0 = DIO0 */
> >>
> >> /* DIAG_STAT */
> >> -#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
> >> -#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
> >> -#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error flag */
> >> +#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status:
> >> + * 1 = alarm active,
> >> + * 0 = alarm inactive */
> >> +#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status:
> >> + * 1 = alarm active,
> >> + * 0 = alarm inactive */
> >> +#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error
> >> + * flag */
> >> #define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3 /* SPI communications failure */
> >> #define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2 /* Flash update failure */
> >> #define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1 /* Power supply above 3.625 V */
> >> --
> >> 1.9.1
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging/iio/accel: checkpatch: fixed long lines by putting comments in seperate lines
2014-12-27 7:24 ` Sudip Mukherjee
@ 2015-01-14 12:18 ` Helene Gsaenger
2015-01-14 12:29 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Helene Gsaenger @ 2015-01-14 12:18 UTC (permalink / raw)
To: helene.gsaenger
Cc: Michael.Hennerich, jic23, knaack.h, pmeerw, gregkh, linux-iio,
devel, linux-kernel, simone.weiss, linux-kernel
Signed-off-by: Helene Gsaenger <helene.gsaenger@studium.fau.de>
Signed-off-by: Simone Weiss <simone.weiss@fau.de>
---
drivers/staging/iio/accel/adis16203.h | 99 +++++++++++++++++++++++------------
1 file changed, 66 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16203.h b/drivers/staging/iio/accel/adis16203.h
index acc688d..8d1e200 100644
--- a/drivers/staging/iio/accel/adis16203.h
+++ b/drivers/staging/iio/accel/adis16203.h
@@ -3,43 +3,76 @@
#define ADIS16203_STARTUP_DELAY 220 /* ms */
-#define ADIS16203_FLASH_CNT 0x00 /* Flash memory write count */
-#define ADIS16203_SUPPLY_OUT 0x02 /* Output, power supply */
-#define ADIS16203_AUX_ADC 0x08 /* Output, auxiliary ADC input */
-#define ADIS16203_TEMP_OUT 0x0A /* Output, temperature */
-#define ADIS16203_XINCL_OUT 0x0C /* Output, x-axis inclination */
-#define ADIS16203_YINCL_OUT 0x0E /* Output, y-axis inclination */
-#define ADIS16203_INCL_NULL 0x18 /* Incline null calibration */
-#define ADIS16203_ALM_MAG1 0x20 /* Alarm 1 amplitude threshold */
-#define ADIS16203_ALM_MAG2 0x22 /* Alarm 2 amplitude threshold */
-#define ADIS16203_ALM_SMPL1 0x24 /* Alarm 1, sample period */
-#define ADIS16203_ALM_SMPL2 0x26 /* Alarm 2, sample period */
-#define ADIS16203_ALM_CTRL 0x28 /* Alarm control */
-#define ADIS16203_AUX_DAC 0x30 /* Auxiliary DAC data */
-#define ADIS16203_GPIO_CTRL 0x32 /* General-purpose digital input/output control */
-#define ADIS16203_MSC_CTRL 0x34 /* Miscellaneous control */
-#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate) control */
-#define ADIS16203_AVG_CNT 0x38 /* Operation, filter configuration */
-#define ADIS16203_SLP_CNT 0x3A /* Operation, sleep mode control */
-#define ADIS16203_DIAG_STAT 0x3C /* Diagnostics, system status register */
-#define ADIS16203_GLOB_CMD 0x3E /* Operation, system command register */
+/* Flash memory write count */
+#define ADIS16203_FLASH_CNT 0x00
+/* Output, power supply */
+#define ADIS16203_SUPPLY_OUT 0x02
+/* Output, auxiliary ADC input */
+#define ADIS16203_AUX_ADC 0x08
+/* Output, temperature */
+#define ADIS16203_TEMP_OUT 0x0A
+/* Output, x-axis inclination */
+#define ADIS16203_XINCL_OUT 0x0C
+/* Output, y-axis inclination */
+#define ADIS16203_YINCL_OUT 0x0E
+/* Incline null calibration */
+#define ADIS16203_INCL_NULL 0x18
+/* Alarm 1 amplitude threshold */
+#define ADIS16203_ALM_MAG1 0x20
+/* Alarm 2 amplitude threshold */
+#define ADIS16203_ALM_MAG2 0x22
+/* Alarm 1, sample period */
+#define ADIS16203_ALM_SMPL1 0x24
+/* Alarm 2, sample period */
+#define ADIS16203_ALM_SMPL2 0x26
+/* Alarm control */
+#define ADIS16203_ALM_CTRL 0x28
+/* Auxiliary DAC data */
+#define ADIS16203_AUX_DAC 0x30
+/* General-purpose digital input/output control */
+#define ADIS16203_GPIO_CTRL 0x32
+/* Miscellaneous control */
+#define ADIS16203_MSC_CTRL 0x34
+/* Internal sample period (rate) control */
+#define ADIS16203_SMPL_PRD 0x36
+/* Operation, filter configuration */
+#define ADIS16203_AVG_CNT 0x38
+/* Operation, sleep mode control */
+#define ADIS16203_SLP_CNT 0x3A
+/* Diagnostics, system status register */
+#define ADIS16203_DIAG_STAT 0x3C
+/* Operation, system command register */
+#define ADIS16203_GLOB_CMD 0x3E
/* MSC_CTRL */
-#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10) /* Self-test at power-on: 1 = disabled, 0 = enabled */
-#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9) /* Reverses rotation of both inclination outputs */
-#define ADIS16203_MSC_CTRL_SELF_TEST_EN (1 << 8) /* Self-test enable */
-#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2) /* Data-ready enable: 1 = enabled, 0 = disabled */
-#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1) /* Data-ready polarity: 1 = active high, 0 = active low */
-#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0) /* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
+/* Self-test at power-on: 1 = disabled, 0 = enabled */
+#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST (1 << 10)
+/* Reverses rotation of both inclination outputs */
+#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN (1 << 9)
+/* Self-test enable */
+#define ADIS16203_MSC_CTRL_SELF_TEST_EN (1 << 8)
+/* Data-ready enable: 1 = enabled, 0 = disabled */
+#define ADIS16203_MSC_CTRL_DATA_RDY_EN (1 << 2)
+/* Data-ready polarity: 1 = active high, 0 = active low */
+#define ADIS16203_MSC_CTRL_ACTIVE_HIGH (1 << 1)
+/* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
+#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 (1 << 0)
/* DIAG_STAT */
-#define ADIS16203_DIAG_STAT_ALARM2 (1<<9) /* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
-#define ADIS16203_DIAG_STAT_ALARM1 (1<<8) /* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
-#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5 /* Self-test diagnostic error flag */
-#define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3 /* SPI communications failure */
-#define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2 /* Flash update failure */
-#define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1 /* Power supply above 3.625 V */
-#define ADIS16203_DIAG_STAT_POWER_LOW_BIT 0 /* Power supply below 3.15 V */
+/* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
+#define ADIS16203_DIAG_STAT_ALARM2 (1<<9)
+/* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
+#define ADIS16203_DIAG_STAT_ALARM1 (1<<8)
+/* Self-test diagnostic error flag */
+#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5
+/* SPI communications failure */
+#define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3
+/* Flash update failure */
+#define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2
+/* Power supply above 3.625 V */
+#define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1
+/* Power supply below 3.15 V */
+#define ADIS16203_DIAG_STAT_POWER_LOW_BIT 0
/* GLOB_CMD */
#define ADIS16203_GLOB_CMD_SW_RESET (1<<7)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging/iio/accel: checkpatch: fixed long lines by putting comments in seperate lines
2015-01-14 12:18 ` [PATCH] staging/iio/accel: checkpatch: fixed long lines by putting comments in seperate lines Helene Gsaenger
@ 2015-01-14 12:29 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-01-14 12:29 UTC (permalink / raw)
To: Helene Gsaenger
Cc: devel, simone.weiss, Michael.Hennerich, linux-kernel, linux-iio,
gregkh, linux-kernel, pmeerw, knaack.h, jic23
On Wed, Jan 14, 2015 at 01:18:10PM +0100, Helene Gsaenger wrote:
> +/* Flash memory write count */
> +#define ADIS16203_FLASH_CNT 0x00
Ugh. No. That's super ugly. The original was fine. Just ignore
checkpatch.pl when it complains about stupid stuff.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-14 12:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-22 1:23 [PATCH] staging/iio/accel: checkpatch: fixed long lines by moving comments Helene Gsaenger
2014-12-22 13:48 ` Sudip Mukherjee
2014-12-26 10:00 ` Jonathan Cameron
2014-12-27 7:24 ` Sudip Mukherjee
2015-01-14 12:18 ` [PATCH] staging/iio/accel: checkpatch: fixed long lines by putting comments in seperate lines Helene Gsaenger
2015-01-14 12:29 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.