* [PATCH] arch: arm: common: edma.c: Remove some unused functions
@ 2014-12-06 22:53 ` Rickard Strandqvist
0 siblings, 0 replies; 8+ messages in thread
From: Rickard Strandqvist @ 2014-12-06 22:53 UTC (permalink / raw)
To: Russell King, Grant Likely
Cc: Rickard Strandqvist, Rob Herring, Peter Ujfalusi, Sekhar Nori,
Vinod Koul, Joel Fernandes, Thomas Gleixner, linux-arm-kernel,
linux-kernel, devicetree
Removes some functions that are not used anywhere:
edma_shadow0_read() edma_or_array()
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/arm/common/edma.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
index d86771a..163273d 100644
--- a/arch/arm/common/edma.c
+++ b/arch/arm/common/edma.c
@@ -160,10 +160,6 @@ static inline void edma_modify_array(unsigned ctlr, int offset, int i,
{
edma_modify(ctlr, offset + (i << 2), and, or);
}
-static inline void edma_or_array(unsigned ctlr, int offset, int i, unsigned or)
-{
- edma_or(ctlr, offset + (i << 2), or);
-}
static inline void edma_or_array2(unsigned ctlr, int offset, int i, int j,
unsigned or)
{
@@ -174,10 +170,6 @@ static inline void edma_write_array2(unsigned ctlr, int offset, int i, int j,
{
edma_write(ctlr, offset + ((i*2 + j) << 2), val);
}
-static inline unsigned int edma_shadow0_read(unsigned ctlr, int offset)
-{
- return edma_read(ctlr, EDMA_SHADOW0 + offset);
-}
static inline unsigned int edma_shadow0_read_array(unsigned ctlr, int offset,
int i)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] arch: arm: common: edma.c: Remove some unused functions
@ 2014-12-06 22:53 ` Rickard Strandqvist
0 siblings, 0 replies; 8+ messages in thread
From: Rickard Strandqvist @ 2014-12-06 22:53 UTC (permalink / raw)
To: linux-arm-kernel
Removes some functions that are not used anywhere:
edma_shadow0_read() edma_or_array()
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/arm/common/edma.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
index d86771a..163273d 100644
--- a/arch/arm/common/edma.c
+++ b/arch/arm/common/edma.c
@@ -160,10 +160,6 @@ static inline void edma_modify_array(unsigned ctlr, int offset, int i,
{
edma_modify(ctlr, offset + (i << 2), and, or);
}
-static inline void edma_or_array(unsigned ctlr, int offset, int i, unsigned or)
-{
- edma_or(ctlr, offset + (i << 2), or);
-}
static inline void edma_or_array2(unsigned ctlr, int offset, int i, int j,
unsigned or)
{
@@ -174,10 +170,6 @@ static inline void edma_write_array2(unsigned ctlr, int offset, int i, int j,
{
edma_write(ctlr, offset + ((i*2 + j) << 2), val);
}
-static inline unsigned int edma_shadow0_read(unsigned ctlr, int offset)
-{
- return edma_read(ctlr, EDMA_SHADOW0 + offset);
-}
static inline unsigned int edma_shadow0_read_array(unsigned ctlr, int offset,
int i)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] arch: arm: common: edma.c: Remove some unused functions
@ 2014-12-29 7:53 ` Peter Ujfalusi
0 siblings, 0 replies; 8+ messages in thread
From: Peter Ujfalusi @ 2014-12-29 7:53 UTC (permalink / raw)
To: Rickard Strandqvist, Russell King, Grant Likely
Cc: Rob Herring, Sekhar Nori, Vinod Koul, Thomas Gleixner,
linux-arm-kernel, linux-kernel, devicetree
On 12/07/2014 12:53 AM, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> edma_shadow0_read() edma_or_array()
>
> This was partially found by using a static code analysis program called cppcheck.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/arm/common/edma.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
> index d86771a..163273d 100644
> --- a/arch/arm/common/edma.c
> +++ b/arch/arm/common/edma.c
> @@ -160,10 +160,6 @@ static inline void edma_modify_array(unsigned ctlr, int offset, int i,
> {
> edma_modify(ctlr, offset + (i << 2), and, or);
> }
> -static inline void edma_or_array(unsigned ctlr, int offset, int i, unsigned or)
> -{
> - edma_or(ctlr, offset + (i << 2), or);
> -}
> static inline void edma_or_array2(unsigned ctlr, int offset, int i, int j,
> unsigned or)
> {
> @@ -174,10 +170,6 @@ static inline void edma_write_array2(unsigned ctlr, int offset, int i, int j,
> {
> edma_write(ctlr, offset + ((i*2 + j) << 2), val);
> }
> -static inline unsigned int edma_shadow0_read(unsigned ctlr, int offset)
> -{
> - return edma_read(ctlr, EDMA_SHADOW0 + offset);
> -}
> static inline unsigned int edma_shadow0_read_array(unsigned ctlr, int offset,
> int i)
> {
>
--
Péter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arch: arm: common: edma.c: Remove some unused functions
@ 2014-12-29 7:53 ` Peter Ujfalusi
0 siblings, 0 replies; 8+ messages in thread
From: Peter Ujfalusi @ 2014-12-29 7:53 UTC (permalink / raw)
To: Rickard Strandqvist, Russell King, Grant Likely
Cc: Rob Herring, Sekhar Nori, Vinod Koul, Thomas Gleixner,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
On 12/07/2014 12:53 AM, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> edma_shadow0_read() edma_or_array()
>
> This was partially found by using a static code analysis program called cppcheck.
Acked-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/arm/common/edma.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
> index d86771a..163273d 100644
> --- a/arch/arm/common/edma.c
> +++ b/arch/arm/common/edma.c
> @@ -160,10 +160,6 @@ static inline void edma_modify_array(unsigned ctlr, int offset, int i,
> {
> edma_modify(ctlr, offset + (i << 2), and, or);
> }
> -static inline void edma_or_array(unsigned ctlr, int offset, int i, unsigned or)
> -{
> - edma_or(ctlr, offset + (i << 2), or);
> -}
> static inline void edma_or_array2(unsigned ctlr, int offset, int i, int j,
> unsigned or)
> {
> @@ -174,10 +170,6 @@ static inline void edma_write_array2(unsigned ctlr, int offset, int i, int j,
> {
> edma_write(ctlr, offset + ((i*2 + j) << 2), val);
> }
> -static inline unsigned int edma_shadow0_read(unsigned ctlr, int offset)
> -{
> - return edma_read(ctlr, EDMA_SHADOW0 + offset);
> -}
> static inline unsigned int edma_shadow0_read_array(unsigned ctlr, int offset,
> int i)
> {
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arch: arm: common: edma.c: Remove some unused functions
@ 2014-12-29 7:53 ` Peter Ujfalusi
0 siblings, 0 replies; 8+ messages in thread
From: Peter Ujfalusi @ 2014-12-29 7:53 UTC (permalink / raw)
To: linux-arm-kernel
On 12/07/2014 12:53 AM, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> edma_shadow0_read() edma_or_array()
>
> This was partially found by using a static code analysis program called cppcheck.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/arm/common/edma.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
> index d86771a..163273d 100644
> --- a/arch/arm/common/edma.c
> +++ b/arch/arm/common/edma.c
> @@ -160,10 +160,6 @@ static inline void edma_modify_array(unsigned ctlr, int offset, int i,
> {
> edma_modify(ctlr, offset + (i << 2), and, or);
> }
> -static inline void edma_or_array(unsigned ctlr, int offset, int i, unsigned or)
> -{
> - edma_or(ctlr, offset + (i << 2), or);
> -}
> static inline void edma_or_array2(unsigned ctlr, int offset, int i, int j,
> unsigned or)
> {
> @@ -174,10 +170,6 @@ static inline void edma_write_array2(unsigned ctlr, int offset, int i, int j,
> {
> edma_write(ctlr, offset + ((i*2 + j) << 2), val);
> }
> -static inline unsigned int edma_shadow0_read(unsigned ctlr, int offset)
> -{
> - return edma_read(ctlr, EDMA_SHADOW0 + offset);
> -}
> static inline unsigned int edma_shadow0_read_array(unsigned ctlr, int offset,
> int i)
> {
>
--
P?ter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arch: arm: common: edma.c: Remove some unused functions
@ 2015-01-14 9:54 ` Sekhar Nori
0 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2015-01-14 9:54 UTC (permalink / raw)
To: Peter Ujfalusi, Rickard Strandqvist, Russell King, Grant Likely
Cc: Rob Herring, Vinod Koul, Thomas Gleixner, linux-arm-kernel,
linux-kernel, devicetree
On Monday 29 December 2014 01:23 PM, Peter Ujfalusi wrote:
> On 12/07/2014 12:53 AM, Rickard Strandqvist wrote:
>> Removes some functions that are not used anywhere:
>> edma_shadow0_read() edma_or_array()
>>
>> This was partially found by using a static code analysis program called cppcheck.
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Queuing for v3.20 through ARM-SoC.
The correct prefix for ARM patches is "ARM: ". I will fix while
applying. Please take care next time on.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arch: arm: common: edma.c: Remove some unused functions
@ 2015-01-14 9:54 ` Sekhar Nori
0 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2015-01-14 9:54 UTC (permalink / raw)
To: Peter Ujfalusi, Rickard Strandqvist, Russell King, Grant Likely
Cc: Rob Herring, Vinod Koul, Thomas Gleixner,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
On Monday 29 December 2014 01:23 PM, Peter Ujfalusi wrote:
> On 12/07/2014 12:53 AM, Rickard Strandqvist wrote:
>> Removes some functions that are not used anywhere:
>> edma_shadow0_read() edma_or_array()
>>
>> This was partially found by using a static code analysis program called cppcheck.
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
Queuing for v3.20 through ARM-SoC.
The correct prefix for ARM patches is "ARM: ". I will fix while
applying. Please take care next time on.
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arch: arm: common: edma.c: Remove some unused functions
@ 2015-01-14 9:54 ` Sekhar Nori
0 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2015-01-14 9:54 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 29 December 2014 01:23 PM, Peter Ujfalusi wrote:
> On 12/07/2014 12:53 AM, Rickard Strandqvist wrote:
>> Removes some functions that are not used anywhere:
>> edma_shadow0_read() edma_or_array()
>>
>> This was partially found by using a static code analysis program called cppcheck.
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Queuing for v3.20 through ARM-SoC.
The correct prefix for ARM patches is "ARM: ". I will fix while
applying. Please take care next time on.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-01-14 9:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-06 22:53 [PATCH] arch: arm: common: edma.c: Remove some unused functions Rickard Strandqvist
2014-12-06 22:53 ` Rickard Strandqvist
2014-12-29 7:53 ` Peter Ujfalusi
2014-12-29 7:53 ` Peter Ujfalusi
2014-12-29 7:53 ` Peter Ujfalusi
2015-01-14 9:54 ` Sekhar Nori
2015-01-14 9:54 ` Sekhar Nori
2015-01-14 9:54 ` Sekhar Nori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.