* [PATCH] reset: sunxi: fix spinlock initialization
@ 2015-01-08 0:54 Tyler Baker
2015-01-08 9:09 ` Philipp Zabel
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Tyler Baker @ 2015-01-08 0:54 UTC (permalink / raw)
To: linux-arm-kernel
Call spin_lock_init() before the spinlocks are used, preventing a lockdep
splat.
I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
and has been tested on a few other sunxi platforms without issue.
[1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
[2] http://kernelci.org/boot/?a80-optimus
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
This patch was tested on 3.19.0-rc3
drivers/reset/reset-sunxi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
index eebc52c..e37250c 100644
--- a/drivers/reset/reset-sunxi.c
+++ b/drivers/reset/reset-sunxi.c
@@ -157,6 +157,8 @@ static int sunxi_reset_probe(struct platform_device *pdev)
if (IS_ERR(data->membase))
return PTR_ERR(data->membase);
+ spin_lock_init(&data->lock);
+
data->rcdev.owner = THIS_MODULE;
data->rcdev.nr_resets = resource_size(res) * 32;
data->rcdev.ops = &sunxi_reset_ops;
--
2.1.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-08 0:54 [PATCH] reset: sunxi: fix spinlock initialization Tyler Baker
@ 2015-01-08 9:09 ` Philipp Zabel
2015-01-08 9:30 ` Maxime Ripard
2015-01-09 11:59 ` Maxime Coquelin
2 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-01-08 9:09 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tyler,
Am Mittwoch, den 07.01.2015, 16:54 -0800 schrieb Tyler Baker:
> Call spin_lock_init() before the spinlocks are used, preventing a lockdep
> splat.
>
> I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
> and has been tested on a few other sunxi platforms without issue.
>
> [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
> [2] http://kernelci.org/boot/?a80-optimus
>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> This patch was tested on 3.19.0-rc3
Applied, thanks!
regards
Philipp
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-08 0:54 [PATCH] reset: sunxi: fix spinlock initialization Tyler Baker
2015-01-08 9:09 ` Philipp Zabel
@ 2015-01-08 9:30 ` Maxime Ripard
2015-01-09 6:38 ` Tyler Baker
2015-01-09 11:59 ` Maxime Coquelin
2 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2015-01-08 9:30 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tyler,
On Wed, Jan 07, 2015 at 04:54:39PM -0800, Tyler Baker wrote:
> Call spin_lock_init() before the spinlocks are used, preventing a lockdep
> splat.
>
> I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
> and has been tested on a few other sunxi platforms without issue.
>
> [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
> [2] http://kernelci.org/boot/?a80-optimus
>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
Thanks for this patch.
Can you send this to stable too please?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150108/f5474105/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-08 9:30 ` Maxime Ripard
@ 2015-01-09 6:38 ` Tyler Baker
0 siblings, 0 replies; 10+ messages in thread
From: Tyler Baker @ 2015-01-09 6:38 UTC (permalink / raw)
To: linux-arm-kernel
Hi Maxime,
On 8 January 2015 at 01:30, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Tyler,
>
> On Wed, Jan 07, 2015 at 04:54:39PM -0800, Tyler Baker wrote:
>> Call spin_lock_init() before the spinlocks are used, preventing a lockdep
>> splat.
>>
>> I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
>> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
>> and has been tested on a few other sunxi platforms without issue.
>>
>> [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
>> [2] http://kernelci.org/boot/?a80-optimus
>>
>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>
> Thanks for this patch.
You're welcome.
>
> Can you send this to stable too please?
Sure. Once it has been merged in Linus' tree I'll send it for -stable review.
>
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
Cheers,
--
Tyler Baker
Tech Lead, LAVA
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-08 0:54 [PATCH] reset: sunxi: fix spinlock initialization Tyler Baker
2015-01-08 9:09 ` Philipp Zabel
2015-01-08 9:30 ` Maxime Ripard
@ 2015-01-09 11:59 ` Maxime Coquelin
2015-01-09 14:44 ` Maxime Coquelin
2 siblings, 1 reply; 10+ messages in thread
From: Maxime Coquelin @ 2015-01-09 11:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tyler, Maxime,
On 01/08/2015 01:54 AM, Tyler Baker wrote:
> Call spin_lock_init() before the spinlocks are used, preventing a lockdep
> splat.
>
> I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
> and has been tested on a few other sunxi platforms without issue.
>
> [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
> [2] http://kernelci.org/boot/?a80-optimus
>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> This patch was tested on 3.19.0-rc3
>
> drivers/reset/reset-sunxi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
> index eebc52c..e37250c 100644
> --- a/drivers/reset/reset-sunxi.c
> +++ b/drivers/reset/reset-sunxi.c
> @@ -157,6 +157,8 @@ static int sunxi_reset_probe(struct platform_device *pdev)
> if (IS_ERR(data->membase))
> return PTR_ERR(data->membase);
>
> + spin_lock_init(&data->lock);
> +
Shouldn't the lock be initialized also in early init function
(sunxi_reset_init) ?
Regards,
Maxime
> data->rcdev.owner = THIS_MODULE;
> data->rcdev.nr_resets = resource_size(res) * 32;
> data->rcdev.ops = &sunxi_reset_ops;
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-09 11:59 ` Maxime Coquelin
@ 2015-01-09 14:44 ` Maxime Coquelin
2015-01-09 20:44 ` Tyler Baker
0 siblings, 1 reply; 10+ messages in thread
From: Maxime Coquelin @ 2015-01-09 14:44 UTC (permalink / raw)
To: linux-arm-kernel
With Maxime in the To: list.
On 01/09/2015 12:59 PM, Maxime Coquelin wrote:
> Hi Tyler, Maxime,
>
> On 01/08/2015 01:54 AM, Tyler Baker wrote:
>> Call spin_lock_init() before the spinlocks are used, preventing a
>> lockdep
>> splat.
>>
>> I have been observing lockdep complaining [1] during boot on my a80
>> optimus [2]
>> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the
>> splat,
>> and has been tested on a few other sunxi platforms without issue.
>>
>> [1]
>> http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
>> [2] http://kernelci.org/boot/?a80-optimus
>>
>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>> ---
>> This patch was tested on 3.19.0-rc3
>>
>> drivers/reset/reset-sunxi.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
>> index eebc52c..e37250c 100644
>> --- a/drivers/reset/reset-sunxi.c
>> +++ b/drivers/reset/reset-sunxi.c
>> @@ -157,6 +157,8 @@ static int sunxi_reset_probe(struct
>> platform_device *pdev)
>> if (IS_ERR(data->membase))
>> return PTR_ERR(data->membase);
>> + spin_lock_init(&data->lock);
>> +
> Shouldn't the lock be initialized also in early init function
> (sunxi_reset_init) ?
>
> Regards,
> Maxime
>> data->rcdev.owner = THIS_MODULE;
>> data->rcdev.nr_resets = resource_size(res) * 32;
>> data->rcdev.ops = &sunxi_reset_ops;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-09 14:44 ` Maxime Coquelin
@ 2015-01-09 20:44 ` Tyler Baker
2015-01-10 0:22 ` Tyler Baker
0 siblings, 1 reply; 10+ messages in thread
From: Tyler Baker @ 2015-01-09 20:44 UTC (permalink / raw)
To: linux-arm-kernel
Hi Maxime,
On 9 January 2015 at 06:44, Maxime Coquelin <maxime.coquelin@st.com> wrote:
> With Maxime in the To: list.
>
>
>
> On 01/09/2015 12:59 PM, Maxime Coquelin wrote:
>>
>> Hi Tyler, Maxime,
>>
>> On 01/08/2015 01:54 AM, Tyler Baker wrote:
>>>
>>> Call spin_lock_init() before the spinlocks are used, preventing a lockdep
>>> splat.
>>>
>>> I have been observing lockdep complaining [1] during boot on my a80
>>> optimus [2]
>>> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the
>>> splat,
>>> and has been tested on a few other sunxi platforms without issue.
>>>
>>> [1]
>>> http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
>>> [2] http://kernelci.org/boot/?a80-optimus
>>>
>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>>> ---
>>> This patch was tested on 3.19.0-rc3
>>>
>>> drivers/reset/reset-sunxi.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
>>> index eebc52c..e37250c 100644
>>> --- a/drivers/reset/reset-sunxi.c
>>> +++ b/drivers/reset/reset-sunxi.c
>>> @@ -157,6 +157,8 @@ static int sunxi_reset_probe(struct platform_device
>>> *pdev)
>>> if (IS_ERR(data->membase))
>>> return PTR_ERR(data->membase);
>>> + spin_lock_init(&data->lock);
>>> +
>>
>> Shouldn't the lock be initialized also in early init function
>> (sunxi_reset_init) ?
Thanks for pointing this out. It seems reasonable to me to add this
for the sun6i platforms that use the early init function. Currently
trying to track down a sun6i platform so I can run a few locking
validation tests.
>>
>> Regards,
>> Maxime
>>>
>>> data->rcdev.owner = THIS_MODULE;
>>> data->rcdev.nr_resets = resource_size(res) * 32;
>>> data->rcdev.ops = &sunxi_reset_ops;
>>
>>
>
--
Tyler Baker
Tech Lead, LAVA
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-09 20:44 ` Tyler Baker
@ 2015-01-10 0:22 ` Tyler Baker
2015-01-12 8:37 ` Philipp Zabel
2015-01-13 8:59 ` Maxime Coquelin
0 siblings, 2 replies; 10+ messages in thread
From: Tyler Baker @ 2015-01-10 0:22 UTC (permalink / raw)
To: linux-arm-kernel
On 9 January 2015 at 12:44, Tyler Baker <tyler.baker@linaro.org> wrote:
> Hi Maxime,
>
> On 9 January 2015 at 06:44, Maxime Coquelin <maxime.coquelin@st.com> wrote:
>> With Maxime in the To: list.
>>
>>
>>
>> On 01/09/2015 12:59 PM, Maxime Coquelin wrote:
>>>
>>> Hi Tyler, Maxime,
>>>
>>> On 01/08/2015 01:54 AM, Tyler Baker wrote:
>>>>
>>>> Call spin_lock_init() before the spinlocks are used, preventing a lockdep
>>>> splat.
>>>>
>>>> I have been observing lockdep complaining [1] during boot on my a80
>>>> optimus [2]
>>>> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the
>>>> splat,
>>>> and has been tested on a few other sunxi platforms without issue.
>>>>
>>>> [1]
>>>> http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
>>>> [2] http://kernelci.org/boot/?a80-optimus
>>>>
>>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>>>> ---
>>>> This patch was tested on 3.19.0-rc3
>>>>
>>>> drivers/reset/reset-sunxi.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
>>>> index eebc52c..e37250c 100644
>>>> --- a/drivers/reset/reset-sunxi.c
>>>> +++ b/drivers/reset/reset-sunxi.c
>>>> @@ -157,6 +157,8 @@ static int sunxi_reset_probe(struct platform_device
>>>> *pdev)
>>>> if (IS_ERR(data->membase))
>>>> return PTR_ERR(data->membase);
>>>> + spin_lock_init(&data->lock);
>>>> +
>>>
>>> Shouldn't the lock be initialized also in early init function
>>> (sunxi_reset_init) ?
>
> Thanks for pointing this out. It seems reasonable to me to add this
> for the sun6i platforms that use the early init function. Currently
> trying to track down a sun6i platform so I can run a few locking
> validation tests.
Olof was kind enough to volunteer his sun6i platform (colombus) and
provide the results. The results confirms there is a need to also
initialize the lock in sunxi_reset_init as Maxime C. mentioned.
DEBUG: sunxi_reset_init()
DEBUG: sunxi_reset_deassert()
INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.19.0-rc3-00039-gccd0de2-dirty #5
Hardware name: Allwinner sun6i (A31) Family
[<c021679c>] (unwind_backtrace) from [<c0212140>] (show_stack+0x10/0x14)
[<c0212140>] (show_stack) from [<c09557c4>] (dump_stack+0x8c/0x9c)
[<c09557c4>] (dump_stack) from [<c028293c>] (__lock_acquire+0x1ef4/0x1f00)
[<c028293c>] (__lock_acquire) from [<c028311c>] (lock_acquire+0x6c/0x8c)
[<c028311c>] (lock_acquire) from [<c095b810>] (_raw_spin_lock_irqsave+0x3c/0x50)
[<c095b810>] (_raw_spin_lock_irqsave) from [<c0542d80>]
(sunxi_reset_deassert+0x2c/0x88)
[<c0542d80>] (sunxi_reset_deassert) from [<c0d39a00>]
(sun5i_timer_init+0xc0/0x1f0)
[<c0d39a00>] (sun5i_timer_init) from [<c0d3897c>]
(clocksource_of_init+0x4c/0x8c)
[<c0d3897c>] (clocksource_of_init) from [<c0cf0b34>] (start_kernel+0x278/0x3c8)
[<c0cf0b34>] (start_kernel) from [<40208074>] (0x40208074)
I'll go ahead and resend an updated patch and cc stable if Philipp and
Maxime R. they agree.
>
>>>
>>> Regards,
>>> Maxime
>>>>
>>>> data->rcdev.owner = THIS_MODULE;
>>>> data->rcdev.nr_resets = resource_size(res) * 32;
>>>> data->rcdev.ops = &sunxi_reset_ops;
>>>
>>>
>>
>
>
>
> --
> Tyler Baker
> Tech Lead, LAVA
> Linaro.org | Open source software for ARM SoCs
> Follow Linaro: http://www.facebook.com/pages/Linaro
> http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
Cheers,
--
Tyler Baker
Tech Lead, LAVA
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-10 0:22 ` Tyler Baker
@ 2015-01-12 8:37 ` Philipp Zabel
2015-01-13 8:59 ` Maxime Coquelin
1 sibling, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-01-12 8:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tyler,
Am Freitag, den 09.01.2015, 16:22 -0800 schrieb Tyler Baker:
> I'll go ahead and resend an updated patch and cc stable if Philipp and
> Maxime R. they agree.
Please do.
thanks
Philipp
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] reset: sunxi: fix spinlock initialization
2015-01-10 0:22 ` Tyler Baker
2015-01-12 8:37 ` Philipp Zabel
@ 2015-01-13 8:59 ` Maxime Coquelin
1 sibling, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2015-01-13 8:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tyler,
On 01/10/2015 01:22 AM, Tyler Baker wrote:
> On 9 January 2015 at 12:44, Tyler Baker <tyler.baker@linaro.org> wrote:
>> Hi Maxime,
>>
>> On 9 January 2015 at 06:44, Maxime Coquelin <maxime.coquelin@st.com> wrote:
>>> With Maxime in the To: list.
>>>
>>>
>>>
>>> On 01/09/2015 12:59 PM, Maxime Coquelin wrote:
>>>> Hi Tyler, Maxime,
>>>>
>>>> On 01/08/2015 01:54 AM, Tyler Baker wrote:
>>>>> Call spin_lock_init() before the spinlocks are used, preventing a lockdep
>>>>> splat.
>>>>>
>>>>> I have been observing lockdep complaining [1] during boot on my a80
>>>>> optimus [2]
>>>>> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the
>>>>> splat,
>>>>> and has been tested on a few other sunxi platforms without issue.
>>>>>
>>>>> [1]
>>>>> http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
>>>>> [2] http://kernelci.org/boot/?a80-optimus
>>>>>
>>>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>>>>> ---
>>>>> This patch was tested on 3.19.0-rc3
>>>>>
>>>>> drivers/reset/reset-sunxi.c | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
>>>>> index eebc52c..e37250c 100644
>>>>> --- a/drivers/reset/reset-sunxi.c
>>>>> +++ b/drivers/reset/reset-sunxi.c
>>>>> @@ -157,6 +157,8 @@ static int sunxi_reset_probe(struct platform_device
>>>>> *pdev)
>>>>> if (IS_ERR(data->membase))
>>>>> return PTR_ERR(data->membase);
>>>>> + spin_lock_init(&data->lock);
>>>>> +
>>>> Shouldn't the lock be initialized also in early init function
>>>> (sunxi_reset_init) ?
>> Thanks for pointing this out. It seems reasonable to me to add this
>> for the sun6i platforms that use the early init function. Currently
>> trying to track down a sun6i platform so I can run a few locking
>> validation tests.
> Olof was kind enough to volunteer his sun6i platform (colombus) and
> provide the results. The results confirms there is a need to also
> initialize the lock in sunxi_reset_init as Maxime C. mentioned.
>
> DEBUG: sunxi_reset_init()
> DEBUG: sunxi_reset_deassert()
> INFO: trying to register non-static key.
> the code is fine but needs lockdep annotation.
> turning off the locking correctness validator.
> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.19.0-rc3-00039-gccd0de2-dirty #5
> Hardware name: Allwinner sun6i (A31) Family
> [<c021679c>] (unwind_backtrace) from [<c0212140>] (show_stack+0x10/0x14)
> [<c0212140>] (show_stack) from [<c09557c4>] (dump_stack+0x8c/0x9c)
> [<c09557c4>] (dump_stack) from [<c028293c>] (__lock_acquire+0x1ef4/0x1f00)
> [<c028293c>] (__lock_acquire) from [<c028311c>] (lock_acquire+0x6c/0x8c)
> [<c028311c>] (lock_acquire) from [<c095b810>] (_raw_spin_lock_irqsave+0x3c/0x50)
> [<c095b810>] (_raw_spin_lock_irqsave) from [<c0542d80>]
> (sunxi_reset_deassert+0x2c/0x88)
> [<c0542d80>] (sunxi_reset_deassert) from [<c0d39a00>]
> (sun5i_timer_init+0xc0/0x1f0)
> [<c0d39a00>] (sun5i_timer_init) from [<c0d3897c>]
> (clocksource_of_init+0x4c/0x8c)
> [<c0d3897c>] (clocksource_of_init) from [<c0cf0b34>] (start_kernel+0x278/0x3c8)
> [<c0cf0b34>] (start_kernel) from [<40208074>] (0x40208074)
>
> I'll go ahead and resend an updated patch and cc stable if Philipp and
> Maxime R. they agree.
Thanks for having done the test.
I have no Allwinner HW to try.
Best regards,
Maxime
>
>>>> Regards,
>>>> Maxime
>>>>> data->rcdev.owner = THIS_MODULE;
>>>>> data->rcdev.nr_resets = resource_size(res) * 32;
>>>>> data->rcdev.ops = &sunxi_reset_ops;
>>>>
>>
>>
>> --
>> Tyler Baker
>> Tech Lead, LAVA
>> Linaro.org | Open source software for ARM SoCs
>> Follow Linaro: http://www.facebook.com/pages/Linaro
>> http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
> Cheers,
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-01-13 8:59 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-08 0:54 [PATCH] reset: sunxi: fix spinlock initialization Tyler Baker
2015-01-08 9:09 ` Philipp Zabel
2015-01-08 9:30 ` Maxime Ripard
2015-01-09 6:38 ` Tyler Baker
2015-01-09 11:59 ` Maxime Coquelin
2015-01-09 14:44 ` Maxime Coquelin
2015-01-09 20:44 ` Tyler Baker
2015-01-10 0:22 ` Tyler Baker
2015-01-12 8:37 ` Philipp Zabel
2015-01-13 8:59 ` Maxime Coquelin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.