[U-Boot] [PATCH 08/18] exynos5: config: prepare for dm i2c support

[Przemyslaw Marczak <p.marczak@samsung.com>]

Hello Heiko Schocher,

Sorry, I missed this message this morning.

On 01/09/2015 07:37 AM, Heiko Schocher wrote:
> Hello Przemyslaw Marczak,
>
> Am 08.01.2015 12:33, schrieb Przemyslaw Marczak:
>> This commit allows for test i2c drivers with new i2c api
>> on Exynos5xxx based boards.
>>
>> The S3C24X0 I2C driver supports driver model I2C api,
>> but i2c peripherials drivers on exynos5 boards doesn't.
>> So this commit allows for test ported driver before switch
>> the Exynos5 boards to DM I2C at all.
>
> Hmm... so this is just a patch for test purposes not for mainline?
>

This patch is for the mainline, but I left the "if 0" just for the 
developers, who want to port the required i2c drivers. I will remove the 
"if 0".
There are some i2c drivers for Exynos based boards, which should be 
ported to the new i2c api.

At present I'm not able to do this at once and as I know someone needs 
the i2c driver for the present work. I required the i2c bus driver for 
the pmic framework, on which now I'm working.

>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> Cc: Akshay Saraswat <akshay.s@samsung.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>> ---
>>   include/configs/exynos5-common.h | 29 ++++++++++++++++++-----------
>>   1 file changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/include/configs/exynos5-common.h
>> b/include/configs/exynos5-common.h
>> index ad63f3c..b7af8a5 100644
>> --- a/include/configs/exynos5-common.h
>> +++ b/include/configs/exynos5-common.h
>> @@ -54,13 +54,6 @@
>>   #define CONFIG_CMD_DTT
>>   #define CONFIG_TMU_CMD_DTT
>>
>> -/* TPM */
>> -#define CONFIG_TPM
>> -#define CONFIG_CMD_TPM
>> -#define CONFIG_TPM_TIS_I2C
>> -#define CONFIG_TPM_TIS_I2C_BUS_NUMBER    3
>> -#define CONFIG_TPM_TIS_I2C_SLAVE_ADDR    0x20
>> -
>>   /* MMC SPL */
>>   #define COPY_BL2_FNPTR_ADDR    0x02020030
>>   #define CONFIG_SUPPORT_EMMC_BOOT
>> @@ -126,15 +119,29 @@
>>   #define SPI_FLASH_UBOOT_POS    (CONFIG_SEC_FW_SIZE + CONFIG_BL1_SIZE)
>>
>>   /* I2C */
>> -#define CONFIG_SYS_I2C_INIT_BOARD
>> -#define CONFIG_SYS_I2C
>> +#if 0 /* For test */
>> +#define CONFIG_DM_I2C
>> +#endif
>
> Hmm.. no, please no dead code in mainline ... maybe you
> enable "CONFIG_DM_I2C" if "CONFIG_DM" is set?
>
> bye,
> Heiko
>

Yes, will be removed. I can't use the CONFIG_DM because of the rest of 
the i2c drivers, which are waiting for the adjust to new i2c api.

>>   #define CONFIG_CMD_I2C
>> -#define CONFIG_SYS_I2C_S3C24X0_SPEED    100000        /* 100 Kbps */
>>   #define CONFIG_SYS_I2C_S3C24X0
>> -#define CONFIG_I2C_MULTI_BUS
>> +#define CONFIG_SYS_I2C_S3C24X0_SPEED    100000        /* 100 Kbps */
>>   #define CONFIG_SYS_I2C_S3C24X0_SLAVE    0x0
>> +#ifndef CONFIG_DM_I2C
>> +#define CONFIG_SYS_I2C_INIT_BOARD
>> +#define CONFIG_SYS_I2C
>> +#define CONFIG_I2C_MULTI_BUS
>> +#endif /* ifndef CONFIG_DM_I2C */
>>   #define CONFIG_I2C_EDID
>>
>> +/* TPM */
>> +#ifndef CONFIG_DM_I2C
>> +#define CONFIG_TPM
>> +#define CONFIG_CMD_TPM
>> +#define CONFIG_TPM_TIS_I2C
>> +#define CONFIG_TPM_TIS_I2C_BUS_NUMBER    3
>> +#define CONFIG_TPM_TIS_I2C_SLAVE_ADDR    0x20
>> +#endif
>> +
>>   /* SPI */
>>   #ifdef CONFIG_SPI_FLASH
>>   #define CONFIG_EXYNOS_SPI
>>
>

Also I'm not going to move the current pmic framework/drivers to the new 
i2c api, since I hope to send the new framework soon.

Thank you and best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com