All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wang, Winston L" <winston.l.wang@intel.com>
To: Keir Fraser <keir.xen@gmail.com>, Jan Beulich <JBeulich@novell.com>
Cc: "Liu, Jinsong" <jinsong.liu@intel.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	KeirFraser <keir@xen.org>,
	"Jiang, Yunhong" <yunhong.jiang@intel.com>,
	"Dugger, Donald D" <donald.d.dugger@intel.com>,
	"Li, Xin" <xin.li@intel.com>
Subject: RE: [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits
Date: Thu, 14 Apr 2011 14:37:19 -0700	[thread overview]
Message-ID: <54B2EB610B7F1340BB6A0D4CA04A4F100100CBC85F@orsmsx505.amr.corp.intel.com> (raw)
In-Reply-To: <C9CD2055.165FF%keir.xen@gmail.com>

> -----Original Message-----
> From: Keir Fraser [mailto:keir.xen@gmail.com]
> Sent: Thursday, April 14, 2011 2:06 PM
> On 14/04/2011 19:33, "Wang, Winston L" <winston.l.wang@intel.com> wrote:
> 
> > Jan and Keir,
> >
> > Great efforts for turning the test code re-validate the processor
> with
> > (X86_FEATURE_TSC_RELIABLE) set. We know for sure that the broken old
> > processors any write TSC will Zero the upper 32 bit. So can we move
> this test
> > code as early as possible, say immediately after the early Processor
> init code
> > where checking CPU id and set X86_FEATURE_TSC_RELIABLE?
> 
> For our meaning of TSC_RELIABLE, there's no need for its setting to
> rely on
> TSC 64-bit writability. I think leaving it where it is in
> init_xen_time() is probably fine.

It's fine with me.

Winston,

  reply	other threads:[~2011-04-14 21:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-14  7:18 [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits Jan Beulich
2011-04-14  7:25 ` Keir Fraser
2011-04-14  7:42   ` Jan Beulich
2011-04-14  7:50     ` Keir Fraser
2011-04-14  8:06       ` Jan Beulich
2011-04-14  9:18         ` Keir Fraser
2011-04-14 22:41           ` Dan Magenheimer
2011-04-15  6:40             ` Keir Fraser
2011-04-15 14:34               ` Dan Magenheimer
2011-04-15 17:28                 ` Keir Fraser
2011-04-14  7:28 ` Jan Beulich
2011-04-14 16:05 ` Keir Fraser
2011-04-14 16:28   ` Jan Beulich
2011-04-14 16:48     ` Keir Fraser
2011-04-14 18:33       ` Wang, Winston L
2011-04-14 21:06         ` Keir Fraser
2011-04-14 21:37           ` Wang, Winston L [this message]
2011-04-15  7:06           ` Jan Beulich
2011-04-15  7:08       ` Jan Beulich
2011-04-15  7:37         ` Keir Fraser
2011-04-15 14:49           ` Wang, Winston L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B2EB610B7F1340BB6A0D4CA04A4F100100CBC85F@orsmsx505.amr.corp.intel.com \
    --to=winston.l.wang@intel.com \
    --cc=JBeulich@novell.com \
    --cc=donald.d.dugger@intel.com \
    --cc=jinsong.liu@intel.com \
    --cc=keir.xen@gmail.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xensource.com \
    --cc=xin.li@intel.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.