* [PATCH] x86: xen: mmu: Remove unused function
@ 2015-01-11 22:35 Rickard Strandqvist
2015-01-12 8:23 ` [Xen-devel] " Jürgen Groß
2015-01-12 8:23 ` Jürgen Groß
0 siblings, 2 replies; 6+ messages in thread
From: Rickard Strandqvist @ 2015-01-11 22:35 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Boris Ostrovsky
Cc: Rickard Strandqvist, David Vrabel, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, xen-devel, linux-kernel
Remove the function set_pte_mfn() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/x86/xen/mmu.c | 9 ---------
arch/x86/xen/mmu.h | 2 --
2 files changed, 11 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index a8a1a3d..6959550 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -281,15 +281,6 @@ static void xen_set_pmd(pmd_t *ptr, pmd_t val)
xen_set_pmd_hyper(ptr, val);
}
-/*
- * Associate a virtual page frame with a given physical page frame
- * and protection flags for that frame.
- */
-void set_pte_mfn(unsigned long vaddr, unsigned long mfn, pgprot_t flags)
-{
- set_pte_vaddr(vaddr, mfn_pte(mfn, flags));
-}
-
static bool xen_batched_set_pte(pte_t *ptep, pte_t pteval)
{
struct mmu_update u;
diff --git a/arch/x86/xen/mmu.h b/arch/x86/xen/mmu.h
index 73809bb..f2dcf79 100644
--- a/arch/x86/xen/mmu.h
+++ b/arch/x86/xen/mmu.h
@@ -13,8 +13,6 @@ enum pt_level {
bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn);
-void set_pte_mfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags);
-
pte_t xen_ptep_modify_prot_start(struct mm_struct *mm, unsigned long addr, pte_t *ptep);
void xen_ptep_modify_prot_commit(struct mm_struct *mm, unsigned long addr,
pte_t *ptep, pte_t pte);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] x86: xen: mmu: Remove unused function
2015-01-11 22:35 [PATCH] x86: xen: mmu: Remove unused function Rickard Strandqvist
@ 2015-01-12 8:23 ` Jürgen Groß
2015-01-13 22:55 ` Rickard Strandqvist
2015-01-13 22:55 ` Rickard Strandqvist
2015-01-12 8:23 ` Jürgen Groß
1 sibling, 2 replies; 6+ messages in thread
From: Jürgen Groß @ 2015-01-12 8:23 UTC (permalink / raw)
To: Rickard Strandqvist, Konrad Rzeszutek Wilk, Boris Ostrovsky
Cc: x86, linux-kernel, Ingo Molnar, David Vrabel, H. Peter Anvin,
xen-devel, Thomas Gleixner
On 01/11/2015 11:35 PM, Rickard Strandqvist wrote:
> Remove the function set_pte_mfn() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
Sorry, you seem not to have checked the newest kernel.
Used by:
xen_do_set_identity_and_remap_chunk()
xen_remap_memory()
So: Nak.
Juergen
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/x86/xen/mmu.c | 9 ---------
> arch/x86/xen/mmu.h | 2 --
> 2 files changed, 11 deletions(-)
>
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index a8a1a3d..6959550 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -281,15 +281,6 @@ static void xen_set_pmd(pmd_t *ptr, pmd_t val)
> xen_set_pmd_hyper(ptr, val);
> }
>
> -/*
> - * Associate a virtual page frame with a given physical page frame
> - * and protection flags for that frame.
> - */
> -void set_pte_mfn(unsigned long vaddr, unsigned long mfn, pgprot_t flags)
> -{
> - set_pte_vaddr(vaddr, mfn_pte(mfn, flags));
> -}
> -
> static bool xen_batched_set_pte(pte_t *ptep, pte_t pteval)
> {
> struct mmu_update u;
> diff --git a/arch/x86/xen/mmu.h b/arch/x86/xen/mmu.h
> index 73809bb..f2dcf79 100644
> --- a/arch/x86/xen/mmu.h
> +++ b/arch/x86/xen/mmu.h
> @@ -13,8 +13,6 @@ enum pt_level {
>
> bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn);
>
> -void set_pte_mfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags);
> -
> pte_t xen_ptep_modify_prot_start(struct mm_struct *mm, unsigned long addr, pte_t *ptep);
> void xen_ptep_modify_prot_commit(struct mm_struct *mm, unsigned long addr,
> pte_t *ptep, pte_t pte);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: xen: mmu: Remove unused function
2015-01-11 22:35 [PATCH] x86: xen: mmu: Remove unused function Rickard Strandqvist
2015-01-12 8:23 ` [Xen-devel] " Jürgen Groß
@ 2015-01-12 8:23 ` Jürgen Groß
1 sibling, 0 replies; 6+ messages in thread
From: Jürgen Groß @ 2015-01-12 8:23 UTC (permalink / raw)
To: Rickard Strandqvist, Konrad Rzeszutek Wilk, Boris Ostrovsky
Cc: x86, linux-kernel, Ingo Molnar, David Vrabel, H. Peter Anvin,
xen-devel, Thomas Gleixner
On 01/11/2015 11:35 PM, Rickard Strandqvist wrote:
> Remove the function set_pte_mfn() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
Sorry, you seem not to have checked the newest kernel.
Used by:
xen_do_set_identity_and_remap_chunk()
xen_remap_memory()
So: Nak.
Juergen
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/x86/xen/mmu.c | 9 ---------
> arch/x86/xen/mmu.h | 2 --
> 2 files changed, 11 deletions(-)
>
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index a8a1a3d..6959550 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -281,15 +281,6 @@ static void xen_set_pmd(pmd_t *ptr, pmd_t val)
> xen_set_pmd_hyper(ptr, val);
> }
>
> -/*
> - * Associate a virtual page frame with a given physical page frame
> - * and protection flags for that frame.
> - */
> -void set_pte_mfn(unsigned long vaddr, unsigned long mfn, pgprot_t flags)
> -{
> - set_pte_vaddr(vaddr, mfn_pte(mfn, flags));
> -}
> -
> static bool xen_batched_set_pte(pte_t *ptep, pte_t pteval)
> {
> struct mmu_update u;
> diff --git a/arch/x86/xen/mmu.h b/arch/x86/xen/mmu.h
> index 73809bb..f2dcf79 100644
> --- a/arch/x86/xen/mmu.h
> +++ b/arch/x86/xen/mmu.h
> @@ -13,8 +13,6 @@ enum pt_level {
>
> bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn);
>
> -void set_pte_mfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags);
> -
> pte_t xen_ptep_modify_prot_start(struct mm_struct *mm, unsigned long addr, pte_t *ptep);
> void xen_ptep_modify_prot_commit(struct mm_struct *mm, unsigned long addr,
> pte_t *ptep, pte_t pte);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] x86: xen: mmu: Remove unused function
2015-01-12 8:23 ` [Xen-devel] " Jürgen Groß
@ 2015-01-13 22:55 ` Rickard Strandqvist
2015-01-13 22:55 ` Rickard Strandqvist
1 sibling, 0 replies; 6+ messages in thread
From: Rickard Strandqvist @ 2015-01-13 22:55 UTC (permalink / raw)
To: Jürgen Groß
Cc: Konrad Rzeszutek Wilk, Boris Ostrovsky, x86,
Linux Kernel Mailing List, Ingo Molnar, David Vrabel,
H. Peter Anvin, xen-devel, Thomas Gleixner
2015-01-12 9:23 GMT+01:00 Jürgen Groß <jgross@suse.com>:
> On 01/11/2015 11:35 PM, Rickard Strandqvist wrote:
>>
>> Remove the function set_pte_mfn() that is not used anywhere.
>>
>> This was partially found by using a static code analysis program called
>> cppcheck.
>
>
> Sorry, you seem not to have checked the newest kernel.
>
> Used by:
>
> xen_do_set_identity_and_remap_chunk()
> xen_remap_memory()
>
> So: Nak.
>
>
> Juergen
>
>
>>
>> Signed-off-by: Rickard Strandqvist
>> <rickard_strandqvist@spectrumdigital.se>
>> ---
>> arch/x86/xen/mmu.c | 9 ---------
>> arch/x86/xen/mmu.h | 2 --
>> 2 files changed, 11 deletions(-)
>>
>> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
>> index a8a1a3d..6959550 100644
>> --- a/arch/x86/xen/mmu.c
>> +++ b/arch/x86/xen/mmu.c
>> @@ -281,15 +281,6 @@ static void xen_set_pmd(pmd_t *ptr, pmd_t val)
>> xen_set_pmd_hyper(ptr, val);
>> }
>>
>> -/*
>> - * Associate a virtual page frame with a given physical page frame
>> - * and protection flags for that frame.
>> - */
>> -void set_pte_mfn(unsigned long vaddr, unsigned long mfn, pgprot_t flags)
>> -{
>> - set_pte_vaddr(vaddr, mfn_pte(mfn, flags));
>> -}
>> -
>> static bool xen_batched_set_pte(pte_t *ptep, pte_t pteval)
>> {
>> struct mmu_update u;
>> diff --git a/arch/x86/xen/mmu.h b/arch/x86/xen/mmu.h
>> index 73809bb..f2dcf79 100644
>> --- a/arch/x86/xen/mmu.h
>> +++ b/arch/x86/xen/mmu.h
>> @@ -13,8 +13,6 @@ enum pt_level {
>>
>> bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn);
>>
>> -void set_pte_mfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags);
>> -
>> pte_t xen_ptep_modify_prot_start(struct mm_struct *mm, unsigned long
>> addr, pte_t *ptep);
>> void xen_ptep_modify_prot_commit(struct mm_struct *mm, unsigned long
>> addr,
>> pte_t *ptep, pte_t pte);
>>
Hi
Sorry. I start this too long ago, too much has happened in some parts
of the code :(
Kind regards
Rickard Strandqvist
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: xen: mmu: Remove unused function
2015-01-12 8:23 ` [Xen-devel] " Jürgen Groß
2015-01-13 22:55 ` Rickard Strandqvist
@ 2015-01-13 22:55 ` Rickard Strandqvist
1 sibling, 0 replies; 6+ messages in thread
From: Rickard Strandqvist @ 2015-01-13 22:55 UTC (permalink / raw)
To: Jürgen Groß
Cc: x86, Linux Kernel Mailing List, Ingo Molnar, David Vrabel,
H. Peter Anvin, xen-devel, Boris Ostrovsky, Thomas Gleixner
2015-01-12 9:23 GMT+01:00 Jürgen Groß <jgross@suse.com>:
> On 01/11/2015 11:35 PM, Rickard Strandqvist wrote:
>>
>> Remove the function set_pte_mfn() that is not used anywhere.
>>
>> This was partially found by using a static code analysis program called
>> cppcheck.
>
>
> Sorry, you seem not to have checked the newest kernel.
>
> Used by:
>
> xen_do_set_identity_and_remap_chunk()
> xen_remap_memory()
>
> So: Nak.
>
>
> Juergen
>
>
>>
>> Signed-off-by: Rickard Strandqvist
>> <rickard_strandqvist@spectrumdigital.se>
>> ---
>> arch/x86/xen/mmu.c | 9 ---------
>> arch/x86/xen/mmu.h | 2 --
>> 2 files changed, 11 deletions(-)
>>
>> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
>> index a8a1a3d..6959550 100644
>> --- a/arch/x86/xen/mmu.c
>> +++ b/arch/x86/xen/mmu.c
>> @@ -281,15 +281,6 @@ static void xen_set_pmd(pmd_t *ptr, pmd_t val)
>> xen_set_pmd_hyper(ptr, val);
>> }
>>
>> -/*
>> - * Associate a virtual page frame with a given physical page frame
>> - * and protection flags for that frame.
>> - */
>> -void set_pte_mfn(unsigned long vaddr, unsigned long mfn, pgprot_t flags)
>> -{
>> - set_pte_vaddr(vaddr, mfn_pte(mfn, flags));
>> -}
>> -
>> static bool xen_batched_set_pte(pte_t *ptep, pte_t pteval)
>> {
>> struct mmu_update u;
>> diff --git a/arch/x86/xen/mmu.h b/arch/x86/xen/mmu.h
>> index 73809bb..f2dcf79 100644
>> --- a/arch/x86/xen/mmu.h
>> +++ b/arch/x86/xen/mmu.h
>> @@ -13,8 +13,6 @@ enum pt_level {
>>
>> bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn);
>>
>> -void set_pte_mfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags);
>> -
>> pte_t xen_ptep_modify_prot_start(struct mm_struct *mm, unsigned long
>> addr, pte_t *ptep);
>> void xen_ptep_modify_prot_commit(struct mm_struct *mm, unsigned long
>> addr,
>> pte_t *ptep, pte_t pte);
>>
Hi
Sorry. I start this too long ago, too much has happened in some parts
of the code :(
Kind regards
Rickard Strandqvist
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] x86: xen: mmu: Remove unused function
@ 2015-01-11 22:35 Rickard Strandqvist
0 siblings, 0 replies; 6+ messages in thread
From: Rickard Strandqvist @ 2015-01-11 22:35 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Boris Ostrovsky
Cc: Rickard Strandqvist, x86, linux-kernel, Ingo Molnar,
David Vrabel, H. Peter Anvin, xen-devel, Thomas Gleixner
Remove the function set_pte_mfn() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/x86/xen/mmu.c | 9 ---------
arch/x86/xen/mmu.h | 2 --
2 files changed, 11 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index a8a1a3d..6959550 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -281,15 +281,6 @@ static void xen_set_pmd(pmd_t *ptr, pmd_t val)
xen_set_pmd_hyper(ptr, val);
}
-/*
- * Associate a virtual page frame with a given physical page frame
- * and protection flags for that frame.
- */
-void set_pte_mfn(unsigned long vaddr, unsigned long mfn, pgprot_t flags)
-{
- set_pte_vaddr(vaddr, mfn_pte(mfn, flags));
-}
-
static bool xen_batched_set_pte(pte_t *ptep, pte_t pteval)
{
struct mmu_update u;
diff --git a/arch/x86/xen/mmu.h b/arch/x86/xen/mmu.h
index 73809bb..f2dcf79 100644
--- a/arch/x86/xen/mmu.h
+++ b/arch/x86/xen/mmu.h
@@ -13,8 +13,6 @@ enum pt_level {
bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn);
-void set_pte_mfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags);
-
pte_t xen_ptep_modify_prot_start(struct mm_struct *mm, unsigned long addr, pte_t *ptep);
void xen_ptep_modify_prot_commit(struct mm_struct *mm, unsigned long addr,
pte_t *ptep, pte_t pte);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-13 22:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-11 22:35 [PATCH] x86: xen: mmu: Remove unused function Rickard Strandqvist
2015-01-12 8:23 ` [Xen-devel] " Jürgen Groß
2015-01-13 22:55 ` Rickard Strandqvist
2015-01-13 22:55 ` Rickard Strandqvist
2015-01-12 8:23 ` Jürgen Groß
-- strict thread matches above, loose matches on Subject: below --
2015-01-11 22:35 Rickard Strandqvist
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.