From: Stephen Boyd <sboyd@codeaurora.org> To: Tomeu Vizoso <tomeu.vizoso@collabora.com> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Mike Turquette <mturquette@linaro.org>, Javier Martinez Canillas <javier.martinez@collabora.co.uk>, Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>, Russell King <linux@arm.linux.org.uk>, linux-omap@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH RESEND v8 1/2] clk: Make clk API return per-user struct clk instances Date: Mon, 19 Jan 2015 10:40:04 -0800 [thread overview] Message-ID: <54BD4F84.1010501@codeaurora.org> (raw) In-Reply-To: <CAAObsKAc6kqgBdWpAvAc2fDW42jNtT1hCD_uL8ums0hHCTXgng@mail.gmail.com> On 01/19/2015 01:55 AM, Tomeu Vizoso wrote: > On 17 January 2015 at 02:02, Stephen Boyd <sboyd@codeaurora.org> wrote: >> On 01/12, Tomeu Vizoso wrote: >> >>> +} >>> EXPORT_SYMBOL_GPL(__clk_get_rate); >>> >>> @@ -630,7 +656,12 @@ out: >>> return !!ret; >>> } >>> >>> -bool __clk_is_enabled(struct clk *clk) >>> +bool __clk_is_prepared(struct clk *clk) >>> +{ >>> + return clk_core_is_prepared(clk->core); >> Oops. clk can be NULL here. Return false if so. Or drop the >> function entirely? It looks like it may become unused. > Are you thinking of anything specific that the alchemy arch can do > instead of calling __clk_is_prepared? > > Ah I missed that one. Bad grep. >>> +} >>> EXPORT_SYMBOL_GPL(__clk_is_enabled); >>> >>> @@ -762,7 +805,12 @@ void __clk_unprepare(struct clk *clk) >>> if (clk->ops->unprepare) >>> clk->ops->unprepare(clk->hw); >>> >>> - __clk_unprepare(clk->parent); >>> + clk_core_unprepare(clk->parent); >>> +} >>> + >>> +void __clk_unprepare(struct clk *clk) >>> +{ >>> + clk_core_unprepare(clk->core); >> OOps. clk can be NULL here. Bail early if so. > Actually, looks like nobody is using __clk_prepare nor __clk_unprepare > so I'm removing these. > Ok. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RESEND v8 1/2] clk: Make clk API return per-user struct clk instances Date: Mon, 19 Jan 2015 10:40:04 -0800 [thread overview] Message-ID: <54BD4F84.1010501@codeaurora.org> (raw) In-Reply-To: <CAAObsKAc6kqgBdWpAvAc2fDW42jNtT1hCD_uL8ums0hHCTXgng@mail.gmail.com> On 01/19/2015 01:55 AM, Tomeu Vizoso wrote: > On 17 January 2015 at 02:02, Stephen Boyd <sboyd@codeaurora.org> wrote: >> On 01/12, Tomeu Vizoso wrote: >> >>> +} >>> EXPORT_SYMBOL_GPL(__clk_get_rate); >>> >>> @@ -630,7 +656,12 @@ out: >>> return !!ret; >>> } >>> >>> -bool __clk_is_enabled(struct clk *clk) >>> +bool __clk_is_prepared(struct clk *clk) >>> +{ >>> + return clk_core_is_prepared(clk->core); >> Oops. clk can be NULL here. Return false if so. Or drop the >> function entirely? It looks like it may become unused. > Are you thinking of anything specific that the alchemy arch can do > instead of calling __clk_is_prepared? > > Ah I missed that one. Bad grep. >>> +} >>> EXPORT_SYMBOL_GPL(__clk_is_enabled); >>> >>> @@ -762,7 +805,12 @@ void __clk_unprepare(struct clk *clk) >>> if (clk->ops->unprepare) >>> clk->ops->unprepare(clk->hw); >>> >>> - __clk_unprepare(clk->parent); >>> + clk_core_unprepare(clk->parent); >>> +} >>> + >>> +void __clk_unprepare(struct clk *clk) >>> +{ >>> + clk_core_unprepare(clk->core); >> OOps. clk can be NULL here. Bail early if so. > Actually, looks like nobody is using __clk_prepare nor __clk_unprepare > so I'm removing these. > Ok. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-01-19 18:40 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-12 14:10 [PATCH RESEND v8 0/2] Per-user clock constraints Tomeu Vizoso 2015-01-12 14:10 ` [PATCH RESEND v8 1/2] clk: Make clk API return per-user struct clk instances Tomeu Vizoso 2015-01-12 14:10 ` Tomeu Vizoso 2015-01-17 1:02 ` Stephen Boyd 2015-01-17 1:02 ` Stephen Boyd 2015-01-19 9:55 ` Tomeu Vizoso 2015-01-19 9:55 ` Tomeu Vizoso 2015-01-19 9:55 ` Tomeu Vizoso 2015-01-19 18:40 ` Stephen Boyd [this message] 2015-01-19 18:40 ` Stephen Boyd 2015-01-19 18:40 ` Stephen Boyd 2015-01-12 14:10 ` [PATCH RESEND v8 2/2] clk: Add floor and ceiling constraints to clock rates Tomeu Vizoso 2015-01-12 14:10 ` Tomeu Vizoso 2015-01-17 1:57 ` Stephen Boyd 2015-01-17 1:57 ` Stephen Boyd 2015-01-17 1:57 ` Stephen Boyd 2015-01-19 17:00 ` Tomeu Vizoso 2015-01-19 17:00 ` Tomeu Vizoso 2015-01-19 17:00 ` Tomeu Vizoso
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54BD4F84.1010501@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=javier.martinez@collabora.co.uk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mturquette@linaro.org \ --cc=paul@pwsan.com \ --cc=tomeu.vizoso@collabora.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.