All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] sparse: Fix build with sparse on .S files
@ 2015-01-22  9:53 Christian Borntraeger
  2015-01-22 13:58 ` Paolo Bonzini
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Borntraeger @ 2015-01-22  9:53 UTC (permalink / raw)
  To: Peter Maydell, Paolo Bonzini
  Cc: Cornelia Huck, Christian Borntraeger, Jens Freimann, qemu-devel

rules.mak has a rule for .S files using CPP. This will result in
errors like
  CPP   s390-ccw/start.asm
 cc: error: unrecognized command line option '-Wbitwise'

Lets also redefine CPP in case of --enable-sparse.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 47048f0..3bdda2e 100755
--- a/configure
+++ b/configure
@@ -4909,6 +4909,7 @@ echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
 echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
 if test "$sparse" = "yes" ; then
   echo "CC           := REAL_CC=\"\$(CC)\" cgcc"       >> $config_host_mak
+  echo "CPP          := REAL_CC=\"\$(CPP)\" cgcc"      >> $config_host_mak
   echo "CXX          := REAL_CC=\"\$(CXX)\" cgcc"      >> $config_host_mak
   echo "HOST_CC      := REAL_CC=\"\$(HOST_CC)\" cgcc"  >> $config_host_mak
   echo "QEMU_CFLAGS  += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_host_mak
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] sparse: Fix build with sparse on .S files
  2015-01-22  9:53 [Qemu-devel] [PATCH] sparse: Fix build with sparse on .S files Christian Borntraeger
@ 2015-01-22 13:58 ` Paolo Bonzini
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2015-01-22 13:58 UTC (permalink / raw)
  To: Christian Borntraeger, Peter Maydell
  Cc: Cornelia Huck, Jens Freimann, qemu-devel



On 22/01/2015 10:53, Christian Borntraeger wrote:
> rules.mak has a rule for .S files using CPP. This will result in
> errors like
>   CPP   s390-ccw/start.asm
>  cc: error: unrecognized command line option '-Wbitwise'
> 
> Lets also redefine CPP in case of --enable-sparse.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index 47048f0..3bdda2e 100755
> --- a/configure
> +++ b/configure
> @@ -4909,6 +4909,7 @@ echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
>  echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
>  if test "$sparse" = "yes" ; then
>    echo "CC           := REAL_CC=\"\$(CC)\" cgcc"       >> $config_host_mak
> +  echo "CPP          := REAL_CC=\"\$(CPP)\" cgcc"      >> $config_host_mak
>    echo "CXX          := REAL_CC=\"\$(CXX)\" cgcc"      >> $config_host_mak
>    echo "HOST_CC      := REAL_CC=\"\$(HOST_CC)\" cgcc"  >> $config_host_mak
>    echo "QEMU_CFLAGS  += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_host_mak
> 

Queued, thanks.

Paolo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-22 13:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-22  9:53 [Qemu-devel] [PATCH] sparse: Fix build with sparse on .S files Christian Borntraeger
2015-01-22 13:58 ` Paolo Bonzini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.