* [U-Boot] removing bit reversing for SCFG in immap_ls102xa.h
@ 2015-01-23 7:11 Sinan Akman
2015-01-23 9:06 ` Huan Wang
0 siblings, 1 reply; 2+ messages in thread
From: Sinan Akman @ 2015-01-23 7:11 UTC (permalink / raw)
To: u-boot
Hi Alison
I was just testing out ls1021atwr board with NOR
boot using rcw_1000.bin.
I noticed that Ethernet is not working.
In ls1021atwr.c we have :
out_be32(&scfg->etsecdmamcr, SCFG_ETSECDMAMCR_LE_BD_FR);
out_be32(&scfg->etsecmcr, SCFG_ETSECCMCR_GE2_CLK125);
In your earlier commit c207ff612903389f8b32e377fe32be43e6efd8f7
you removed the bit reversing around this but those defines are not
in big-endian. By setting bit reversing before those lines as
before makes Ethernet working.
Could you please take a look at this. Should we reverse
your commit since we are accessing SCFG registers directly
in the board specific files ?
Regards
Sinan Akman
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] removing bit reversing for SCFG in immap_ls102xa.h
2015-01-23 7:11 [U-Boot] removing bit reversing for SCFG in immap_ls102xa.h Sinan Akman
@ 2015-01-23 9:06 ` Huan Wang
0 siblings, 0 replies; 2+ messages in thread
From: Huan Wang @ 2015-01-23 9:06 UTC (permalink / raw)
To: u-boot
Hi, Sinan Akman,
As the comment of commit c207ff612903389f8b32e377fe32be43e6efd8f7 said, we removes the bit reversing for SCFG registers in u-boot. It is implemented through PBI command in RCW.
.pbi
write 0x570200, 0xffffffff
.end
Through this way, other SCFG registers could be written in big-endian mode in u-boot or kernel directly. No other bit reversing is needed. For example, we only need to set SCFG_ETSECDMAMCR register as follows.
out_be32(&scfg->etsecdmamcr, SCFG_ETSECDMAMCR_LE_BD_FR);
According to your test, I think your RCW is very old and the above PBI command is not added. So I suggest you to add this PBI command in RCW, it will make Ethernet work.
Best Regards,
Alison Wang
> -----Original Message-----
> From: Sinan Akman [mailto:sinan at writeme.com]
> Sent: Friday, January 23, 2015 3:11 PM
> To: U-Boot-Denx
> Cc: Wang Huan-B18965; Sun York-R58495
> Subject: removing bit reversing for SCFG in immap_ls102xa.h
>
>
> Hi Alison
>
> I was just testing out ls1021atwr board with NOR boot using
> rcw_1000.bin.
>
> I noticed that Ethernet is not working.
>
> In ls1021atwr.c we have :
>
> out_be32(&scfg->etsecdmamcr, SCFG_ETSECDMAMCR_LE_BD_FR);
> out_be32(&scfg->etsecmcr, SCFG_ETSECCMCR_GE2_CLK125);
>
> In your earlier commit c207ff612903389f8b32e377fe32be43e6efd8f7
> you removed the bit reversing around this but those defines are not in
> big-endian. By setting bit reversing before those lines as before makes
> Ethernet working.
>
> Could you please take a look at this. Should we reverse your commit
> since we are accessing SCFG registers directly in the board specific
> files ?
>
> Regards
>
> Sinan Akman
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-23 9:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-23 7:11 [U-Boot] removing bit reversing for SCFG in immap_ls102xa.h Sinan Akman
2015-01-23 9:06 ` Huan Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.