* [PATCH] ACPI/sleep: mark acpi_sleep_dmi_check() __init
@ 2015-01-23 8:12 Jan Beulich
2015-01-30 0:09 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2015-01-23 8:12 UTC (permalink / raw)
To: linux-acpi; +Cc: Len Brown, rjw
ACPI/sleep: mark acpi_sleep_dmi_check() __init
This makes a difference if the compiler decides not to inline the
function, as then the function's reference to acpisleep_dmi_table[]
yields a section mismatch warning.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/acpi/sleep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 3.19-rc5/drivers/acpi/sleep.c
+++ 3.19-rc5-ACPI-sleep-DMI-check-init/drivers/acpi/sleep.c
@@ -321,7 +321,7 @@ static struct dmi_system_id acpisleep_dm
{},
};
-static void acpi_sleep_dmi_check(void)
+static void __init acpi_sleep_dmi_check(void)
{
int year;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI/sleep: mark acpi_sleep_dmi_check() __init
2015-01-23 8:12 [PATCH] ACPI/sleep: mark acpi_sleep_dmi_check() __init Jan Beulich
@ 2015-01-30 0:09 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2015-01-30 0:09 UTC (permalink / raw)
To: Jan Beulich; +Cc: linux-acpi, Len Brown
On Friday, January 23, 2015 08:12:06 AM Jan Beulich wrote:
> ACPI/sleep: mark acpi_sleep_dmi_check() __init
>
> This makes a difference if the compiler decides not to inline the
> function, as then the function's reference to acpisleep_dmi_table[]
> yields a section mismatch warning.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Queued up for 3.20, thanks!
> ---
> drivers/acpi/sleep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 3.19-rc5/drivers/acpi/sleep.c
> +++ 3.19-rc5-ACPI-sleep-DMI-check-init/drivers/acpi/sleep.c
> @@ -321,7 +321,7 @@ static struct dmi_system_id acpisleep_dm
> {},
> };
>
> -static void acpi_sleep_dmi_check(void)
> +static void __init acpi_sleep_dmi_check(void)
> {
> int year;
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-29 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-23 8:12 [PATCH] ACPI/sleep: mark acpi_sleep_dmi_check() __init Jan Beulich
2015-01-30 0:09 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.