* [PATCH] kconfig: use va_end to match corresponding va_start
@ 2015-01-12 13:18 Colin King
2015-01-27 15:59 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2015-01-12 13:18 UTC (permalink / raw)
To: Yann E. MORIN, linux-kbuild; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Although on some systems va_end is a no-op, it is good practice
to use va_end, especially since the manual states:
"Each invocation of va_start() must be matched by a corresponding
invocation of va_end() in the same function."
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
scripts/kconfig/confdata.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index f88d90f..28df18d 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -59,6 +59,7 @@ static void conf_message(const char *fmt, ...)
va_start(ap, fmt);
if (conf_message_callback)
conf_message_callback(fmt, ap);
+ va_end(ap);
}
const char *conf_get_configname(void)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kconfig: use va_end to match corresponding va_start
2015-01-12 13:18 [PATCH] kconfig: use va_end to match corresponding va_start Colin King
@ 2015-01-27 15:59 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2015-01-27 15:59 UTC (permalink / raw)
To: Colin King, Yann E. MORIN, linux-kbuild; +Cc: linux-kernel
On 2015-01-12 14:18, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Although on some systems va_end is a no-op, it is good practice
> to use va_end, especially since the manual states:
>
> "Each invocation of va_start() must be matched by a corresponding
> invocation of va_end() in the same function."
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to kbuild.git#kconfig, thanks.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-27 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-12 13:18 [PATCH] kconfig: use va_end to match corresponding va_start Colin King
2015-01-27 15:59 ` Michal Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.