From: Sylwester Nawrocki <s.nawrocki@samsung.com> To: Inha Song <ideal.song@samsung.com> Cc: alsa-devel@alsa-project.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, kgene@kernel.org, sbkim73@samsung.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.de, grant.likely@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v4 1/3] ASoC: samsung: Add machine driver for Trats2 Date: Tue, 27 Jan 2015 18:09:39 +0100 [thread overview] Message-ID: <54C7C653.6080904@samsung.com> (raw) In-Reply-To: <1421989410-12490-2-git-send-email-ideal.song@samsung.com> On 23/01/15 06:03, Inha Song wrote: > +static int trats2_aif1_startup(struct snd_pcm_substream *substream) > +{ > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct trats2_machine_priv *priv = snd_soc_card_get_drvdata(rtd->card); > + int ret; > + > + ret = clk_prepare_enable(priv->clk_mclk); > + if (ret) { > + dev_err(rtd->card->dev, "Failed to enable mclk: %d\n", ret); > + return ret; > + } > + > + return 0; > +} > + > +static void trats2_aif1_shutdown(struct snd_pcm_substream *substream) > +{ > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct trats2_machine_priv *priv = snd_soc_card_get_drvdata(rtd->card); > + > + clk_disable_unprepare(priv->clk_mclk); > +} > + > +static const struct snd_soc_ops trats2_aif1_ops = { > + .startup = trats2_aif1_startup, > + .shutdown = trats2_aif1_shutdown, > + .hw_params = trats2_aif1_hw_params, > +}; > +static int trats2_audio_probe(struct platform_device *pdev) > +{ > + priv->clk_mclk = of_clk_get_by_name(codec_node, "MCLK1"); > + if (IS_ERR(priv->clk_mclk)) { > + dev_err(&pdev->dev, "Failed to get mclk clock\n"); > + of_node_put(codec_node); > + return PTR_ERR(priv->clk_mclk); > + } Wouldn't it also work if we added clock handling into the wm8994 codec driver instead? Not sure if it is correct to retrieve the codec's clock in the machine driver like this. Or perhaps the MCLK1 (SoC CLKOUT) clock should be added to the sound DT node and handled only by the machine driver, together with the other (MCLK2) clock? > + of_node_put(codec_node); -- Regards, Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki) To: linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH v4 1/3] ASoC: samsung: Add machine driver for Trats2 Date: Tue, 27 Jan 2015 18:09:39 +0100 [thread overview] Message-ID: <54C7C653.6080904@samsung.com> (raw) In-Reply-To: <1421989410-12490-2-git-send-email-ideal.song@samsung.com> On 23/01/15 06:03, Inha Song wrote: > +static int trats2_aif1_startup(struct snd_pcm_substream *substream) > +{ > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct trats2_machine_priv *priv = snd_soc_card_get_drvdata(rtd->card); > + int ret; > + > + ret = clk_prepare_enable(priv->clk_mclk); > + if (ret) { > + dev_err(rtd->card->dev, "Failed to enable mclk: %d\n", ret); > + return ret; > + } > + > + return 0; > +} > + > +static void trats2_aif1_shutdown(struct snd_pcm_substream *substream) > +{ > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct trats2_machine_priv *priv = snd_soc_card_get_drvdata(rtd->card); > + > + clk_disable_unprepare(priv->clk_mclk); > +} > + > +static const struct snd_soc_ops trats2_aif1_ops = { > + .startup = trats2_aif1_startup, > + .shutdown = trats2_aif1_shutdown, > + .hw_params = trats2_aif1_hw_params, > +}; > +static int trats2_audio_probe(struct platform_device *pdev) > +{ > + priv->clk_mclk = of_clk_get_by_name(codec_node, "MCLK1"); > + if (IS_ERR(priv->clk_mclk)) { > + dev_err(&pdev->dev, "Failed to get mclk clock\n"); > + of_node_put(codec_node); > + return PTR_ERR(priv->clk_mclk); > + } Wouldn't it also work if we added clock handling into the wm8994 codec driver instead? Not sure if it is correct to retrieve the codec's clock in the machine driver like this. Or perhaps the MCLK1 (SoC CLKOUT) clock should be added to the sound DT node and handled only by the machine driver, together with the other (MCLK2) clock? > + of_node_put(codec_node); -- Regards, Sylwester
next prev parent reply other threads:[~2015-01-27 17:09 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-23 5:03 [alsa-devel] [PATCH v4 0/3] Sound support for Exynos4412 Trats2 board Inha Song 2015-01-23 5:03 ` Inha Song 2015-01-23 5:03 ` [alsa-devel] [PATCH v4 1/3] ASoC: samsung: Add machine driver for Trats2 Inha Song 2015-01-23 5:03 ` Inha Song 2015-01-27 17:09 ` Sylwester Nawrocki [this message] 2015-01-27 17:09 ` Sylwester Nawrocki 2015-01-27 18:48 ` Mark Brown 2015-01-27 18:48 ` Mark Brown 2015-01-27 18:48 ` Mark Brown 2015-01-27 18:59 ` [alsa-devel] " Mark Brown 2015-01-27 18:59 ` Mark Brown 2015-01-27 18:59 ` Mark Brown 2015-01-23 5:03 ` [alsa-devel] [PATCH v4 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings Inha Song 2015-01-23 5:03 ` Inha Song 2015-01-23 14:13 ` Sylwester Nawrocki 2015-01-23 14:13 ` Sylwester Nawrocki 2015-01-27 18:49 ` Mark Brown 2015-01-27 18:49 ` Mark Brown 2015-01-27 18:49 ` Mark Brown 2015-01-23 5:03 ` [alsa-devel] [PATCH v4 3/3] ARM: dts: Add sound nodes for exynos4412-trats2 Inha Song 2015-01-23 5:03 ` Inha Song 2015-01-23 5:03 ` Inha Song 2015-01-23 6:56 ` Inha Song 2015-01-23 6:56 ` Inha Song 2015-01-23 6:56 ` Inha Song 2015-01-23 14:10 ` Sylwester Nawrocki 2015-01-23 14:10 ` Sylwester Nawrocki 2015-02-03 4:18 ` Kukjin Kim 2015-02-03 4:18 ` Kukjin Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54C7C653.6080904@samsung.com \ --to=s.nawrocki@samsung.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=grant.likely@linaro.org \ --cc=ideal.song@samsung.com \ --cc=ijc+devicetree@hellion.org.uk \ --cc=kgene@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=perex@perex.cz \ --cc=robh+dt@kernel.org \ --cc=sbkim73@samsung.com \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.