All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mmc: Manual BKOPs enablement bug fix
@ 2015-01-27 14:01 Alexey Skidanov
  2015-01-28 10:35 ` Jaehoon Chung
  2015-01-28 20:54 ` Ulf Hansson
  0 siblings, 2 replies; 5+ messages in thread
From: Alexey Skidanov @ 2015-01-27 14:01 UTC (permalink / raw)
  To: chris, ulf.hansson, linux-mmc; +Cc: alex.lemberg, Alexey Skidanov

This patch is coming to fix compatibility issue of BKOPS_EN  field of EXT_CSD.
In eMMC-5.1, BKOPS_EN was changed, and now it has two operational bits:
Bit 0 - MANUAL_EN
Bit 1 - AUTO_EN
In previous eMMC revisions, only Bit 0 was supported.

Signed-off-by: Alexey Skidanov <alexey.skidanov@sandisk.com>
---
 drivers/mmc/core/core.c  |    2 +-
 drivers/mmc/core/mmc.c   |    6 ++++--
 include/linux/mmc/card.h |    5 ++++-
 include/linux/mmc/mmc.h  |    6 ++++++
 4 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 1be7055..0dc64e6 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -275,7 +275,7 @@ void mmc_start_bkops(struct mmc_card *card, bool from_exception)
 
 	BUG_ON(!card);
 
-	if (!card->ext_csd.bkops_en || mmc_card_doing_bkops(card))
+	if (!card->ext_csd.man_bkops_en || mmc_card_doing_bkops(card))
 		return;
 
 	err = mmc_read_bkops_status(card);
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 1fc48a2..c35bf6e 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -483,10 +483,12 @@ static int mmc_decode_ext_csd(struct mmc_card *card, u8 *ext_csd)
 		/* check whether the eMMC card supports BKOPS */
 		if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) {
 			card->ext_csd.bkops = 1;
-			card->ext_csd.bkops_en = ext_csd[EXT_CSD_BKOPS_EN];
+			card->ext_csd.man_bkops_en =
+					(ext_csd[EXT_CSD_BKOPS_EN] &
+						EXT_CSD_MANUAL_BKOPS_MASK);
 			card->ext_csd.raw_bkops_status =
 				ext_csd[EXT_CSD_BKOPS_STATUS];
-			if (!card->ext_csd.bkops_en)
+			if (!card->ext_csd.man_bkops_en)
 				pr_info("%s: BKOPS_EN bit is not set\n",
 					mmc_hostname(card->host));
 		}
diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
index 4d69c00..15772d0 100644
--- a/include/linux/mmc/card.h
+++ b/include/linux/mmc/card.h
@@ -83,7 +83,10 @@ struct mmc_ext_csd {
 	bool			hpi;			/* HPI support bit */
 	unsigned int		hpi_cmd;		/* cmd used as HPI */
 	bool			bkops;		/* background support bit */
-	bool			bkops_en;	/* background enable bit */
+	bool			man_bkops_en;	/* manual background
+						enable bit */
+	bool			auto_bkops_en;	/* automatic background
+						enable bit */
 	unsigned int            data_sector_size;       /* 512 bytes or 4KB */
 	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
 	unsigned int		boot_ro_lock;		/* ro lock support */
diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h
index fb97b5c..d39db3e 100644
--- a/include/linux/mmc/mmc.h
+++ b/include/linux/mmc/mmc.h
@@ -428,6 +428,12 @@ struct _mmc_csd {
 #define EXT_CSD_BKOPS_LEVEL_2		0x2
 
 /*
+ * BKOPS modes
+ */
+#define EXT_CSD_MANUAL_BKOPS_MASK	0x01
+#define EXT_CSD_AUTOMATIC_BKOPS_MASK	0x02
+
+/*
  * MMC_SWITCH access modes
  */
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: Manual BKOPs enablement bug fix
  2015-01-27 14:01 [PATCH] mmc: Manual BKOPs enablement bug fix Alexey Skidanov
@ 2015-01-28 10:35 ` Jaehoon Chung
  2015-01-28 12:12   ` Alex Lemberg
  2015-01-28 20:54 ` Ulf Hansson
  1 sibling, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2015-01-28 10:35 UTC (permalink / raw)
  To: Alexey Skidanov, chris, ulf.hansson, linux-mmc; +Cc: alex.lemberg

Hi, Alexey.

On 01/27/2015 11:01 PM, Alexey Skidanov wrote:
> This patch is coming to fix compatibility issue of BKOPS_EN  field of EXT_CSD.
> In eMMC-5.1, BKOPS_EN was changed, and now it has two operational bits:
> Bit 0 - MANUAL_EN
> Bit 1 - AUTO_EN
> In previous eMMC revisions, only Bit 0 was supported.

Well, i don't have eMMC5.1 spec, so i want to know more exactly what is "auto_enable".
If AUTO_EN is set, what happen?

I can't find where auto_bkops_en is used.


Best Regards,
Jaehoon CHung

> 
> Signed-off-by: Alexey Skidanov <alexey.skidanov@sandisk.com>
> ---
>  drivers/mmc/core/core.c  |    2 +-
>  drivers/mmc/core/mmc.c   |    6 ++++--
>  include/linux/mmc/card.h |    5 ++++-
>  include/linux/mmc/mmc.h  |    6 ++++++
>  4 files changed, 15 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 1be7055..0dc64e6 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -275,7 +275,7 @@ void mmc_start_bkops(struct mmc_card *card, bool from_exception)
>  
>  	BUG_ON(!card);
>  
> -	if (!card->ext_csd.bkops_en || mmc_card_doing_bkops(card))
> +	if (!card->ext_csd.man_bkops_en || mmc_card_doing_bkops(card))
>  		return;
>  
>  	err = mmc_read_bkops_status(card);
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 1fc48a2..c35bf6e 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -483,10 +483,12 @@ static int mmc_decode_ext_csd(struct mmc_card *card, u8 *ext_csd)
>  		/* check whether the eMMC card supports BKOPS */
>  		if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) {
>  			card->ext_csd.bkops = 1;
> -			card->ext_csd.bkops_en = ext_csd[EXT_CSD_BKOPS_EN];
> +			card->ext_csd.man_bkops_en =
> +					(ext_csd[EXT_CSD_BKOPS_EN] &
> +						EXT_CSD_MANUAL_BKOPS_MASK);
>  			card->ext_csd.raw_bkops_status =
>  				ext_csd[EXT_CSD_BKOPS_STATUS];
> -			if (!card->ext_csd.bkops_en)
> +			if (!card->ext_csd.man_bkops_en)
>  				pr_info("%s: BKOPS_EN bit is not set\n",
>  					mmc_hostname(card->host));
>  		}
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
> index 4d69c00..15772d0 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -83,7 +83,10 @@ struct mmc_ext_csd {
>  	bool			hpi;			/* HPI support bit */
>  	unsigned int		hpi_cmd;		/* cmd used as HPI */
>  	bool			bkops;		/* background support bit */
> -	bool			bkops_en;	/* background enable bit */
> +	bool			man_bkops_en;	/* manual background
> +						enable bit */
> +	bool			auto_bkops_en;	/* automatic background
> +						enable bit */
>  	unsigned int            data_sector_size;       /* 512 bytes or 4KB */
>  	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
>  	unsigned int		boot_ro_lock;		/* ro lock support */
> diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h
> index fb97b5c..d39db3e 100644
> --- a/include/linux/mmc/mmc.h
> +++ b/include/linux/mmc/mmc.h
> @@ -428,6 +428,12 @@ struct _mmc_csd {
>  #define EXT_CSD_BKOPS_LEVEL_2		0x2
>  
>  /*
> + * BKOPS modes
> + */
> +#define EXT_CSD_MANUAL_BKOPS_MASK	0x01
> +#define EXT_CSD_AUTOMATIC_BKOPS_MASK	0x02
> +
> +/*
>   * MMC_SWITCH access modes
>   */
>  
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [PATCH] mmc: Manual BKOPs enablement bug fix
  2015-01-28 10:35 ` Jaehoon Chung
@ 2015-01-28 12:12   ` Alex Lemberg
  0 siblings, 0 replies; 5+ messages in thread
From: Alex Lemberg @ 2015-01-28 12:12 UTC (permalink / raw)
  To: Jaehoon Chung, Alexey Skidanov, chris, ulf.hansson, linux-mmc

Hi Jaehoon,


> -----Original Message-----
> From: Jaehoon Chung [mailto:jh80.chung@samsung.com]
> Sent: Wednesday, January 28, 2015 12:36 PM
> To: Alexey Skidanov; chris@printf.net; ulf.hansson@linaro.org; linux-
> mmc@vger.kernel.org
> Cc: Alex Lemberg
> Subject: Re: [PATCH] mmc: Manual BKOPs enablement bug fix
> 
> Hi, Alexey.
> 
> On 01/27/2015 11:01 PM, Alexey Skidanov wrote:
> > This patch is coming to fix compatibility issue of BKOPS_EN  field of EXT_CSD.
> > In eMMC-5.1, BKOPS_EN was changed, and now it has two operational bits:
> > Bit 0 - MANUAL_EN
> > Bit 1 - AUTO_EN
> > In previous eMMC revisions, only Bit 0 was supported.
> 
> Well, i don't have eMMC5.1 spec, so i want to know more exactly what is
> "auto_enable".
> If AUTO_EN is set, what happen?

According to the spec, when AUTO_EN bit is set, device may perform background operations while not servicing the host.
> 
> I can't find where auto_bkops_en is used.

auto_bkops_en is not used, but once we make a differentiation between two bits, we found it as needed for future support. 

The main purpose of this patch is proper usage of ext_csd[EXT_CSD_BKOPS_EN] field for both eMMC5.0 and eMMC5.1 devices.

Thanks,
Alex

> 
> 
> Best Regards,
> Jaehoon CHung
> 
> >
> > Signed-off-by: Alexey Skidanov <alexey.skidanov@sandisk.com>
> > ---
> >  drivers/mmc/core/core.c  |    2 +-
> >  drivers/mmc/core/mmc.c   |    6 ++++--
> >  include/linux/mmc/card.h |    5 ++++-
> >  include/linux/mmc/mmc.h  |    6 ++++++
> >  4 files changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index
> > 1be7055..0dc64e6 100644
> > --- a/drivers/mmc/core/core.c
> > +++ b/drivers/mmc/core/core.c
> > @@ -275,7 +275,7 @@ void mmc_start_bkops(struct mmc_card *card, bool
> > from_exception)
> >
> >  	BUG_ON(!card);
> >
> > -	if (!card->ext_csd.bkops_en || mmc_card_doing_bkops(card))
> > +	if (!card->ext_csd.man_bkops_en || mmc_card_doing_bkops(card))
> >  		return;
> >
> >  	err = mmc_read_bkops_status(card);
> > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index
> > 1fc48a2..c35bf6e 100644
> > --- a/drivers/mmc/core/mmc.c
> > +++ b/drivers/mmc/core/mmc.c
> > @@ -483,10 +483,12 @@ static int mmc_decode_ext_csd(struct mmc_card
> *card, u8 *ext_csd)
> >  		/* check whether the eMMC card supports BKOPS */
> >  		if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) {
> >  			card->ext_csd.bkops = 1;
> > -			card->ext_csd.bkops_en =
> ext_csd[EXT_CSD_BKOPS_EN];
> > +			card->ext_csd.man_bkops_en =
> > +					(ext_csd[EXT_CSD_BKOPS_EN] &
> > +
> 	EXT_CSD_MANUAL_BKOPS_MASK);
> >  			card->ext_csd.raw_bkops_status =
> >  				ext_csd[EXT_CSD_BKOPS_STATUS];
> > -			if (!card->ext_csd.bkops_en)
> > +			if (!card->ext_csd.man_bkops_en)
> >  				pr_info("%s: BKOPS_EN bit is not set\n",
> >  					mmc_hostname(card->host));
> >  		}
> > diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index
> > 4d69c00..15772d0 100644
> > --- a/include/linux/mmc/card.h
> > +++ b/include/linux/mmc/card.h
> > @@ -83,7 +83,10 @@ struct mmc_ext_csd {
> >  	bool			hpi;			/* HPI support bit */
> >  	unsigned int		hpi_cmd;		/* cmd used as HPI */
> >  	bool			bkops;		/* background support bit */
> > -	bool			bkops_en;	/* background enable bit */
> > +	bool			man_bkops_en;	/* manual background
> > +						enable bit */
> > +	bool			auto_bkops_en;	/* automatic background
> > +						enable bit */
> >  	unsigned int            data_sector_size;       /* 512 bytes or 4KB */
> >  	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
> >  	unsigned int		boot_ro_lock;		/* ro lock support */
> > diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h index
> > fb97b5c..d39db3e 100644
> > --- a/include/linux/mmc/mmc.h
> > +++ b/include/linux/mmc/mmc.h
> > @@ -428,6 +428,12 @@ struct _mmc_csd {
> >  #define EXT_CSD_BKOPS_LEVEL_2		0x2
> >
> >  /*
> > + * BKOPS modes
> > + */
> > +#define EXT_CSD_MANUAL_BKOPS_MASK	0x01
> > +#define EXT_CSD_AUTOMATIC_BKOPS_MASK	0x02
> > +
> > +/*
> >   * MMC_SWITCH access modes
> >   */
> >
> >


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: Manual BKOPs enablement bug fix
  2015-01-27 14:01 [PATCH] mmc: Manual BKOPs enablement bug fix Alexey Skidanov
  2015-01-28 10:35 ` Jaehoon Chung
@ 2015-01-28 20:54 ` Ulf Hansson
  2015-01-28 20:58   ` Ulf Hansson
  1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2015-01-28 20:54 UTC (permalink / raw)
  To: Alexey Skidanov; +Cc: Chris Ball, linux-mmc, Alex Lemberg

On 27 January 2015 at 15:01, Alexey Skidanov
<alexey.skidanov@sandisk.com> wrote:
> This patch is coming to fix compatibility issue of BKOPS_EN  field of EXT_CSD.
> In eMMC-5.1, BKOPS_EN was changed, and now it has two operational bits:
> Bit 0 - MANUAL_EN
> Bit 1 - AUTO_EN
> In previous eMMC revisions, only Bit 0 was supported.
>
> Signed-off-by: Alexey Skidanov <alexey.skidanov@sandisk.com>
> ---
>  drivers/mmc/core/core.c  |    2 +-
>  drivers/mmc/core/mmc.c   |    6 ++++--
>  include/linux/mmc/card.h |    5 ++++-
>  include/linux/mmc/mmc.h  |    6 ++++++
>  4 files changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 1be7055..0dc64e6 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -275,7 +275,7 @@ void mmc_start_bkops(struct mmc_card *card, bool from_exception)
>
>         BUG_ON(!card);
>
> -       if (!card->ext_csd.bkops_en || mmc_card_doing_bkops(card))
> +       if (!card->ext_csd.man_bkops_en || mmc_card_doing_bkops(card))
>                 return;
>
>         err = mmc_read_bkops_status(card);
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 1fc48a2..c35bf6e 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -483,10 +483,12 @@ static int mmc_decode_ext_csd(struct mmc_card *card, u8 *ext_csd)
>                 /* check whether the eMMC card supports BKOPS */
>                 if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) {
>                         card->ext_csd.bkops = 1;
> -                       card->ext_csd.bkops_en = ext_csd[EXT_CSD_BKOPS_EN];
> +                       card->ext_csd.man_bkops_en =
> +                                       (ext_csd[EXT_CSD_BKOPS_EN] &
> +                                               EXT_CSD_MANUAL_BKOPS_MASK);
>                         card->ext_csd.raw_bkops_status =
>                                 ext_csd[EXT_CSD_BKOPS_STATUS];
> -                       if (!card->ext_csd.bkops_en)
> +                       if (!card->ext_csd.man_bkops_en)
>                                 pr_info("%s: BKOPS_EN bit is not set\n",

Should we maybe update the pr_info to say "MAN_BKOPS_EN bit is not set"?

>                                         mmc_hostname(card->host));
>                 }
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
> index 4d69c00..15772d0 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -83,7 +83,10 @@ struct mmc_ext_csd {
>         bool                    hpi;                    /* HPI support bit */
>         unsigned int            hpi_cmd;                /* cmd used as HPI */
>         bool                    bkops;          /* background support bit */
> -       bool                    bkops_en;       /* background enable bit */
> +       bool                    man_bkops_en;   /* manual background
> +                                               enable bit */
> +       bool                    auto_bkops_en;  /* automatic background
> +                                               enable bit */

Please remove "auto_bkops_en", since it's not used. If see a need for
it later, then we can add it.

>         unsigned int            data_sector_size;       /* 512 bytes or 4KB */
>         unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
>         unsigned int            boot_ro_lock;           /* ro lock support */
> diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h
> index fb97b5c..d39db3e 100644
> --- a/include/linux/mmc/mmc.h
> +++ b/include/linux/mmc/mmc.h
> @@ -428,6 +428,12 @@ struct _mmc_csd {
>  #define EXT_CSD_BKOPS_LEVEL_2          0x2
>
>  /*
> + * BKOPS modes
> + */
> +#define EXT_CSD_MANUAL_BKOPS_MASK      0x01
> +#define EXT_CSD_AUTOMATIC_BKOPS_MASK   0x02

Please remove EXT_CSD_AUTOMATIC_BKOPS_MASK, it's not used in this patch.

> +
> +/*
>   * MMC_SWITCH access modes
>   */
>
> --
> 1.7.9.5
>

Kind regards
Uffe

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: Manual BKOPs enablement bug fix
  2015-01-28 20:54 ` Ulf Hansson
@ 2015-01-28 20:58   ` Ulf Hansson
  0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2015-01-28 20:58 UTC (permalink / raw)
  To: Alexey Skidanov; +Cc: Chris Ball, linux-mmc, Alex Lemberg

On 28 January 2015 at 21:54, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 27 January 2015 at 15:01, Alexey Skidanov
> <alexey.skidanov@sandisk.com> wrote:
>> This patch is coming to fix compatibility issue of BKOPS_EN  field of EXT_CSD.
>> In eMMC-5.1, BKOPS_EN was changed, and now it has two operational bits:
>> Bit 0 - MANUAL_EN
>> Bit 1 - AUTO_EN
>> In previous eMMC revisions, only Bit 0 was supported.
>>
>> Signed-off-by: Alexey Skidanov <alexey.skidanov@sandisk.com>

One more thing. Please update the commit message header, since I don't
think you are fixing a bug. You are fixing a compatibility issue due
to a version of the spec, let's state that instead.

Kind regards
Uffe

>> ---
>>  drivers/mmc/core/core.c  |    2 +-
>>  drivers/mmc/core/mmc.c   |    6 ++++--
>>  include/linux/mmc/card.h |    5 ++++-
>>  include/linux/mmc/mmc.h  |    6 ++++++
>>  4 files changed, 15 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>> index 1be7055..0dc64e6 100644
>> --- a/drivers/mmc/core/core.c
>> +++ b/drivers/mmc/core/core.c
>> @@ -275,7 +275,7 @@ void mmc_start_bkops(struct mmc_card *card, bool from_exception)
>>
>>         BUG_ON(!card);
>>
>> -       if (!card->ext_csd.bkops_en || mmc_card_doing_bkops(card))
>> +       if (!card->ext_csd.man_bkops_en || mmc_card_doing_bkops(card))
>>                 return;
>>
>>         err = mmc_read_bkops_status(card);
>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
>> index 1fc48a2..c35bf6e 100644
>> --- a/drivers/mmc/core/mmc.c
>> +++ b/drivers/mmc/core/mmc.c
>> @@ -483,10 +483,12 @@ static int mmc_decode_ext_csd(struct mmc_card *card, u8 *ext_csd)
>>                 /* check whether the eMMC card supports BKOPS */
>>                 if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) {
>>                         card->ext_csd.bkops = 1;
>> -                       card->ext_csd.bkops_en = ext_csd[EXT_CSD_BKOPS_EN];
>> +                       card->ext_csd.man_bkops_en =
>> +                                       (ext_csd[EXT_CSD_BKOPS_EN] &
>> +                                               EXT_CSD_MANUAL_BKOPS_MASK);
>>                         card->ext_csd.raw_bkops_status =
>>                                 ext_csd[EXT_CSD_BKOPS_STATUS];
>> -                       if (!card->ext_csd.bkops_en)
>> +                       if (!card->ext_csd.man_bkops_en)
>>                                 pr_info("%s: BKOPS_EN bit is not set\n",
>
> Should we maybe update the pr_info to say "MAN_BKOPS_EN bit is not set"?
>
>>                                         mmc_hostname(card->host));
>>                 }
>> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
>> index 4d69c00..15772d0 100644
>> --- a/include/linux/mmc/card.h
>> +++ b/include/linux/mmc/card.h
>> @@ -83,7 +83,10 @@ struct mmc_ext_csd {
>>         bool                    hpi;                    /* HPI support bit */
>>         unsigned int            hpi_cmd;                /* cmd used as HPI */
>>         bool                    bkops;          /* background support bit */
>> -       bool                    bkops_en;       /* background enable bit */
>> +       bool                    man_bkops_en;   /* manual background
>> +                                               enable bit */
>> +       bool                    auto_bkops_en;  /* automatic background
>> +                                               enable bit */
>
> Please remove "auto_bkops_en", since it's not used. If see a need for
> it later, then we can add it.
>
>>         unsigned int            data_sector_size;       /* 512 bytes or 4KB */
>>         unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
>>         unsigned int            boot_ro_lock;           /* ro lock support */
>> diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h
>> index fb97b5c..d39db3e 100644
>> --- a/include/linux/mmc/mmc.h
>> +++ b/include/linux/mmc/mmc.h
>> @@ -428,6 +428,12 @@ struct _mmc_csd {
>>  #define EXT_CSD_BKOPS_LEVEL_2          0x2
>>
>>  /*
>> + * BKOPS modes
>> + */
>> +#define EXT_CSD_MANUAL_BKOPS_MASK      0x01
>> +#define EXT_CSD_AUTOMATIC_BKOPS_MASK   0x02
>
> Please remove EXT_CSD_AUTOMATIC_BKOPS_MASK, it's not used in this patch.
>
>> +
>> +/*
>>   * MMC_SWITCH access modes
>>   */
>>
>> --
>> 1.7.9.5
>>
>
> Kind regards
> Uffe

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-29  3:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-27 14:01 [PATCH] mmc: Manual BKOPs enablement bug fix Alexey Skidanov
2015-01-28 10:35 ` Jaehoon Chung
2015-01-28 12:12   ` Alex Lemberg
2015-01-28 20:54 ` Ulf Hansson
2015-01-28 20:58   ` Ulf Hansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.