* [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
@ 2015-01-28 5:46 roopa
2015-01-28 7:05 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: roopa @ 2015-01-28 5:46 UTC (permalink / raw)
To: netdev, stephen, rami.rosen
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081
This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
handler does not return any bytes in the skb.
Alternately, the skb->len check can be moved inside rtnl_notify.
For the bridge vlan case described in 92081, there is also a fix needed
in bridge driver to generate a proper notification. Will fix that in
subsequent patch.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
net/core/rtnetlink.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 07447d1..e9d0f86 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2934,7 +2934,7 @@ static int rtnl_bridge_notify(struct net_device *dev)
}
err = dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, dev, 0);
- if (err < 0)
+ if (err < 0 || !skb->len)
goto errout;
rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
@@ -2942,7 +2942,8 @@ static int rtnl_bridge_notify(struct net_device *dev)
errout:
WARN_ON(err == -EMSGSIZE);
kfree_skb(skb);
- rtnl_set_sk_err(net, RTNLGRP_LINK, err);
+ if (err)
+ rtnl_set_sk_err(net, RTNLGRP_LINK, err);
return err;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
2015-01-28 5:46 [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify roopa
@ 2015-01-28 7:05 ` David Miller
2015-01-28 13:37 ` roopa
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2015-01-28 7:05 UTC (permalink / raw)
To: roopa; +Cc: netdev, stephen, rami.rosen
From: roopa@cumulusnetworks.com
Date: Tue, 27 Jan 2015 21:46:24 -0800
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081
>
> This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
> handler does not return any bytes in the skb.
>
> Alternately, the skb->len check can be moved inside rtnl_notify.
>
> For the bridge vlan case described in 92081, there is also a fix needed
> in bridge driver to generate a proper notification. Will fix that in
> subsequent patch.
>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
This doesn't apply to the 'net' tree, is there something I missed?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
2015-01-28 7:05 ` David Miller
@ 2015-01-28 13:37 ` roopa
2015-01-28 14:01 ` roopa
0 siblings, 1 reply; 4+ messages in thread
From: roopa @ 2015-01-28 13:37 UTC (permalink / raw)
To: David Miller; +Cc: netdev, stephen, rami.rosen
On 1/27/15, 11:05 PM, David Miller wrote:
> From: roopa@cumulusnetworks.com
> Date: Tue, 27 Jan 2015 21:46:24 -0800
>
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081
>>
>> This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
>> handler does not return any bytes in the skb.
>>
>> Alternately, the skb->len check can be moved inside rtnl_notify.
>>
>> For the bridge vlan case described in 92081, there is also a fix needed
>> in bridge driver to generate a proper notification. Will fix that in
>> subsequent patch.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> This doesn't apply to the 'net' tree, is there something I missed?
sorry, that's me. This should be net-next. Resubmitting with net-next in
the PATCH line.
thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
2015-01-28 13:37 ` roopa
@ 2015-01-28 14:01 ` roopa
0 siblings, 0 replies; 4+ messages in thread
From: roopa @ 2015-01-28 14:01 UTC (permalink / raw)
To: David Miller; +Cc: netdev, stephen, rami.rosen
On 1/28/15, 5:37 AM, roopa wrote:
> On 1/27/15, 11:05 PM, David Miller wrote:
>> From: roopa@cumulusnetworks.com
>> Date: Tue, 27 Jan 2015 21:46:24 -0800
>>
>>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>>
>>> Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081
>>>
>>> This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
>>> handler does not return any bytes in the skb.
>>>
>>> Alternately, the skb->len check can be moved inside rtnl_notify.
>>>
>>> For the bridge vlan case described in 92081, there is also a fix needed
>>> in bridge driver to generate a proper notification. Will fix that in
>>> subsequent patch.
>>>
>>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>> This doesn't apply to the 'net' tree, is there something I missed?
> sorry, that's me. This should be net-next. Resubmitting with net-next
> in the PATCH line.
>
A few more details ...
....This bug exists in 'net' tree (and I believe previous releases) as
well.
However my patch was generated on net-next, And there are other changes
in the related area in net-next tree hence the patch will not apply on
'net'.
Looks like its better for me to regenerate and submit against 'net'.
will do.
Thanks,
Roopa
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-29 2:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 5:46 [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify roopa
2015-01-28 7:05 ` David Miller
2015-01-28 13:37 ` roopa
2015-01-28 14:01 ` roopa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.