From: Peter Hurley <peter@hurleysoftware.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Varka Bhadram <varkabhadram@gmail.com>,
Chunyan Zhang <chunyan.zhang@spreadtrum.com>,
gregkh@linuxfoundation.org, mark.rutland@arm.com,
gnomes@lxorguk.ukuu.org.uk, heiko@sntech.de, andrew@lunn.ch,
jslaby@suse.cz, lanqing.liu@spreadtrum.com, pawel.moll@arm.com,
zhang.lyra@gmail.com, zhizhou.zhang@spreadtrum.com,
geng.ren@spreadtrum.com, antonynpavlov@gmail.com,
linux-serial@vger.kernel.org, grant.likely@linaro.org,
orsonzhai@gmail.com, florian.vaussard@epfl.ch,
devicetree@vger.kernel.org, jason@lakedaemon.net, arnd@arndb.de,
ijc+devicetree@hellion.org.uk, hytszk@gmail.com,
robh+dt@kernel.org, wei.qiao@spreadtrum.com,
linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, galak@codeaurora.org,
shawn.guo@linaro.org
Subject: Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support
Date: Thu, 29 Jan 2015 11:34:26 -0500 [thread overview]
Message-ID: <54CA6112.9020805@hurleysoftware.com> (raw)
In-Reply-To: <20150129160553.GC26493@n2100.arm.linux.org.uk>
On 01/29/2015 11:05 AM, Russell King - ARM Linux wrote:
> On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote:
>> Hi Varka,
>>
>> On 01/29/2015 10:26 AM, Varka Bhadram wrote:
>>> This check is not required. It will be done by devm_ioremap_resource()
>>
>> I disagree. devm_ioremap_resource() interprets the NULL resource as
>> a bad parameter and returns -EINVAL which is then forwarded as the
>> return value from the probe.
>>
>> -ENODEV is the correct return value from the probe if the expected
>> resource is not available (either because it doesn't exist or was already
>> claimed by another driver).
>
> (Adding Thierry as the author of this function.)
>
> I believe devm_ioremap_resource() was explicitly designed to remove such
> error handling from drivers, and to give drivers a unified error response
> to such things as missing resources.
>
> See the comments for this function in lib/devres.c.
Maybe the purpose would be better served by wrapping the idiom in a single
function.
Regards,
Peter Hurley
WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
To: Russell King - ARM Linux
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Varka Bhadram
<varkabhadram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Chunyan Zhang
<chunyan.zhang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
andrew-g2DYL2Zd6BY@public.gmane.org,
jslaby-AlSwsSmVLrQ@public.gmane.org,
lanqing.liu-lxIno14LUO0EEoCn2XhGlw@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
zhang.lyra-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
zhizhou.zhang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org,
geng.ren-lxIno14LUO0EEoCn2XhGlw@public.gmane.org,
antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
orsonzhai-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
florian.vaussard-p8DiymsW2f8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
hytszk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
wei.qiao-lxIno14LUO0EEoCn2XhGlw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support
Date: Thu, 29 Jan 2015 11:34:26 -0500 [thread overview]
Message-ID: <54CA6112.9020805@hurleysoftware.com> (raw)
In-Reply-To: <20150129160553.GC26493-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On 01/29/2015 11:05 AM, Russell King - ARM Linux wrote:
> On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote:
>> Hi Varka,
>>
>> On 01/29/2015 10:26 AM, Varka Bhadram wrote:
>>> This check is not required. It will be done by devm_ioremap_resource()
>>
>> I disagree. devm_ioremap_resource() interprets the NULL resource as
>> a bad parameter and returns -EINVAL which is then forwarded as the
>> return value from the probe.
>>
>> -ENODEV is the correct return value from the probe if the expected
>> resource is not available (either because it doesn't exist or was already
>> claimed by another driver).
>
> (Adding Thierry as the author of this function.)
>
> I believe devm_ioremap_resource() was explicitly designed to remove such
> error handling from drivers, and to give drivers a unified error response
> to such things as missing resources.
>
> See the comments for this function in lib/devres.c.
Maybe the purpose would be better served by wrapping the idiom in a single
function.
Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support
Date: Thu, 29 Jan 2015 11:34:26 -0500 [thread overview]
Message-ID: <54CA6112.9020805@hurleysoftware.com> (raw)
In-Reply-To: <20150129160553.GC26493@n2100.arm.linux.org.uk>
On 01/29/2015 11:05 AM, Russell King - ARM Linux wrote:
> On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote:
>> Hi Varka,
>>
>> On 01/29/2015 10:26 AM, Varka Bhadram wrote:
>>> This check is not required. It will be done by devm_ioremap_resource()
>>
>> I disagree. devm_ioremap_resource() interprets the NULL resource as
>> a bad parameter and returns -EINVAL which is then forwarded as the
>> return value from the probe.
>>
>> -ENODEV is the correct return value from the probe if the expected
>> resource is not available (either because it doesn't exist or was already
>> claimed by another driver).
>
> (Adding Thierry as the author of this function.)
>
> I believe devm_ioremap_resource() was explicitly designed to remove such
> error handling from drivers, and to give drivers a unified error response
> to such things as missing resources.
>
> See the comments for this function in lib/devres.c.
Maybe the purpose would be better served by wrapping the idiom in a single
function.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-01-29 16:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <sc9836-serial-v10>
2015-01-28 11:08 ` [PATCH v10 0/2] Add Spreadtrum SoC bindings and serial driver support Chunyan Zhang
2015-01-28 11:08 ` Chunyan Zhang
2015-01-28 11:08 ` Chunyan Zhang
2015-01-28 11:08 ` [PATCH v10 1/2] Documentation: DT: Add bindings for Spreadtrum SoC Platform Chunyan Zhang
2015-01-28 11:08 ` Chunyan Zhang
2015-01-28 11:08 ` Chunyan Zhang
2015-01-28 11:08 ` [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support Chunyan Zhang
2015-01-28 11:08 ` Chunyan Zhang
2015-01-28 11:08 ` Chunyan Zhang
2015-01-29 15:26 ` Varka Bhadram
2015-01-29 15:26 ` Varka Bhadram
2015-01-29 15:32 ` Varka Bhadram
2015-01-29 15:32 ` Varka Bhadram
2015-01-29 15:32 ` Varka Bhadram
2015-01-29 15:49 ` Peter Hurley
2015-01-29 15:49 ` Peter Hurley
2015-01-29 15:49 ` Peter Hurley
2015-01-29 16:04 ` Varka Bhadram
2015-01-29 16:16 ` Peter Hurley
2015-01-29 16:16 ` Peter Hurley
2015-01-29 16:16 ` Peter Hurley
2015-01-29 16:05 ` Russell King - ARM Linux
2015-01-29 16:05 ` Russell King - ARM Linux
2015-01-29 16:05 ` Russell King - ARM Linux
2015-01-29 16:34 ` Peter Hurley [this message]
2015-01-29 16:34 ` Peter Hurley
2015-01-29 16:34 ` Peter Hurley
2015-01-30 10:18 ` Thierry Reding
2015-01-30 10:18 ` Thierry Reding
2015-01-30 10:18 ` Thierry Reding
2015-01-30 12:03 ` Peter Hurley
2015-01-30 12:03 ` Peter Hurley
2015-01-30 12:03 ` Peter Hurley
2015-01-30 14:08 ` Russell King - ARM Linux
2015-01-30 14:08 ` Russell King - ARM Linux
2015-01-30 14:08 ` Russell King - ARM Linux
2015-01-30 15:32 ` Peter Hurley
2015-01-30 15:32 ` Peter Hurley
2015-01-30 15:49 ` Russell King - ARM Linux
2015-01-30 15:49 ` Russell King - ARM Linux
2015-01-30 15:49 ` Russell King - ARM Linux
2015-01-30 15:59 ` Peter Hurley
2015-01-30 15:59 ` Peter Hurley
2015-01-30 15:59 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA6112.9020805@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=andrew@lunn.ch \
--cc=antonynpavlov@gmail.com \
--cc=arnd@arndb.de \
--cc=chunyan.zhang@spreadtrum.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=geng.ren@spreadtrum.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hytszk@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jslaby@suse.cz \
--cc=lanqing.liu@spreadtrum.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=varkabhadram@gmail.com \
--cc=wei.qiao@spreadtrum.com \
--cc=zhang.lyra@gmail.com \
--cc=zhizhou.zhang@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.