From: Ian Abbott <abbotti@mev.co.uk>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fred Akers <knivey@botops.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used
Date: Fri, 30 Jan 2015 10:29:44 +0000 [thread overview]
Message-ID: <54CB5D18.8020001@mev.co.uk> (raw)
In-Reply-To: <1422570895-9239-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 29/01/15 22:34, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/addi_apci_3501.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
> index a726efc..5961f19 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
> @@ -267,7 +267,6 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> struct apci3501_private *devpriv = dev->private;
> unsigned int ui_Timer_AOWatchdog;
> unsigned long ul_Command1;
> - int i_temp;
>
> /* Disable Interrupt */
> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> @@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
> outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
> - i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> + inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
>
> return IRQ_HANDLED;
> }
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-01-30 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 22:34 [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used Rickard Strandqvist
2015-01-30 10:29 ` Ian Abbott [this message]
2015-01-30 12:10 ` Dan Carpenter
2015-01-30 13:16 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CB5D18.8020001@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=knivey@botops.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.