* [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used
@ 2015-01-29 22:34 Rickard Strandqvist
2015-01-30 10:29 ` Ian Abbott
0 siblings, 1 reply; 4+ messages in thread
From: Rickard Strandqvist @ 2015-01-29 22:34 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten
Cc: Rickard Strandqvist, Greg Kroah-Hartman, Fred Akers, devel, linux-kernel
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/comedi/drivers/addi_apci_3501.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
index a726efc..5961f19 100644
--- a/drivers/staging/comedi/drivers/addi_apci_3501.c
+++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
@@ -267,7 +267,6 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
struct apci3501_private *devpriv = dev->private;
unsigned int ui_Timer_AOWatchdog;
unsigned long ul_Command1;
- int i_temp;
/* Disable Interrupt */
ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
- i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
+ inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
return IRQ_HANDLED;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used
2015-01-29 22:34 [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used Rickard Strandqvist
@ 2015-01-30 10:29 ` Ian Abbott
2015-01-30 12:10 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Ian Abbott @ 2015-01-30 10:29 UTC (permalink / raw)
To: Rickard Strandqvist, H Hartley Sweeten
Cc: Greg Kroah-Hartman, Fred Akers, devel, linux-kernel
On 29/01/15 22:34, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/addi_apci_3501.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
> index a726efc..5961f19 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
> @@ -267,7 +267,6 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> struct apci3501_private *devpriv = dev->private;
> unsigned int ui_Timer_AOWatchdog;
> unsigned long ul_Command1;
> - int i_temp;
>
> /* Disable Interrupt */
> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> @@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
> outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
> - i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> + inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
>
> return IRQ_HANDLED;
> }
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used
2015-01-30 10:29 ` Ian Abbott
@ 2015-01-30 12:10 ` Dan Carpenter
2015-01-30 13:16 ` Ian Abbott
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2015-01-30 12:10 UTC (permalink / raw)
To: Ian Abbott
Cc: Rickard Strandqvist, H Hartley Sweeten, devel,
Greg Kroah-Hartman, linux-kernel, Fred Akers
On Fri, Jan 30, 2015 at 10:29:44AM +0000, Ian Abbott wrote:
> >@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> > ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> > ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
> > outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
> >- i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> >+ inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
> >
> > return IRQ_HANDLED;
> > }
> >
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Ian, is the inl() really needed? Richard did the conservative thing,
but if we knew we could delete the inl() that would be nice.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used
2015-01-30 12:10 ` Dan Carpenter
@ 2015-01-30 13:16 ` Ian Abbott
0 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2015-01-30 13:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Rickard Strandqvist, H Hartley Sweeten, devel,
Greg Kroah-Hartman, linux-kernel, Fred Akers
On 30/01/15 12:10, Dan Carpenter wrote:
> On Fri, Jan 30, 2015 at 10:29:44AM +0000, Ian Abbott wrote:
>>> @@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
>>> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
>>> ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
>>> outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
>>> - i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
>>> + inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
>>>
>>> return IRQ_HANDLED;
>>> }
>>>
>>
>> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
> Ian, is the inl() really needed? Richard did the conservative thing,
> but if we knew we could delete the inl() that would be nice.
I'm not sure if it's really needed, but it is part of some watchdog
functionality, so I thought it best to leave it alone.
Hartley might know if it's needed.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-30 13:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 22:34 [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used Rickard Strandqvist
2015-01-30 10:29 ` Ian Abbott
2015-01-30 12:10 ` Dan Carpenter
2015-01-30 13:16 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.