All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Zhang Yanfei <zhangyanfei.ok@hotmail.com>,
	Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>,
	David Rientjes <rientjes@google.com>,
	Rik van Riel <riel@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 2/4] mm/compaction: stop the isolation when we isolate enough freepage
Date: Sat, 31 Jan 2015 09:31:57 +0100	[thread overview]
Message-ID: <54CC92FD.5000601@suse.cz> (raw)
In-Reply-To: <BLU436-SMTP105DFBF63EAF672F3272FFA833E0@phx.gbl>

On 01/31/2015 08:49 AM, Zhang Yanfei wrote:
> Hello,
> 
> At 2015/1/30 20:34, Joonsoo Kim wrote:
>
> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> 
> IMHO, the patch making the free scanner move slower makes both scanners
> meet further. Before this patch, if we isolate too many free pages and even 
> after we release the unneeded free pages later the free scanner still already
> be there and will be moved forward again next time -- the free scanner just
> cannot be moved back to grab the free pages we released before no matter where
> the free pages in, pcp or buddy. 

It can be actually moved back. If we are releasing free pages, it means the
current compaction is terminating, and it will set zone->compact_cached_free_pfn
back to the position of the released free page that was furthest back. The next
compaction will start from the cached free pfn.

It is however possible that another compaction runs in parallel and has
progressed further and overwrites the cached free pfn.



WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Zhang Yanfei <zhangyanfei.ok@hotmail.com>,
	Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>,
	David Rientjes <rientjes@google.com>,
	Rik van Riel <riel@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 2/4] mm/compaction: stop the isolation when we isolate enough freepage
Date: Sat, 31 Jan 2015 09:31:57 +0100	[thread overview]
Message-ID: <54CC92FD.5000601@suse.cz> (raw)
In-Reply-To: <BLU436-SMTP105DFBF63EAF672F3272FFA833E0@phx.gbl>

On 01/31/2015 08:49 AM, Zhang Yanfei wrote:
> Hello,
> 
> At 2015/1/30 20:34, Joonsoo Kim wrote:
>
> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> 
> IMHO, the patch making the free scanner move slower makes both scanners
> meet further. Before this patch, if we isolate too many free pages and even 
> after we release the unneeded free pages later the free scanner still already
> be there and will be moved forward again next time -- the free scanner just
> cannot be moved back to grab the free pages we released before no matter where
> the free pages in, pcp or buddy. 

It can be actually moved back. If we are releasing free pages, it means the
current compaction is terminating, and it will set zone->compact_cached_free_pfn
back to the position of the released free page that was furthest back. The next
compaction will start from the cached free pfn.

It is however possible that another compaction runs in parallel and has
progressed further and overwrites the cached free pfn.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-01-31  8:32 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 12:34 [PATCH v2 0/4] enhance compaction success rate Joonsoo Kim
2015-01-30 12:34 ` Joonsoo Kim
2015-01-30 12:34 ` [PATCH v2 1/4] mm/compaction: fix wrong order check in compact_finished() Joonsoo Kim
2015-01-30 12:34   ` Joonsoo Kim
2015-01-30 12:34   ` Joonsoo Kim
2015-01-30 13:27   ` Vlastimil Babka
2015-01-30 13:27     ` Vlastimil Babka
2015-01-31  7:38   ` Zhang Yanfei
2015-01-31  7:38     ` Zhang Yanfei
2015-01-30 12:34 ` [PATCH v2 2/4] mm/compaction: stop the isolation when we isolate enough freepage Joonsoo Kim
2015-01-30 12:34   ` Joonsoo Kim
2015-01-30 13:47   ` Vlastimil Babka
2015-01-30 13:47     ` Vlastimil Babka
2015-01-31  7:49   ` Zhang Yanfei
2015-01-31  7:49     ` Zhang Yanfei
2015-01-31  8:31     ` Vlastimil Babka [this message]
2015-01-31  8:31       ` Vlastimil Babka
2015-01-31 10:17       ` Zhang Yanfei
2015-01-31 10:17         ` Zhang Yanfei
2015-01-30 12:34 ` [PATCH v2 3/4] mm/page_alloc: separate steal decision from steal behaviour part Joonsoo Kim
2015-01-30 12:34   ` Joonsoo Kim
2015-01-30 14:27   ` Vlastimil Babka
2015-01-30 14:27     ` Vlastimil Babka
2015-02-02  7:02     ` Joonsoo Kim
2015-02-02  7:02       ` Joonsoo Kim
2015-01-31 12:38   ` Zhang Yanfei
2015-01-31 12:38     ` Zhang Yanfei
2015-02-02  7:03     ` Joonsoo Kim
2015-02-02  7:03       ` Joonsoo Kim
2015-01-30 12:34 ` [PATCH v2 4/4] mm/compaction: enhance compaction finish condition Joonsoo Kim
2015-01-30 12:34   ` Joonsoo Kim
2015-01-30 14:43   ` Vlastimil Babka
2015-01-30 14:43     ` Vlastimil Babka
2015-02-02  7:11     ` Joonsoo Kim
2015-02-02  7:11       ` Joonsoo Kim
2015-01-31 15:58   ` Zhang Yanfei
2015-01-31 15:58     ` Zhang Yanfei
2015-02-02  7:12     ` Joonsoo Kim
2015-02-02  7:12       ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CC92FD.5000601@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=zhangyanfei.ok@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.