[PATCH] iio: ad5686: fix optional reference voltage declaration

[PATCH] iio: ad5686: fix optional reference voltage declaration

[Urs Fässler]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

When not using the "_optional" function, a dummy regulator is returned
and the driver fails to initialize.

Signed-off-by: Urs Fässler <urs.fassler@bytesatwork.ch>
---
 drivers/iio/dac/ad5686.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index f57562a..15c73e2 100644
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -322,7 +322,7 @@ static int ad5686_probe(struct spi_device *spi)
 	st = iio_priv(indio_dev);
 	spi_set_drvdata(spi, indio_dev);
 -	st->reg = devm_regulator_get(&spi->dev, "vcc");
+	st->reg = devm_regulator_get_optional(&spi->dev, "vcc");
 	if (!IS_ERR(st->reg)) {
 		ret = regulator_enable(st->reg);
 		if (ret)
-- 
2.1.4



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] iio: ad5686: fix optional reference voltage declaration

[Lars-Peter Clausen]

On 02/02/2015 05:12 PM, Urs Fässler wrote:
> When not using the "_optional" function, a dummy regulator is returned
> and the driver fails to initialize.
>
> Signed-off-by: Urs Fässler <urs.fassler@bytesatwork.ch>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

Added Jonathan to Cc.

Re: [PATCH] iio: ad5686: fix optional reference voltage declaration

[Jonathan Cameron]

On 02/02/15 17:47, Lars-Peter Clausen wrote:
> On 02/02/2015 05:12 PM, Urs Fässler wrote:
>> When not using the "_optional" function, a dummy regulator is returned
>> and the driver fails to initialize.
>>
>> Signed-off-by: Urs Fässler <urs.fassler@bytesatwork.ch>
> 
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> 
> Thanks.
> 
> Added Jonathan to Cc.
Applied to fixes-togreg (will hit git.kernel.org at the weekend
as I am travelling, and Greg / Mainline after the merge window)
Marked for stable.

Jonathan