All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Tomeu Vizoso
	<tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Javier Martinez Canillas
	<javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
	Dylan Reid <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Andrew Bresticker
	<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 01/10] ARM: tegra: Set the sound card model that alsaucm expects
Date: Mon, 02 Feb 2015 14:08:36 -0700	[thread overview]
Message-ID: <54CFE754.7000500@wwwdotorg.org> (raw)
In-Reply-To: <1422442278-10405-2-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>

On 01/28/2015 03:50 AM, Tomeu Vizoso wrote:
> Patches are on its way to add a config file to alsaucm for the Nyan
> boards. Use the same card ID that alsaucm will expect.

> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts

>   	sound {
> -		compatible = "nvidia,tegra-audio-max98090-nyan-big",
> +		compatible = "nvidia,tegra-audio-max98090-nyan",
>   			     "nvidia,tegra-audio-max98090";

I'm not convinced that removing the board-specific compatible value is a 
great idea. What if we find we need to distinguish between different 
boards that use this same binding in the future. That situation is 
exactly why we have board-/SoC-specific values in compatible even if we 
don't immediately use them.

> -		nvidia,model = "Acer Chromebook 13";
> +		nvidia,model = "GoogleNyan";

I believe this also technically breaks ABI, since some user-space tools 
use the model to look up saved state. Can we not leave this as is, and 
just have the UCM files know about both names?

Aside from that, I think the series looks OK at a quick glance.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>, linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Dylan Reid <dgreid@chromium.org>,
	Andrew Bresticker <abrestic@chromium.org>,
	Simon Glass <sjg@chromium.org>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 01/10] ARM: tegra: Set the sound card model that alsaucm expects
Date: Mon, 02 Feb 2015 14:08:36 -0700	[thread overview]
Message-ID: <54CFE754.7000500@wwwdotorg.org> (raw)
In-Reply-To: <1422442278-10405-2-git-send-email-tomeu.vizoso@collabora.com>

On 01/28/2015 03:50 AM, Tomeu Vizoso wrote:
> Patches are on its way to add a config file to alsaucm for the Nyan
> boards. Use the same card ID that alsaucm will expect.

> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts

>   	sound {
> -		compatible = "nvidia,tegra-audio-max98090-nyan-big",
> +		compatible = "nvidia,tegra-audio-max98090-nyan",
>   			     "nvidia,tegra-audio-max98090";

I'm not convinced that removing the board-specific compatible value is a 
great idea. What if we find we need to distinguish between different 
boards that use this same binding in the future. That situation is 
exactly why we have board-/SoC-specific values in compatible even if we 
don't immediately use them.

> -		nvidia,model = "Acer Chromebook 13";
> +		nvidia,model = "GoogleNyan";

I believe this also technically breaks ABI, since some user-space tools 
use the model to look up saved state. Can we not leave this as is, and 
just have the UCM files know about both names?

Aside from that, I think the series looks OK at a quick glance.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/10] ARM: tegra: Set the sound card model that alsaucm expects
Date: Mon, 02 Feb 2015 14:08:36 -0700	[thread overview]
Message-ID: <54CFE754.7000500@wwwdotorg.org> (raw)
In-Reply-To: <1422442278-10405-2-git-send-email-tomeu.vizoso@collabora.com>

On 01/28/2015 03:50 AM, Tomeu Vizoso wrote:
> Patches are on its way to add a config file to alsaucm for the Nyan
> boards. Use the same card ID that alsaucm will expect.

> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts

>   	sound {
> -		compatible = "nvidia,tegra-audio-max98090-nyan-big",
> +		compatible = "nvidia,tegra-audio-max98090-nyan",
>   			     "nvidia,tegra-audio-max98090";

I'm not convinced that removing the board-specific compatible value is a 
great idea. What if we find we need to distinguish between different 
boards that use this same binding in the future. That situation is 
exactly why we have board-/SoC-specific values in compatible even if we 
don't immediately use them.

> -		nvidia,model = "Acer Chromebook 13";
> +		nvidia,model = "GoogleNyan";

I believe this also technically breaks ABI, since some user-space tools 
use the model to look up saved state. Can we not leave this as is, and 
just have the UCM files know about both names?

Aside from that, I think the series looks OK at a quick glance.

  parent reply	other threads:[~2015-02-02 21:08 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 10:50 [PATCH v3 00/10] Improvements to Tegra-based Chromebook support Tomeu Vizoso
2015-01-28 10:50 ` Tomeu Vizoso
2015-01-28 10:50 ` Tomeu Vizoso
2015-01-28 10:50 ` [PATCH v3 01/10] ARM: tegra: Set the sound card model that alsaucm expects Tomeu Vizoso
2015-01-28 10:50   ` Tomeu Vizoso
2015-01-28 10:50   ` Tomeu Vizoso
     [not found]   ` <1422442278-10405-2-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2015-02-02 21:08     ` Stephen Warren [this message]
2015-02-02 21:08       ` Stephen Warren
2015-02-02 21:08       ` Stephen Warren
     [not found]       ` <54CFE754.7000500-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-02-03 13:13         ` Tomeu Vizoso
2015-02-03 13:13           ` Tomeu Vizoso
2015-02-03 13:13           ` Tomeu Vizoso
     [not found]           ` <CAAObsKCm-9GOvis=MZ-nyA0N+g_ZuWYUfDSdEcVy5p5ykCmkcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-03 16:35             ` Stephen Warren
2015-02-03 16:35               ` Stephen Warren
2015-02-03 16:35               ` Stephen Warren
     [not found]               ` <54D0F8E3.3020902-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-02-04  9:13                 ` Tomeu Vizoso
2015-02-04  9:13                   ` Tomeu Vizoso
2015-02-04  9:13                   ` Tomeu Vizoso
     [not found]                   ` <54D1E2B6.4050004-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2015-02-04 16:56                     ` Stephen Warren
2015-02-04 16:56                       ` Stephen Warren
2015-02-04 16:56                       ` Stephen Warren
2015-01-28 10:51 ` [PATCH v3 02/10] ARM: tegra: Move out nyan-generic parts out from the nyan-big DT Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 03/10] drm/panel: add support for Samsung LTN140AT29 panel Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 04/10] ARM: tegra: Add DTS for the nyan-blaze board Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 05/10] ARM: tegra: Add node for trackpad in Nyan boards Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 06/10] ASoC: tegra: Add a control for the headphone switch Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 11:02   ` Mark Brown
2015-01-28 11:02     ` Mark Brown
2015-01-28 17:46     ` Dylan Reid
2015-01-28 17:46       ` Dylan Reid
2015-01-28 18:24       ` Mark Brown
2015-01-28 18:24         ` Mark Brown
2015-01-28 10:51 ` [PATCH v3 07/10] ASoC: tegra: add sink for the internal mic to tegra_max98090 Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 17:15   ` Mark Brown
2015-01-28 17:15     ` Mark Brown
2015-01-28 10:51 ` [PATCH v3 08/10] ARM: tegra: Use pwrseq-simple for the wifi in Nyan Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 09/10] ARM: tegra: Use the generated pinmux data Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51 ` [PATCH v3 10/10] ARM: tegra: Set spi-max-frequency property to flash node Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso
2015-01-28 10:51   ` Tomeu Vizoso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CFE754.7000500@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.