* [PATCH] xfs: fix panic_mask documentation
@ 2015-02-03 16:33 Eric Sandeen
2015-02-05 14:08 ` Brian Foster
2015-02-05 16:44 ` [PATCH V2] " Eric Sandeen
0 siblings, 2 replies; 4+ messages in thread
From: Eric Sandeen @ 2015-02-03 16:33 UTC (permalink / raw)
To: xfs-oss
This bit of the docs didn't quite reflect reality.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt
index 5be51fd..157d440 100644
--- a/Documentation/filesystems/xfs.txt
+++ b/Documentation/filesystems/xfs.txt
@@ -287,7 +287,7 @@ The following sysctls are available for the XFS filesystem:
XFS_ERRLEVEL_LOW: 1
XFS_ERRLEVEL_HIGH: 5
- fs.xfs.panic_mask (Min: 0 Default: 0 Max: 127)
+ fs.xfs.panic_mask (Min: 0 Default: 0 Max: 255)
Causes certain error conditions to call BUG(). Value is a bitmask;
AND together the tags which represent errors which should cause panics:
@@ -299,6 +299,7 @@ The following sysctls are available for the XFS filesystem:
XFS_PTAG_SHUTDOWN_CORRUPT 0x00000010
XFS_PTAG_SHUTDOWN_IOERROR 0x00000020
XFS_PTAG_SHUTDOWN_LOGERROR 0x00000040
+ XFS_PTAG_FSBLOCK_ZERO 0x00000080
This option is intended for debugging only.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: fix panic_mask documentation
2015-02-03 16:33 [PATCH] xfs: fix panic_mask documentation Eric Sandeen
@ 2015-02-05 14:08 ` Brian Foster
2015-02-05 16:44 ` [PATCH V2] " Eric Sandeen
1 sibling, 0 replies; 4+ messages in thread
From: Brian Foster @ 2015-02-05 14:08 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Tue, Feb 03, 2015 at 10:33:28AM -0600, Eric Sandeen wrote:
> This bit of the docs didn't quite reflect reality.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt
> index 5be51fd..157d440 100644
> --- a/Documentation/filesystems/xfs.txt
> +++ b/Documentation/filesystems/xfs.txt
> @@ -287,7 +287,7 @@ The following sysctls are available for the XFS filesystem:
> XFS_ERRLEVEL_LOW: 1
> XFS_ERRLEVEL_HIGH: 5
>
> - fs.xfs.panic_mask (Min: 0 Default: 0 Max: 127)
> + fs.xfs.panic_mask (Min: 0 Default: 0 Max: 255)
> Causes certain error conditions to call BUG(). Value is a bitmask;
> AND together the tags which represent errors which should cause panics:
Looks good, though shouldn't the above say "OR together the tags ..?"
Brian
>
> @@ -299,6 +299,7 @@ The following sysctls are available for the XFS filesystem:
> XFS_PTAG_SHUTDOWN_CORRUPT 0x00000010
> XFS_PTAG_SHUTDOWN_IOERROR 0x00000020
> XFS_PTAG_SHUTDOWN_LOGERROR 0x00000040
> + XFS_PTAG_FSBLOCK_ZERO 0x00000080
>
> This option is intended for debugging only.
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V2] xfs: fix panic_mask documentation
2015-02-03 16:33 [PATCH] xfs: fix panic_mask documentation Eric Sandeen
2015-02-05 14:08 ` Brian Foster
@ 2015-02-05 16:44 ` Eric Sandeen
2015-02-05 22:05 ` Brian Foster
1 sibling, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2015-02-05 16:44 UTC (permalink / raw)
To: xfs-oss
This bit of the docs didn't quite reflect reality.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: s/AND/OR/
diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt
index 5be51fd..2e56845 100644
--- a/Documentation/filesystems/xfs.txt
+++ b/Documentation/filesystems/xfs.txt
@@ -287,9 +287,9 @@ The following sysctls are available for the XFS filesystem:
XFS_ERRLEVEL_LOW: 1
XFS_ERRLEVEL_HIGH: 5
- fs.xfs.panic_mask (Min: 0 Default: 0 Max: 127)
+ fs.xfs.panic_mask (Min: 0 Default: 0 Max: 255)
Causes certain error conditions to call BUG(). Value is a bitmask;
- AND together the tags which represent errors which should cause panics:
+ OR together the tags which represent errors which should cause panics:
XFS_NO_PTAG 0
XFS_PTAG_IFLUSH 0x00000001
@@ -299,6 +299,7 @@ The following sysctls are available for the XFS filesystem:
XFS_PTAG_SHUTDOWN_CORRUPT 0x00000010
XFS_PTAG_SHUTDOWN_IOERROR 0x00000020
XFS_PTAG_SHUTDOWN_LOGERROR 0x00000040
+ XFS_PTAG_FSBLOCK_ZERO 0x00000080
This option is intended for debugging only.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2] xfs: fix panic_mask documentation
2015-02-05 16:44 ` [PATCH V2] " Eric Sandeen
@ 2015-02-05 22:05 ` Brian Foster
0 siblings, 0 replies; 4+ messages in thread
From: Brian Foster @ 2015-02-05 22:05 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Feb 05, 2015 at 10:44:49AM -0600, Eric Sandeen wrote:
> This bit of the docs didn't quite reflect reality.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> V2: s/AND/OR/
>
> diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt
> index 5be51fd..2e56845 100644
> --- a/Documentation/filesystems/xfs.txt
> +++ b/Documentation/filesystems/xfs.txt
> @@ -287,9 +287,9 @@ The following sysctls are available for the XFS filesystem:
> XFS_ERRLEVEL_LOW: 1
> XFS_ERRLEVEL_HIGH: 5
>
> - fs.xfs.panic_mask (Min: 0 Default: 0 Max: 127)
> + fs.xfs.panic_mask (Min: 0 Default: 0 Max: 255)
> Causes certain error conditions to call BUG(). Value is a bitmask;
> - AND together the tags which represent errors which should cause panics:
> + OR together the tags which represent errors which should cause panics:
>
> XFS_NO_PTAG 0
> XFS_PTAG_IFLUSH 0x00000001
> @@ -299,6 +299,7 @@ The following sysctls are available for the XFS filesystem:
> XFS_PTAG_SHUTDOWN_CORRUPT 0x00000010
> XFS_PTAG_SHUTDOWN_IOERROR 0x00000020
> XFS_PTAG_SHUTDOWN_LOGERROR 0x00000040
> + XFS_PTAG_FSBLOCK_ZERO 0x00000080
>
> This option is intended for debugging only.
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-05 22:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-03 16:33 [PATCH] xfs: fix panic_mask documentation Eric Sandeen
2015-02-05 14:08 ` Brian Foster
2015-02-05 16:44 ` [PATCH V2] " Eric Sandeen
2015-02-05 22:05 ` Brian Foster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.