* [PATCH -next] ARC: Fix earlycon build breakage
@ 2015-02-04 1:08 Peter Hurley
2015-02-04 1:16 ` Greg Kroah-Hartman
2015-02-04 5:15 ` Vineet Gupta
0 siblings, 2 replies; 5+ messages in thread
From: Peter Hurley @ 2015-02-04 1:08 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-next, linux-kernel, Stephen Rothwell, Vineet Gupta,
Guenter Roeck, Peter Hurley
Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
breaks arc:defconfig build:
drivers/built-in.o: In function `of_setup_earlycon':
(.init.text+0xb3e): undefined reference to `arc_early_base_baud'
drivers/built-in.o: In function `setup_earlycon':
(.init.text+0xcd0): undefined reference to `arc_early_base_baud'
make: *** [vmlinux] Error 1
BASE_BAUD is only required for earlycon, which should depend on
CONFIG_SERIAL_EARLYCON.
Reported-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
arch/arc/kernel/devtree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c
index 5036d4c..e32b54a 100644
--- a/arch/arc/kernel/devtree.c
+++ b/arch/arc/kernel/devtree.c
@@ -17,7 +17,7 @@
#include <asm/clk.h>
#include <asm/mach_desc.h>
-#ifdef CONFIG_SERIAL_8250_CONSOLE
+#ifdef CONFIG_SERIAL_EARLYCON
static unsigned int __initdata arc_base_baud;
--
2.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] ARC: Fix earlycon build breakage
2015-02-04 1:08 [PATCH -next] ARC: Fix earlycon build breakage Peter Hurley
@ 2015-02-04 1:16 ` Greg Kroah-Hartman
2015-02-04 1:21 ` Peter Hurley
2015-02-04 2:27 ` Stephen Rothwell
2015-02-04 5:15 ` Vineet Gupta
1 sibling, 2 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-02-04 1:16 UTC (permalink / raw)
To: Peter Hurley
Cc: linux-next, linux-kernel, Stephen Rothwell, Vineet Gupta, Guenter Roeck
On Tue, Feb 03, 2015 at 08:08:52PM -0500, Peter Hurley wrote:
> Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
> breaks arc:defconfig build:
I don't see that commit id in my trees, so why send this to me? Where
did you find it?
confused,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] ARC: Fix earlycon build breakage
2015-02-04 1:16 ` Greg Kroah-Hartman
@ 2015-02-04 1:21 ` Peter Hurley
2015-02-04 2:27 ` Stephen Rothwell
1 sibling, 0 replies; 5+ messages in thread
From: Peter Hurley @ 2015-02-04 1:21 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-next, linux-kernel, Stephen Rothwell, Vineet Gupta, Guenter Roeck
On 02/03/2015 08:16 PM, Greg Kroah-Hartman wrote:
> On Tue, Feb 03, 2015 at 08:08:52PM -0500, Peter Hurley wrote:
>> Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
>> breaks arc:defconfig build:
>
> I don't see that commit id in my trees, so why send this to me?
Sorry. The earlier version of this patch was originally submitted to you,
but I forgot that since all the tty parts were cut out (at my urging :/),
it went through Vineet's tree directly.
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] ARC: Fix earlycon build breakage
2015-02-04 1:16 ` Greg Kroah-Hartman
2015-02-04 1:21 ` Peter Hurley
@ 2015-02-04 2:27 ` Stephen Rothwell
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2015-02-04 2:27 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Peter Hurley, linux-next, linux-kernel, Vineet Gupta, Guenter Roeck
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Hi Greg,
On Tue, 3 Feb 2015 17:16:35 -0800 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Feb 03, 2015 at 08:08:52PM -0500, Peter Hurley wrote:
> > Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
> > breaks arc:defconfig build:
>
> I don't see that commit id in my trees, so why send this to me? Where
> did you find it?
It comes from the arc tree. So, yes, not your concern.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] ARC: Fix earlycon build breakage
2015-02-04 1:08 [PATCH -next] ARC: Fix earlycon build breakage Peter Hurley
2015-02-04 1:16 ` Greg Kroah-Hartman
@ 2015-02-04 5:15 ` Vineet Gupta
1 sibling, 0 replies; 5+ messages in thread
From: Vineet Gupta @ 2015-02-04 5:15 UTC (permalink / raw)
To: Peter Hurley, Greg Kroah-Hartman
Cc: linux-next, linux-kernel, Stephen Rothwell, Vineet Gupta, Guenter Roeck
On Wednesday 04 February 2015 06:39 AM, Peter Hurley wrote:
> Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
> breaks arc:defconfig build:
>
> drivers/built-in.o: In function `of_setup_earlycon':
> (.init.text+0xb3e): undefined reference to `arc_early_base_baud'
> drivers/built-in.o: In function `setup_earlycon':
> (.init.text+0xcd0): undefined reference to `arc_early_base_baud'
> make: *** [vmlinux] Error 1
>
> BASE_BAUD is only required for earlycon, which should depend on
> CONFIG_SERIAL_EARLYCON.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
/Me slaps myself :-(
Thx for the quick fix Peter. Now applied to my for-next and also quickly tested on
simulator.
FWIW, the issue came about because defconfig doesn't use the 8250 uart driver,
rather the legacy arc uart which still uses earlycon - but I still can't fathom
why i didn't see it earlier.
Thx,
-Vineet
> ---
> arch/arc/kernel/devtree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c
> index 5036d4c..e32b54a 100644
> --- a/arch/arc/kernel/devtree.c
> +++ b/arch/arc/kernel/devtree.c
> @@ -17,7 +17,7 @@
> #include <asm/clk.h>
> #include <asm/mach_desc.h>
>
> -#ifdef CONFIG_SERIAL_8250_CONSOLE
> +#ifdef CONFIG_SERIAL_EARLYCON
>
> static unsigned int __initdata arc_base_baud;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-04 5:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04 1:08 [PATCH -next] ARC: Fix earlycon build breakage Peter Hurley
2015-02-04 1:16 ` Greg Kroah-Hartman
2015-02-04 1:21 ` Peter Hurley
2015-02-04 2:27 ` Stephen Rothwell
2015-02-04 5:15 ` Vineet Gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.