All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: allow CFLAGS specification in new build
@ 2015-02-05 20:31 Eric Sandeen
  2015-02-05 21:08 ` Eric Sandeen
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2015-02-05 20:31 UTC (permalink / raw)
  To: linux-btrfs, David Sterba

Disclaimer: I am not an auto$FOO expert by any means.

But I could find no way to specify additional CFLAGS, and I think
that this is because they are hard-coded in configure.ac.

The below works for me, but I don't know if it's the right solution...

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/Makefile.in b/Makefile.in
index 93b6a3c..4a36f6a 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -12,6 +12,7 @@ DISABLE_BTRFSCONVERT = @DISABLE_BTRFSCONVERT@
 
 # Non-static compilation flags
 CFLAGS = @CFLAGS@ \
+	 -g -O1 \
 	 -include config.h -Wall \
 	 -D_FILE_OFFSET_BITS=64 -DBTRFS_FLAT_INCLUDES \
 	 -D_XOPEN_SOURCE=700  \
diff --git a/configure.ac b/configure.ac
index cbad099..f6ebb7d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8,8 +8,6 @@ LIBBTRFS_MAJOR=0
 LIBBTRFS_MINOR=1
 LIBBTRFS_PATCHLEVEL=1
 
-CFLAGS="-g -O1"
-
 AC_PREREQ([2.60])
 
 AC_CONFIG_AUX_DIR([config])


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs-progs: allow CFLAGS specification in new build
  2015-02-05 20:31 [PATCH] btrfs-progs: allow CFLAGS specification in new build Eric Sandeen
@ 2015-02-05 21:08 ` Eric Sandeen
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2015-02-05 21:08 UTC (permalink / raw)
  To: linux-btrfs, David Sterba

On 2/5/15 2:31 PM, Eric Sandeen wrote:
> Disclaimer: I am not an auto$FOO expert by any means.
> 
> But I could find no way to specify additional CFLAGS, and I think
> that this is because they are hard-coded in configure.ac.
> 
> The below works for me, but I don't know if it's the right solution...

gah, looking at the wrong branch in git.  Never mind.

-Eric


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-05 21:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 20:31 [PATCH] btrfs-progs: allow CFLAGS specification in new build Eric Sandeen
2015-02-05 21:08 ` Eric Sandeen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.