* [PATCH] ARM: EXYNOS: Use platform device name as power domain name
@ 2015-02-10 12:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-02-10 12:57 UTC (permalink / raw)
To: Kukjin Kim, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Javier Martinez Canillas, Sergei Shtylyov, Krzysztof Kozlowski
The power domain nodes in DTS may be very generic (e.g. "power-domain"
for Exynos 5420) making it very hard to debug:
$ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
domain status slaves
power-domain on
Use platform device name instead so the names will be a little more user
friendly:
domain status slaves
100440e0.power-domain on
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/mach-exynos/pm_domains.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
index 20f267121b3e..37642ea97d23 100644
--- a/arch/arm/mach-exynos/pm_domains.c
+++ b/arch/arm/mach-exynos/pm_domains.c
@@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
return -ENOMEM;
}
- pd->pd.name = kstrdup(np->name, GFP_KERNEL);
+ pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
pd->name = pd->pd.name;
pd->base = of_iomap(np, 0);
pd->pd.power_off = exynos_pd_power_off;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: EXYNOS: Use platform device name as power domain name
@ 2015-02-10 12:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-02-10 12:57 UTC (permalink / raw)
To: linux-arm-kernel
The power domain nodes in DTS may be very generic (e.g. "power-domain"
for Exynos 5420) making it very hard to debug:
$ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
domain status slaves
power-domain on
Use platform device name instead so the names will be a little more user
friendly:
domain status slaves
100440e0.power-domain on
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/mach-exynos/pm_domains.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
index 20f267121b3e..37642ea97d23 100644
--- a/arch/arm/mach-exynos/pm_domains.c
+++ b/arch/arm/mach-exynos/pm_domains.c
@@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
return -ENOMEM;
}
- pd->pd.name = kstrdup(np->name, GFP_KERNEL);
+ pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
pd->name = pd->pd.name;
pd->base = of_iomap(np, 0);
pd->pd.power_off = exynos_pd_power_off;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: EXYNOS: Use platform device name as power domain name
2015-02-10 12:57 ` Krzysztof Kozlowski
@ 2015-02-10 13:12 ` Javier Martinez Canillas
-1 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-02-10 13:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Sergei Shtylyov
Hello
Krzysztof,
On 02/10/2015 01:57 PM, Krzysztof Kozlowski wrote:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>
I would had preferred to have even more info like 100440e0.mau-power-domain.
Maybe using the OF aliases approach that Sylwester suggested? But in any case
that could be complementary to your patch.
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: EXYNOS: Use platform device name as power domain name
@ 2015-02-10 13:12 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-02-10 13:12 UTC (permalink / raw)
To: linux-arm-kernel
Hello
Krzysztof,
On 02/10/2015 01:57 PM, Krzysztof Kozlowski wrote:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>
I would had preferred to have even more info like 100440e0.mau-power-domain.
Maybe using the OF aliases approach that Sylwester suggested? But in any case
that could be complementary to your patch.
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-10 13:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-10 12:57 [PATCH] ARM: EXYNOS: Use platform device name as power domain name Krzysztof Kozlowski
2015-02-10 12:57 ` Krzysztof Kozlowski
2015-02-10 13:12 ` Javier Martinez Canillas
2015-02-10 13:12 ` Javier Martinez Canillas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.