All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning
@ 2015-02-18 11:39 Geert Uytterhoeven
  2015-02-18 12:41 ` Karol Wrona
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-02-18 11:39 UTC (permalink / raw)
  To: Karol Wrona, Jonathan Cameron, Hartmut Knaack,
	Lars-Peter Clausen, Peter Meerwald
  Cc: linux-iio, linux-kernel, Geert Uytterhoeven

If CONFIG_PM_SLEEP=n:

    drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used
    drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used

Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2:
  - Fix driver name in one-line summary
---
 drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
index 52d70435f5a11c55..55a90082a29bd484 100644
--- a/drivers/iio/common/ssp_sensors/ssp_dev.c
+++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
@@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
 	return 0;
 }
 
+#ifdef CONFIG_PM_SLEEP
 static int ssp_suspend(struct device *dev)
 {
 	int ret;
@@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
 
 	return 0;
 }
+#endif /* CONFIG_PM_SLEEP */
 
 static const struct dev_pm_ops ssp_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning
  2015-02-18 11:39 [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning Geert Uytterhoeven
@ 2015-02-18 12:41 ` Karol Wrona
  2015-02-22  9:48   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Karol Wrona @ 2015-02-18 12:41 UTC (permalink / raw)
  To: Geert Uytterhoeven, Jonathan Cameron, Hartmut Knaack,
	Lars-Peter Clausen, Peter Meerwald
  Cc: linux-iio, linux-kernel

On 02/18/2015 12:39 PM, Geert Uytterhoeven wrote:
> If CONFIG_PM_SLEEP=n:
> 
>     drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used
>     drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used
> 
> Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> v2:
>   - Fix driver name in one-line summary
> ---
>  drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> index 52d70435f5a11c55..55a90082a29bd484 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_PM_SLEEP
>  static int ssp_suspend(struct device *dev)
>  {
>  	int ret;
> @@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
>  
>  	return 0;
>  }
> +#endif /* CONFIG_PM_SLEEP */
>  
>  static const struct dev_pm_ops ssp_pm_ops = {
>  	SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
> 

Acked-by: Karol Wrona <k.wrona@samsung.com>

Thanks for doing that.
Karol

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning
  2015-02-18 12:41 ` Karol Wrona
@ 2015-02-22  9:48   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2015-02-22  9:48 UTC (permalink / raw)
  To: Karol Wrona, Geert Uytterhoeven, Hartmut Knaack,
	Lars-Peter Clausen, Peter Meerwald
  Cc: linux-iio, linux-kernel

On 18/02/15 12:41, Karol Wrona wrote:
> On 02/18/2015 12:39 PM, Geert Uytterhoeven wrote:
>> If CONFIG_PM_SLEEP=n:
>>
>>     drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used
>>     drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used
>>
>> Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>> v2:
>>   - Fix driver name in one-line summary
>> ---
>>  drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
>> index 52d70435f5a11c55..55a90082a29bd484 100644
>> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
>> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
>> @@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
>>  	return 0;
>>  }
>>  
>> +#ifdef CONFIG_PM_SLEEP
>>  static int ssp_suspend(struct device *dev)
>>  {
>>  	int ret;
>> @@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
>>  
>>  	return 0;
>>  }
>> +#endif /* CONFIG_PM_SLEEP */
>>  
>>  static const struct dev_pm_ops ssp_pm_ops = {
>>  	SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
>>
> 
> Acked-by: Karol Wrona <k.wrona@samsung.com>
Applied to the fixes-post-3.20-rc1 branch which I'll sort out once rc1 is
tagged.

Thanks,

Jonathan
> 
> Thanks for doing that.
> Karol
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-22  9:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 11:39 [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning Geert Uytterhoeven
2015-02-18 12:41 ` Karol Wrona
2015-02-22  9:48   ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.