All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: David Long <dave.long@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Russell King <linux@arm.linux.org.uk>,
	Sandeepa Prabhu <sandeepa.prabhu@linaro.org>,
	William Cohen <wcohen@redhat.com>,
	Steve Capper <steve.capper@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"Jon Medhurst (Tixy)" <tixy@linaro.org>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 6/6] kprobes: Add arm64 case in kprobe example module
Date: Thu, 19 Feb 2015 23:18:56 +0900	[thread overview]
Message-ID: <54E5F0D0.5030606@hitachi.com> (raw)
In-Reply-To: <1424214701-4899-7-git-send-email-dave.long@linaro.org>

(2015/02/18 8:11), David Long wrote:
> From: Sandeepa Prabhu <sandeepa.prabhu@linaro.org>
> 
> Add info prints in sample kprobe handlers for ARM64
> 
> Signed-off-by: Sandeepa Prabhu <sandeepa.prabhu@linaro.org>

Looks good to me:)

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks!

> ---
>  samples/kprobes/kprobe_example.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index 366db1a..51d459c 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -42,6 +42,10 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs)
>  			" ex1 = 0x%lx\n",
>  		p->addr, regs->pc, regs->ex1);
>  #endif
> +#ifdef CONFIG_ARM64
> +	pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n",
> +		p->addr, (long)regs->pc);
> +#endif
>  
>  	/* A dump_stack() here will give a stack backtrace */
>  	return 0;
> @@ -67,6 +71,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs,
>  	printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n",
>  		p->addr, regs->ex1);
>  #endif
> +#ifdef CONFIG_ARM64
> +	pr_info("post_handler: p->addr = 0x%p, pc = 0x%lx\n",
> +		p->addr, (long)regs->pc);
> +#endif
>  }
>  
>  /*
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



WARNING: multiple messages have this Message-ID (diff)
From: masami.hiramatsu.pt@hitachi.com (Masami Hiramatsu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 6/6] kprobes: Add arm64 case in kprobe example module
Date: Thu, 19 Feb 2015 23:18:56 +0900	[thread overview]
Message-ID: <54E5F0D0.5030606@hitachi.com> (raw)
In-Reply-To: <1424214701-4899-7-git-send-email-dave.long@linaro.org>

(2015/02/18 8:11), David Long wrote:
> From: Sandeepa Prabhu <sandeepa.prabhu@linaro.org>
> 
> Add info prints in sample kprobe handlers for ARM64
> 
> Signed-off-by: Sandeepa Prabhu <sandeepa.prabhu@linaro.org>

Looks good to me:)

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks!

> ---
>  samples/kprobes/kprobe_example.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index 366db1a..51d459c 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -42,6 +42,10 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs)
>  			" ex1 = 0x%lx\n",
>  		p->addr, regs->pc, regs->ex1);
>  #endif
> +#ifdef CONFIG_ARM64
> +	pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n",
> +		p->addr, (long)regs->pc);
> +#endif
>  
>  	/* A dump_stack() here will give a stack backtrace */
>  	return 0;
> @@ -67,6 +71,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs,
>  	printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n",
>  		p->addr, regs->ex1);
>  #endif
> +#ifdef CONFIG_ARM64
> +	pr_info("post_handler: p->addr = 0x%p, pc = 0x%lx\n",
> +		p->addr, (long)regs->pc);
> +#endif
>  }
>  
>  /*
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt at hitachi.com

  reply	other threads:[~2015-02-19 14:19 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 23:11 [PATCH v5 0/6] arm64: Add kernel probes (kprobes) support David Long
2015-02-17 23:11 ` David Long
2015-02-17 23:11 ` [PATCH v5 1/6] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature David Long
2015-02-17 23:11   ` David Long
2015-02-18 14:59   ` Masami Hiramatsu
2015-02-18 14:59     ` Masami Hiramatsu
2015-03-25 13:44   ` Catalin Marinas
2015-03-25 13:44     ` Catalin Marinas
2015-04-20  7:15     ` David Long
2015-04-20  7:15       ` David Long
2015-02-17 23:11 ` [PATCH v5 2/6] arm64: Add more test functions to insn.c David Long
2015-02-17 23:11   ` David Long
2015-02-18 15:00   ` Masami Hiramatsu
2015-02-18 15:00     ` Masami Hiramatsu
2015-02-17 23:11 ` [PATCH v5 3/6] arm64: Kprobes with single stepping support David Long
2015-02-17 23:11   ` David Long
2015-02-18 14:59   ` Masami Hiramatsu
2015-02-18 14:59     ` Masami Hiramatsu
2015-02-27  6:38     ` David Long
2015-02-27  6:38       ` David Long
2015-02-27  8:27       ` Masami Hiramatsu
2015-02-27  8:27         ` Masami Hiramatsu
2015-04-08  6:07   ` Pratyush Anand
2015-04-08  6:07     ` Pratyush Anand
2015-04-08 11:01     ` David Long
2015-04-08 11:01       ` David Long
2015-02-17 23:11 ` [PATCH v5 4/6] arm64: kprobes instruction simulation support David Long
2015-02-17 23:11   ` David Long
2015-03-06 11:39   ` Steve Capper
2015-03-06 11:39     ` Steve Capper
2015-03-06 14:42     ` David Long
2015-03-06 14:42       ` David Long
2015-02-17 23:11 ` [PATCH v5 5/6] arm64: Add kernel return probes support (kretprobes) David Long
2015-02-17 23:11   ` David Long
2015-02-19 14:49   ` Masami Hiramatsu
2015-02-19 14:49     ` Masami Hiramatsu
2015-02-17 23:11 ` [PATCH v5 6/6] kprobes: Add arm64 case in kprobe example module David Long
2015-02-17 23:11   ` David Long
2015-02-19 14:18   ` Masami Hiramatsu [this message]
2015-02-19 14:18     ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E5F0D0.5030606@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=dave.long@linaro.org \
    --cc=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sandeepa.prabhu@linaro.org \
    --cc=steve.capper@linaro.org \
    --cc=tixy@linaro.org \
    --cc=wcohen@redhat.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.