From: David Vrabel <dvrabel@cantab.net>
To: Bob Liu <bob.liu@oracle.com>, xen-devel@lists.xen.org
Cc: hch@infradead.org, felipe.franciosi@citrix.com,
linux-kernel@vger.kernel.org, axboe@fb.com,
david.vrabel@citrix.com, avanzini.arianna@gmail.com,
roger.pau@citrix.com
Subject: Re: [Xen-devel] [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return
Date: Thu, 19 Feb 2015 16:51:20 +0000 [thread overview]
Message-ID: <54E61488.2020402@cantab.net> (raw)
In-Reply-To: <1423988345-4005-11-git-send-email-bob.liu@oracle.com>
On 15/02/2015 08:19, Bob Liu wrote:
> Move the request complete logic out of blkif_interrupt() to a work queue,
> after that we can replace 'spin_lock_irq' with 'spin_lock' so that irq won't
> be disabled too long in blk_mq_queue_rq().
I think using a threaded interrupt (like scsifront) is better than work.
Also, this seems orthogonal to the multiqueue support. Is it a useful
bug fix on its own?
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <dvrabel@cantab.net>
To: Bob Liu <bob.liu@oracle.com>, xen-devel@lists.xen.org
Cc: axboe@fb.com, felipe.franciosi@citrix.com,
linux-kernel@vger.kernel.org, hch@infradead.org,
david.vrabel@citrix.com, avanzini.arianna@gmail.com,
roger.pau@citrix.com
Subject: Re: [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return
Date: Thu, 19 Feb 2015 16:51:20 +0000 [thread overview]
Message-ID: <54E61488.2020402@cantab.net> (raw)
In-Reply-To: <1423988345-4005-11-git-send-email-bob.liu@oracle.com>
On 15/02/2015 08:19, Bob Liu wrote:
> Move the request complete logic out of blkif_interrupt() to a work queue,
> after that we can replace 'spin_lock_irq' with 'spin_lock' so that irq won't
> be disabled too long in blk_mq_queue_rq().
I think using a threaded interrupt (like scsifront) is better than work.
Also, this seems orthogonal to the multiqueue support. Is it a useful
bug fix on its own?
David
next prev parent reply other threads:[~2015-02-19 17:26 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 8:18 [RFC PATCH 00/10] Multi-queue support for xen-block driver Bob Liu
2015-02-15 8:18 ` Bob Liu
2015-02-15 8:18 ` [PATCH 01/10] xen/blkfront: convert to blk-mq API Bob Liu
2015-02-15 8:18 ` Bob Liu
2015-02-15 8:18 ` [PATCH 02/10] xen/blkfront: drop legacy block layer support Bob Liu
2015-02-18 17:02 ` Christoph Hellwig
2015-02-18 17:02 ` Christoph Hellwig
2015-02-15 8:18 ` Bob Liu
2015-02-15 8:18 ` [PATCH 03/10] xen/blkfront: reorg info->io_lock after using blk-mq API Bob Liu
2015-02-15 8:18 ` Bob Liu
2015-02-18 17:05 ` Christoph Hellwig
2015-02-19 2:07 ` Bob Liu
2015-02-19 2:07 ` Bob Liu
2015-02-18 17:05 ` Christoph Hellwig
2015-02-15 8:18 ` [PATCH 04/10] xen/blkfront: separate ring information to an new struct Bob Liu
2015-02-15 8:18 ` Bob Liu
2015-02-18 17:28 ` Roger Pau Monné
2015-02-18 17:37 ` Konrad Rzeszutek Wilk
2015-02-18 17:37 ` Konrad Rzeszutek Wilk
2015-02-18 18:08 ` Felipe Franciosi
2015-02-18 18:29 ` Konrad Rzeszutek Wilk
2015-02-18 18:29 ` Konrad Rzeszutek Wilk
2015-02-19 2:05 ` Bob Liu
2015-02-19 2:05 ` Bob Liu
2015-02-19 11:08 ` Roger Pau Monné
2015-02-19 11:08 ` Roger Pau Monné
2015-02-19 11:14 ` David Vrabel
2015-02-19 11:14 ` David Vrabel
2015-02-19 12:06 ` Felipe Franciosi
2015-02-19 13:12 ` Roger Pau Monné
2015-02-19 13:12 ` Roger Pau Monné
2015-02-20 18:59 ` Konrad Rzeszutek Wilk
2015-02-20 18:59 ` Konrad Rzeszutek Wilk
2015-02-27 12:52 ` Bob Liu
2015-02-27 12:52 ` Bob Liu
2015-03-04 21:21 ` Konrad Rzeszutek Wilk
2015-03-04 21:21 ` Konrad Rzeszutek Wilk
2015-03-05 0:47 ` Bob Liu
2015-03-05 0:47 ` Bob Liu
2015-03-06 10:30 ` Felipe Franciosi
2015-03-06 10:30 ` Felipe Franciosi
2015-03-17 7:00 ` Bob Liu
2015-03-17 7:00 ` Bob Liu
2015-03-17 14:52 ` Felipe Franciosi
2015-03-17 14:52 ` Felipe Franciosi
2015-03-18 0:52 ` Bob Liu
2015-03-18 0:52 ` Bob Liu
2015-02-19 12:06 ` Felipe Franciosi
2015-02-19 11:30 ` Malcolm Crossley
2015-02-18 18:08 ` Felipe Franciosi
2015-02-18 17:28 ` Roger Pau Monné
2015-02-15 8:19 ` [PATCH 05/10] xen/blkback: separate ring information out of struct xen_blkif Bob Liu
2015-02-15 8:19 ` Bob Liu
2015-02-15 8:19 ` [PATCH 06/10] xen/blkfront: pseudo support for multi hardware queues Bob Liu
2015-02-15 8:19 ` Bob Liu
2015-02-15 8:19 ` [PATCH 07/10] xen/blkback: " Bob Liu
2015-02-15 8:19 ` Bob Liu
2015-02-19 16:57 ` David Vrabel
2015-02-19 16:57 ` [Xen-devel] " David Vrabel
2015-02-15 8:19 ` [PATCH 08/10] xen/blkfront: negotiate hardware queue number with backend Bob Liu
2015-02-15 8:19 ` Bob Liu
2015-02-15 8:19 ` [PATCH 09/10] xen/blkback: get hardware queue number from blkfront Bob Liu
2015-02-15 8:19 ` Bob Liu
2015-02-15 8:19 ` [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return Bob Liu
2015-02-19 16:51 ` David Vrabel [this message]
2015-02-19 16:51 ` David Vrabel
2015-02-15 8:19 ` Bob Liu
2015-02-18 17:01 ` [RFC PATCH 00/10] Multi-queue support for xen-block driver Christoph Hellwig
2015-02-18 17:01 ` Christoph Hellwig
2015-02-18 18:22 ` Felipe Franciosi
2015-02-18 18:22 ` Felipe Franciosi
2015-02-19 2:04 ` Bob Liu
2015-02-19 2:04 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E61488.2020402@cantab.net \
--to=dvrabel@cantab.net \
--cc=avanzini.arianna@gmail.com \
--cc=axboe@fb.com \
--cc=bob.liu@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=felipe.franciosi@citrix.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.