All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] added defconfig for Jesurun Q5
@ 2015-02-25 23:16 Gábor Nyers
  2015-02-26  8:56 ` Hans de Goede
  0 siblings, 1 reply; 8+ messages in thread
From: Gábor Nyers @ 2015-02-25 23:16 UTC (permalink / raw)
  To: u-boot

The Jesurun Q5 has a black plastic casing with the approximate
dimensions of 100mm x 100mm x 24mm with rounded edges. In terms of
hardware it features an Allwinner A10 SoC with 1GB RAM and 8GB of NAND
flash. The storage capacity can be extended up to 32GB with a MicroSD
card. The external connectors are: 2x USB-A female supporting USB2.0,
3.5mm female jack for audio, HDMI female, SPDIF, RJ45 LAN and Power.  In
addition the device has a red (hard wired to power) and a programmable
green LED. The pins for the UART are easily located on the PCB. The
devices is equipped with an AXP209 PMU.

For more details see: http://linux-sunxi.org/Jesurun_Q5
---
 configs/jesurun_q5_defconfig | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 configs/jesurun_q5_defconfig

diff --git a/configs/jesurun_q5_defconfig b/configs/jesurun_q5_defconfig
new file mode 100644
index 0000000..7ef35f2
--- /dev/null
+++ b/configs/jesurun_q5_defconfig
@@ -0,0 +1,9 @@
+CONFIG_SPL=y
+CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_EMAC,USB_EHCI,MACPWR=SUNXI_GPH(19)"
+CONFIG_FDTFILE="sun4i-a10-jesurun-q5.dtb"
++S:CONFIG_ARM=y
++S:CONFIG_ARCH_SUNXI=y
++S:CONFIG_MACH_SUN4I=y
++S:CONFIG_DRAM_CLK=312
++S:CONFIG_DRAM_ZQ=123
++S:CONFIG_DRAM_EMR1=0
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] added defconfig for Jesurun Q5
  2015-02-25 23:16 [U-Boot] [PATCH] added defconfig for Jesurun Q5 Gábor Nyers
@ 2015-02-26  8:56 ` Hans de Goede
  2015-02-26 11:08   ` Gábor Nyers
  2015-02-26 11:30   ` Gábor Nyers
  0 siblings, 2 replies; 8+ messages in thread
From: Hans de Goede @ 2015-02-26  8:56 UTC (permalink / raw)
  To: u-boot

Hi G?bor,

On 26-02-15 00:16, G?bor Nyers wrote:
> The Jesurun Q5 has a black plastic casing with the approximate
> dimensions of 100mm x 100mm x 24mm with rounded edges. In terms of
> hardware it features an Allwinner A10 SoC with 1GB RAM and 8GB of NAND
> flash. The storage capacity can be extended up to 32GB with a MicroSD
> card. The external connectors are: 2x USB-A female supporting USB2.0,
> 3.5mm female jack for audio, HDMI female, SPDIF, RJ45 LAN and Power.  In
> addition the device has a red (hard wired to power) and a programmable
> green LED. The pins for the UART are easily located on the PCB. The
> devices is equipped with an AXP209 PMU.
>
> For more details see: http://linux-sunxi.org/Jesurun_Q5

You're missing a:

Signed-off-by: G?bor Nyers <gnyers@opensuse.org>

At the end of you're commit msg here (my bad I forgot that when we
we're discussing how to submit patches).

Can you please resend with that line added to the end of the commit msg?

For you're next patch(es) you can do "git commit -s" to make git automatically
add the Signed-off-by.

Thanks & Regards,

Hans


> ---
>   configs/jesurun_q5_defconfig | 9 +++++++++
>   1 file changed, 9 insertions(+)
>   create mode 100644 configs/jesurun_q5_defconfig
>
> diff --git a/configs/jesurun_q5_defconfig b/configs/jesurun_q5_defconfig
> new file mode 100644
> index 0000000..7ef35f2
> --- /dev/null
> +++ b/configs/jesurun_q5_defconfig
> @@ -0,0 +1,9 @@
> +CONFIG_SPL=y
> +CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_EMAC,USB_EHCI,MACPWR=SUNXI_GPH(19)"
> +CONFIG_FDTFILE="sun4i-a10-jesurun-q5.dtb"
> ++S:CONFIG_ARM=y
> ++S:CONFIG_ARCH_SUNXI=y
> ++S:CONFIG_MACH_SUN4I=y
> ++S:CONFIG_DRAM_CLK=312
> ++S:CONFIG_DRAM_ZQ=123
> ++S:CONFIG_DRAM_EMR1=0
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] added defconfig for Jesurun Q5
  2015-02-26  8:56 ` Hans de Goede
@ 2015-02-26 11:08   ` Gábor Nyers
  2015-02-26 14:33     ` Hans de Goede
  2015-02-26 20:01     ` Siarhei Siamashka
  2015-02-26 11:30   ` Gábor Nyers
  1 sibling, 2 replies; 8+ messages in thread
From: Gábor Nyers @ 2015-02-26 11:08 UTC (permalink / raw)
  To: u-boot

The Jesurun Q5 has a black plastic casing with the approximate dimensions of
100mm x 100mm x 24mm with rounded edges. In terms of hardware it features an
Allwinner A10 SoC with 1GB RAM and 8GB of NAND flash. The storage capacity can
be extended up to 32GB with a MicroSD card. The external connectors are: 2x
USB-A female supporting USB2.0, 3.5mm female jack for audio, HDMI female,
SPDIF, RJ45 LAN and Power. In addition the device has 1x red LED (hard wired to
power) and an programmable green led. On the board there is also an unpopulated
IR receiver and the UART. The devices is equipped with an AXP209 PMU.

For more details see: http://linux-sunxi.org/Jesurun_Q5

Signed-off-by: G?bor Nyers <gnyers@opensuse.org>
---
 configs/jesurun_q5_defconfig | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 configs/jesurun_q5_defconfig

diff --git a/configs/jesurun_q5_defconfig b/configs/jesurun_q5_defconfig
new file mode 100644
index 0000000..7ef35f2
--- /dev/null
+++ b/configs/jesurun_q5_defconfig
@@ -0,0 +1,9 @@
+CONFIG_SPL=y
+CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_EMAC,USB_EHCI,MACPWR=SUNXI_GPH(19)"
+CONFIG_FDTFILE="sun4i-a10-jesurun-q5.dtb"
++S:CONFIG_ARM=y
++S:CONFIG_ARCH_SUNXI=y
++S:CONFIG_MACH_SUN4I=y
++S:CONFIG_DRAM_CLK=312
++S:CONFIG_DRAM_ZQ=123
++S:CONFIG_DRAM_EMR1=0
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] added defconfig for Jesurun Q5
  2015-02-26  8:56 ` Hans de Goede
  2015-02-26 11:08   ` Gábor Nyers
@ 2015-02-26 11:30   ` Gábor Nyers
  1 sibling, 0 replies; 8+ messages in thread
From: Gábor Nyers @ 2015-02-26 11:30 UTC (permalink / raw)
  To: u-boot

Hans,

I've resubmitted the patch with the Sign-off line included. Thanks a lot
for your help!

Regards,
G?bor


On Thu, 26 Feb 2015 09:56:58 +0100
Hans de Goede <hdegoede@redhat.com> wrote:

> Hi G?bor,
> 
> On 26-02-15 00:16, G?bor Nyers wrote:
> > The Jesurun Q5 has a black plastic casing with the approximate
> > dimensions of 100mm x 100mm x 24mm with rounded edges. In terms of
> > hardware it features an Allwinner A10 SoC with 1GB RAM and 8GB of NAND
> > flash. The storage capacity can be extended up to 32GB with a MicroSD
> > card. The external connectors are: 2x USB-A female supporting USB2.0,
> > 3.5mm female jack for audio, HDMI female, SPDIF, RJ45 LAN and Power.  In
> > addition the device has a red (hard wired to power) and a programmable
> > green LED. The pins for the UART are easily located on the PCB. The
> > devices is equipped with an AXP209 PMU.
> >
> > For more details see: http://linux-sunxi.org/Jesurun_Q5
> 
> You're missing a:
> 
> Signed-off-by: G?bor Nyers <gnyers@opensuse.org>
> 
> At the end of you're commit msg here (my bad I forgot that when we
> we're discussing how to submit patches).
> 
> Can you please resend with that line added to the end of the commit msg?
> 
> For you're next patch(es) you can do "git commit -s" to make git
> automatically add the Signed-off-by.
> 
> Thanks & Regards,
> 
> Hans
> 
> 
> > ---
> >   configs/jesurun_q5_defconfig | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >   create mode 100644 configs/jesurun_q5_defconfig
> >
> > diff --git a/configs/jesurun_q5_defconfig b/configs/jesurun_q5_defconfig
> > new file mode 100644
> > index 0000000..7ef35f2
> > --- /dev/null
> > +++ b/configs/jesurun_q5_defconfig
> > @@ -0,0 +1,9 @@
> > +CONFIG_SPL=y
> > +CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_EMAC,USB_EHCI,MACPWR=SUNXI_GPH(19)"
> > +CONFIG_FDTFILE="sun4i-a10-jesurun-q5.dtb"
> > ++S:CONFIG_ARM=y
> > ++S:CONFIG_ARCH_SUNXI=y
> > ++S:CONFIG_MACH_SUN4I=y
> > ++S:CONFIG_DRAM_CLK=312
> > ++S:CONFIG_DRAM_ZQ=123
> > ++S:CONFIG_DRAM_EMR1=0
> >
> 



-- 
G?bor Nyers  |  Sr. Sales Engineer at SUSE
mob: +31-6-22-377588  |  tel: +31-172-505555   |  fax: +31-172-505551
address: Raoul Wallenbergplein 23, 2404 ND Alphen a/d Rijn, Netherlands

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] added defconfig for Jesurun Q5
  2015-02-26 11:08   ` Gábor Nyers
@ 2015-02-26 14:33     ` Hans de Goede
  2015-02-26 20:01     ` Siarhei Siamashka
  1 sibling, 0 replies; 8+ messages in thread
From: Hans de Goede @ 2015-02-26 14:33 UTC (permalink / raw)
  To: u-boot

Hi,

On 26-02-15 12:08, G?bor Nyers wrote:
> The Jesurun Q5 has a black plastic casing with the approximate dimensions of
> 100mm x 100mm x 24mm with rounded edges. In terms of hardware it features an
> Allwinner A10 SoC with 1GB RAM and 8GB of NAND flash. The storage capacity can
> be extended up to 32GB with a MicroSD card. The external connectors are: 2x
> USB-A female supporting USB2.0, 3.5mm female jack for audio, HDMI female,
> SPDIF, RJ45 LAN and Power. In addition the device has 1x red LED (hard wired to
> power) and an programmable green led. On the board there is also an unpopulated
> IR receiver and the UART. The devices is equipped with an AXP209 PMU.
>
> For more details see: http://linux-sunxi.org/Jesurun_Q5
>
> Signed-off-by: G?bor Nyers <gnyers@opensuse.org>

Thanks, queued up in u-boot-sunxi/next for merging upstream.

Regards,

Hans

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] added defconfig for Jesurun Q5
  2015-02-26 11:08   ` Gábor Nyers
  2015-02-26 14:33     ` Hans de Goede
@ 2015-02-26 20:01     ` Siarhei Siamashka
  2015-02-27 11:20       ` Ian Campbell
  2015-03-02 12:46       ` Hans de Goede
  1 sibling, 2 replies; 8+ messages in thread
From: Siarhei Siamashka @ 2015-02-26 20:01 UTC (permalink / raw)
  To: u-boot

On Thu, 26 Feb 2015 12:08:15 +0100
G?bor Nyers <gnyers@opensuse.org> wrote:

> The Jesurun Q5 has a black plastic casing with the approximate dimensions of
> 100mm x 100mm x 24mm with rounded edges. In terms of hardware it features an
> Allwinner A10 SoC with 1GB RAM and 8GB of NAND flash. The storage capacity can
> be extended up to 32GB with a MicroSD card. The external connectors are: 2x
> USB-A female supporting USB2.0, 3.5mm female jack for audio, HDMI female,
> SPDIF, RJ45 LAN and Power. In addition the device has 1x red LED (hard wired to
> power) and an programmable green led. On the board there is also an unpopulated
> IR receiver and the UART. The devices is equipped with an AXP209 PMU.
> 
> For more details see: http://linux-sunxi.org/Jesurun_Q5
> 
> Signed-off-by: G?bor Nyers <gnyers@opensuse.org>
> ---
>  configs/jesurun_q5_defconfig | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 configs/jesurun_q5_defconfig
> 
> diff --git a/configs/jesurun_q5_defconfig b/configs/jesurun_q5_defconfig
> new file mode 100644
> index 0000000..7ef35f2
> --- /dev/null
> +++ b/configs/jesurun_q5_defconfig
> @@ -0,0 +1,9 @@
> +CONFIG_SPL=y
> +CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_EMAC,USB_EHCI,MACPWR=SUNXI_GPH(19)"
> +CONFIG_FDTFILE="sun4i-a10-jesurun-q5.dtb"
> ++S:CONFIG_ARM=y
> ++S:CONFIG_ARCH_SUNXI=y
> ++S:CONFIG_MACH_SUN4I=y
> ++S:CONFIG_DRAM_CLK=312
> ++S:CONFIG_DRAM_ZQ=123
> ++S:CONFIG_DRAM_EMR1=0

This patch is missing the "sunxi:" prefix in the summary line and
also an entry in the "board/sunxi/MAINTAINERS" file.

Additionally, it may be a good idea to have a reference to
the http://linux-sunxi.org/Jesurun_Q5 page as a comment in
the defconfig file. And eventually do the same for all
sunxi defconfigs. Right now the u-boot "configs" directory
is a growing pile of unsorted stuff. And it may be difficult
for a user to decide, which defconfig would be the right one
for his device (considering that some devices are not perfectly
labelled with exactly the same name as the defconfig file).

-- 
Best regards,
Siarhei Siamashka

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] added defconfig for Jesurun Q5
  2015-02-26 20:01     ` Siarhei Siamashka
@ 2015-02-27 11:20       ` Ian Campbell
  2015-03-02 12:46       ` Hans de Goede
  1 sibling, 0 replies; 8+ messages in thread
From: Ian Campbell @ 2015-02-27 11:20 UTC (permalink / raw)
  To: u-boot

On Thu, 2015-02-26 at 22:01 +0200, Siarhei Siamashka wrote:

> Additionally, it may be a good idea to have a reference to
> the http://linux-sunxi.org/Jesurun_Q5 page as a comment in
> the defconfig file. And eventually do the same for all
> sunxi defconfigs. Right now the u-boot "configs" directory
> is a growing pile of unsorted stuff. And it may be difficult
> for a user to decide, which defconfig would be the right one
> for his device (considering that some devices are not perfectly
> labelled with exactly the same name as the defconfig file).

I've been periodically doing a sweep and adding the upstream defconfig
name and [[Category:Mainline U-boot]] to the appropriate pages, but it's
been a while since I've had the chance and I'm no doubt waaaaay behind.

If someone were to do such a sweep, even just for the boards in
v2015.01, then it would be *very* appreciated.

I've also been wondering the first mainline u-boot version to support a
given board ought to be on each wiki page -- I think it most likely
should be.

Ian.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH] added defconfig for Jesurun Q5
  2015-02-26 20:01     ` Siarhei Siamashka
  2015-02-27 11:20       ` Ian Campbell
@ 2015-03-02 12:46       ` Hans de Goede
  1 sibling, 0 replies; 8+ messages in thread
From: Hans de Goede @ 2015-03-02 12:46 UTC (permalink / raw)
  To: u-boot

Hi,

On 26-02-15 21:01, Siarhei Siamashka wrote:
> On Thu, 26 Feb 2015 12:08:15 +0100
> G?bor Nyers <gnyers@opensuse.org> wrote:
>
>> The Jesurun Q5 has a black plastic casing with the approximate dimensions of
>> 100mm x 100mm x 24mm with rounded edges. In terms of hardware it features an
>> Allwinner A10 SoC with 1GB RAM and 8GB of NAND flash. The storage capacity can
>> be extended up to 32GB with a MicroSD card. The external connectors are: 2x
>> USB-A female supporting USB2.0, 3.5mm female jack for audio, HDMI female,
>> SPDIF, RJ45 LAN and Power. In addition the device has 1x red LED (hard wired to
>> power) and an programmable green led. On the board there is also an unpopulated
>> IR receiver and the UART. The devices is equipped with an AXP209 PMU.
>>
>> For more details see: http://linux-sunxi.org/Jesurun_Q5
>>
>> Signed-off-by: G?bor Nyers <gnyers@opensuse.org>
>> ---
>>   configs/jesurun_q5_defconfig | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>   create mode 100644 configs/jesurun_q5_defconfig
>>
>> diff --git a/configs/jesurun_q5_defconfig b/configs/jesurun_q5_defconfig
>> new file mode 100644
>> index 0000000..7ef35f2
>> --- /dev/null
>> +++ b/configs/jesurun_q5_defconfig
>> @@ -0,0 +1,9 @@
>> +CONFIG_SPL=y
>> +CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_EMAC,USB_EHCI,MACPWR=SUNXI_GPH(19)"
>> +CONFIG_FDTFILE="sun4i-a10-jesurun-q5.dtb"
>> ++S:CONFIG_ARM=y
>> ++S:CONFIG_ARCH_SUNXI=y
>> ++S:CONFIG_MACH_SUN4I=y
>> ++S:CONFIG_DRAM_CLK=312
>> ++S:CONFIG_DRAM_ZQ=123
>> ++S:CONFIG_DRAM_EMR1=0
>
> This patch is missing the "sunxi:" prefix in the summary line and
> also an entry in the "board/sunxi/MAINTAINERS" file.
>
> Additionally, it may be a good idea to have a reference to
> the http://linux-sunxi.org/Jesurun_Q5 page as a comment in
> the defconfig file. And eventually do the same for all
> sunxi defconfigs. Right now the u-boot "configs" directory
> is a growing pile of unsorted stuff. And it may be difficult
> for a user to decide, which defconfig would be the right one
> for his device (considering that some devices are not perfectly
> labelled with exactly the same name as the defconfig file).

All good points, all fixed in u-boot-sunxi/next (with a forced
push).

Regards,

Hans

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-03-02 12:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-25 23:16 [U-Boot] [PATCH] added defconfig for Jesurun Q5 Gábor Nyers
2015-02-26  8:56 ` Hans de Goede
2015-02-26 11:08   ` Gábor Nyers
2015-02-26 14:33     ` Hans de Goede
2015-02-26 20:01     ` Siarhei Siamashka
2015-02-27 11:20       ` Ian Campbell
2015-03-02 12:46       ` Hans de Goede
2015-02-26 11:30   ` Gábor Nyers

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.