All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] qapi-schema: Fix SpiceChannel docs
@ 2015-02-26 18:59 Cole Robinson
  2015-02-26 20:43 ` Eric Blake
  2015-02-28  9:21 ` Michael Tokarev
  0 siblings, 2 replies; 3+ messages in thread
From: Cole Robinson @ 2015-02-26 18:59 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Cole Robinson

The value is called channel-type, not connection-type

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 qapi-schema.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index e16f8eb..8141f71 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -860,31 +860,31 @@
 # Since: 2.1
 ##
 { 'type': 'SpiceServerInfo',
   'base': 'SpiceBasicInfo',
   'data': { '*auth': 'str' } }
 
 ##
 # @SpiceChannel
 #
 # Information about a SPICE client channel.
 #
 # @connection-id: SPICE connection id number.  All channels with the same id
 #                 belong to the same SPICE session.
 #
-# @connection-type: SPICE channel type number.  "1" is the main control
-#                   channel, filter for this one if you want to track spice
-#                   sessions only
+# @channel-type: SPICE channel type number.  "1" is the main control
+#                channel, filter for this one if you want to track spice
+#                sessions only
 #
 # @channel-id: SPICE channel ID number.  Usually "0", might be different when
 #              multiple channels of the same type exist, such as multiple
 #              display channels in a multihead setup
 #
 # @tls: true if the channel is encrypted, false otherwise.
 #
 # Since: 0.14.0
 ##
 { 'type': 'SpiceChannel',
   'base': 'SpiceBasicInfo',
   'data': {'connection-id': 'int', 'channel-type': 'int', 'channel-id': 'int',
            'tls': 'bool'} }
 
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] qapi-schema: Fix SpiceChannel docs
  2015-02-26 18:59 [Qemu-devel] [PATCH] qapi-schema: Fix SpiceChannel docs Cole Robinson
@ 2015-02-26 20:43 ` Eric Blake
  2015-02-28  9:21 ` Michael Tokarev
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2015-02-26 20:43 UTC (permalink / raw)
  To: Cole Robinson, qemu-devel; +Cc: qemu-trivial

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

On 02/26/2015 11:59 AM, Cole Robinson wrote:
> The value is called channel-type, not connection-type
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  qapi-schema.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks for adding the extra context to make the email self-contained :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] qapi-schema: Fix SpiceChannel docs
  2015-02-26 18:59 [Qemu-devel] [PATCH] qapi-schema: Fix SpiceChannel docs Cole Robinson
  2015-02-26 20:43 ` Eric Blake
@ 2015-02-28  9:21 ` Michael Tokarev
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2015-02-28  9:21 UTC (permalink / raw)
  To: Cole Robinson, qemu-devel; +Cc: qemu-trivial

Applied to -trivial, thank you!

/mjt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-28  9:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-26 18:59 [Qemu-devel] [PATCH] qapi-schema: Fix SpiceChannel docs Cole Robinson
2015-02-26 20:43 ` Eric Blake
2015-02-28  9:21 ` Michael Tokarev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.