Re: [PATCH 2/2] xen: arm: Warn if timer interrupts are not level triggered

From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 2/2] xen: arm: Warn if timer interrupts are not level triggered
Date: Sat, 28 Feb 2015 22:20:19 +0000	[thread overview]
Message-ID: <54F23F23.4070506@linaro.org> (raw)
In-Reply-To: <1424359443-21584-2-git-send-email-ian.campbell@citrix.com>

Hi Ian,

On 19/02/2015 15:24, Ian Campbell wrote:
> +static void check_timer_irq_cfg(unsigned int irq, const char *which)
> +{
> +    struct irq_desc *desc = irq_to_desc(irq);
> +
> +    /*
> +     * The interrupt contoller driver will update desc->arch.type with
> +     * the actual type which ended up configured in the hardware.
> +     */
> +    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_LOW )
> +        return;

I should have spotted it before ... The timer interrupts can be either 
level low or high.

For instance Seattle is using level high interrupts. Therefore, the 
error message will be odd on this platform.

I will send a patch Monday to fix it.

Regards,

-- 
Julien Grall