[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[Fabio Estevam]

Currently the usage text for the 'ums' command looks like this:
                                                                                
Usage:                                                                          
ums ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0                     

,so remove the extra 'ums' in the text.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 common/cmd_usb_mass_storage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/cmd_usb_mass_storage.c b/common/cmd_usb_mass_storage.c
index 2c879ea..51c3fff 100644
--- a/common/cmd_usb_mass_storage.c
+++ b/common/cmd_usb_mass_storage.c
@@ -159,6 +159,6 @@ exit:
 
 U_BOOT_CMD(ums, 4, 1, do_usb_mass_storage,
 	"Use the UMS [User Mass Storage]",
-	"ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0\n"
+	"<USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0\n"
 	"    devtype defaults to mmc"
 );
-- 
1.9.1

[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[Otavio Salvador]

On Wed, Feb 25, 2015 at 1:03 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Currently the usage text for the 'ums' command looks like this:
>
> Usage:
> ums ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0
>
> ,so remove the extra 'ums' in the text.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[Marek Vasut]

On Wednesday, February 25, 2015 at 05:03:19 PM, Fabio Estevam wrote:
> Currently the usage text for the 'ums' command looks like this:
> 
> Usage:
> ums ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0
> 
> ,so remove the extra 'ums' in the text.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[Soeren Moch]

> Currently the usage text for the 'ums' command looks like this:
>
> Usage:
> ums ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0
>
> ,so remove the extra 'ums' in the text.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>


When fixing the ums help text, I think we also should change the
"long name" from "User Mass Storage" to "USB Mass Storage".

Regards,
  Soeren

[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[Fabio Estevam]

Hi Soeren,

On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch <smoch@web.de> wrote:
>> Currently the usage text for the 'ums' command looks like this:
>>
>> Usage:
>> ums ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0
>>
>> ,so remove the extra 'ums' in the text.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
>
>
> When fixing the ums help text, I think we also should change the
> "long name" from "User Mass Storage" to "USB Mass Storage".

Maybe a separate patch for this?

Regards,

Fabio Estevam

[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[Marek Vasut]

On Saturday, February 28, 2015 at 05:04:09 PM, Fabio Estevam wrote:
> Hi Soeren,
> 
> On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch <smoch@web.de> wrote:
> >> Currently the usage text for the 'ums' command looks like this:
> >> 
> >> Usage:
> >> ums ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0
> >> 
> >> ,so remove the extra 'ums' in the text.
> >> 
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > When fixing the ums help text, I think we also should change the
> > "long name" from "User Mass Storage" to "USB Mass Storage".
> 
> Maybe a separate patch for this?

Separate please .

Best regards,
Marek Vasut

[U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[Soeren Moch]

Hi Fabio,

On 28.02.2015 17:04, Fabio Estevam wrote:
> Hi Soeren,
> 
> On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch <smoch@web.de> wrote:
>>> Currently the usage text for the 'ums' command looks like this:
>>>
>>> Usage:
>>> ums ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0
>>>
>>> ,so remove the extra 'ums' in the text.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>>
>> When fixing the ums help text, I think we also should change the
>> "long name" from "User Mass Storage" to "USB Mass Storage".
> 
> Maybe a separate patch for this?
> 

Thank you for preparing and sending the patch.

Regards,
  Soeren

[U-Boot] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

[Tom Rini]

On Wed, Feb 25, 2015 at 01:03:19PM -0300, Fabio Estevam wrote:

> Currently the usage text for the 'ums' command looks like this:
>                                                                                 
> Usage:                                                                          
> ums ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0                     
> 
> ,so remove the extra 'ums' in the text.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
> Acked-by: Marek Vasut <marex@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150306/dd2894a6/attachment.sig>