* [review-request] 7191 Version2 format shaid on all layers page
@ 2015-03-03 22:56 Lerner, Dave
2015-03-04 12:26 ` Barros Pena, Belen
0 siblings, 1 reply; 3+ messages in thread
From: Lerner, Dave @ 2015-03-03 22:56 UTC (permalink / raw)
To: BARROS PENA, BELEN, DAMIAN, ALEXANDRU, WOOD, MICHAEL; +Cc: toaster
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/layers_commitfield_7191
7191 - If field looks like a commit SHAID(hex and 40 digits), truncate field as button label, and show full SHAID when button depressed.
Dave Lerner
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [review-request] 7191 Version2 format shaid on all layers page
2015-03-03 22:56 [review-request] 7191 Version2 format shaid on all layers page Lerner, Dave
@ 2015-03-04 12:26 ` Barros Pena, Belen
2015-03-04 15:58 ` Michael Wood
0 siblings, 1 reply; 3+ messages in thread
From: Barros Pena, Belen @ 2015-03-04 12:26 UTC (permalink / raw)
To: Lerner, David M (Wind River), Damian, Alexandru, Wood, Michael G; +Cc: toaster
On 03/03/2015 22:56, "Lerner, Dave" <dave.lerner@windriver.com> wrote:
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/layer
>s_commitfield_7191
>
>7191 - If field looks like a commit SHAID(hex and 40 digits), truncate
>field as button label, and show full SHAID when button depressed.
This seems to be working for me.
Thanks!
Belén
>
>Dave Lerner
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [review-request] 7191 Version2 format shaid on all layers page
2015-03-04 12:26 ` Barros Pena, Belen
@ 2015-03-04 15:58 ` Michael Wood
0 siblings, 0 replies; 3+ messages in thread
From: Michael Wood @ 2015-03-04 15:58 UTC (permalink / raw)
To: Barros Pena, Belen, Lerner, David M (Wind River), Damian, Alexandru
Cc: toaster
Hi Dave,
Only one thing, we have renamed the branch column to "reference" because
the database confusingly splits up the vcs reference into, branch,
commit, upstream branch etc etc
We have abstracted trying to work out which to display via the function
"get_vcs_reference"
So if you switch
+ {% if o.branch|is_shaid %}
to
+ {% if o.get_vcs_reference|is_shaid %}
and you can then also remove the check to see if which kind of reference
to display
+ {% else %}
+ {{o.up_branch.name}}
It's a bit confusing so if you'd like me just to push a patch on top
then you can squash it into yours.
Michael
On 04/03/15 12:26, Barros Pena, Belen wrote:
> On 03/03/2015 22:56, "Lerner, Dave" <dave.lerner@windriver.com> wrote:
>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/layer
>> s_commitfield_7191
>>
>> 7191 - If field looks like a commit SHAID(hex and 40 digits), truncate
>> field as button label, and show full SHAID when button depressed.
> This seems to be working for me.
>
> Thanks!
>
> Belén
>
>> Dave Lerner
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-04 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-03 22:56 [review-request] 7191 Version2 format shaid on all layers page Lerner, Dave
2015-03-04 12:26 ` Barros Pena, Belen
2015-03-04 15:58 ` Michael Wood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.