From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> To: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> Cc: linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jassi Brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Craig McGeachie <slapdau-/E1597aS9LT0CCvOHzKKcA@public.gmane.org>, Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Subject: Re: [PATCH 09/10] ARM: bcm2835: Add the mailbox property channel driver. Date: Thu, 05 Mar 2015 22:05:25 -0700 [thread overview] Message-ID: <54F93595.6050809@wwwdotorg.org> (raw) In-Reply-To: <87vbif6wzi.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> On 03/05/2015 12:54 PM, Eric Anholt wrote: > Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> writes: > >> On 03/02/2015 01:54 PM, Eric Anholt wrote: >>> Many of the operations with the firmware are done through this >>> mailbox channel pair with a specific packet format. Notably, >>> it's used for clock control, which is apparently not actually >>> totally possible to do from the ARM side (some regs aren't >>> addressable). I need clock control for the VC4 DRM driver, to >>> turn on the 3D engine. >> >>> diff --git a/drivers/mailbox/bcm2835-mailbox-property.c >>> b/drivers/mailbox/bcm2835-mailbox-property.c +int >>> bcm_mbox_property(void *data, size_t tag_size) >> >>> + buf = dma_alloc_coherent(NULL, PAGE_ALIGN(size), &bus_addr, >>> GFP_ATOMIC); + if (!buf) + return -ENOMEM; >> >> Can't the driver (this one or the client) maintain some >> persistent buffer rather than allocating/freeing a new one each >> time. It seems like the alloc/free might introduce quite some >> overhead? > > The size of the buffer is arbitrary (up to 1MB), the frequency of > requessts is low, and the hardware's pretty starved for RAM. > However, we're probably only ever going to see single page > allocations, so the RAM cost is probably low and the allocation > time is probably also correspondingly low (not like when I was > trying to do 256k allocations in the vc4 driver. ouch). OK. Since this is an implementation detail with no effect on DT ABI, it would be easy to change later if it did turn out to be an issue. >>> + writel(size, buf); + writel(bcm_mbox_status_request, buf + >>> 4); + memcpy_toio(buf + 8, data, tag_size); + >>> writel(bcm_mbox_property_end, buf + size - 4); >> >> Since this is just a regular chunk of RAM, can't the code just >> use regular memory writes and memcpy()? > > will wmb() guarantee that the compiler won't optimize out my write > to buf[0] and corresponding read from buf[0]? I was originally > treating it as RAM and using volatile, but then reread the old > "don't use volatile" doc. Yes, all of the barrier implementations boil down to one of: #define isb(x) __asm__ __volatile__ ("mcr p15, 0, %0, c7, c5, 4" \ : : "r" (0) : "memory") #define dsb(x) __asm__ __volatile__ ("mcr p15, 0, %0, c7, c10, 4" \ : : "r" (0) : "memory") #define dmb(x) __asm__ __volatile__ ("mcr p15, 0, %0, c7, c10, 5" \ : : "r" (0) : "memory") The final :"memory" tells the compiler that the __asm__ statement may change memory, so the compiler isn't allowed to "cache" anything over the statement. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/10] ARM: bcm2835: Add the mailbox property channel driver. Date: Thu, 05 Mar 2015 22:05:25 -0700 [thread overview] Message-ID: <54F93595.6050809@wwwdotorg.org> (raw) In-Reply-To: <87vbif6wzi.fsf@eliezer.anholt.net> On 03/05/2015 12:54 PM, Eric Anholt wrote: > Stephen Warren <swarren@wwwdotorg.org> writes: > >> On 03/02/2015 01:54 PM, Eric Anholt wrote: >>> Many of the operations with the firmware are done through this >>> mailbox channel pair with a specific packet format. Notably, >>> it's used for clock control, which is apparently not actually >>> totally possible to do from the ARM side (some regs aren't >>> addressable). I need clock control for the VC4 DRM driver, to >>> turn on the 3D engine. >> >>> diff --git a/drivers/mailbox/bcm2835-mailbox-property.c >>> b/drivers/mailbox/bcm2835-mailbox-property.c +int >>> bcm_mbox_property(void *data, size_t tag_size) >> >>> + buf = dma_alloc_coherent(NULL, PAGE_ALIGN(size), &bus_addr, >>> GFP_ATOMIC); + if (!buf) + return -ENOMEM; >> >> Can't the driver (this one or the client) maintain some >> persistent buffer rather than allocating/freeing a new one each >> time. It seems like the alloc/free might introduce quite some >> overhead? > > The size of the buffer is arbitrary (up to 1MB), the frequency of > requessts is low, and the hardware's pretty starved for RAM. > However, we're probably only ever going to see single page > allocations, so the RAM cost is probably low and the allocation > time is probably also correspondingly low (not like when I was > trying to do 256k allocations in the vc4 driver. ouch). OK. Since this is an implementation detail with no effect on DT ABI, it would be easy to change later if it did turn out to be an issue. >>> + writel(size, buf); + writel(bcm_mbox_status_request, buf + >>> 4); + memcpy_toio(buf + 8, data, tag_size); + >>> writel(bcm_mbox_property_end, buf + size - 4); >> >> Since this is just a regular chunk of RAM, can't the code just >> use regular memory writes and memcpy()? > > will wmb() guarantee that the compiler won't optimize out my write > to buf[0] and corresponding read from buf[0]? I was originally > treating it as RAM and using volatile, but then reread the old > "don't use volatile" doc. Yes, all of the barrier implementations boil down to one of: #define isb(x) __asm__ __volatile__ ("mcr p15, 0, %0, c7, c5, 4" \ : : "r" (0) : "memory") #define dsb(x) __asm__ __volatile__ ("mcr p15, 0, %0, c7, c10, 4" \ : : "r" (0) : "memory") #define dmb(x) __asm__ __volatile__ ("mcr p15, 0, %0, c7, c10, 5" \ : : "r" (0) : "memory") The final :"memory" tells the compiler that the __asm__ statement may change memory, so the compiler isn't allowed to "cache" anything over the statement.
next prev parent reply other threads:[~2015-03-06 5:05 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-02 20:54 Raspberry Pi mailbox drivers Eric Anholt 2015-03-02 20:54 ` [PATCH 02/10] mailbox: Enable BCM2835 mailbox support Eric Anholt 2015-03-02 20:54 ` Eric Anholt [not found] ` <1425329684-23968-3-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-04 3:03 ` Stephen Warren 2015-03-04 3:03 ` Stephen Warren [not found] ` <54F675F1.60205-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-04 9:48 ` Arnd Bergmann 2015-03-04 9:48 ` Arnd Bergmann 2015-03-04 18:20 ` Eric Anholt 2015-03-04 18:20 ` Eric Anholt [not found] ` <87a8zs8vzo.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> 2015-03-06 4:54 ` Stephen Warren 2015-03-06 4:54 ` Stephen Warren [not found] ` <54F932FD.5040207-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-06 20:00 ` Eric Anholt 2015-03-06 20:00 ` Eric Anholt [not found] ` <87bnk5lwvt.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> 2015-03-06 20:29 ` Stephen Warren 2015-03-06 20:29 ` Stephen Warren [not found] ` <54FA0E2B.30300-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-06 21:40 ` Stephen Warren 2015-03-06 21:40 ` Stephen Warren 2015-03-04 18:28 ` Eric Anholt 2015-03-04 18:28 ` Eric Anholt [not found] ` <1425329684-23968-1-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-02 20:54 ` [PATCH 01/10] dt/bindings: Add binding for BCM2835 mailbox driver Eric Anholt [not found] ` <1425329684-23968-2-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-03 8:05 ` Lee Jones 2015-03-03 19:28 ` Eric Anholt [not found] ` <87vbih98za.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> 2015-03-04 2:37 ` Stephen Warren [not found] ` <54F66FDD.2040409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-04 17:44 ` Eric Anholt 2015-03-12 23:23 ` Eric Anholt [not found] ` <87egothkaf.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> 2015-03-17 3:08 ` Stephen Warren [not found] ` <55079AA0.5090904-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-17 19:10 ` Eric Anholt [not found] ` <87vbhzl9t1.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> 2015-03-18 1:52 ` Stephen Warren 2015-03-02 20:54 ` [PATCH 03/10] ARM: bcm2835: Add the mailbox to the device tree Eric Anholt [not found] ` <1425329684-23968-4-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-03 8:34 ` Lee Jones 2015-03-02 20:54 ` [PATCH 04/10] dt/bindings: Add binding for BCM2835 mailbox power channel driver Eric Anholt [not found] ` <1425329684-23968-5-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-04 3:07 ` Stephen Warren 2015-03-02 20:54 ` [PATCH 05/10] ARM: bcm2835: Add the " Eric Anholt [not found] ` <1425329684-23968-6-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-02 21:09 ` Arnd Bergmann 2015-03-02 22:02 ` Eric Anholt 2015-03-04 3:15 ` Stephen Warren 2015-03-02 20:54 ` [PATCH 06/10] ARM: bcm2835: Add the mailbox power channel to the device tree Eric Anholt 2015-03-02 20:54 ` [PATCH 07/10] usb: Make sure that DWC2 initializes after the power channel mailbox driver Eric Anholt [not found] ` <1425329684-23968-8-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-03 8:32 ` Lee Jones 2015-03-03 20:32 ` [PATCH 07/10 v2] " Eric Anholt [not found] ` <1425414778-30820-1-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-04 3:24 ` Stephen Warren 2015-03-04 3:17 ` [PATCH 07/10] " Stephen Warren [not found] ` <54F67944.1030501-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-04 9:50 ` Arnd Bergmann 2015-03-02 20:54 ` [PATCH 08/10] dt/bindings: Add binding for BCM2835 mailbox property channel driver Eric Anholt [not found] ` <1425329684-23968-9-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-04 3:53 ` Stephen Warren [not found] ` <54F681CE.2070801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-05 19:50 ` Eric Anholt [not found] ` <87wq2v6x69.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> 2015-03-06 5:15 ` Stephen Warren [not found] ` <54F937DF.3020001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-06 6:05 ` Jassi Brar 2015-03-02 20:54 ` [PATCH 09/10] ARM: bcm2835: Add the " Eric Anholt [not found] ` <1425329684-23968-10-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> 2015-03-04 4:00 ` Stephen Warren [not found] ` <54F68352.5080108-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-03-05 19:54 ` Eric Anholt [not found] ` <87vbif6wzi.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> 2015-03-06 5:05 ` Stephen Warren [this message] 2015-03-06 5:05 ` Stephen Warren 2015-03-02 20:54 ` [PATCH 10/10] ARM: bcm2835: Add the mailbox property channel to the device tree Eric Anholt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54F93595.6050809@wwwdotorg.org \ --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \ --cc=jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=lkundrak-NGH9Lh4a5iE@public.gmane.org \ --cc=slapdau-/E1597aS9LT0CCvOHzKKcA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.