Re: [PATCH 06/20] c6x: convert fdt pointers to opaque pointers

From: Nishanth Menon <menon.nishanth@gmail.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh@kernel.org>, Mark Salter <msalter@redhat.com>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	linux-c6x-dev@linux-c6x.org
Subject: Re: [PATCH 06/20] c6x: convert fdt pointers to opaque pointers
Date: Sat, 07 Mar 2015 03:16:45 -0600	[thread overview]
Message-ID: <54FAC1FD.504@gmail.com> (raw)
In-Reply-To: <CAMuHMdUvuxCie+iayBr9TpOxhubWQ8My2Z3WC_fXJMEqX9NxvA@mail.gmail.com>

Hi Rob,
On 04/04/2014 02:57 AM, Geert Uytterhoeven wrote:
> On Fri, Apr 4, 2014 at 12:16 AM, Rob Herring <robherring2@gmail.com> wrote:
>> --- a/arch/c6x/kernel/setup.c
>> +++ b/arch/c6x/kernel/setup.c
>> @@ -265,8 +265,8 @@ int __init c6x_add_memory(phys_addr_t start, unsigned long size)
>>   */
>>  notrace void __init machine_init(unsigned long dt_ptr)
>>  {
>> -       struct boot_param_header *dtb = __va(dt_ptr);
>> -       struct boot_param_header *fdt = (struct boot_param_header *)_fdt_start;
>> +       const void *dtb = __va(dt_ptr);
>> +       const void *fdt = (const void *)_fdt_start;
> 
> Unless it has changed recently, _fdt_start is "char _fdt_start[]",
> so the cast should not be needed.
Also, just noticed the following with evmc6678_defconfig
arch/c6x/kernel/setup.c: In function ‘machine_init’:
arch/c6x/kernel/setup.c:290:21: warning: passing argument 1 of
‘early_init_dt_scan’ discards ‘const’ qualifier from pointer target type
  early_init_dt_scan(fdt);
                     ^
In file included from arch/c6x/kernel/setup.c:19:0:
include/linux/of_fdt.h:75:13: note: expected ‘void *’ but argument is of
type ‘const void *’
 extern bool early_init_dt_scan(void *params);

on current tip "af13e86 Merge branch 'drm-fixes' of
git://people.freedesktop.org/~airlied/linux"

Compiler used:
c6x-linux-gnu-gcc (GCC) 4.9.2 20150107 (Red Hat Cross 4.9.2-3)
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.