Re: [PATCH 06/20] c6x: convert fdt pointers to opaque pointers

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robherring2@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh@kernel.org>, Mark Salter <msalter@redhat.com>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	linux-c6x-dev@linux-c6x.org
Subject: Re: [PATCH 06/20] c6x: convert fdt pointers to opaque pointers
Date: Fri, 4 Apr 2014 09:57:36 +0200	[thread overview]
Message-ID: <CAMuHMdUvuxCie+iayBr9TpOxhubWQ8My2Z3WC_fXJMEqX9NxvA@mail.gmail.com> (raw)
In-Reply-To: <1396563423-30893-7-git-send-email-robherring2@gmail.com>

Hi Rob,

On Fri, Apr 4, 2014 at 12:16 AM, Rob Herring <robherring2@gmail.com> wrote:
> --- a/arch/c6x/kernel/setup.c
> +++ b/arch/c6x/kernel/setup.c
> @@ -265,8 +265,8 @@ int __init c6x_add_memory(phys_addr_t start, unsigned long size)
>   */
>  notrace void __init machine_init(unsigned long dt_ptr)
>  {
> -       struct boot_param_header *dtb = __va(dt_ptr);
> -       struct boot_param_header *fdt = (struct boot_param_header *)_fdt_start;
> +       const void *dtb = __va(dt_ptr);
> +       const void *fdt = (const void *)_fdt_start;

Unless it has changed recently, _fdt_start is "char _fdt_start[]",
so the cast should not be needed.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds