* [PATCH] drivers: watchdog: ts72xx_wdt: fix build error
@ 2020-04-06 21:50 Shyam Saini
2020-04-06 22:42 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Shyam Saini @ 2020-04-06 21:50 UTC (permalink / raw)
To: wim; +Cc: linux, linux-watchdog, jerome.oufella, Shyam Saini
If TS72XX_WATCHDOG is y and WATCHDOG_CORE is not enabled or its m,
then building fails:
drivers/watchdog/ts72xx_wdt.o: in function `ts72xx_wdt_probe':
ts72xx_wdt.c:(.text+0x14c): undefined reference to \
`watchdog_init_timeout'
ts72xx_wdt.c:(.text+0x15c): undefined reference to \
`devm_watchdog_register_device'
Select WATCHDOG_CORE to fix this.
Signed-off-by: Shyam Saini <shyam.saini@savoirfairelinux.com>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index cec868f8db3f..62da6e903336 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -669,6 +669,7 @@ config TS4800_WATCHDOG
config TS72XX_WATCHDOG
tristate "TS-72XX SBC Watchdog"
depends on MACH_TS72XX || COMPILE_TEST
+ select WATCHDOG_CORE
help
Technologic Systems TS-7200, TS-7250 and TS-7260 boards have
watchdog timer implemented in a external CPLD chip. Say Y here
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: watchdog: ts72xx_wdt: fix build error
2020-04-06 21:50 [PATCH] drivers: watchdog: ts72xx_wdt: fix build error Shyam Saini
@ 2020-04-06 22:42 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-04-06 22:42 UTC (permalink / raw)
To: Shyam Saini, wim; +Cc: linux-watchdog, jerome.oufella, Shyam Saini
On 4/6/20 2:50 PM, Shyam Saini wrote:
> If TS72XX_WATCHDOG is y and WATCHDOG_CORE is not enabled or its m,
> then building fails:
>
> drivers/watchdog/ts72xx_wdt.o: in function `ts72xx_wdt_probe':
> ts72xx_wdt.c:(.text+0x14c): undefined reference to \
> `watchdog_init_timeout'
> ts72xx_wdt.c:(.text+0x15c): undefined reference to \
> `devm_watchdog_register_device'
>
> Select WATCHDOG_CORE to fix this.
>
> Signed-off-by: Shyam Saini <shyam.saini@savoirfairelinux.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index cec868f8db3f..62da6e903336 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -669,6 +669,7 @@ config TS4800_WATCHDOG
> config TS72XX_WATCHDOG
> tristate "TS-72XX SBC Watchdog"
> depends on MACH_TS72XX || COMPILE_TEST
> + select WATCHDOG_CORE
> help
> Technologic Systems TS-7200, TS-7250 and TS-7260 boards have
> watchdog timer implemented in a external CPLD chip. Say Y here
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-06 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 21:50 [PATCH] drivers: watchdog: ts72xx_wdt: fix build error Shyam Saini
2020-04-06 22:42 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.