* [Buildroot] [PATCH] package/casync: undefine NDEBUG
@ 2021-06-24 5:28 Baruch Siach
2021-07-04 19:55 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2021-06-24 5:28 UTC (permalink / raw)
To: buildroot
The casync code relies on assert() calls being non-empty. Undefine
NDEBUG to override BR2_ENABLE_RUNTIME_DEBUG not being set.
Fixes:
http://autobuild.buildroot.net/results/4c69f45a41462564382f667f5e97b78b49c97759/
http://autobuild.buildroot.net/results/778a94f63c8e9f805badb5c8ff040dcfc5c193e7/
http://autobuild.buildroot.net/results/d4c23639747dafcded4e28602ccbe48d102c385b/
Cc: Yair Ben Avraham <yairba@protonmail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/casync/casync.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/casync/casync.mk b/package/casync/casync.mk
index d74cb1bfe85d..e161c7bbc6d3 100644
--- a/package/casync/casync.mk
+++ b/package/casync/casync.mk
@@ -12,6 +12,9 @@ CASYNC_DEPENDENCIES = acl libcurl openssl
CASYNC_CONF_OPTS = -Dman=false -Doss-fuzz=false -Dllvm-fuzz=false
+# Code relies on assert(false) calls
+CASYNC_CFLAGS = $(TARGET_CFLAGS) -UNDEBUG
+
ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
CASYNC_DEPENDENCIES += bash-completion
# The default path is correct, leave it as-is
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/casync: undefine NDEBUG
2021-06-24 5:28 [Buildroot] [PATCH] package/casync: undefine NDEBUG Baruch Siach
@ 2021-07-04 19:55 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2021-07-04 19:55 UTC (permalink / raw)
To: buildroot
Baruch, All,
On 2021-06-24 08:28 +0300, Baruch Siach spake thusly:
> The casync code relies on assert() calls being non-empty. Undefine
> NDEBUG to override BR2_ENABLE_RUNTIME_DEBUG not being set.
>
> Fixes:
> http://autobuild.buildroot.net/results/4c69f45a41462564382f667f5e97b78b49c97759/
> http://autobuild.buildroot.net/results/778a94f63c8e9f805badb5c8ff040dcfc5c193e7/
> http://autobuild.buildroot.net/results/d4c23639747dafcded4e28602ccbe48d102c385b/
>
> Cc: Yair Ben Avraham <yairba@protonmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
We are now no longer setting NDEBUG in the infra; see a1c7cff1a081.
So this patch is no longer needed; I've marked it as rejected.
Thanks!
Regards,
Yann E. MORIN.
> ---
> package/casync/casync.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/casync/casync.mk b/package/casync/casync.mk
> index d74cb1bfe85d..e161c7bbc6d3 100644
> --- a/package/casync/casync.mk
> +++ b/package/casync/casync.mk
> @@ -12,6 +12,9 @@ CASYNC_DEPENDENCIES = acl libcurl openssl
>
> CASYNC_CONF_OPTS = -Dman=false -Doss-fuzz=false -Dllvm-fuzz=false
>
> +# Code relies on assert(false) calls
> +CASYNC_CFLAGS = $(TARGET_CFLAGS) -UNDEBUG
> +
> ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
> CASYNC_DEPENDENCIES += bash-completion
> # The default path is correct, leave it as-is
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-04 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 5:28 [Buildroot] [PATCH] package/casync: undefine NDEBUG Baruch Siach
2021-07-04 19:55 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.