From: Yin Fengwei <fengwei.yin@intel.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: kernel test robot <oliver.sang@intel.com>,
Yosry Ahmed <yosryahmed@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, <lkp@lists.01.org>,
kernel test robot <lkp@intel.com>,
Huang Ying <ying.huang@intel.com>,
Feng Tang <feng.tang@intel.com>,
Xing Zhengjun <zhengjun.xing@linux.intel.com>
Subject: Re: [memcg] a8c49af3be: hackbench.throughput -13.7% regression
Date: Thu, 28 Apr 2022 13:12:08 +0800 [thread overview]
Message-ID: <54bcab1b-2c39-9052-2bc4-4a779fe7b27a@intel.com> (raw)
In-Reply-To: <CALvZod4_vNWYxzGR3BksZYgoti-9hOioMGwF2UVRnwcAGpFqXA@mail.gmail.com>
Hi Shakeel,
On 4/27/2022 1:02 PM, Shakeel Butt wrote:
> Can you to comment out the following block instead of the above line
> and see if there is any impact?
Changed the code as following:
+static void memcg_account_kmem(struct mem_cgroup *memcg, int nr_pages)
+{
+ mod_memcg_state(memcg, MEMCG_KMEM, nr_pages);
+
+#if 0
+ if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) {
+ if (nr_pages > 0)
+ page_counter_charge(&memcg->kmem, nr_pages);
+ else
+ page_counter_uncharge(&memcg->kmem, -nr_pages);
+ }
+#endif
+}
+
The hackbench test result is 147% better:
086f694a75e1a283 cee08cab8eefaaffdec62343e8d
---------------- ---------------------------
fail:runs %reproduction fail:runs
| | |
8691:15 -52942% 750:6 dmesg.timestamp:last
:15 13% 2:6 last_state.booting
:15 13% 2:6 last_state.is_incomplete_run
1:15 -7% :6 kmsg.common_interrupt:#No_irq_handler_for_vector
2:15 -18% :6 kmsg.timestamp:common_interrupt:#No_irq_handler_for_vector
4656:15 -26039% 750:6 kmsg.timestamp:last
%stddev %change %stddev
\ | \
143619 ± 4% +147.0% 354807 ± 2% hackbench.throughput <------
475.91 ± 4% -58.8% 196.09 ± 2% hackbench.time.elapsed_time
Regards
Yin, Fengwei
WARNING: multiple messages have this Message-ID (diff)
From: Yin Fengwei <fengwei.yin@intel.com>
To: lkp@lists.01.org
Subject: Re: [memcg] a8c49af3be: hackbench.throughput -13.7% regression
Date: Thu, 28 Apr 2022 13:12:08 +0800 [thread overview]
Message-ID: <54bcab1b-2c39-9052-2bc4-4a779fe7b27a@intel.com> (raw)
In-Reply-To: <CALvZod4_vNWYxzGR3BksZYgoti-9hOioMGwF2UVRnwcAGpFqXA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]
Hi Shakeel,
On 4/27/2022 1:02 PM, Shakeel Butt wrote:
> Can you to comment out the following block instead of the above line
> and see if there is any impact?
Changed the code as following:
+static void memcg_account_kmem(struct mem_cgroup *memcg, int nr_pages)
+{
+ mod_memcg_state(memcg, MEMCG_KMEM, nr_pages);
+
+#if 0
+ if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) {
+ if (nr_pages > 0)
+ page_counter_charge(&memcg->kmem, nr_pages);
+ else
+ page_counter_uncharge(&memcg->kmem, -nr_pages);
+ }
+#endif
+}
+
The hackbench test result is 147% better:
086f694a75e1a283 cee08cab8eefaaffdec62343e8d
---------------- ---------------------------
fail:runs %reproduction fail:runs
| | |
8691:15 -52942% 750:6 dmesg.timestamp:last
:15 13% 2:6 last_state.booting
:15 13% 2:6 last_state.is_incomplete_run
1:15 -7% :6 kmsg.common_interrupt:#No_irq_handler_for_vector
2:15 -18% :6 kmsg.timestamp:common_interrupt:#No_irq_handler_for_vector
4656:15 -26039% 750:6 kmsg.timestamp:last
%stddev %change %stddev
\ | \
143619 ± 4% +147.0% 354807 ± 2% hackbench.throughput <------
475.91 ± 4% -58.8% 196.09 ± 2% hackbench.time.elapsed_time
Regards
Yin, Fengwei
next prev parent reply other threads:[~2022-04-28 5:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 5:58 [memcg] a8c49af3be: hackbench.throughput -13.7% regression kernel test robot
2022-04-20 5:58 ` kernel test robot
2022-04-27 2:52 ` Yin Fengwei
2022-04-27 2:52 ` Yin Fengwei
2022-04-27 4:34 ` Yosry Ahmed
2022-04-27 4:34 ` Yosry Ahmed
2022-04-27 4:59 ` Yin Fengwei
2022-04-27 4:59 ` Yin Fengwei
2022-04-27 5:08 ` Shakeel Butt
2022-04-27 5:08 ` Shakeel Butt
2022-04-27 5:02 ` Shakeel Butt
2022-04-27 5:02 ` Shakeel Butt
2022-04-27 5:03 ` Yin Fengwei
2022-04-27 5:03 ` Yin Fengwei
2022-04-28 5:12 ` Yin Fengwei [this message]
2022-04-28 5:12 ` Yin Fengwei
2022-04-28 13:16 ` Shakeel Butt
2022-04-28 13:16 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54bcab1b-2c39-9052-2bc4-4a779fe7b27a@intel.com \
--to=fengwei.yin@intel.com \
--cc=akpm@linux-foundation.org \
--cc=feng.tang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mhocko@kernel.org \
--cc=oliver.sang@intel.com \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.