From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
Date: Wed, 11 Mar 2015 18:56:22 +0900 [thread overview]
Message-ID: <55001146.3040304@samsung.com> (raw)
In-Reply-To: <1426067672-21589-1-git-send-email-k.kozlowski@samsung.com>
On 03/11/2015 06:54 PM, Krzysztof Kozlowski wrote:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Notes:
> Changes since v1:
> 1. Add Javier's reviewed-by.
>
> arch/arm/mach-exynos/pm_domains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
> index 37266a826437..84e1d9f4d76c 100644
> --- a/arch/arm/mach-exynos/pm_domains.c
> +++ b/arch/arm/mach-exynos/pm_domains.c
> @@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
> return -ENOMEM;
> }
>
> - pd->pd.name = kstrdup(np->name, GFP_KERNEL);
> + pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
> pd->name = pd->pd.name;
> pd->base = of_iomap(np, 0);
> pd->pd.power_off = exynos_pd_power_off;
>
Looks good to me. This patch is very useful for debug.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name
Date: Wed, 11 Mar 2015 18:56:22 +0900 [thread overview]
Message-ID: <55001146.3040304@samsung.com> (raw)
In-Reply-To: <1426067672-21589-1-git-send-email-k.kozlowski@samsung.com>
On 03/11/2015 06:54 PM, Krzysztof Kozlowski wrote:
> The power domain nodes in DTS may be very generic (e.g. "power-domain"
> for Exynos 5420) making it very hard to debug:
>
> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> power-domain on
>
> Use platform device name instead so the names will be a little more user
> friendly:
> domain status slaves
> 100440e0.power-domain on
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Notes:
> Changes since v1:
> 1. Add Javier's reviewed-by.
>
> arch/arm/mach-exynos/pm_domains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
> index 37266a826437..84e1d9f4d76c 100644
> --- a/arch/arm/mach-exynos/pm_domains.c
> +++ b/arch/arm/mach-exynos/pm_domains.c
> @@ -125,7 +125,7 @@ static __init int exynos4_pm_init_power_domain(void)
> return -ENOMEM;
> }
>
> - pd->pd.name = kstrdup(np->name, GFP_KERNEL);
> + pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
> pd->name = pd->pd.name;
> pd->base = of_iomap(np, 0);
> pd->pd.power_off = exynos_pd_power_off;
>
Looks good to me. This patch is very useful for debug.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2015-03-11 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 9:54 [PATCH v2] ARM: EXYNOS: Use platform device name as power domain name Krzysztof Kozlowski
2015-03-11 9:54 ` Krzysztof Kozlowski
2015-03-11 9:56 ` Chanwoo Choi [this message]
2015-03-11 9:56 ` Chanwoo Choi
2015-03-11 17:15 ` Kevin Hilman
2015-03-11 17:15 ` Kevin Hilman
2015-03-17 17:19 ` Kukjin Kim
2015-03-17 17:19 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55001146.3040304@samsung.com \
--to=cw00.choi@samsung.com \
--cc=arnd@arndb.de \
--cc=javier.martinez@collabora.co.uk \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.