All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK
Date: Fri, 13 Mar 2015 09:55:02 +0000	[thread overview]
Message-ID: <5502B3F6.2050603@arm.com> (raw)
In-Reply-To: <1426237389-10093-1-git-send-email-linux@roeck-us.net>

On 13/03/15 09:03, Guenter Roeck wrote:
> Building alpha:allmodconfig fails with
> 
> mm/memtest.c: In function 'reserve_bad_mem':
> mm/memtest.c:38:2: error: implicit declaration of function 'memblock_reserve'
> mm/memtest.c: In function 'do_one_pass':
> mm/memtest.c:77:2: error: implicit declaration of function 'for_each_free_mem_range'
> mm/memtest.c:77:73: error: expected ';' before '{' token
> 
> because it depends on MEMBLOCK which is not defined for the alpha
> architecture.
> 
> Fixes: 420c89e6185d ("mm: move memtest under mm")
> Cc: Vladimir Murzin <vladimir.murzin@arm.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  lib/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8b4e69a..dc1e69c 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1797,6 +1797,7 @@ config TEST_UDELAY
>  
>  config MEMTEST
>  	bool "Memtest"
> +	depends on MEMBLOCK
>  	---help---
>  	  This option adds a kernel parameter 'memtest', which allows memtest
>  	  to be set.
> 

Thanks for fixing it!

Acked-by: Vladimir Murzin <vladimir.murzin@arm.com>

Cheers
Vladimir


  reply	other threads:[~2015-03-13  9:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13  9:03 [PATCH -next] mm: MEMTEST depends on MEMBLOCK Guenter Roeck
2015-03-13  9:55 ` Vladimir Murzin [this message]
2015-03-16 11:04 ` Geert Uytterhoeven
2015-03-20 10:23 ` Paul Bolle
2015-03-20 10:39   ` Vladimir Murzin
2015-03-20 10:52     ` Paul Bolle
2015-03-20 10:59       ` Valentin Rothberg
2015-03-20 14:34       ` Stefan Hengelein
2015-03-20 15:11         ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5502B3F6.2050603@arm.com \
    --to=vladimir.murzin@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.